4.19.119-rc1 review
Subsystems (2)
Greg Kroah-Hartman
maintainercover 4.19.119-rc1 review
This is the start of the stable review cycle for the 4.19.119 release. There are 131 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 30 Apr 2020 18:20:45 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.19.119-rc1
Christian Borntraeger <[email protected]>
s390/mm: fix page table upgrade vs 2ndary address mode accesses
kaixuxia <[email protected]>
xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT
Kazuhiro Fujita <[email protected]>
serial: sh-sci: Make sure status register SCxSR is read in correct sequence
Mathias Nyman <[email protected]>
xhci: prevent bus suspend if a roothub port detected a over-current condition
Udipto Goswami <[email protected]>
usb: f_fs: Clear OS Extended descriptor counts to zero in ffs_data_reset()
Thinh Nguyen <[email protected]>
usb: dwc3: gadget: Fix request completion check
Oliver Neukum <[email protected]>
UAS: fix deadlock in error handling and PM flushing work
Oliver Neukum <[email protected]>
UAS: no use logging any details in case of ENODEV
Oliver Neukum <[email protected]>
cdc-acm: introduce a cool down
Oliver Neukum <[email protected]>
cdc-acm: close race betrween suspend() and acm_softint
Malcolm Priestley <[email protected]>
staging: vt6656: Power save stop wake_up_count wrap around.
Malcolm Priestley <[email protected]>
staging: vt6656: Fix pairwise key entry save.
Malcolm Priestley <[email protected]>
staging: vt6656: Fix drivers TBTT timing counter.
Malcolm Priestley <[email protected]>
staging: vt6656: Fix calling conditions of vnt_set_bss_mode
Malcolm Priestley <[email protected]>
staging: vt6656: Don't set RCR_MULTICAST or RCR_BROADCAST by default.
Nicolas Pitre <[email protected]>
vt: don't use kmalloc() for the unicode screen buffer
Nicolas Pitre <[email protected]>
vt: don't hardcode the mem allocation upper bound
Xiyu Yang <[email protected]>
staging: comedi: Fix comedi_device refcnt leak in comedi_open
Ian Abbott <[email protected]>
staging: comedi: dt2815: fix writing hi byte of analog output
Chris Packham <[email protected]>
powerpc/setup_64: Set cache-line-size based on cache-block-size
Ahmad Fatoum <[email protected]>
ARM: imx: provide v7_cpu_resume() only on ARM_CPU_SUSPEND=y
Mordechay Goodstein <[email protected]>
iwlwifi: mvm: beacon statistics shouldn't go backwards
Johannes Berg <[email protected]>
iwlwifi: pcie: actually release queue memory in TVQM
Gyeongtaek Lee <[email protected]>
ASoC: dapm: fixup dapm kcontrol widget
Paul Moore <[email protected]>
audit: check the length of userspace generated audit records
Alan Stern <[email protected]>
usb-storage: Add unusual_devs entry for JMicron JMS566
Jiri Slaby <[email protected]>
tty: rocket, avoid OOB access
Andrew Melnychenko <[email protected]>
tty: hvc: fix buffer overflow during hvc_alloc().
Uros Bizjak <[email protected]>
KVM: VMX: Enable machine check support for 32bit targets
Sean Christopherson <[email protected]>
KVM: Check validity of resolved slot when searching memslots
Sean Christopherson <[email protected]>
KVM: s390: Return last valid slot if approx index is out-of-bounds
George Wilson <[email protected]>
tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()
Jarkko Sakkinen <[email protected]>
tpm/tpm_tis: Free IRQ if probing fails
Alexander Tsoy <[email protected]>
ALSA: usb-audio: Filter out unsupported sample rates on Focusrite devices
Xiyu Yang <[email protected]>
ALSA: usb-audio: Fix usb audio refcnt leak when getting spdif
Kailang Yang <[email protected]>
ALSA: hda/realtek - Add new codec supported for ALC245
Takashi Iwai <[email protected]>
ALSA: hda/realtek - Fix unexpected init_amp override
Takashi Iwai <[email protected]>
ALSA: usx2y: Fix potential NULL dereference
Lucas Stach <[email protected]>
tools/vm: fix cross-compile build
Muchun Song <[email protected]>
mm/ksm: fix NULL pointer dereference when KSM zero page is enabled
Longpeng <[email protected]>
mm/hugetlb: fix a addressing exception caused by huge_pte_offset
Jann Horn <[email protected]>
vmalloc: fix remap_vmalloc_range() bounds checks
Alan Stern <[email protected]>
USB: hub: Fix handling of connect changes during sleep
Alan Stern <[email protected]>
USB: core: Fix free-while-in-use bug in the USB S-Glibrary
Jann Horn <[email protected]>
USB: early: Handle AMD's spec-compliant identifiers, too
Jonathan Cox <[email protected]>
USB: Add USB_QUIRK_DELAY_CTRL_MSG and USB_QUIRK_DELAY_INIT for Corsair K70 RGB RAPIDFIRE
Changming Liu <[email protected]>
USB: sisusbvga: Change port variable from signed to unsigned
Piotr Krysiuk <[email protected]>
fs/namespace.c: fix mountpoint reference counter race
Lars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Make sure not exceed maximum samplerate
Lars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Fix sequencer configuration for aux channels in simultaneous mode
Lars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Fix clearing interrupt when enabling trigger
Lars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Fix ADC-B powerdown
Olivier Moysan <[email protected]>
iio: adc: stm32-adc: fix sleep in atomic context
Lary Gibaud <[email protected]>
iio: st_sensors: rely on odr mask to know if odr can be set
Lars Engebretsen <[email protected]>
iio: core: remove extra semi-colon from devm_iio_device_register() macro
Takashi Iwai <[email protected]>
ALSA: usb-audio: Add connector notifier delegation
Takashi Iwai <[email protected]>
ALSA: usb-audio: Add static mapping table for ALC1220-VB-based mobos
Takashi Iwai <[email protected]>
ALSA: hda: Remove ASUS ROG Zenith from the blacklist
Waiman Long <[email protected]>
KEYS: Avoid false positive ENOMEM error on key read
Dan Carpenter <[email protected]>
mlxsw: Fix some IS_ERR() vs NULL bugs
David Ahern <[email protected]>
vrf: Check skb for XFRM_TRANSFORMED flag
David Ahern <[email protected]>
xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish
Florian Fainelli <[email protected]>
net: dsa: b53: b53_arl_rw_op() needs to select IVL or SVL
Florian Fainelli <[email protected]>
net: dsa: b53: Rework ARL bin logic
Florian Fainelli <[email protected]>
net: dsa: b53: Fix ARL register definitions
Florian Fainelli <[email protected]>
net: dsa: b53: Lookup VID in ARL searches when VLAN is enabled
David Ahern <[email protected]>
vrf: Fix IPv6 with qdisc and xfrm
Taehee Yoo <[email protected]>
team: fix hang in team_mode_get()
Eric Dumazet <[email protected]>
tcp: cache line align MAX_TCP_HEADER
Eric Dumazet <[email protected]>
sched: etf: do not assume all sockets are full blown
Xiyu Yang <[email protected]>
net/x25: Fix x25_neigh refcnt leak when receiving frame
Marc Zyngier <[email protected]>
net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array
Xiyu Yang <[email protected]>
net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node
Doug Berger <[email protected]>
net: bcmgenet: correct per TX/RX ring statistics
Taehee Yoo <[email protected]>
macvlan: fix null dereference in macvlan_device_event()
Taehee Yoo <[email protected]>
macsec: avoid to set wrong mtu
John Haxby <[email protected]>
ipv6: fix restrict IPV6_ADDRFORM operation
Rahul Lakkireddy <[email protected]>
cxgb4: fix large delays in PTP synchronization
Vishal Kulkarni <[email protected]>
cxgb4: fix adapter crash due to wrong MC size
Boris Ostrovsky <[email protected]>
x86/KVM: Clean up host's steal time structure
Boris Ostrovsky <[email protected]>
x86/KVM: Make sure KVM_VCPU_FLUSH_TLB flag is not missed
Boris Ostrovsky <[email protected]>
x86/kvm: Cache gfn to pfn translation
Boris Ostrovsky <[email protected]>
x86/kvm: Introduce kvm_(un)map_gfn()
KarimAllah Ahmed <[email protected]>
KVM: Properly check if "page" is valid in kvm_vcpu_unmap
Christian Borntraeger <[email protected]>
kvm: fix compile on s390 part 2
Paolo Bonzini <[email protected]>
kvm: fix compilation on s390
Paolo Bonzini <[email protected]>
kvm: fix compilation on aarch64
KarimAllah Ahmed <[email protected]>
KVM: Introduce a new guest mapping API
Sean Christopherson <[email protected]>
KVM: nVMX: Always sync GUEST_BNDCFGS when it comes from vmcs01
Sean Christopherson <[email protected]>
KVM: VMX: Zero out *all* general purpose registers after VM-Exit
Randall Huang <[email protected]>
f2fs: fix to avoid memory leakage in f2fs_listxattr
Cengiz Can <[email protected]>
blktrace: fix dereference after null check
Jan Kara <[email protected]>
blktrace: Protect q->blk_trace with RCU
Sabrina Dubroca <[email protected]>
net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup
Sabrina Dubroca <[email protected]>
net: ipv6: add net argument to ip6_dst_lookup_flow
Heiner Kallweit <[email protected]>
PCI/ASPM: Allow re-enabling Clock PM
Murthy Bhat <[email protected]>
scsi: smartpqi: fix call trace in device discovery
Halil Pasic <[email protected]>
virtio-blk: improve virtqueue error to BLK_STS
Steven Rostedt (VMware) <[email protected]>
tracing/selftests: Turn off timeout setting
Yongqiang Sun <[email protected]>
drm/amd/display: Not doing optimize bandwidth if flip pending.
Kai-Heng Feng <[email protected]>
xhci: Ensure link state is U3 after setting USB_SS_PORT_LS_U3
Hans de Goede <[email protected]>
ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
Jiri Olsa <[email protected]>
perf/core: Disable page faults when getting phys address
Florian Fainelli <[email protected]>
pwm: bcm2835: Dynamically allocate base
Geert Uytterhoeven <[email protected]>
pwm: renesas-tpu: Fix late Runtime PM enablement
Nicholas Piggin <[email protected]>
Revert "powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled"
Evan Green <[email protected]>
loop: Better discard support for block devices
Cornelia Huck <[email protected]>
s390/cio: avoid duplicated 'ADD' uevents
Mauro Carvalho Chehab <[email protected]>
kconfig: qconf: Fix a few alignment issues
Vasily Averin <[email protected]>
ipc/util.c: sysvipc_find_ipc() should increase position index
Eric Biggers <[email protected]>
selftests: kmod: fix handling test numbers above 9
Vasily Averin <[email protected]>
kernel/gcov/fs.c: gcov_seq_next() should increase position index
Sagi Grimberg <[email protected]>
nvme: fix deadlock caused by ANA update wrong locking
Hans de Goede <[email protected]>
ASoC: Intel: atom: Take the drv->lock mutex before calling sst_send_slot_map()
Wu Bo <[email protected]>
scsi: iscsi: Report unbind session event when the target has been removed
Geert Uytterhoeven <[email protected]>
pwm: rcar: Fix late Runtime PM enablement
Yan, Zheng <[email protected]>
ceph: don't skip updating wanted caps when cap is stale
Qiujun Huang <[email protected]>
ceph: return ceph_mdsc_do_request() errors from __get_parent()
James Smart <[email protected]>
scsi: lpfc: Fix crash in target side cable pulls hitting WAIT_FOR_UNREG
James Smart <[email protected]>
scsi: lpfc: Fix kasan slab-out-of-bounds error in lpfc_unreg_login
Tero Kristo <[email protected]>
watchdog: reset last_hw_keepalive time at start
Catalin Marinas <[email protected]>
arm64: Silence clang warning on mismatched value/register sizes
James Morse <[email protected]>
arm64: compat: Workaround Neoverse-N1 #1542419 for compat user-space
James Morse <[email protected]>
arm64: Fake the IminLine size on systems affected by Neoverse-N1 #1542419
James Morse <[email protected]>
arm64: errata: Hide CTR_EL0.DIC on systems affected by Neoverse-N1 #1542419
Marc Zyngier <[email protected]>
arm64: Add part number for Neoverse N1
Jeremy Sowden <[email protected]>
vti4: removed duplicate log message.
Wei Yongjun <[email protected]>
crypto: mxs-dcp - make symbols 'sha1_null_hash' and 'sha256_null_hash' static
Martin KaFai Lau <[email protected]>
bpftool: Fix printing incorrect pointer in btf_dump_ptr
Rob Clark <[email protected]>
drm/msm: Use the correct dma_sync calls harder
Dmitry Monakhov <[email protected]>
ext4: fix extent_status fragmentation for plain files
-------------
Diffstat:
Documentation/arm64/silicon-errata.txt | 1 + Makefile | 4 +- arch/arm/mach-imx/Makefile | 2 + arch/arm64/Kconfig | 16 +++ arch/arm64/include/asm/cache.h | 3 +- arch/arm64/include/asm/cpucaps.h | 3 +- arch/arm64/include/asm/cputype.h | 2 + arch/arm64/kernel/cpu_errata.c | 22 +++ arch/arm64/kernel/sys_compat.c | 11 ++ arch/arm64/kernel/traps.c | 9 ++ arch/powerpc/kernel/setup_64.c | 2 + arch/powerpc/kernel/time.c | 44 ++---- arch/s390/kvm/kvm-s390.c | 3 + arch/s390/lib/uaccess.c | 4 + arch/s390/mm/pgalloc.c | 16 ++- arch/x86/include/asm/kvm_host.h | 4 +- arch/x86/kvm/vmx.c | 27 ++-- arch/x86/kvm/x86.c | 66 +++++---- drivers/block/loop.c | 42 ++++-- drivers/block/virtio_blk.c | 9 +- drivers/char/tpm/tpm_ibmvtpm.c | 136 ++++++++++--------- drivers/char/tpm/tpm_tis_core.c | 8 +- drivers/crypto/mxs-dcp.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 23 ++++ drivers/gpu/drm/msm/msm_gem.c | 4 +- drivers/iio/adc/stm32-adc.c | 31 ++++- drivers/iio/adc/xilinx-xadc-core.c | 95 ++++++++++--- drivers/iio/common/st_sensors/st_sensors_core.c | 2 +- drivers/infiniband/core/addr.c | 7 +- drivers/infiniband/sw/rxe/rxe_net.c | 8 +- drivers/net/dsa/b53/b53_common.c | 37 ++++- drivers/net/dsa/b53/b53_regs.h | 8 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 3 + drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 27 +++- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 27 +--- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 3 + drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 11 +- .../mellanox/mlxsw/core_acl_flex_actions.c | 4 +- .../ethernet/mellanox/mlxsw/spectrum2_acl_tcam.c | 4 +- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 3 +- .../net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c | 4 +- .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 1 + drivers/net/geneve.c | 4 +- drivers/net/macsec.c | 12 +- drivers/net/macvlan.c | 2 +- drivers/net/team/team.c | 4 + drivers/net/vrf.c | 10 +- drivers/net/vxlan.c | 8 +- drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 9 ++ drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 3 + drivers/nvme/host/multipath.c | 4 +- drivers/pci/pcie/aspm.c | 18 ++- drivers/pwm/pwm-bcm2835.c | 1 + drivers/pwm/pwm-rcar.c | 10 +- drivers/pwm/pwm-renesas-tpu.c | 9 +- drivers/s390/cio/device.c | 13 +- drivers/scsi/lpfc/lpfc_nvme.c | 14 +- drivers/scsi/lpfc/lpfc_sli.c | 2 + drivers/scsi/scsi_transport_iscsi.c | 4 +- drivers/scsi/smartpqi/smartpqi_sas_transport.c | 2 +- drivers/staging/comedi/comedi_fops.c | 4 +- drivers/staging/comedi/drivers/dt2815.c | 3 + drivers/staging/vt6656/int.c | 3 +- drivers/staging/vt6656/key.c | 14 +- drivers/staging/vt6656/main_usb.c | 31 +++-- drivers/tty/hvc/hvc_console.c | 23 ++-- drivers/tty/rocket.c | 25 ++-- drivers/tty/serial/sh-sci.c | 13 +- drivers/tty/vt/vt.c | 7 +- drivers/usb/class/cdc-acm.c | 36 ++++- drivers/usb/class/cdc-acm.h | 5 +- drivers/usb/core/hub.c | 14 ++ drivers/usb/core/message.c | 9 +- drivers/usb/core/quirks.c | 4 + drivers/usb/dwc3/gadget.c | 12 +- drivers/usb/early/xhci-dbc.c | 8 +- drivers/usb/early/xhci-dbc.h | 18 ++- drivers/usb/gadget/function/f_fs.c | 4 + drivers/usb/host/xhci-hub.c | 20 ++- drivers/usb/misc/sisusbvga/sisusb.c | 20 +-- drivers/usb/misc/sisusbvga/sisusb_init.h | 14 +- drivers/usb/storage/uas.c | 46 ++++++- drivers/usb/storage/unusual_devs.h | 7 + drivers/watchdog/watchdog_dev.c | 1 + fs/ceph/caps.c | 8 +- fs/ceph/export.c | 5 + fs/ext4/extents.c | 47 ++++--- fs/f2fs/xattr.c | 15 ++- fs/namespace.c | 2 +- fs/proc/vmcore.c | 5 +- fs/xfs/xfs_inode.c | 85 ++++++------ include/linux/blkdev.h | 2 +- include/linux/blktrace_api.h | 18 ++- include/linux/iio/iio.h | 2 +- include/linux/kvm_host.h | 35 ++++- include/linux/kvm_types.h | 9 +- include/linux/vmalloc.h | 2 +- include/net/addrconf.h | 6 +- include/net/ipv6.h | 2 +- include/net/tcp.h | 2 +- ipc/util.c | 2 +- kernel/audit.c | 3 + kernel/events/core.c | 9 +- kernel/gcov/fs.c | 2 +- kernel/trace/blktrace.c | 117 +++++++++++----- mm/hugetlb.c | 14 +- mm/ksm.c | 12 +- mm/vmalloc.c | 16 ++- net/dccp/ipv6.c | 6 +- net/ipv4/ip_vti.c | 4 +- net/ipv4/xfrm4_output.c | 2 - net/ipv6/addrconf_core.c | 11 +- net/ipv6/af_inet6.c | 4 +- net/ipv6/datagram.c | 2 +- net/ipv6/inet6_connection_sock.c | 4 +- net/ipv6/ip6_output.c | 8 +- net/ipv6/ipv6_sockglue.c | 13 +- net/ipv6/raw.c | 2 +- net/ipv6/syncookies.c | 2 +- net/ipv6/tcp_ipv6.c | 4 +- net/ipv6/xfrm6_output.c | 2 - net/l2tp/l2tp_ip6.c | 2 +- net/mpls/af_mpls.c | 7 +- net/netrom/nr_route.c | 1 + net/sched/sch_etf.c | 7 +- net/sctp/ipv6.c | 4 +- net/tipc/udp_media.c | 9 +- net/x25/x25_dev.c | 4 +- samples/vfio-mdev/mdpy.c | 2 +- scripts/kconfig/qconf.cc | 13 +- security/keys/internal.h | 12 ++ security/keys/keyctl.c | 58 +++++--- sound/pci/hda/hda_intel.c | 1 - sound/pci/hda/patch_realtek.c | 11 +- sound/soc/intel/atom/sst-atom-controls.c | 2 + sound/soc/intel/boards/bytcr_rt5640.c | 11 ++ sound/soc/soc-dapm.c | 20 ++- sound/usb/format.c | 52 +++++++ sound/usb/mixer.c | 37 ++++- sound/usb/mixer.h | 10 ++ sound/usb/mixer_maps.c | 37 ++++- sound/usb/mixer_quirks.c | 12 +- sound/usb/quirks-table.h | 14 ++ sound/usb/usx2y/usbusx2yaudio.c | 2 + tools/bpf/bpftool/btf_dumper.c | 2 +- tools/testing/selftests/ftrace/settings | 1 + tools/testing/selftests/kmod/kmod.sh | 13 +- tools/vm/Makefile | 2 + virt/kvm/kvm_main.c | 149 ++++++++++++++++++++- 149 files changed, 1591 insertions(+), 598 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/131 ext4: fix extent_status fragmentation for plain files
From: Dmitry Monakhov <[email protected]>
[ Upstream commit 4068664e3cd2312610ceac05b74c4cf1853b8325 ]
Extents are cached in read_extent_tree_block(); as a result, extents are not cached for inodes with depth == 0 when we try to find the extent using ext4_find_extent(). The result of the lookup is cached in ext4_map_blocks() but is only a subset of the extent on disk. As a result, the contents of extents status cache can get very badly fragmented for certain workloads, such as a random 4k read workload.
File size of /mnt/test is 33554432 (8192 blocks of 4096 bytes)
ext: logical_offset: physical_offset: length: expected: flags:
0: 0.. 8191: 40960.. 49151: 8192: last,eof
$ perf record -e 'ext4:ext4_es_*' /root/bin/fio --name=t --direct=0 --rw=randread --bs=4k --filesize=32M --size=32M --filename=/mnt/test
$ perf script | grep ext4_es_insert_extent | head -n 10
fio 131 [000] 13.975421: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [494/1) mapped 41454 status W
fio 131 [000] 13.975939: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [6064/1) mapped 47024 status W
fio 131 [000] 13.976467: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [6907/1) mapped 47867 status W
fio 131 [000] 13.976937: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [3850/1) mapped 44810 status W
fio 131 [000] 13.977440: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [3292/1) mapped 44252 status W
fio 131 [000] 13.977931: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [6882/1) mapped 47842 status W
fio 131 [000] 13.978376: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [3117/1) mapped 44077 status W
fio 131 [000] 13.978957: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [2896/1) mapped 43856 status W
fio 131 [000] 13.979474: ext4:ext4_es_insert_extent: dev 253,0 ino 12 es [7479/1) mapped 48439 status WFix this by caching the extents for inodes with depth == 0 in ext4_find_extent().
[ Renamed ext4_es_cache_extents() to ext4_cache_extents() since this
newly added function is not in extents_cache.c, and to avoid potential visual confusion with ext4_es_cache_extent(). -TYT ]
--- fs/ext4/extents.c | 47 +++++++++++++++++++++++++++-------------------- 1 file changed, 27 insertions(+), 20 deletions(-)
fs/ext4/extents.c +27 -20
@@ -498,6 +498,30 @@ int ext4_ext_check_inode(struct inode *inode)return ext4_ext_check (inode,ext_inode_hdr (inode),ext_depth (inode),0 ); } +static void ext4_cache_extents (struct inode *inode, +struct ext4_extent_header *eh) +{ +struct ext4_extent *ex =EXT_FIRST_EXTENT (eh); +ext4_lblk_t prev =0 ; +int i; + +for (i =le16_to_cpu (eh->eh_entries); i >0 ; i--, ex++) { +unsigned int status =EXTENT_STATUS_WRITTEN ; +ext4_lblk_t lblk =le32_to_cpu (ex->ee_block); +int len =ext4_ext_get_actual_len (ex); + +if (prev && (prev != lblk)) +ext4_es_cache_extent (inode, prev, lblk - prev, ~0 , +EXTENT_STATUS_HOLE ); + +if (ext4_ext_is_unwritten (ex)) + status =EXTENT_STATUS_UNWRITTEN ; +ext4_es_cache_extent (inode, lblk, len, +ext4_ext_pblock (ex), status); + prev = lblk + len; + } +} +static struct buffer_head * __read_extent_tree_block(const char *function, unsigned int line, struct inode *inode, ext4_fsblk_t pblk, int depth,
@@ -532,26 +556,7 @@ __read_extent_tree_block(const char *function, unsigned int line,*/ if (!(flags &EXT4_EX_NOCACHE ) && depth ==0 ) {struct ext4_extent_header *eh =ext_block_hdr (bh); -struct ext4_extent *ex =EXT_FIRST_EXTENT (eh); -ext4_lblk_t prev =0 ; -int i; - -for (i =le16_to_cpu (eh->eh_entries); i >0 ; i--, ex++) { -unsigned int status =EXTENT_STATUS_WRITTEN ; -ext4_lblk_t lblk =le32_to_cpu (ex->ee_block); -int len =ext4_ext_get_actual_len (ex); - -if (prev && (prev != lblk)) -ext4_es_cache_extent (inode, prev, - lblk - prev, ~0 , -EXTENT_STATUS_HOLE ); - -if (ext4_ext_is_unwritten (ex)) - status =EXTENT_STATUS_UNWRITTEN ; -ext4_es_cache_extent (inode, lblk, len, -ext4_ext_pblock (ex), status); - prev = lblk + len; - } +ext4_cache_extents (inode, eh); }return bh; errout:
@@ -899,6 +904,8 @@ ext4_find_extent(struct inode *inode, ext4_lblk_t block, path[0 ].p_bh =NULL ; i = depth; +if (!(flags &EXT4_EX_NOCACHE ) && depth ==0 ) +ext4_cache_extents (inode, eh);/* walk through the tree */ while (i) { ext_debug("depth %d: num %d, max %d\n",
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 2/131 drm/msm: Use the correct dma_sync calls harder
In reply to Greg Kroah-HartmanFrom: Rob Clark <[email protected]>
commit 9f614197c744002f9968e82c649fdf7fe778e1e7 upstream.
Looks like the dma_sync calls don't do what we want on armv7 either. Fixes:
Unable to handle kernel paging request at virtual address 50001000 pgd = (ptrval) [50001000] *pgd=00000000 Internal error: Oops: 805 [#1] SMP ARM Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.3.0-rc6-00271-g9f159ae07f07 #4 Hardware name: Freescale i.MX53 (Device Tree Support) PC is at v7_dma_clean_range+0x20/0x38 LR is at __dma_page_cpu_to_dev+0x28/0x90 pc : [<c011c76c>] lr : [<c01181c4>] psr: 20000013 sp : d80b5a88 ip : de96c000 fp : d840ce6c r10: 00000000 r9 : 00000001 r8 : d843e010 r7 : 00000000 r6 : 00008000 r5 : ddb6c000 r4 : 00000000 r3 : 0000003f r2 : 00000040 r1 : 50008000 r0 : 50001000 Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c5387d Table: 70004019 DAC: 00000051 Process swapper/0 (pid: 1, stack limit = 0x(ptrval))
--- drivers/gpu/drm/msm/msm_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +2 -2
@@ -61,7 +61,7 @@ static void sync_for_device(struct msm_g {struct device *dev = msm_obj->base.dev->dev; -if (get_dma_ops (dev)) { +if (get_dma_ops (dev) &&IS_ENABLED (CONFIG_ARM64 )) {dma_sync_sg_for_device (dev, msm_obj->sgt->sgl, msm_obj->sgt->nents,DMA_BIDIRECTIONAL ); }else {
@@ -74,7 +74,7 @@ static void sync_for_cpu(struct msm_gem_ {struct device *dev = msm_obj->base.dev->dev; -if (get_dma_ops (dev)) { +if (get_dma_ops (dev) &&IS_ENABLED (CONFIG_ARM64 )) {dma_sync_sg_for_cpu (dev, msm_obj->sgt->sgl, msm_obj->sgt->nents,DMA_BIDIRECTIONAL ); }else {
Greg Kroah-Hartman
maintainerPATCH 3/131 bpftool: Fix printing incorrect pointer in btf_dump_ptr
In reply to Greg Kroah-HartmanFrom: Martin KaFai Lau <[email protected]>
commit 555089fdfc37ad65e0ee9b42ca40c238ff546f83 upstream.
For plain text output, it incorrectly prints the pointer value "void *data". The "void *data" is actually pointing to memory that contains a bpf-map's value. The intention is to print the content of the bpf-map's value instead of printing the pointer pointing to the bpf-map's value.
In this case, a member of the bpf-map's value is a pointer type. Thus, it should print the "*(void **)data".
--- tools/bpf/bpftool/btf_dumper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/bpf/bpftool/btf_dumper.c +1 -1
@@ -26,7 +26,7 @@ static void btf_dumper_ptr(const void *d bool is_plain_text) {if (is_plain_text) -jsonw_printf (jw,"%p" , data); +jsonw_printf (jw,"%p" , *(void **)data);else jsonw_printf (jw,"%lu" , *(unsigned long *)data); }
Greg Kroah-Hartman
maintainerPATCH 4/131 crypto: mxs-dcp - make symbols sha1_null_hash and sha256_null_hash static
In reply to Greg Kroah-HartmanFrom: Wei Yongjun <[email protected]>
commit ce4e45842de3eb54b8dd6e081765d741f5b92b56 upstream.
Fixes the following sparse warnings:
drivers/crypto/mxs-dcp.c:39:15: warning:
symbol 'sha1_null_hash' was not declared. Should it be static?drivers/crypto/mxs-dcp.c:43:15: warning:
symbol 'sha256_null_hash' was not declared. Should it be static?
--- drivers/crypto/mxs-dcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/mxs-dcp.c +2 -2
@@ -37,11 +37,11 @@* Null hashes to align with hw behavior on imx6sl and ull * these are flipped for consistency with hw output */ -const uint8_t sha1_null_hash[] = +static const uint8_t sha1_null_hash[] ="\x09\x07\xd8\xaf\x90\x18\x60\x95\xef\xbf" "\x55\x32\x0d\x4b\x6b\x5e\xee\xa3\x39\xda" ; -const uint8_t sha256_null_hash[] = +static const uint8_t sha256_null_hash[] ="\x55\xb8\x52\x78\x1b\x99\x95\xa4" "\x4c\x93\x9b\x64\xe4\x41\xae\x27" "\x24\xb9\x6f\x99\xc8\xf4\xfb\x9a"
Greg Kroah-Hartman
maintainerPATCH 5/131 vti4: removed duplicate log message.
In reply to Greg Kroah-HartmanFrom: Jeremy Sowden <[email protected]>
commit 01ce31c57b3f07c91c9d45bbaf126124cce83a5d upstream.
Removed info log-message if ipip tunnel registration fails during
module-initialization: it adds nothing to the error message that is written on all failures.
--- net/ipv4/ip_vti.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
net/ipv4/ip_vti.c +1 -3
@@ -677,10 +677,8 @@ static int __init vti_init(void) msg ="ipip tunnel" ; err =xfrm4_tunnel_register (&ipip_handler,AF_INET ); -if (err <0 ) { -pr_info ("%s: cant't register tunnel\n" ,__func__); +if (err <0 ) goto xfrm_tunnel_failed; - } msg ="netlink interface" ; err =rtnl_link_register (&vti_link_ops);
Greg Kroah-Hartman
maintainerPATCH 6/131 arm64: Add part number for Neoverse N1
In reply to Greg Kroah-HartmanFrom: Marc Zyngier <[email protected]>
[ Upstream commit 0cf57b86859c49381addb3ce47be70aadf5fd2c0 ]
New CPU, new part number. You know the drill.
--- arch/arm64/include/asm/cputype.h | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/include/asm/cputype.h +2 -0
@@ -80,6 +80,7 @@#define ARM_CPU_PART_CORTEX_A35 0xD04#define ARM_CPU_PART_CORTEX_A55 0xD05#define ARM_CPU_PART_CORTEX_A76 0xD0B +#define ARM_CPU_PART_NEOVERSE_N1 0xD0C#define APM_CPU_PART_POTENZA 0x000
@@ -107,6 +108,7 @@#define MIDR_CORTEX_A35 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A35)#define MIDR_CORTEX_A55 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A55)#define MIDR_CORTEX_A76 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A76) +#define MIDR_NEOVERSE_N1 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_N1)#define MIDR_THUNDERX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX)#define MIDR_THUNDERX_81XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_81XX)#define MIDR_THUNDERX_83XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_83XX)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 7/131 arm64: errata: Hide CTR_EL0.DIC on systems affected by Neoverse-N1 #1542419
In reply to Greg Kroah-HartmanFrom: James Morse <[email protected]>
[ Upstream commit 05460849c3b51180d5ada3373d0449aea19075e4 ]
Cores affected by Neoverse-N1 #1542419 could execute a stale instruction when a branch is updated to point to freshly generated instructions.
To workaround this issue we need user-space to issue unnecessary icache maintenance that we can trap. Start by hiding CTR_EL0.DIC.
--- Documentation/arm64/silicon-errata.txt | 1 + arch/arm64/Kconfig | 16 ++++++++++++++++ arch/arm64/include/asm/cpucaps.h | 3 ++- arch/arm64/kernel/cpu_errata.c | 22 ++++++++++++++++++++++ arch/arm64/kernel/traps.c | 3 +++ 5 files changed, 44 insertions(+), 1 deletion(-)
Documentation/arm64/silicon-errata.txt +1 -0
@@ -59,6 +59,7 @@ stable kernels. | ARM | Cortex-A73 | #858921 | ARM64_ERRATUM_858921 | | ARM | Cortex-A55 | #1024718 | ARM64_ERRATUM_1024718 | | ARM | Cortex-A76 | #1463225 | ARM64_ERRATUM_1463225 | +| ARM | Neoverse-N1 | #1542419 | ARM64_ERRATUM_1542419 | | ARM | MMU-500 | #841119,#826419 | N/A | | | | | | | Cavium | ThunderX ITS | #22375, #24313 | CAVIUM_ERRATUM_22375 |
arch/arm64/Kconfig +16 -0
@@ -499,6 +499,22 @@ config ARM64_ERRATUM_1463225 If unsure, say Y. +config ARM64_ERRATUM_1542419 + bool "Neoverse-N1: workaround mis-ordering of instruction fetches" + default y + help + This option adds a workaround for ARM Neoverse-N1 erratum + 1542419. + + Affected Neoverse-N1 cores could execute a stale instruction when + modified by another CPU. The workaround depends on a firmware + counterpart. + + Workaround the issue by hiding the DIC feature from EL0. This + forces user-space to perform cache maintenance. + + If unsure, say Y. + config CAVIUM_ERRATUM_22375 bool "Cavium erratum 22375, 24313" default y
arch/arm64/include/asm/cpucaps.h +2 -1
@@ -53,7 +53,8 @@#define ARM64_HAS_STAGE2_FWB 32#define ARM64_WORKAROUND_1463225 33#define ARM64_SSBS 34 +#define ARM64_WORKAROUND_1542419 35 -#define ARM64_NCAPS 35 +#define ARM64_NCAPS 36#endif /* __ASM_CPUCAPS_H */
arch/arm64/kernel/cpu_errata.c +22 -0
@@ -643,6 +643,18 @@ needs_tx2_tvm_workaround(const struct arm64_cpu_capabilities *entry,return false; } +static bool __maybe_unused +has_neoverse_n1_erratum_1542419 (const struct arm64_cpu_capabilities *entry, +int scope) +{ +u32 midr =read_cpuid_id (); +bool has_dic =read_cpuid_cachetype () &BIT (CTR_DIC_SHIFT ); +const struct midr_range range =MIDR_ALL_VERSIONS (MIDR_NEOVERSE_N1 ); + +WARN_ON (scope !=SCOPE_LOCAL_CPU ||preemptible ()); +return is_midr_in_range (midr, &range) && has_dic; +} +#ifdef CONFIG_HARDEN_EL2_VECTORS static const struct midr_range arm64_harden_el2_vectors[] = {
@@ -834,6 +846,16 @@ const struct arm64_cpu_capabilities arm64_errata[] = { ERRATA_MIDR_RANGE_LIST(tx2_family_cpus), .matches = needs_tx2_tvm_workaround, }, +#endif +#ifdef CONFIG_ARM64_ERRATUM_1542419 + { + /* we depend on the firmware portion for correctness */ + .desc = "ARM erratum 1542419 (kernel portion)", + .capability = ARM64_WORKAROUND_1542419, + .type = ARM64_CPUCAP_LOCAL_CPU_ERRATUM, + .matches = has_neoverse_n1_erratum_1542419, + .cpu_enable = cpu_enable_trap_ctr_access, + }, #endif { }
arch/arm64/kernel/traps.c +3 -0
@@ -481,6 +481,9 @@ static void ctr_read_handler(unsigned int esr, struct pt_regs *regs)int rt = (esr & ESR_ELx_SYS64_ISS_RT_MASK) >> ESR_ELx_SYS64_ISS_RT_SHIFT;unsigned long val =arm64_ftr_reg_user_value (&arm64_ftr_reg_ctrel0); +if (cpus_have_const_cap (ARM64_WORKAROUND_1542419 )) + val &= ~BIT (CTR_DIC_SHIFT ); +pt_regs_write_reg (regs, rt, val);arm64_skip_faulting_instruction (regs,AARCH64_INSN_SIZE );
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 8/131 arm64: Fake the IminLine size on systems affected by Neoverse-N1 #1542419
In reply to Greg Kroah-HartmanFrom: James Morse <[email protected]>
[ Upstream commit ee9d90be9ddace01b7fb126567e4b539fbe1f82f ]
Systems affected by Neoverse-N1 #1542419 support DIC so do not need to perform icache maintenance once new instructions are cleaned to the PoU. For the errata workaround, the kernel hides DIC from user-space, so that the unnecessary cache maintenance can be trapped by firmware.
To reduce the number of traps, produce a fake IminLine value based on PAGE_SIZE.
--- arch/arm64/include/asm/cache.h | 3 ++- arch/arm64/kernel/traps.c | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-)
arch/arm64/include/asm/cache.h +2 -1
@@ -22,6 +22,7 @@#define CTR_L1IP_MASK 3#define CTR_DMINLINE_SHIFT 16#define CTR_IMINLINE_SHIFT 0 +#define CTR_IMINLINE_MASK 0xf#define CTR_ERG_SHIFT 20#define CTR_CWG_SHIFT 24#define CTR_CWG_MASK 15
@@ -29,7 +30,7 @@#define CTR_DIC_SHIFT 29#define CTR_CACHE_MINLINE_MASK \ - (0xf << CTR_DMINLINE_SHIFT | 0xf << CTR_IMINLINE_SHIFT) + (0xf << CTR_DMINLINE_SHIFT | CTR_IMINLINE_MASK << CTR_IMINLINE_SHIFT)#define CTR_L1IP (ctr) (((ctr) >> CTR_L1IP_SHIFT) & CTR_L1IP_MASK)
arch/arm64/kernel/traps.c +7 -1
@@ -481,9 +481,15 @@ static void ctr_read_handler(unsigned int esr, struct pt_regs *regs)int rt = (esr & ESR_ELx_SYS64_ISS_RT_MASK) >> ESR_ELx_SYS64_ISS_RT_SHIFT;unsigned long val =arm64_ftr_reg_user_value (&arm64_ftr_reg_ctrel0); -if (cpus_have_const_cap (ARM64_WORKAROUND_1542419 )) +if (cpus_have_const_cap (ARM64_WORKAROUND_1542419 )) { +/* Hide DIC so that we can trap the unnecessary maintenance...*/ val &= ~BIT (CTR_DIC_SHIFT ); +/* ... and fake IminLine to reduce the number of traps. */ + val &= ~CTR_IMINLINE_MASK ; + val |= (PAGE_SHIFT -2 ) &CTR_IMINLINE_MASK ; + } +pt_regs_write_reg (regs, rt, val);arm64_skip_faulting_instruction (regs,AARCH64_INSN_SIZE );
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 9/131 arm64: compat: Workaround Neoverse-N1 #1542419 for compat user-space
In reply to Greg Kroah-HartmanFrom: James Morse <[email protected]>
[ Upstream commit: 222fc0c8503d98cec3cb2bac2780cdd21a6e31c0 ]
Compat user-space is unable to perform ICIMVAU instructions from user-space. Instead it uses a compat-syscall. Add the workaround for Neoverse-N1 #1542419 to this code path.
--- arch/arm64/kernel/sys_compat.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm64/kernel/sys_compat.c +11 -0
@@ -19,6 +19,7 @@*/ #include <linux/compat.h> +#include <linux/cpufeature.h> #include <linux/personality.h> #include <linux/sched.h> #include <linux/sched/signal.h>
@@ -28,6 +29,7 @@#include <asm/cacheflush.h> #include <asm/system_misc.h> +#include <asm/tlbflush.h> #include <asm/unistd.h> static long
@@ -41,6 +43,15 @@ __do_compat_cache_op(unsigned long start, unsigned long end)if (fatal_signal_pending (current))return 0 ; +if (cpus_have_const_cap (ARM64_WORKAROUND_1542419 )) { +/* +* The workaround requires an inner-shareable tlbi. +* We pick the reserved-ASID to minimise the impact. +*/ +__tlbi (aside1is,0 ); +dsb (ish); + } + ret =__flush_cache_user_range (start, start + chunk);if (ret)return ret;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 10/131 arm64: Silence clang warning on mismatched value/register sizes
In reply to Greg Kroah-HartmanFrom: Catalin Marinas <[email protected]>
[ Upstream commit: 27a22fbdeedd6c5c451cf5f830d51782bf50c3a2 ]
Clang reports a warning on the __tlbi(aside1is, 0) macro expansion since the value size does not match the register size specified in the inline asm. Construct the ASID value using the __TLBI_VADDR() macro.
--- arch/arm64/kernel/sys_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/sys_compat.c +1 -1
@@ -48,7 +48,7 @@ __do_compat_cache_op(unsigned long start, unsigned long end)* The workaround requires an inner-shareable tlbi. * We pick the reserved-ASID to minimise the impact. */ -__tlbi (aside1is,0 ); +__tlbi (aside1is,__TLBI_VADDR (0 ,0 ));dsb (ish); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 11/131 watchdog: reset last_hw_keepalive time at start
In reply to Greg Kroah-HartmanFrom: Tero Kristo <[email protected]>
[ Upstream commit 982bb70517aef2225bad1d802887b733db492cc0 ]
Currently the watchdog core does not initialize the last_hw_keepalive time during watchdog startup. This will cause the watchdog to be pinged immediately if enough time has passed from the system boot-up time, and some types of watchdogs like K3 RTI does not like this.
To avoid the issue, setup the last_hw_keepalive time during watchdog startup.
--- drivers/watchdog/watchdog_dev.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/watchdog_dev.c +1 -0
@@ -264,6 +264,7 @@ static int watchdog_start(struct watchdog_device *wdd)if (err ==0 ) {set_bit (WDOG_ACTIVE , &wdd->status); wd_data->last_keepalive = started_at; + wd_data->last_hw_keepalive = started_at;watchdog_update_worker (wdd); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 12/131 scsi: lpfc: Fix kasan slab-out-of-bounds error in lpfc_unreg_login
In reply to Greg Kroah-HartmanFrom: James Smart <[email protected]>
[ Upstream commit 38503943c89f0bafd9e3742f63f872301d44cbea ]
The following kasan bug was called out:
BUG: KASAN: slab-out-of-bounds in lpfc_unreg_login+0x7c/0xc0 [lpfc] Read of size 2 at addr ffff889fc7c50a22 by task lpfc_worker_3/6676 ... Call Trace: dump_stack+0x96/0xe0 ? lpfc_unreg_login+0x7c/0xc0 [lpfc] print_address_description.constprop.6+0x1b/0x220 ? lpfc_unreg_login+0x7c/0xc0 [lpfc] ? lpfc_unreg_login+0x7c/0xc0 [lpfc] __kasan_report.cold.9+0x37/0x7c ? lpfc_unreg_login+0x7c/0xc0 [lpfc] kasan_report+0xe/0x20 lpfc_unreg_login+0x7c/0xc0 [lpfc] lpfc_sli_def_mbox_cmpl+0x334/0x430 [lpfc] ...
When processing the completion of a "Reg Rpi" login mailbox command in lpfc_sli_def_mbox_cmpl, a call may be made to lpfc_unreg_login. The vpi is extracted from the completing mailbox context and passed as an input for the next. However, the vpi stored in the mailbox command context is an absolute vpi, which for SLI4 represents both base + offset. When used with a non-zero base component, (function id > 0) this results in an out-of-range access beyond the allocated phba->vpi_ids array.
Fix by subtracting the function's base value to get an accurate vpi number.
--- drivers/scsi/lpfc/lpfc_sli.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/scsi/lpfc/lpfc_sli.c +2 -0
@@ -2472,6 +2472,8 @@ lpfc_sli_def_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) !pmb->u.mb.mbxStatus) { rpi = pmb->u.mb.un.varWords[0 ]; vpi = pmb->u.mb.un.varRegLogin.vpi; +if (phba->sli_rev ==LPFC_SLI_REV4 ) + vpi -= phba->sli4_hba.max_cfg_param.vpi_base;lpfc_unreg_login (phba, vpi, rpi, pmb); pmb->vport = vport; pmb->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 13/131 scsi: lpfc: Fix crash in target side cable pulls hitting WAIT_FOR_UNREG
In reply to Greg Kroah-HartmanFrom: James Smart <[email protected]>
[ Upstream commit 807e7353d8a7105ce884d22b0dbc034993c6679c ]
Kernel is crashing with the following stacktrace:
BUG: unable to handle kernel NULL pointer dereference at
00000000000005bc
IP: lpfc_nvme_register_port+0x1a8/0x3a0 [lpfc]
...
Call Trace:
lpfc_nlp_state_cleanup+0x2b2/0x500 [lpfc]
lpfc_nlp_set_state+0xd7/0x1a0 [lpfc]
lpfc_cmpl_prli_prli_issue+0x1f7/0x450 [lpfc]
lpfc_disc_state_machine+0x7a/0x1e0 [lpfc]
lpfc_cmpl_els_prli+0x16f/0x1e0 [lpfc]
lpfc_sli_sp_handle_rspiocb+0x5b2/0x690 [lpfc]
lpfc_sli_handle_slow_ring_event_s4+0x182/0x230 [lpfc]
lpfc_do_work+0x87f/0x1570 [lpfc]
kthread+0x10d/0x130
ret_from_fork+0x35/0x40During target side fault injections, it is possible to hit the NLP_WAIT_FOR_UNREG case in lpfc_nvme_remoteport_delete. A prior commit fixed a rebind and delete race condition, but called lpfc_nlp_put unconditionally. This triggered a deletion and the crash.
Fix by movng nlp_put to inside the NLP_WAIT_FOR_UNREG case, where the nlp will be being unregistered/removed. Leave the reference if the flag isn't set.
--- drivers/scsi/lpfc/lpfc_nvme.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/scsi/lpfc/lpfc_nvme.c +8 -6
@@ -342,13 +342,15 @@ lpfc_nvme_remoteport_delete(struct nvme_fc_remote_port *remoteport)if (ndlp->upcall_flags &NLP_WAIT_FOR_UNREG ) { ndlp->nrport =NULL ; ndlp->upcall_flags &= ~NLP_WAIT_FOR_UNREG ; - } -spin_unlock_irq (&vport->phba->hbalock); +spin_unlock_irq (&vport->phba->hbalock); -/* Remove original register reference. The host transport -* won't reference this rport/remoteport any further. -*/ -lpfc_nlp_put (ndlp); +/* Remove original register reference. The host transport +* won't reference this rport/remoteport any further. +*/ +lpfc_nlp_put (ndlp); + }else { +spin_unlock_irq (&vport->phba->hbalock); + } rport_err:return ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 14/131 ceph: return ceph_mdsc_do_request() errors from __get_parent()
In reply to Greg Kroah-HartmanFrom: Qiujun Huang <[email protected]>
[ Upstream commit c6d50296032f0b97473eb2e274dc7cc5d0173847 ]
Return the error returned by ceph_mdsc_do_request(). Otherwise, r_target_inode ends up being NULL this ends up returning ENOENT regardless of the error.
--- fs/ceph/export.c | 5 +++++ 1 file changed, 5 insertions(+)
fs/ceph/export.c +5 -0
@@ -151,6 +151,11 @@ static struct dentry *__get_parent(struct super_block *sb, req->r_num_caps =1 ; err =ceph_mdsc_do_request (mdsc,NULL , req); +if (err) { +ceph_mdsc_put_request (req); +return ERR_PTR (err); + } + inode = req->r_target_inode;if (inode)ihold (inode);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 15/131 ceph: dont skip updating wanted caps when cap is stale
In reply to Greg Kroah-HartmanFrom: Yan, Zheng <[email protected]>
[ Upstream commit 0aa971b6fd3f92afef6afe24ef78d9bb14471519 ]
1. try_get_cap_refs() fails to get caps and finds that mds_wanted does not include what it wants. It returns -ESTALE.
2. ceph_get_caps() calls ceph_renew_caps(). ceph_renew_caps() finds that inode has cap, so it calls ceph_check_caps().
3. ceph_check_caps() finds that issued caps (without checking if it's stale) already includes caps wanted by open file, so it skips updating wanted caps.
Above events can cause an infinite loop inside ceph_get_caps().
--- fs/ceph/caps.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
fs/ceph/caps.c +6 -2
@@ -1972,8 +1972,12 @@ retry_locked: }/* want more caps from mds? */ -if (want & ~(cap->mds_wanted | cap->issued)) - goto ack; +if (want & ~cap->mds_wanted) { +if (want & ~(cap->mds_wanted | cap->issued)) + goto ack; +if (!__cap_is_valid (cap)) + goto ack; + }/* things we might delay */ if ((cap->issued & ~retain) == 0 &&
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 16/131 pwm: rcar: Fix late Runtime PM enablement
In reply to Greg Kroah-HartmanFrom: Geert Uytterhoeven <[email protected]>
[ Upstream commit 1451a3eed24b5fd6a604683f0b6995e0e7e16c79 ]
Runtime PM should be enabled before calling pwmchip_add(), as PWM users can appear immediately after the PWM chip has been added. Likewise, Runtime PM should be disabled after the removal of the PWM chip.
--- drivers/pwm/pwm-rcar.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/pwm/pwm-rcar.c +7 -3
@@ -232,24 +232,28 @@ static int rcar_pwm_probe(struct platform_device *pdev) rcar_pwm->chip.base =-1 ; rcar_pwm->chip.npwm =1 ; +pm_runtime_enable (&pdev->dev); + ret =pwmchip_add (&rcar_pwm->chip);if (ret <0 ) {dev_err (&pdev->dev,"failed to register PWM chip: %d\n" , ret); +pm_runtime_disable (&pdev->dev);return ret; } -pm_runtime_enable (&pdev->dev); -return 0 ; }static int rcar_pwm_remove (struct platform_device *pdev) {struct rcar_pwm_chip *rcar_pwm =platform_get_drvdata (pdev); +int ret; + + ret =pwmchip_remove (&rcar_pwm->chip);pm_runtime_disable (&pdev->dev); -return pwmchip_remove (&rcar_pwm->chip); +return ret; }static const struct of_device_id rcar_pwm_of_table[] = {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 17/131 scsi: iscsi: Report unbind session event when the target has been removed
In reply to Greg Kroah-HartmanFrom: Wu Bo <[email protected]>
[ Upstream commit 13e60d3ba287d96eeaf1deaadba51f71578119a3 ]
If the daemon is restarted or crashes while logging out of a session, the unbind session event sent by the kernel is not processed and is lost. When the daemon starts again, the session can't be unbound because the daemon is waiting for the event message. However, the kernel has already logged out and the event will not be resent.
When iscsid restart is complete, logout session reports error:
Logging out of session [sid: 6, target: iqn.xxxxx, portal: xx.xx.xx.xx,3260]
iscsiadm: Could not logout of [sid: 6, target: iscsiadm -m node iqn.xxxxx, portal: xx.xx.xx.xx,3260].
iscsiadm: initiator reported error (9 - internal error)
iscsiadm: Could not logout of all requested sessions
Make sure the unbind event is emitted.
[mkp: commit desc and applied by hand since patch was mangled]
--- drivers/scsi/scsi_transport_iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/scsi/scsi_transport_iscsi.c +3 -1
@@ -2010,7 +2010,7 @@ static void __iscsi_unbind_session(struct work_struct *work)if (session->target_id ==ISCSI_MAX_TARGET ) {spin_unlock_irqrestore (&session->lock, flags);mutex_unlock (&ihost->mutex); -return ; + goto unbind_session_exit; } target_id = session->target_id;
@@ -2022,6 +2022,8 @@ static void __iscsi_unbind_session(struct work_struct *work)ida_simple_remove (&iscsi_sess_ida, target_id);scsi_remove_target (&session->dev); + +unbind_session_exit:iscsi_session_event (session,ISCSI_KEVENT_UNBIND_SESSION );ISCSI_DBG_TRANS_SESSION (session,"Completed target removal\n" ); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 18/131 ASoC: Intel: atom: Take the drv->lock mutex before calling sst_send_slot_map()
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
[ Upstream commit 81630dc042af998b9f58cd8e2c29dab9777ea176 ]
sst_send_slot_map() uses sst_fill_and_send_cmd_unlocked() because in some places it is called with the drv->lock mutex already held.
So it must always be called with the mutex locked. This commit adds missing locking in the sst_set_be_modules() code-path.
--- sound/soc/intel/atom/sst-atom-controls.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/intel/atom/sst-atom-controls.c +2 -0
@@ -974,7 +974,9 @@ static int sst_set_be_modules(struct snd_soc_dapm_widget *w,dev_dbg (c->dev,"Enter: widget=%s\n" , w->name);if (SND_SOC_DAPM_EVENT_ON (event)) { +mutex_lock (&drv->lock); ret =sst_send_slot_map (drv); +mutex_unlock (&drv->lock);if (ret)return ret; ret =sst_send_pipe_module_params (w, k);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 19/131 nvme: fix deadlock caused by ANA update wrong locking
In reply to Greg Kroah-HartmanFrom: Sagi Grimberg <[email protected]>
[ Upstream commit 657f1975e9d9c880fa13030e88ba6cc84964f1db ]
The deadlock combines 4 flows in parallel:
- ns scanning (triggered from reconnect)
- request timeout
- ANA update (triggered from reconnect)
- I/O coming into the mpath device
(1) ns scanning triggers disk revalidation -> update disk info ->
freeze queue -> but blocked, due to (2)
(2) timeout handler reference the g_usage_counter - > but blocks in the transport .timeout() handler, due to (3)
(3) the transport timeout handler (indirectly) calls nvme_stop_queue() -> which takes the (down_read) namespaces_rwsem - > but blocks, due to (4)
(4) ANA update takes the (down_write) namespaces_rwsem -> calls
nvme_mpath_set_live() -> which synchronize the ns_head srcu
(see commit 504db087aacc) -> but blocks, due to (5)(5) I/O came into nvme_mpath_make_request -> took srcu_read_lock ->
direct_make_request > blk_queue_enter -> but blocked, due to (1)
==> the request queue is under freeze -> deadlock.
The fix is making ANA update take a read lock as the namespaces list is not manipulated, it is just the ns and ns->head that are being updated (which is protected with the ns->head lock).
--- drivers/nvme/host/multipath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/host/multipath.c +2 -2
@@ -402,7 +402,7 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl,if (!nr_nsids)return 0 ; -down_write (&ctrl->namespaces_rwsem); +down_read (&ctrl->namespaces_rwsem);list_for_each_entry (ns, &ctrl->namespaces, list) {unsigned nsid =le32_to_cpu (desc->nsids[n]);
@@ -413,7 +413,7 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl,if (++n == nr_nsids)break ; } -up_write (&ctrl->namespaces_rwsem); +up_read (&ctrl->namespaces_rwsem);return 0 ; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 20/131 kernel/gcov/fs.c: gcov_seq_next() should increase position index
In reply to Greg Kroah-HartmanFrom: Vasily Averin <[email protected]>
[ Upstream commit f4d74ef6220c1eda0875da30457bef5c7111ab06 ]
If seq_file .next function does not change position index, read after some lseek can generate unexpected output.
https://bugzilla.kernel.org/show_bug.cgi?id=206283
--- kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/gcov/fs.c +1 -1
@@ -109,9 +109,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos) {struct gcov_iterator *iter = data; + (*pos)++;if (gcov_iter_next (iter))return NULL ; - (*pos)++;return iter; }
Signature · 14 lines
2.20.1 sizeof(kctl->id.name)); + + if (check_mapped_name(map, kctl->id.name, sizeof(kctl->id.name))) + strlcat(kctl->id.name, " Jack", sizeof(kctl->id.name)); + else + get_connector_control_name(mixer, term, is_input, kctl->id.name, + sizeof(kctl->id.name)); kctl->private_free = snd_usb_mixer_elem_free; snd_usb_mixer_add_control(&cval->head, kctl); }
sound/usb/mixer_maps.c +21 -3
@@ -369,6 +369,24 @@ static const struct usbmix_name_map asus_rog_map[] = { {} }; +/* TRX40 mobos with Realtek ALC1220-VB */ +static const struct usbmix_name_map trx40_mobo_map[] = { + {18 ,NULL },/* OT, IEC958 - broken response, disabled */ + {19 ,NULL ,12 },/* FU, Input Gain Pad - broken response, disabled */ + {16 ,"Speaker" },/* OT */ + {22 ,"Speaker Playback" },/* FU */ + {7 ,"Line" },/* IT */ + {19 ,"Line Capture" },/* FU */ + {17 ,"Front Headphone" },/* OT */ + {23 ,"Front Headphone Playback" },/* FU */ + {8 ,"Mic" },/* IT */ + {20 ,"Mic Capture" },/* FU */ + {9 ,"Front Mic" },/* IT */ + {21 ,"Front Mic Capture" },/* FU */ + {24 ,"IEC958 Playback" },/* FU */ + {} +}; +/* * Control map entries */
@@ -500,7 +518,7 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = { }, {/* Gigabyte TRX40 Aorus Pro WiFi */ .id = USB_ID(0x0414, 0xa002), - .map = asus_rog_map, + .map = trx40_mobo_map, }, {/* ASUS ROG Zenith II */ .id = USB_ID(0x0b05, 0x1916),
@@ -512,11 +530,11 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = { }, {/* MSI TRX40 Creator */ .id = USB_ID(0x0db0, 0x0d64), - .map = asus_rog_map, + .map = trx40_mobo_map, }, {/* MSI TRX40 */ .id = USB_ID(0x0db0, 0x543d), - .map = asus_rog_map, + .map = trx40_mobo_map, }, { 0 } /* terminator */ };
sound/usb/quirks-table.h +14 -0
@@ -3635,4 +3635,18 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"), } }, +#define ALC1220_VB_DESKTOP (vend, prod) { \ + USB_DEVICE(vend, prod), \ + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { \ + .vendor_name = "Realtek", \ + .product_name = "ALC1220-VB-DT", \ + .profile_name = "Realtek-ALC1220-VB-Desktop", \ + .ifnum = QUIRK_NO_INTERFACE \ + } \ +} +ALC1220_VB_DESKTOP (0x0414 ,0xa002 ),/* Gigabyte TRX40 Aorus Pro WiFi */ +ALC1220_VB_DESKTOP (0x0db0 ,0x0d64 ),/* MSI TRX40 Creator */ +ALC1220_VB_DESKTOP (0x0db0 ,0x543d ),/* MSI TRX40 */ +#undef ALC1220_VB_DESKTOP + #undef USB_DEVICE_VENDOR_SPEC
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 21/131 selftests: kmod: fix handling test numbers above 9
In reply to Greg Kroah-HartmanFrom: Eric Biggers <[email protected]>
[ Upstream commit 6d573a07528308eb77ec072c010819c359bebf6e ]
get_test_count() and get_test_enabled() were broken for test numbers above 9 due to awk interpreting a field specification like '$0010' as octal rather than decimal. Fix it by stripping the leading zeroes.
--- tools/testing/selftests/kmod/kmod.sh | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
tools/testing/selftests/kmod/kmod.sh +9 -4
@@ -505,18 +505,23 @@ function test_num() fi } -function get_test_count() +function get_test_data() { test_num $1 - TEST_DATA=$(echo $ALL_TESTS | awk '{print $'$1'}') + local field_num=$(echo $1 | sed 's/^0*//') + echo $ALL_TESTS | awk '{print $'$field_num'}' +} + +function get_test_count() +{ + TEST_DATA=$(get_test_data $1) LAST_TWO=${TEST_DATA#*:*} echo ${LAST_TWO%:*} } function get_test_enabled() { - test_num $1 - TEST_DATA=$(echo $ALL_TESTS | awk '{print $'$1'}') + TEST_DATA=$(get_test_data $1) echo ${TEST_DATA#*:*:} }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 22/131 ipc/util.c: sysvipc_find_ipc() should increase position index
In reply to Greg Kroah-HartmanFrom: Vasily Averin <[email protected]>
[ Upstream commit 89163f93c6f969da5811af5377cc10173583123b ]
If seq_file .next function does not change position index, read after some lseek can generate unexpected output.
https://bugzilla.kernel.org/show_bug.cgi?id=206283
--- ipc/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ipc/util.c +1 -1
@@ -735,13 +735,13 @@ static struct kern_ipc_perm *sysvipc_find_ipc(struct ipc_ids *ids, loff_t pos, total++; } + *new_pos = pos +1 ;if (total >= ids->in_use)return NULL ;for (; pos <IPCMNI ; pos++) { ipc =idr_find (&ids->ipcs_idr, pos);if (ipc !=NULL ) { - *new_pos = pos +1 ;rcu_read_lock ();ipc_lock_object (ipc);return ipc;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 23/131 kconfig: qconf: Fix a few alignment issues
In reply to Greg Kroah-HartmanFrom: Mauro Carvalho Chehab <[email protected]>
[ Upstream commit 60969f02f07ae1445730c7b293c421d179da729c ]
There are a few items with wrong alignments. Solve them.
--- scripts/kconfig/qconf.cc | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
scripts/kconfig/qconf.cc +7 -6
@@ -627,7 +627,7 @@ void ConfigList::updateMenuList(ConfigItem *parent, struct menu* menu) last = item; continue; } - hide: +hide: if (item && item->menu == child) { last = parent->firstChild(); if (last == item)
@@ -692,7 +692,7 @@ void ConfigList::updateMenuList(ConfigList *parent, struct menu* menu) last = item; continue; } - hide: +hide: if (item && item->menu == child) { last = (ConfigItem*)parent->topLevelItem(0); if (last == item)
@@ -1225,10 +1225,11 @@ QMenu* ConfigInfoView::createStandardContextMenu(const QPoint & pos) { QMenu* popup = Parent::createStandardContextMenu(pos); QAction* action = new QAction("Show Debug Info", popup); - action->setCheckable(true); - connect(action, SIGNAL(toggled(bool)), SLOT(setShowDebug(bool))); - connect(this, SIGNAL(showDebugChanged(bool)), action, SLOT(setOn(bool))); - action->setChecked(showDebug()); + + action->setCheckable(true); + connect(action, SIGNAL(toggled(bool)), SLOT(setShowDebug(bool))); + connect(this, SIGNAL(showDebugChanged(bool)), action, SLOT(setOn(bool))); + action->setChecked(showDebug()); popup->addSeparator(); popup->addAction(action); return popup;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 24/131 s390/cio: avoid duplicated ADD uevents
In reply to Greg Kroah-HartmanFrom: Cornelia Huck <[email protected]>
[ Upstream commit 05ce3e53f375295c2940390b2b429e506e07655c ]
The common I/O layer delays the ADD uevent for subchannels and delegates generating this uevent to the individual subchannel drivers. The io_subchannel driver will do so when the associated ccw_device has been registered -- but unconditionally, so more ADD uevents will be generated if a subchannel has been unbound from the io_subchannel driver and later rebound.
To fix this, only generate the ADD event if uevents were still suppressed for the device.
Message-Id: <[email protected]>
--- drivers/s390/cio/device.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
drivers/s390/cio/device.c +9 -4
@@ -827,8 +827,10 @@ static void io_subchannel_register(struct ccw_device *cdev)* Now we know this subchannel will stay, we can throw * our delayed uevent. */ -dev_set_uevent_suppress (&sch->dev,0 ); -kobject_uevent (&sch->dev.kobj,KOBJ_ADD ); +if (dev_get_uevent_suppress (&sch->dev)) { +dev_set_uevent_suppress (&sch->dev,0 ); +kobject_uevent (&sch->dev.kobj,KOBJ_ADD ); + }/* make it known to the system */ ret =ccw_device_add (cdev);if (ret) {
@@ -1036,8 +1038,11 @@ static int io_subchannel_probe(struct subchannel *sch)* Throw the delayed uevent for the subchannel, register * the ccw_device and exit. */ -dev_set_uevent_suppress (&sch->dev,0 ); -kobject_uevent (&sch->dev.kobj,KOBJ_ADD ); +if (dev_get_uevent_suppress (&sch->dev)) { +/* should always be the case for the console */ +dev_set_uevent_suppress (&sch->dev,0 ); +kobject_uevent (&sch->dev.kobj,KOBJ_ADD ); + } cdev =sch_get_cdev (sch); rc =ccw_device_add (cdev);if (rc) {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 25/131 loop: Better discard support for block devices
In reply to Greg Kroah-HartmanFrom: Evan Green <[email protected]>
[ Upstream commit c52abf563049e787c1341cdf15c7dbe1bfbc951b ]
If the backing device for a loop device is itself a block device, then mirror the "write zeroes" capabilities of the underlying block device into the loop device. Copy this capability into both max_write_zeroes_sectors and max_discard_sectors of the loop device.
The reason for this is that REQ_OP_DISCARD on a loop device translates into blkdev_issue_zeroout(), rather than blkdev_issue_discard(). This presents a consistent interface for loop devices (that discarded data is zeroed), regardless of the backing device type of the loop device. There should be no behavior change for loop devices backed by regular files.
This change fixes blktest block/003, and removes an extraneous error print in block/013 when testing on a loop device backed by a block device that does not support discard.
--- drivers/block/loop.c | 42 +++++++++++++++++++++++++++++++----------- 1 file changed, 31 insertions(+), 11 deletions(-)
drivers/block/loop.c +31 -11
@@ -426,11 +426,12 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,* information. */ struct file *file = lo->lo_backing_file; +struct request_queue *q = lo->lo_queue;int ret; mode |=FALLOC_FL_KEEP_SIZE ; -if ((!file->f_op->fallocate) || lo->lo_encrypt_key_size) { +if (!blk_queue_discard (q)) { ret = -EOPNOTSUPP ; goto out; }
@@ -864,28 +865,47 @@ static void loop_config_discard(struct loop_device *lo)struct inode *inode = file->f_mapping->host;struct request_queue *q = lo->lo_queue; +/* +* If the backing device is a block device, mirror its zeroing +* capability. Set the discard sectors to the block device's zeroing +* capabilities because loop discards result in blkdev_issue_zeroout(), +* not blkdev_issue_discard(). This maintains consistent behavior with +* file-backed loop devices: discarded regions read back as zero. +*/ +if (S_ISBLK (inode->i_mode) && !lo->lo_encrypt_key_size) { +struct request_queue *backingq; + + backingq =bdev_get_queue (inode->i_bdev); +blk_queue_max_discard_sectors (q, + backingq->limits.max_write_zeroes_sectors); + +blk_queue_max_write_zeroes_sectors (q, + backingq->limits.max_write_zeroes_sectors); +/* * We use punch hole to reclaim the free space used by the * image a.k.a. discard. However we do not support discard if * encryption is enabled, because it may give an attacker * useful information. */ -if ((!file->f_op->fallocate) || - lo->lo_encrypt_key_size) { + }else if (!file->f_op->fallocate || lo->lo_encrypt_key_size) { q->limits.discard_granularity =0 ; q->limits.discard_alignment =0 ;blk_queue_max_discard_sectors (q,0 );blk_queue_max_write_zeroes_sectors (q,0 ); -blk_queue_flag_clear (QUEUE_FLAG_DISCARD , q); -return ; - } - q->limits.discard_granularity = inode->i_sb->s_blocksize; - q->limits.discard_alignment =0 ; + }else { + q->limits.discard_granularity = inode->i_sb->s_blocksize; + q->limits.discard_alignment =0 ; -blk_queue_max_discard_sectors (q,UINT_MAX >>9 ); -blk_queue_max_write_zeroes_sectors (q,UINT_MAX >>9 ); -blk_queue_flag_set (QUEUE_FLAG_DISCARD , q); +blk_queue_max_discard_sectors (q,UINT_MAX >>9 ); +blk_queue_max_write_zeroes_sectors (q,UINT_MAX >>9 ); + } + +if (q->limits.max_write_zeroes_sectors) +blk_queue_flag_set (QUEUE_FLAG_DISCARD , q); +else +blk_queue_flag_clear (QUEUE_FLAG_DISCARD , q); }static void loop_unprepare_queue (struct loop_device *lo)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 26/131 Revert "powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled"
In reply to Greg Kroah-HartmanFrom: Nicholas Piggin <[email protected]>
[ Upstream commit abc3fce76adbdfa8f87272c784b388cd20b46049 ]
This reverts commit ebb37cf3ffd39fdb6ec5b07111f8bb2f11d92c5f.
That commit does not play well with soft-masked irq state manipulations in idle, interrupt replay, and possibly others due to tracing code sometimes using irq_work_queue (e.g., in trace_hardirqs_on()). That can cause PACA_IRQ_DEC to become set when it is not expected, and be ignored or cleared or cause warnings.
The net result seems to be missing an irq_work until the next timer interrupt in the worst case which is usually not going to be noticed, however it could be a long time if the tick is disabled, which is against the spirit of irq_work and might cause real problems.
The idea is still solid, but it would need more work. It's not really clear if it would be worth added complexity, so revert this for now (not a straight revert, but replace with a comment explaining why we might see interrupts happening, and gives git blame something to find).
--- arch/powerpc/kernel/time.c | 44 +++++++++++--------------------------- 1 file changed, 13 insertions(+), 31 deletions(-)
arch/powerpc/kernel/time.c +13 -31
@@ -492,35 +492,6 @@ static inline void clear_irq_work_pending(void) "i" (offsetof(struct paca_struct, irq_work_pending))); } -void arch_irq_work_raise (void ) -{ -preempt_disable (); -set_irq_work_pending_flag (); -/* -* Non-nmi code running with interrupts disabled will replay -* irq_happened before it re-enables interrupts, so setthe -* decrementer there instead of causing a hardware exception -* which would immediately hit the masked interrupt handler -* and have the net effect of setting the decrementer in -* irq_happened. -* -* NMI interrupts can not check this when they return, so the -* decrementer hardware exception is raised, which will fire -* when interrupts are next enabled. -* -* BookE does not support this yet, it must audit all NMI -* interrupt handlers to ensure they call nmi_enter() so this -* check would be correct. -*/ -if (IS_ENABLED (CONFIG_BOOKE ) || !irqs_disabled () ||in_nmi ()) { -set_dec (1 ); - }else { -hard_irq_disable (); - local_paca->irq_happened |=PACA_IRQ_DEC ; - } -preempt_enable (); -} -#else /* 32-bit */ DEFINE_PER_CPU (u8, irq_work_pending);
@@ -529,16 +500,27 @@ DEFINE_PER_CPU(u8, irq_work_pending);#define test_irq_work_pending () __this_cpu_read(irq_work_pending)#define clear_irq_work_pending () __this_cpu_write(irq_work_pending, 0) +#endif /* 32 vs 64 bit */ +void arch_irq_work_raise (void ) { +/* +* 64-bit code that uses irq soft-mask can just cause an immediate +* interrupt here that gets soft masked, if this is called under +* local_irq_disable(). It might be possible to prevent that happening +* by noticing interrupts are disabled and setting decrementer pending +* to be replayed when irqs are enabled. The problem there is that +* tracing can call irq_work_raise, including in code that does low +* level manipulations of irq soft-mask state (e.g., trace_hardirqs_on) +* which could get tangled up if we're messing with the same state +* here. +*/ preempt_disable ();set_irq_work_pending_flag ();set_dec (1 );preempt_enable (); } -#endif /* 32 vs 64 bit */ -#else /* CONFIG_IRQ_WORK */ #define test_irq_work_pending () 0
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 27/131 pwm: renesas-tpu: Fix late Runtime PM enablement
In reply to Greg Kroah-HartmanFrom: Geert Uytterhoeven <[email protected]>
[ Upstream commit d5a3c7a4536e1329a758e14340efd0e65252bd3d ]
Runtime PM should be enabled before calling pwmchip_add(), as PWM users can appear immediately after the PWM chip has been added. Likewise, Runtime PM should always be disabled after the removal of the PWM chip, even if the latter failed.
--- drivers/pwm/pwm-renesas-tpu.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/pwm/pwm-renesas-tpu.c +4 -5
@@ -423,16 +423,17 @@ static int tpu_probe(struct platform_device *pdev) tpu->chip.base =-1 ; tpu->chip.npwm =TPU_CHANNEL_MAX ; +pm_runtime_enable (&pdev->dev); + ret =pwmchip_add (&tpu->chip);if (ret <0 ) {dev_err (&pdev->dev,"failed to register PWM chip\n" ); +pm_runtime_disable (&pdev->dev);return ret; }dev_info (&pdev->dev,"TPU PWM %d registered\n" , tpu->pdev->id); -pm_runtime_enable (&pdev->dev); -return 0 ; }
@@ -442,12 +443,10 @@ static int tpu_remove(struct platform_device *pdev)int ret; ret =pwmchip_remove (&tpu->chip); -if (ret) -return ret;pm_runtime_disable (&pdev->dev); -return 0 ; +return ret; }#ifdef CONFIG_OF
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 28/131 pwm: bcm2835: Dynamically allocate base
In reply to Greg Kroah-HartmanFrom: Florian Fainelli <[email protected]>
[ Upstream commit 2c25b07e5ec119cab609e41407a1fb3fa61442f5 ]
The newer 2711 and 7211 chips have two PWM controllers and failure to dynamically allocate the PWM base would prevent the second PWM controller instance being probed for succeeding with an -EEXIST error from alloc_pwms().
--- drivers/pwm/pwm-bcm2835.c | 1 + 1 file changed, 1 insertion(+)
drivers/pwm/pwm-bcm2835.c +1 -0
@@ -166,6 +166,7 @@ static int bcm2835_pwm_probe(struct platform_device *pdev) pc->chip.dev = &pdev->dev; pc->chip.ops = &bcm2835_pwm_ops; + pc->chip.base =-1 ; pc->chip.npwm =2 ; pc->chip.of_xlate = of_pwm_xlate_with_flags; pc->chip.of_pwm_n_cells =3 ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 29/131 perf/core: Disable page faults when getting phys address
In reply to Greg Kroah-HartmanFrom: Jiri Olsa <[email protected]>
[ Upstream commit d3296fb372bf7497b0e5d0478c4e7a677ec6f6e9 ]
We hit following warning when running tests on kernel compiled with CONFIG_DEBUG_ATOMIC_SLEEP=y:
WARNING: CPU: 19 PID: 4472 at mm/gup.c:2381 __get_user_pages_fast+0x1a4/0x200 CPU: 19 PID: 4472 Comm: dummy Not tainted 5.6.0-rc6+ #3 RIP: 0010:__get_user_pages_fast+0x1a4/0x200 ... Call Trace: perf_prepare_sample+0xff1/0x1d90 perf_event_output_forward+0xe8/0x210 __perf_event_overflow+0x11a/0x310 __intel_pmu_pebs_event+0x657/0x850 intel_pmu_drain_pebs_nhm+0x7de/0x11d0 handle_pmi_common+0x1b2/0x650 intel_pmu_handle_irq+0x17b/0x370 perf_event_nmi_handler+0x40/0x60 nmi_handle+0x192/0x590 default_do_nmi+0x6d/0x150 do_nmi+0x2f9/0x3c0 nmi+0x8e/0xd7
While __get_user_pages_fast() is IRQ-safe, it calls access_ok(), which warns on:
WARN_ON_ONCE(!in_task() && !pagefault_disabled())
Peter suggested disabling page faults around __get_user_pages_fast(), which gets rid of the warning in access_ok() call.
--- kernel/events/core.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
kernel/events/core.c +6 -3
@@ -6411,9 +6411,12 @@ static u64 perf_virt_to_phys(u64 virt)* Try IRQ-safe __get_user_pages_fast first. * If failed, leave phys_addr as 0. */ -if ((current->mm !=NULL ) && - (__get_user_pages_fast (virt,1 ,0 , &p) ==1 )) - phys_addr =page_to_phys (p) + virt %PAGE_SIZE ; +if (current->mm !=NULL ) { +pagefault_disable (); +if (__get_user_pages_fast (virt,1 ,0 , &p) ==1 ) + phys_addr =page_to_phys (p) + virt %PAGE_SIZE ; +pagefault_enable (); + }if (p)put_page (p);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 30/131 ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
[ Upstream commit c8b78f24c1247b7bd0882885c672d9dec5800bc6 ]
The MPMAN MPWIN895CL tablet almost fully works with out default settings. The only problem is that it has only 1 speaker so any sounds only playing on the right channel get lost.
Add a quirk for this model using the default settings + MONO_SPEAKER.
--- sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
sound/soc/intel/boards/bytcr_rt5640.c +11 -0
@@ -588,6 +588,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { +/* MPMAN MPWIN895CL */ + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"MPMAN" ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"), + }, + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | +BYT_RT5640_MONO_SPEAKER | +BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { /* MSI S100 tablet */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 31/131 xhci: Ensure link state is U3 after setting USB_SS_PORT_LS_U3
In reply to Greg Kroah-HartmanFrom: Kai-Heng Feng <[email protected]>
[ Upstream commit eb002726fac7cefb98ff39ddb89e150a1c24fe85 ]
The xHCI spec doesn't specify the upper bound of U3 transition time. For some devices 20ms is not enough, so we need to make sure the link state is in U3 before further actions.
I've tried to use U3 Entry Capability by setting U3 Entry Enable in config register, however the port change event for U3 transition interrupts the system suspend process.
For now let's use the less ideal method by polling PLS.
--- drivers/usb/host/xhci-hub.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
drivers/usb/host/xhci-hub.c +10 -1
@@ -1266,7 +1266,16 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,xhci_set_link_state (xhci, ports[wIndex], link_state);spin_unlock_irqrestore (&xhci->lock, flags); -msleep (20 );/* wait device to enter */ +if (link_state ==USB_SS_PORT_LS_U3 ) { +int retries =16 ; + +while (retries--) { +usleep_range (4000 ,8000 ); + temp =readl (ports[wIndex]->addr); +if ((temp &PORT_PLS_MASK ) ==XDEV_U3 ) +break ; + } + }spin_lock_irqsave (&xhci->lock, flags); temp =readl (ports[wIndex]->addr);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 32/131 drm/amd/display: Not doing optimize bandwidth if flip pending.
In reply to Greg Kroah-HartmanFrom: Yongqiang Sun <[email protected]>
[ Upstream commit 9941b8129030c9202aaf39114477a0e58c0d6ffc ]
[Why]
In some scenario like 1366x768 VSR enabled connected with a 4K monitor and playing 4K video in clone mode, underflow will be observed due to decrease dppclk when previouse surface scan isn't finished
[How]
In this use case, surface flip is switching between 4K and 1366x768, 1366x768 needs smaller dppclk, and when decrease the clk and previous surface scan is for 4K and scan isn't done, underflow will happen. Not doing optimize bandwidth in case of flip pending.
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc.c +23 -0
@@ -996,6 +996,26 @@ bool dc_commit_state(struct dc *dc, struct dc_state *context)return (result ==DC_OK ); } +static bool is_flip_pending_in_pipes (struct dc *dc,struct dc_state *context) +{ +int i; +struct pipe_ctx *pipe; + +for (i =0 ; i <MAX_PIPES ; i++) { + pipe = &context->res_ctx.pipe_ctx[i]; + +if (!pipe->plane_state) +continue ; + +/* Must set to false to start with, due to OR in update function */ + pipe->plane_state->status.is_flip_pending = false; + dc->hwss.update_pending_status (pipe); +if (pipe->plane_state->status.is_flip_pending) +return true; + } +return false; +} +bool dc_post_update_surfaces_to_stream (struct dc *dc) {int i;
@@ -1003,6 +1023,9 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)post_surface_trace (dc); +if (is_flip_pending_in_pipes (dc, context)) +return true; +for (i =0 ; i < dc->res_pool->pipe_count; i++)if (context->res_ctx.pipe_ctx[i].stream ==NULL || context->res_ctx.pipe_ctx[i].plane_state ==NULL ) {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 33/131 tracing/selftests: Turn off timeout setting
In reply to Greg Kroah-HartmanFrom: Steven Rostedt (VMware) <[email protected]>
[ Upstream commit b43e78f65b1d35fd3e13c7b23f9b64ea83c9ad3a ]
As the ftrace selftests can run for a long period of time, disable the timeout that the general selftests have. If a selftest hangs, then it probably means the machine will hang too.
--- tools/testing/selftests/ftrace/settings | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/ftrace/settings
tools/testing/selftests/ftrace/settings new file +1 -0
@@ -0,0 +1 @@ +timeout=0
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 34/131 virtio-blk: improve virtqueue error to BLK_STS
In reply to Greg Kroah-HartmanFrom: Halil Pasic <[email protected]>
[ Upstream commit 3d973b2e9a625996ee997c7303cd793b9d197c65 ]
Let's change the mapping between virtqueue_add errors to BLK_STS statuses, so that -ENOSPC, which indicates virtqueue full is still mapped to BLK_STS_DEV_RESOURCE, but -ENOMEM which indicates non-device specific resource outage is mapped to BLK_STS_RESOURCE.
--- drivers/block/virtio_blk.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/block/virtio_blk.c +7 -2
@@ -277,9 +277,14 @@ static blk_status_t virtio_queue_rq(struct blk_mq_hw_ctx *hctx,if (err == -ENOSPC )blk_mq_stop_hw_queue (hctx);spin_unlock_irqrestore (&vblk->vqs[qid].lock, flags); -if (err == -ENOMEM || err == -ENOSPC ) +switch (err) { +case -ENOSPC :return BLK_STS_DEV_RESOURCE ; -return BLK_STS_IOERR ; +case -ENOMEM : +return BLK_STS_RESOURCE ; +default : +return BLK_STS_IOERR ; + } }if (bd->last &&virtqueue_kick_prepare (vblk->vqs[qid].vq))
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 35/131 scsi: smartpqi: fix call trace in device discovery
In reply to Greg Kroah-HartmanFrom: Murthy Bhat <[email protected]>
[ Upstream commit b969261134c1b990b96ea98fe5e0fcf8ec937c04 ]
Use sas_phy_delete rather than sas_phy_free which, according to comments, should not be called for PHYs that have been set up successfully.
--- drivers/scsi/smartpqi/smartpqi_sas_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/smartpqi/smartpqi_sas_transport.c +1 -1
@@ -50,9 +50,9 @@ static void pqi_free_sas_phy(struct pqi_sas_phy *pqi_sas_phy)struct sas_phy *phy = pqi_sas_phy->phy;sas_port_delete_phy (pqi_sas_phy->parent_port->port, phy); -sas_phy_free (phy);if (pqi_sas_phy->added_to_port)list_del (&pqi_sas_phy->phy_list_entry); +sas_phy_delete (phy);kfree (pqi_sas_phy); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 36/131 PCI/ASPM: Allow re-enabling Clock PM
In reply to Greg Kroah-HartmanFrom: Heiner Kallweit <[email protected]>
[ Upstream commit 35efea32b26f9aacc99bf07e0d2cdfba2028b099 ]
Previously Clock PM could not be re-enabled after being disabled by pci_disable_link_state() because clkpm_capable was reset. Change this by adding a clkpm_disable field similar to aspm_disable.
--- drivers/pci/pcie/aspm.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
drivers/pci/pcie/aspm.c +11 -7
@@ -67,6 +67,7 @@ struct pcie_link_state { u32 clkpm_capable:1; /* Clock PM capable? */ u32 clkpm_enabled:1; /* Current Clock PM state */ u32 clkpm_default:1; /* Default Clock PM state by BIOS */ + u32 clkpm_disable:1; /* Clock PM disabled *//* Exit latencies */ struct aspm_latency latency_up;/* Upstream direction exit latency */
@@ -164,8 +165,11 @@ static void pcie_set_clkpm_nocheck(struct pcie_link_state *link, int enable)static void pcie_set_clkpm (struct pcie_link_state *link,int enable) { -/* Don't enable Clock PM if the link is not Clock PM capable */ -if (!link->clkpm_capable) +/* +* Don't enable Clock PM if the link is not Clock PM capable +* or Clock PM is disabled +*/ +if (!link->clkpm_capable || link->clkpm_disable) enable =0 ;/* Need nothing if the specified equals to current state */ if (link->clkpm_enabled == enable)
@@ -195,7 +199,8 @@ static void pcie_clkpm_cap_init(struct pcie_link_state *link, int blacklist) } link->clkpm_enabled = enabled; link->clkpm_default = enabled; - link->clkpm_capable = (blacklist) ?0 : capable; + link->clkpm_capable = capable; + link->clkpm_disable = blacklist ?1 :0 ; }static bool pcie_retrain_link (struct pcie_link_state *link)
@@ -1106,10 +1111,9 @@ static void __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem) link->aspm_disable |=ASPM_STATE_L1 ;pcie_config_aspm_link (link,policy_to_aspm_state (link)); -if (state &PCIE_LINK_STATE_CLKPM ) { - link->clkpm_capable =0 ; -pcie_set_clkpm (link,0 ); - } +if (state &PCIE_LINK_STATE_CLKPM ) + link->clkpm_disable =1 ; +pcie_set_clkpm (link,policy_to_clkpm_state (link));mutex_unlock (&aspm_lock);if (sem)up_read (&pci_bus_sem);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 37/131 net: ipv6: add net argument to ip6_dst_lookup_flow
In reply to Greg Kroah-HartmanFrom: Sabrina Dubroca <[email protected]>
commit c4e85f73afb6384123e5ef1bba3315b2e3ad031e upstream.
This will be used in the conversion of ipv6_stub to ip6_dst_lookup_flow, as some modules currently pass a net argument without a socket to ip6_dst_lookup. This is equivalent to commit 343d60aada5a ("ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument").
--- include/net/ipv6.h | 2 +- net/dccp/ipv6.c | 6 +++--- net/ipv6/af_inet6.c | 2 +- net/ipv6/datagram.c | 2 +- net/ipv6/inet6_connection_sock.c | 4 ++-- net/ipv6/ip6_output.c | 8 ++++---- net/ipv6/raw.c | 2 +- net/ipv6/syncookies.c | 2 +- net/ipv6/tcp_ipv6.c | 4 ++-- net/l2tp/l2tp_ip6.c | 2 +- net/sctp/ipv6.c | 4 ++-- 11 files changed, 19 insertions(+), 19 deletions(-)
include/net/ipv6.h +1 -1
@@ -959,7 +959,7 @@ static inline struct sk_buff *ip6_finish_skb(struct sock *sk)int ip6_dst_lookup (struct net *net,struct sock *sk,struct dst_entry **dst,struct flowi6 *fl6); -struct dst_entry *ip6_dst_lookup_flow (const struct sock *sk,struct flowi6 *fl6, +struct dst_entry *ip6_dst_lookup_flow (struct net *net,const struct sock *sk,struct flowi6 *fl6,const struct in6_addr *final_dst); struct dst_entry *ip6_sk_dst_lookup_flow(struct sock *sk, struct flowi6 *fl6, const struct in6_addr *final_dst,
net/dccp/ipv6.c +3 -3
@@ -211,7 +211,7 @@ static int dccp_v6_send_response(const struct sock *sk, struct request_sock *req final_p =fl6_update_dst (&fl6,rcu_dereference (np->opt), &final);rcu_read_unlock (); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) { err =PTR_ERR (dst); dst =NULL ;
@@ -282,7 +282,7 @@ static void dccp_v6_ctl_send_reset(const struct sock *sk, struct sk_buff *rxskb)security_skb_classify_flow (rxskb,flowi6_to_flowi (&fl6));/* sk = NULL, but it is safe for now. RST socket required. */ - dst =ip6_dst_lookup_flow (ctl_sk, &fl6,NULL ); + dst =ip6_dst_lookup_flow (sock_net (ctl_sk), ctl_sk, &fl6,NULL );if (!IS_ERR (dst)) {skb_dst_set (skb, dst);ip6_xmit (ctl_sk, skb, &fl6,0 ,NULL ,0 );
@@ -912,7 +912,7 @@ static int dccp_v6_connect(struct sock *sk, struct sockaddr *uaddr, opt =rcu_dereference_protected (np->opt,lockdep_sock_is_held (sk)); final_p =fl6_update_dst (&fl6, opt, &final); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) { err =PTR_ERR (dst); goto failure;
net/ipv6/af_inet6.c +1 -1
@@ -740,7 +740,7 @@ int inet6_sk_rebuild_header(struct sock *sk) &final);rcu_read_unlock (); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) { sk->sk_route_caps =0 ; sk->sk_err_soft = -PTR_ERR (dst);
net/ipv6/datagram.c +1 -1
@@ -89,7 +89,7 @@ int ip6_datagram_dst_update(struct sock *sk, bool fix_sk_saddr) final_p =fl6_update_dst (&fl6, opt, &final);rcu_read_unlock (); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) { err =PTR_ERR (dst); goto out;
net/ipv6/inet6_connection_sock.c +2 -2
@@ -52,7 +52,7 @@ struct dst_entry *inet6_csk_route_req(const struct sock *sk, fl6->flowi6_uid = sk->sk_uid;security_req_classify_flow (req,flowi6_to_flowi (fl6)); - dst =ip6_dst_lookup_flow (sk, fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, fl6, final_p);if (IS_ERR (dst))return NULL ;
@@ -107,7 +107,7 @@ static struct dst_entry *inet6_csk_route_socket(struct sock *sk, dst =__inet6_csk_dst_check (sk, np->dst_cookie);if (!dst) { - dst =ip6_dst_lookup_flow (sk, fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, fl6, final_p);if (!IS_ERR (dst))ip6_dst_store (sk, dst,NULL ,NULL );
net/ipv6/ip6_output.c +4 -4
@@ -1071,19 +1071,19 @@ EXPORT_SYMBOL_GPL(ip6_dst_lookup);* It returns a valid dst pointer on success, or a pointer encoded * error code. */ -struct dst_entry *ip6_dst_lookup_flow (const struct sock *sk,struct flowi6 *fl6, +struct dst_entry *ip6_dst_lookup_flow (struct net *net,const struct sock *sk,struct flowi6 *fl6,const struct in6_addr *final_dst) {struct dst_entry *dst =NULL ;int err; - err =ip6_dst_lookup_tail (sock_net (sk), sk, &dst, fl6); + err =ip6_dst_lookup_tail (net, sk, &dst, fl6);if (err)return ERR_PTR (err);if (final_dst) fl6->daddr = *final_dst; -return xfrm_lookup_route (sock_net (sk), dst,flowi6_to_flowi (fl6), sk,0 ); +return xfrm_lookup_route (net, dst,flowi6_to_flowi (fl6), sk,0 ); }EXPORT_SYMBOL_GPL (ip6_dst_lookup_flow);
@@ -1115,7 +1115,7 @@ struct dst_entry *ip6_sk_dst_lookup_flow(struct sock *sk, struct flowi6 *fl6,if (dst)return dst; - dst =ip6_dst_lookup_flow (sk, fl6, final_dst); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, fl6, final_dst);if (connected && !IS_ERR (dst))ip6_sk_dst_store_flow (sk,dst_clone (dst), fl6);
net/ipv6/raw.c +1 -1
@@ -928,7 +928,7 @@ static int rawv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) fl6.flowlabel =ip6_make_flowinfo (ipc6.tclass, fl6.flowlabel); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) { err =PTR_ERR (dst); goto out;
net/ipv6/syncookies.c +1 -1
@@ -240,7 +240,7 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb) fl6.flowi6_uid = sk->sk_uid;security_req_classify_flow (req,flowi6_to_flowi (&fl6)); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) goto out_free; }
net/ipv6/tcp_ipv6.c +2 -2
@@ -268,7 +268,7 @@ static int tcp_v6_connect(struct sock *sk, struct sockaddr *uaddr,security_sk_classify_flow (sk,flowi6_to_flowi (&fl6)); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) { err =PTR_ERR (dst); goto failure;
@@ -885,7 +885,7 @@ static void tcp_v6_send_response(const struct sock *sk, struct sk_buff *skb, u32* Underlying function will use this to retrieve the network * namespace */ - dst =ip6_dst_lookup_flow (ctl_sk, &fl6,NULL ); + dst =ip6_dst_lookup_flow (sock_net (ctl_sk), ctl_sk, &fl6,NULL );if (!IS_ERR (dst)) {skb_dst_set (buff, dst);ip6_xmit (ctl_sk, buff, &fl6, fl6.flowi6_mark,NULL , tclass);
net/l2tp/l2tp_ip6.c +1 -1
@@ -619,7 +619,7 @@ static int l2tp_ip6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) fl6.flowlabel =ip6_make_flowinfo (ipc6.tclass, fl6.flowlabel); - dst =ip6_dst_lookup_flow (sk, &fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, &fl6, final_p);if (IS_ERR (dst)) { err =PTR_ERR (dst); goto out;
net/sctp/ipv6.c +2 -2
@@ -288,7 +288,7 @@ static void sctp_v6_get_dst(struct sctp_transport *t, union sctp_addr *saddr, final_p =fl6_update_dst (fl6,rcu_dereference (np->opt), &final);rcu_read_unlock (); - dst =ip6_dst_lookup_flow (sk, fl6, final_p); + dst =ip6_dst_lookup_flow (sock_net (sk), sk, fl6, final_p);if (!asoc || saddr) { t->dst = dst;memcpy (fl, &_fl,sizeof (_fl));
@@ -346,7 +346,7 @@ static void sctp_v6_get_dst(struct sctp_transport *t, union sctp_addr *saddr, fl6->saddr = laddr->a.v6.sin6_addr; fl6->fl6_sport = laddr->a.v6.sin6_port; final_p =fl6_update_dst (fl6,rcu_dereference (np->opt), &final); - bdst =ip6_dst_lookup_flow (sk, fl6, final_p); + bdst =ip6_dst_lookup_flow (sock_net (sk), sk, fl6, final_p);if (IS_ERR (bdst))continue ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 38/131 net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup
In reply to Greg Kroah-HartmanFrom: Sabrina Dubroca <[email protected]>
commit 6c8991f41546c3c472503dff1ea9daaddf9331c2 upstream.
ipv6_stub uses the ip6_dst_lookup function to allow other modules to perform IPv6 lookups. However, this function skips the XFRM layer entirely.
All users of ipv6_stub->ip6_dst_lookup use ip_route_output_flow (via the ip_route_output_key and ip_route_output helpers) for their IPv4 lookups, which calls xfrm_lookup_route(). This patch fixes this inconsistent behavior by switching the stub to ip6_dst_lookup_flow, which also calls xfrm_lookup_route().
This requires some changes in all the callers, as these two functions take different arguments and have different return types.
[bwh: Backported to 4.19:
- Drop change in lwt_bpf.c
- Delete now-unused "ret" in mlx5e_route_lookup_ipv6()
- Initialise "out_dev" in mlx5e_create_encap_header_ipv6() to avoid introducing a spurious "may be used uninitialised" warning
- Adjust filenames, context, indentation]
--- drivers/infiniband/core/addr.c | 7 +++---- drivers/infiniband/sw/rxe/rxe_net.c | 8 +++++--- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 11 +++++------ drivers/net/geneve.c | 4 +++- drivers/net/vxlan.c | 8 +++----- include/net/addrconf.h | 6 ++++-- net/ipv6/addrconf_core.c | 11 ++++++----- net/ipv6/af_inet6.c | 2 +- net/mpls/af_mpls.c | 7 +++---- net/tipc/udp_media.c | 9 ++++++--- 10 files changed, 39 insertions(+), 34 deletions(-)
drivers/infiniband/core/addr.c +3 -4
@@ -408,16 +408,15 @@ static int addr6_resolve(struct sockaddr_in6 *src_in,struct flowi6 fl6;struct dst_entry *dst;struct rt6_info *rt; -int ret;memset (&fl6,0 ,sizeof fl6); fl6.daddr = dst_in->sin6_addr; fl6.saddr = src_in->sin6_addr; fl6.flowi6_oif = addr->bound_dev_if; - ret = ipv6_stub->ipv6_dst_lookup (addr->net,NULL , &dst, &fl6); -if (ret <0 ) -return ret; + dst = ipv6_stub->ipv6_dst_lookup_flow (addr->net,NULL , &fl6,NULL ); +if (IS_ERR (dst)) +return PTR_ERR (dst); rt = (struct rt6_info *)dst;if (ipv6_addr_any (&src_in->sin6_addr)) {
drivers/infiniband/sw/rxe/rxe_net.c +5 -3
@@ -154,10 +154,12 @@ static struct dst_entry *rxe_find_route6(struct net_device *ndev,memcpy (&fl6.daddr, daddr,sizeof (*daddr)); fl6.flowi6_proto =IPPROTO_UDP ; -if (unlikely (ipv6_stub->ipv6_dst_lookup (sock_net (recv_sockets.sk6->sk), - recv_sockets.sk6->sk, &ndst, &fl6))) { + ndst = ipv6_stub->ipv6_dst_lookup_flow (sock_net (recv_sockets.sk6->sk), + recv_sockets.sk6->sk, &fl6, +NULL ); +if (unlikely (IS_ERR (ndst))) {pr_err_ratelimited ("no route to %pI6\n" , daddr); - goto put; +return NULL ; }if (unlikely (ndst->error)) {
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +5 -6
@@ -2217,12 +2217,11 @@ static int mlx5e_route_lookup_ipv6(struct mlx5e_priv *priv,#if IS_ENABLED (CONFIG_INET ) &&IS_ENABLED (CONFIG_IPV6 )struct mlx5e_rep_priv *uplink_rpriv;struct mlx5_eswitch *esw = priv->mdev->priv.eswitch; -int ret; - ret = ipv6_stub->ipv6_dst_lookup (dev_net (mirred_dev),NULL , &dst, - fl6); -if (ret <0 ) -return ret; + dst = ipv6_stub->ipv6_dst_lookup_flow (dev_net (mirred_dev),NULL , fl6, +NULL ); +if (IS_ERR (dst)) +return PTR_ERR (dst);if (!(*out_ttl)) *out_ttl =ip6_dst_hoplimit (dst);
@@ -2428,7 +2427,7 @@ static int mlx5e_create_encap_header_ipv6(struct mlx5e_priv *priv,int max_encap_size =MLX5_CAP_ESW (priv->mdev, max_encap_header_size);int ipv6_encap_size =ETH_HLEN +sizeof (struct ipv6hdr ) +VXLAN_HLEN ;struct ip_tunnel_key *tun_key = &e->tun_info.key; -struct net_device *out_dev; +struct net_device *out_dev =NULL ;struct neighbour *n =NULL ;struct flowi6 fl6 = {};u8 nud_state, tos, ttl;
drivers/net/geneve.c +3 -1
@@ -801,7 +801,9 @@ static struct dst_entry *geneve_get_v6_dst(struct sk_buff *skb,if (dst)return dst; } -if (ipv6_stub->ipv6_dst_lookup (geneve->net, gs6->sock->sk, &dst, fl6)) { + dst = ipv6_stub->ipv6_dst_lookup_flow (geneve->net, gs6->sock->sk, fl6, +NULL ); +if (IS_ERR (dst)) {netdev_dbg (dev,"no route to %pI6\n" , &fl6->daddr);return ERR_PTR (-ENETUNREACH ); }
drivers/net/vxlan.c +3 -5
@@ -1963,7 +1963,6 @@ static struct dst_entry *vxlan6_get_route(struct vxlan_dev *vxlan,bool use_cache =ip_tunnel_dst_cache_usable (skb, info);struct dst_entry *ndst;struct flowi6 fl6; -int err;if (!sock6)return ERR_PTR (-EIO );
@@ -1986,10 +1985,9 @@ static struct dst_entry *vxlan6_get_route(struct vxlan_dev *vxlan, fl6.fl6_dport = dport; fl6.fl6_sport = sport; - err = ipv6_stub->ipv6_dst_lookup (vxlan->net, - sock6->sock->sk, - &ndst, &fl6); -if (unlikely (err <0 )) { + ndst = ipv6_stub->ipv6_dst_lookup_flow (vxlan->net, sock6->sock->sk, + &fl6,NULL ); +if (unlikely (IS_ERR (ndst))) {netdev_dbg (dev,"no route to %pI6\n" , daddr);return ERR_PTR (-ENETUNREACH ); }
include/net/addrconf.h +4 -2
@@ -235,8 +235,10 @@ struct ipv6_stub { const struct in6_addr *addr);int (*ipv6_sock_mc_drop)(struct sock *sk,int ifindex,const struct in6_addr *addr); -int (*ipv6_dst_lookup)(struct net *net,struct sock *sk, -struct dst_entry **dst,struct flowi6 *fl6); +struct dst_entry *(*ipv6_dst_lookup_flow)(struct net *net, +const struct sock *sk, +struct flowi6 *fl6, +const struct in6_addr *final_dst);struct fib6_table *(*fib6_get_table)(struct net *net,u32 id); struct fib6_info *(*fib6_lookup)(struct net *net, int oif,
net/ipv6/addrconf_core.c +6 -5
@@ -127,11 +127,12 @@ int inet6addr_validator_notifier_call_chain(unsigned long val, void *v) }EXPORT_SYMBOL (inet6addr_validator_notifier_call_chain); -static int eafnosupport_ipv6_dst_lookup (struct net *net,struct sock *u1, -struct dst_entry **u2, -struct flowi6 *u3) +static struct dst_entry *eafnosupport_ipv6_dst_lookup_flow (struct net *net, +const struct sock *sk, +struct flowi6 *fl6, +const struct in6_addr *final_dst) { -return -EAFNOSUPPORT ; +return ERR_PTR (-EAFNOSUPPORT ); }static struct fib6_table *eafnosupport_fib6_get_table (struct net *net,u32 id)
@@ -169,7 +170,7 @@ eafnosupport_ip6_mtu_from_fib6(struct fib6_info *f6i, struct in6_addr *daddr, }const struct ipv6_stub *ipv6_stub__read_mostly = &(struct ipv6_stub ) { - .ipv6_dst_lookup = eafnosupport_ipv6_dst_lookup, + .ipv6_dst_lookup_flow = eafnosupport_ipv6_dst_lookup_flow, .fib6_get_table = eafnosupport_fib6_get_table, .fib6_table_lookup = eafnosupport_fib6_table_lookup, .fib6_lookup = eafnosupport_fib6_lookup,
net/ipv6/af_inet6.c +1 -1
@@ -904,7 +904,7 @@ static struct pernet_operations inet6_net_ops = {static const struct ipv6_stub ipv6_stub_impl = { .ipv6_sock_mc_join = ipv6_sock_mc_join, .ipv6_sock_mc_drop = ipv6_sock_mc_drop, - .ipv6_dst_lookup = ip6_dst_lookup, + .ipv6_dst_lookup_flow = ip6_dst_lookup_flow, .fib6_get_table = fib6_get_table, .fib6_table_lookup = fib6_table_lookup, .fib6_lookup = fib6_lookup,
net/mpls/af_mpls.c +3 -4
@@ -618,16 +618,15 @@ static struct net_device *inet6_fib_lookup_dev(struct net *net,struct net_device *dev;struct dst_entry *dst;struct flowi6 fl6; -int err;if (!ipv6_stub)return ERR_PTR (-EAFNOSUPPORT );memset (&fl6,0 ,sizeof (fl6));memcpy (&fl6.daddr, addr,sizeof (struct in6_addr )); - err = ipv6_stub->ipv6_dst_lookup (net,NULL , &dst, &fl6); -if (err) -return ERR_PTR (err); + dst = ipv6_stub->ipv6_dst_lookup_flow (net,NULL , &fl6,NULL ); +if (IS_ERR (dst)) +return ERR_CAST (dst); dev = dst->dev;dev_hold (dev);
net/tipc/udp_media.c +6 -3
@@ -189,10 +189,13 @@ static int tipc_udp_xmit(struct net *net, struct sk_buff *skb, .saddr = src->ipv6, .flowi6_proto = IPPROTO_UDP }; - err = ipv6_stub->ipv6_dst_lookup (net, ub->ubsock->sk, &ndst, - &fl6); -if (err) + ndst = ipv6_stub->ipv6_dst_lookup_flow (net, + ub->ubsock->sk, + &fl6,NULL ); +if (IS_ERR (ndst)) { + err =PTR_ERR (ndst); goto tx_error; + } ttl =ip6_dst_hoplimit (ndst); err = udp_tunnel6_xmit_skb(ndst, ub->ubsock->sk, skb, NULL, &src->ipv6, &dst->ipv6, 0, ttl, 0,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 39/131 blktrace: Protect q->blk_trace with RCU
In reply to Greg Kroah-HartmanFrom: Jan Kara <[email protected]>
commit c780e86dd48ef6467a1146cf7d0fe1e05a635039 upstream.
KASAN is reporting that __blk_add_trace() has a use-after-free issue when accessing q->blk_trace. Indeed the switching of block tracing (and thus eventual freeing of q->blk_trace) is completely unsynchronized with the currently running tracing and thus it can happen that the blk_trace structure is being freed just while __blk_add_trace() works on it. Protect accesses to q->blk_trace by RCU during tracing and make sure we wait for the end of RCU grace period when shutting down tracing. Luckily that is rare enough event that we can afford that. Note that postponing the freeing of blk_trace to an RCU callback should better be avoided as it could have unexpected user visible side-effects as debugfs files would be still existing for a short while block tracing has been shut down.
--- include/linux/blkdev.h | 2 +- include/linux/blktrace_api.h | 18 ++++-- kernel/trace/blktrace.c | 114 +++++++++++++++++++++++++---------- 3 files changed, 97 insertions(+), 37 deletions(-)
include/linux/blkdev.h +1 -1
@@ -624,7 +624,7 @@ struct request_queue {unsigned int sg_reserved_size;int node;#ifdef CONFIG_BLK_DEV_IO_TRACE -struct blk_trace *blk_trace; +struct blk_trace __rcu *blk_trace;struct mutex blk_trace_mutex;#endif /*
include/linux/blktrace_api.h +13 -5
@@ -51,9 +51,13 @@ void __trace_note_message(struct blk_trace *, struct blkcg *blkcg, const char *f**/ #define blk_add_cgroup_trace_msg (q, cg, fmt, ...) \ do { \ - struct blk_trace *bt = (q)->blk_trace; \ + struct blk_trace *bt; \ + \ + rcu_read_lock(); \ + bt = rcu_dereference((q)->blk_trace); \ if (unlikely(bt)) \ __trace_note_message(bt, cg, fmt, ##__VA_ARGS__);\ + rcu_read_unlock(); \ } while (0)#define blk_add_trace_msg (q, fmt, ...) \ blk_add_cgroup_trace_msg(q, NULL, fmt, ##__VA_ARGS__)
@@ -61,10 +65,14 @@ void __trace_note_message(struct blk_trace *, struct blkcg *blkcg, const char *fstatic inline bool blk_trace_note_message_enabled (struct request_queue *q) { -struct blk_trace *bt = q->blk_trace; -if (likely (!bt)) -return false; -return bt->act_mask &BLK_TC_NOTIFY ; +struct blk_trace *bt; +bool ret; + +rcu_read_lock (); + bt =rcu_dereference (q->blk_trace); + ret = bt && (bt->act_mask &BLK_TC_NOTIFY ); +rcu_read_unlock (); +return ret; } extern void blk_add_driver_data(struct request_queue *q, struct request *rq,
kernel/trace/blktrace.c +83 -31
314 lines not on this page · raw message
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 40/131 blktrace: fix dereference after null check
In reply to Greg Kroah-HartmanFrom: Cengiz Can <[email protected]>
commit 153031a301bb07194e9c37466cfce8eacb977621 upstream.
There was a recent change in blktrace.c that added a RCU protection to q->blk_trace in order to fix a use-after-free issue during access.
However the change missed an edge case that can lead to dereferencing of bt pointer even when it's NULL:
Coverity static analyzer marked this as a FORWARD_NULL issue with CID 1460458.
```
/kernel/trace/blktrace.c: 1904 in sysfs_blk_trace_attr_store()
1898 ret = 0;
1899 if (bt == NULL)
1900 ret = blk_trace_setup_queue(q, bdev);
1901
1902 if (ret == 0) {
1903 if (attr == &dev_attr_act_mask)
>>> CID 1460458: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "bt".
1904 bt->act_mask = value;
1905 else if (attr == &dev_attr_pid)
1906 bt->pid = value;
1907 else if (attr == &dev_attr_start_lba)
1908 bt->start_lba = value;
1909 else if (attr == &dev_attr_end_lba)
```Added a reassignment with RCU annotation to fix the issue.
--- kernel/trace/blktrace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
kernel/trace/blktrace.c +4 -1
@@ -1893,8 +1893,11 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev, } ret =0 ; -if (bt ==NULL ) +if (bt ==NULL ) { ret =blk_trace_setup_queue (q, bdev); + bt =rcu_dereference_protected (q->blk_trace, +lockdep_is_held (&q->blk_trace_mutex)); + }if (ret ==0 ) {if (attr == &dev_attr_act_mask)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 41/131 f2fs: fix to avoid memory leakage in f2fs_listxattr
In reply to Greg Kroah-HartmanFrom: Randall Huang <[email protected]>
commit 688078e7f36c293dae25b338ddc9e0a2790f6e06 upstream.
In f2fs_listxattr, there is no boundary check before memcpy e_name to buffer.
If the e_name_len is corrupted,
unexpected memory contents may be returned to the buffer.
--- fs/f2fs/xattr.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
fs/f2fs/xattr.c +14 -1
@@ -538,8 +538,9 @@ out:ssize_t f2fs_listxattr (struct dentry *dentry,char *buffer,size_t buffer_size) {struct inode *inode =d_inode (dentry); +nid_t xnid =F2FS_I (inode)->i_xattr_nid;struct f2fs_xattr_entry *entry; -void *base_addr; +void *base_addr, *last_base_addr;int error =0 ;size_t rest = buffer_size;
@@ -549,6 +550,8 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size)if (error)return error; + last_base_addr = (void *)base_addr +XATTR_SIZE (xnid, inode); +list_for_each_xattr (entry, base_addr) {const struct xattr_handler *handler =f2fs_xattr_handler (entry->e_name_index);
@@ -556,6 +559,16 @@ ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size)size_t prefix_len;size_t size; +if ((void *)(entry) +sizeof (__u32) > last_base_addr || + (void *)XATTR_NEXT_ENTRY (entry) > last_base_addr) { +f2fs_msg (dentry->d_sb,KERN_ERR , +"inode (%lu) has corrupted xattr" , + inode->i_ino); +set_sbi_flag (F2FS_I_SB (inode),SBI_NEED_FSCK ); + error = -EFSCORRUPTED ; + goto cleanup; + } +if (!handler || (handler->list && !handler->list (dentry)))continue ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 42/131 KVM: VMX: Zero out *all* general purpose registers after VM-Exit
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
commit 0e0ab73c9a0243736bcd779b30b717e23ba9a56d upstream.
...except RSP, which is restored by hardware as part of VM-Exit.
Paolo theorized that restoring registers from the stack after a VM-Exit in lieu of zeroing them could lead to speculative execution with the guest's values, e.g. if the stack accesses miss the L1 cache[1]. Zeroing XORs are dirt cheap, so just be ultra-paranoid.
Note that the scratch register (currently RCX) used to save/restore the guest state is also zeroed as its host-defined value is loaded via the stack, just with a MOV instead of a POP.
[1] https://patchwork.kernel.org/patch/10771539/#22441255
--- arch/x86/kvm/vmx.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/x86/kvm/vmx.c +12 -0
@@ -10841,6 +10841,15 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)"mov %%r13, %c[r13](%0) \n\t" "mov %%r14, %c[r14](%0) \n\t" "mov %%r15, %c[r15](%0) \n\t" + +/* +* Clear all general purpose registers (except RSP, which is loaded by +* the CPU during VM-Exit) to prevent speculative use of the guest's +* values, even those that are saved/loaded via the stack. In theory, +* an L1 cache miss when restoring registers could lead to speculative +* execution with the guest's values. Zeroing XORs are dirt cheap, +* i.e. the extra paranoia is essentially free. +*/ "xor %%r8d, %%r8d \n\t" "xor %%r9d, %%r9d \n\t" "xor %%r10d, %%r10d \n\t"
@@ -10855,8 +10864,11 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)"xor %%eax, %%eax \n\t" "xor %%ebx, %%ebx \n\t" +"xor %%ecx, %%ecx \n\t" +"xor %%edx, %%edx \n\t" "xor %%esi, %%esi \n\t" "xor %%edi, %%edi \n\t" +"xor %%ebp, %%ebp \n\t" "pop %%" _ASM_BP"; pop %%" _ASM_DX" \n\t" ".pushsection .rodata \n\t" ".global vmx_return \n\t"
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 43/131 KVM: nVMX: Always sync GUEST_BNDCFGS when it comes from vmcs01
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
commit 3b013a2972d5bc344d6eaa8f24fdfe268211e45f upstream.
If L1 does not set VM_ENTRY_LOAD_BNDCFGS, then L1's BNDCFGS value must be propagated to vmcs02 since KVM always runs with VM_ENTRY_LOAD_BNDCFGS when MPX is supported. Because the value effectively comes from vmcs01, vmcs02 must be updated even if vmcs12 is clean.
--- arch/x86/kvm/vmx.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
arch/x86/kvm/vmx.c +6 -7
@@ -12137,13 +12137,9 @@ static void prepare_vmcs02_full(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)set_cr4_guest_host_mask (vmx); -if (kvm_mpx_supported ()) { -if (vmx->nested.nested_run_pending && - (vmcs12->vm_entry_controls &VM_ENTRY_LOAD_BNDCFGS )) -vmcs_write64 (GUEST_BNDCFGS , vmcs12->guest_bndcfgs); -else -vmcs_write64 (GUEST_BNDCFGS , vmx->nested.vmcs01_guest_bndcfgs); - } +if (kvm_mpx_supported () && vmx->nested.nested_run_pending && + (vmcs12->vm_entry_controls &VM_ENTRY_LOAD_BNDCFGS )) +vmcs_write64 (GUEST_BNDCFGS , vmcs12->guest_bndcfgs);if (enable_vpid) {if (nested_cpu_has_vpid (vmcs12) && vmx->nested.vpid02)
@@ -12207,6 +12203,9 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,kvm_set_dr (vcpu,7 , vcpu->arch.dr7);vmcs_write64 (GUEST_IA32_DEBUGCTL , vmx->nested.vmcs01_debugctl); } +if (kvm_mpx_supported () && (!vmx->nested.nested_run_pending || + !(vmcs12->vm_entry_controls &VM_ENTRY_LOAD_BNDCFGS ))) +vmcs_write64 (GUEST_BNDCFGS , vmx->nested.vmcs01_guest_bndcfgs);if (vmx->nested.nested_run_pending) {vmcs_write32 (VM_ENTRY_INTR_INFO_FIELD , vmcs12->vm_entry_intr_info_field);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 44/131 KVM: Introduce a new guest mapping API
In reply to Greg Kroah-HartmanFrom: KarimAllah Ahmed <[email protected]>
commit e45adf665a53df0db37f784ed87c6b57ddd81885 upstream.
In KVM, specially for nested guests, there is a dominant pattern of:
=> map guest memory -> do_something -> unmap guest memory
In addition to all this unnecessarily noise in the code due to boiler plate code, most of the time the mapping function does not properly handle memory that is not backed by "struct page". This new guest mapping API encapsulate most of this boiler plate code and also handles guest memory that is not backed by "struct page".
The current implementation of this API is using memremap for memory that is not backed by a "struct page" which would lead to a huge slow-down if it was used for high-frequency mapping operations. The API does not have any effect on current setups where guest memory is backed by a "struct page". Further patches are going to also introduce a pfn-cache which would significantly improve the performance of the memremap case.
[bwh: Backported to 4.19 as dependency of commit 1eff70a9abd4
"x86/kvm: Introduce kvm_(un)map_gfn()"]
--- include/linux/kvm_host.h | 28 ++++++++++++++++++ virt/kvm/kvm_main.c | 64 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 92 insertions(+)
include/linux/kvm_host.h +28 -0
@@ -206,6 +206,32 @@ enum { READING_SHADOW_PAGE_TABLES, }; +#define KVM_UNMAPPED_PAGE ((void *) 0x500 + POISON_POINTER_DELTA) + +struct kvm_host_map { +/* +* Only valid if the 'pfn' is managed by the host kernel (i.e. There is +* a 'struct page' for it. When using mem= kernel parameter some memory +* can be used as guest memory but they are not managed by host +* kernel). +* If 'pfn' is not managed by the host kernel, this field is +* initialized to KVM_UNMAPPED_PAGE. +*/ +struct page *page; +void *hva; +kvm_pfn_t pfn; +kvm_pfn_t gfn; +}; + +/* +* Used to check if the mapping is valid or not. Never use 'kvm_host_map' +* directly to check for that. +*/ +static inline bool kvm_vcpu_mapped (struct kvm_host_map *map) +{ +return !!map->hva; +} +/* * Sometimes a large or cross-page mmio needs to be broken up into separate * exits for userspace servicing.
@@ -711,7 +737,9 @@ struct kvm_memslots *kvm_vcpu_memslots(struct kvm_vcpu *vcpu);struct kvm_memory_slot *kvm_vcpu_gfn_to_memslot (struct kvm_vcpu *vcpu,gfn_t gfn);kvm_pfn_t kvm_vcpu_gfn_to_pfn_atomic (struct kvm_vcpu *vcpu,gfn_t gfn);kvm_pfn_t kvm_vcpu_gfn_to_pfn (struct kvm_vcpu *vcpu,gfn_t gfn); +int kvm_vcpu_map (struct kvm_vcpu *vcpu,gpa_t gpa,struct kvm_host_map *map);struct page *kvm_vcpu_gfn_to_page (struct kvm_vcpu *vcpu,gfn_t gfn); +void kvm_vcpu_unmap (struct kvm_vcpu *vcpu,struct kvm_host_map *map,bool dirty);unsigned long kvm_vcpu_gfn_to_hva (struct kvm_vcpu *vcpu,gfn_t gfn);unsigned long kvm_vcpu_gfn_to_hva_prot (struct kvm_vcpu *vcpu,gfn_t gfn,bool *writable); int kvm_vcpu_read_guest_page(struct kvm_vcpu *vcpu, gfn_t gfn, void *data, int offset,
virt/kvm/kvm_main.c +64 -0
70 lines not on this page · raw message
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 45/131 kvm: fix compilation on aarch64
In reply to Greg Kroah-HartmanFrom: Paolo Bonzini <[email protected]>
commit c011d23ba046826ccf8c4a4a6c1d01c9ccaa1403 upstream.
Commit e45adf665a53 ("KVM: Introduce a new guest mapping API", 2019-01-31) introduced a build failure on aarch64 defconfig:
$ make -j$(nproc) ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=out defconfig \
Image.gz
...
../arch/arm64/kvm/../../../virt/kvm/kvm_main.c:
In function '__kvm_map_gfn':
../arch/arm64/kvm/../../../virt/kvm/kvm_main.c:1763:9: error:
implicit declaration of function 'memremap'; did you mean 'memset_p'?
../arch/arm64/kvm/../../../virt/kvm/kvm_main.c:1763:46: error:
'MEMREMAP_WB' undeclared (first use in this function)
../arch/arm64/kvm/../../../virt/kvm/kvm_main.c:
In function 'kvm_vcpu_unmap':
../arch/arm64/kvm/../../../virt/kvm/kvm_main.c:1795:3: error:
implicit declaration of function 'memunmap'; did you mean 'vm_munmap'?because these functions are declared in <linux/io.h> rather than <asm/io.h>, and the former was being pulled in already on x86 but not on aarch64.
--- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/kvm_main.c +1 -1
@@ -52,9 +52,9 @@#include <linux/sort.h> #include <linux/bsearch.h> #include <linux/kthread.h> +#include <linux/io.h> #include <asm/processor.h> -#include <asm/io.h> #include <asm/ioctl.h> #include <linux/uaccess.h> #include <asm/pgtable.h>
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 46/131 kvm: fix compilation on s390
In reply to Greg Kroah-HartmanFrom: Paolo Bonzini <[email protected]>
commit d30b214d1d0addb7b2c9c78178d1501cd39a01fb upstream.
s390 does not have memremap, even though in this particular case it would be useful.
--- virt/kvm/kvm_main.c | 2 ++ 1 file changed, 2 insertions(+)
virt/kvm/kvm_main.c +2 -0
@@ -1722,8 +1722,10 @@ static int __kvm_map_gfn(struct kvm_memory_slot *slot, gfn_t gfn,if (pfn_valid (pfn)) { page =pfn_to_page (pfn); hva =kmap (page); +#ifdef CONFIG_HAS_IOMEM }else { hva =memremap (pfn_to_hpa (pfn),PAGE_SIZE ,MEMREMAP_WB ); +#endif }if (!hva)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 47/131 kvm: fix compile on s390 part 2
In reply to Greg Kroah-HartmanFrom: Christian Borntraeger <[email protected]>
commit eb1f2f387db8c0d084581fb26e7faffde700bc8e upstream.
We also need to fence the memunmap part.
--- virt/kvm/kvm_main.c | 2 ++ 1 file changed, 2 insertions(+)
virt/kvm/kvm_main.c +2 -0
@@ -1756,8 +1756,10 @@ void kvm_vcpu_unmap(struct kvm_vcpu *vcpu, struct kvm_host_map *map,if (map->page)kunmap (map->page); +#ifdef CONFIG_HAS_IOMEM else memunmap(map->hva); +#endif if (dirty) {kvm_vcpu_mark_page_dirty (vcpu, map->gfn);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 48/131 KVM: Properly check if "page" is valid in kvm_vcpu_unmap
In reply to Greg Kroah-HartmanFrom: KarimAllah Ahmed <[email protected]>
commit b614c6027896ff9ad6757122e84760d938cab15e upstream.
The field "page" is initialized to KVM_UNMAPPED_PAGE when it is not used (i.e. when the memory lives outside kernel control). So this check will always end up using kunmap even for memremap regions.
--- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/kvm_main.c +1 -1
@@ -1754,7 +1754,7 @@ void kvm_vcpu_unmap(struct kvm_vcpu *vcpu, struct kvm_host_map *map,if (!map->hva)return ; -if (map->page) +if (map->page !=KVM_UNMAPPED_PAGE )kunmap (map->page);#ifdef CONFIG_HAS_IOMEM else
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 49/131 x86/kvm: Introduce kvm_(un)map_gfn()
In reply to Greg Kroah-HartmanFrom: Boris Ostrovsky <[email protected]>
commit 1eff70a9abd46f175defafd29bc17ad456f398a7 upstream.
kvm_vcpu_(un)map operates on gfns from any current address space. In certain cases we want to make sure we are not mapping SMRAM and for that we can use kvm_(un)map_gfn() that we are introducing in this patch.
This is part of CVE-2019-3016.
--- include/linux/kvm_host.h | 2 ++ virt/kvm/kvm_main.c | 29 ++++++++++++++++++++++++----- 2 files changed, 26 insertions(+), 5 deletions(-)
include/linux/kvm_host.h +2 -0
@@ -738,8 +738,10 @@ struct kvm_memory_slot *kvm_vcpu_gfn_to_memslot(struct kvm_vcpu *vcpu, gfn_t gfnkvm_pfn_t kvm_vcpu_gfn_to_pfn_atomic (struct kvm_vcpu *vcpu,gfn_t gfn);kvm_pfn_t kvm_vcpu_gfn_to_pfn (struct kvm_vcpu *vcpu,gfn_t gfn);int kvm_vcpu_map (struct kvm_vcpu *vcpu,gpa_t gpa,struct kvm_host_map *map); +int kvm_map_gfn (struct kvm_vcpu *vcpu,gfn_t gfn,struct kvm_host_map *map);struct page *kvm_vcpu_gfn_to_page (struct kvm_vcpu *vcpu,gfn_t gfn);void kvm_vcpu_unmap (struct kvm_vcpu *vcpu,struct kvm_host_map *map,bool dirty); +int kvm_unmap_gfn (struct kvm_vcpu *vcpu,struct kvm_host_map *map,bool dirty);unsigned long kvm_vcpu_gfn_to_hva (struct kvm_vcpu *vcpu,gfn_t gfn);unsigned long kvm_vcpu_gfn_to_hva_prot (struct kvm_vcpu *vcpu,gfn_t gfn,bool *writable); int kvm_vcpu_read_guest_page(struct kvm_vcpu *vcpu, gfn_t gfn, void *data, int offset,
virt/kvm/kvm_main.c +24 -5
@@ -1705,12 +1705,13 @@ struct page *gfn_to_page(struct kvm *kvm, gfn_t gfn) }EXPORT_SYMBOL_GPL (gfn_to_page); -static int __kvm_map_gfn (struct kvm_memory_slot *slot,gfn_t gfn, +static int __kvm_map_gfn (struct kvm_memslots *slots,gfn_t gfn,struct kvm_host_map *map) {kvm_pfn_t pfn;void *hva =NULL ;struct page *page =KVM_UNMAPPED_PAGE ; +struct kvm_memory_slot *slot =__gfn_to_memslot (slots, gfn);if (!map)return -EINVAL ;
@@ -1739,14 +1740,20 @@ static int __kvm_map_gfn(struct kvm_memory_slot *slot, gfn_t gfn,return 0 ; } +int kvm_map_gfn (struct kvm_vcpu *vcpu,gfn_t gfn,struct kvm_host_map *map) +{ +return __kvm_map_gfn (kvm_memslots (vcpu->kvm), gfn, map); +} +EXPORT_SYMBOL_GPL (kvm_map_gfn); +int kvm_vcpu_map (struct kvm_vcpu *vcpu,gfn_t gfn,struct kvm_host_map *map) { -return __kvm_map_gfn (kvm_vcpu_gfn_to_memslot (vcpu, gfn), gfn, map); +return __kvm_map_gfn (kvm_vcpu_memslots (vcpu), gfn, map); }EXPORT_SYMBOL_GPL (kvm_vcpu_map); -void kvm_vcpu_unmap (struct kvm_vcpu *vcpu,struct kvm_host_map *map, -bool dirty) +static void __kvm_unmap_gfn (struct kvm_memory_slot *memslot, +struct kvm_host_map *map,bool dirty) {if (!map)return ;
@@ -1762,7 +1769,7 @@ void kvm_vcpu_unmap(struct kvm_vcpu *vcpu, struct kvm_host_map *map,#endif if (dirty) { -kvm_vcpu_mark_page_dirty (vcpu, map->gfn); +mark_page_dirty_in_slot (memslot, map->gfn);kvm_release_pfn_dirty (map->pfn); }else {kvm_release_pfn_clean (map->pfn);
@@ -1771,6 +1778,18 @@ void kvm_vcpu_unmap(struct kvm_vcpu *vcpu, struct kvm_host_map *map, map->hva =NULL ; map->page =NULL ; } + +int kvm_unmap_gfn (struct kvm_vcpu *vcpu,struct kvm_host_map *map,bool dirty) +{ +__kvm_unmap_gfn (gfn_to_memslot (vcpu->kvm, map->gfn), map, dirty); +return 0 ; +} +EXPORT_SYMBOL_GPL (kvm_unmap_gfn); + +void kvm_vcpu_unmap (struct kvm_vcpu *vcpu,struct kvm_host_map *map,bool dirty) +{ +__kvm_unmap_gfn (kvm_vcpu_gfn_to_memslot (vcpu, map->gfn), map, dirty); +}EXPORT_SYMBOL_GPL (kvm_vcpu_unmap);struct page *kvm_vcpu_gfn_to_page (struct kvm_vcpu *vcpu,gfn_t gfn)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 50/131 x86/kvm: Cache gfn to pfn translation
In reply to Greg Kroah-HartmanFrom: Boris Ostrovsky <[email protected]>
commit 917248144db5d7320655dbb41d3af0b8a0f3d589 upstream.
__kvm_map_gfn()'s call to gfn_to_pfn_memslot() is
* relatively expensive
* in certain cases (such as when done from atomic context) cannot be called
Stashing gfn-to-pfn mapping should help with both cases.
This is part of CVE-2019-3016.
--- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/x86.c | 10 ++++ include/linux/kvm_host.h | 7 ++- include/linux/kvm_types.h | 9 ++- virt/kvm/kvm_main.c | 98 ++++++++++++++++++++++++++------- 5 files changed, 103 insertions(+), 22 deletions(-)
arch/x86/include/asm/kvm_host.h +1 -0
@@ -626,6 +626,7 @@ struct kvm_vcpu_arch {u64 last_steal;struct gfn_to_hva_cache stime;struct kvm_steal_time steal; +struct gfn_to_pfn_cache cache; } st;u64 tsc_offset;
arch/x86/kvm/x86.c +10 -0
@@ -8634,6 +8634,9 @@ static void fx_init(struct kvm_vcpu *vcpu)void kvm_arch_vcpu_free (struct kvm_vcpu *vcpu) {void *wbinvd_dirty_mask = vcpu->arch.wbinvd_dirty_mask; +struct gfn_to_pfn_cache *cache = &vcpu->arch.st.cache; + +kvm_release_pfn (cache->pfn, cache->dirty, cache);kvmclock_reset (vcpu);
@@ -9298,11 +9301,18 @@ int kvm_arch_create_memslot(struct kvm *kvm, struct kvm_memory_slot *slot,void kvm_arch_memslots_updated (struct kvm *kvm,u64 gen) { +struct kvm_vcpu *vcpu; +int i; +/* * memslots->generation has been incremented. * mmio generation may have reached its maximum value. */ kvm_mmu_invalidate_mmio_sptes (kvm, gen); + +/* Force re-initialization of steal_time cache */ +kvm_for_each_vcpu (i, vcpu, kvm) +kvm_vcpu_kick (vcpu); } int kvm_arch_prepare_memory_region(struct kvm *kvm,
include/linux/kvm_host.h +5 -2
@@ -708,6 +708,7 @@ void kvm_set_pfn_dirty(kvm_pfn_t pfn);void kvm_set_pfn_accessed (kvm_pfn_t pfn);void kvm_get_pfn (kvm_pfn_t pfn); +void kvm_release_pfn (kvm_pfn_t pfn,bool dirty,struct gfn_to_pfn_cache *cache);int kvm_read_guest_page (struct kvm *kvm,gfn_t gfn,void *data,int offset,int len); int kvm_read_guest_atomic(struct kvm *kvm, gpa_t gpa, void *data,
@@ -738,10 +739,12 @@ struct kvm_memory_slot *kvm_vcpu_gfn_to_memslot(struct kvm_vcpu *vcpu, gfn_t gfnkvm_pfn_t kvm_vcpu_gfn_to_pfn_atomic (struct kvm_vcpu *vcpu,gfn_t gfn);kvm_pfn_t kvm_vcpu_gfn_to_pfn (struct kvm_vcpu *vcpu,gfn_t gfn);int kvm_vcpu_map (struct kvm_vcpu *vcpu,gpa_t gpa,struct kvm_host_map *map); -int kvm_map_gfn (struct kvm_vcpu *vcpu,gfn_t gfn,struct kvm_host_map *map); +int kvm_map_gfn (struct kvm_vcpu *vcpu,gfn_t gfn,struct kvm_host_map *map, +struct gfn_to_pfn_cache *cache,bool atomic);struct page *kvm_vcpu_gfn_to_page (struct kvm_vcpu *vcpu,gfn_t gfn);void kvm_vcpu_unmap (struct kvm_vcpu *vcpu,struct kvm_host_map *map,bool dirty); -int kvm_unmap_gfn (struct kvm_vcpu *vcpu,struct kvm_host_map *map,bool dirty); +int kvm_unmap_gfn (struct kvm_vcpu *vcpu,struct kvm_host_map *map, +struct gfn_to_pfn_cache *cache,bool dirty,bool atomic);unsigned long kvm_vcpu_gfn_to_hva (struct kvm_vcpu *vcpu,gfn_t gfn);unsigned long kvm_vcpu_gfn_to_hva_prot (struct kvm_vcpu *vcpu,gfn_t gfn,bool *writable); int kvm_vcpu_read_guest_page(struct kvm_vcpu *vcpu, gfn_t gfn, void *data, int offset,
include/linux/kvm_types.h +8 -1
@@ -32,7 +32,7 @@ struct kvm_memslots;enum kvm_mr_change ; -#include <asm/types.h> +#include <linux/types.h> /* * Address types:
@@ -63,4 +63,11 @@ struct gfn_to_hva_cache { struct kvm_memory_slot *memslot; }; +struct gfn_to_pfn_cache { +u64 generation; +gfn_t gfn; +kvm_pfn_t pfn; +bool dirty; +}; +#endif /* __KVM_TYPES_H__ */
virt/kvm/kvm_main.c +79 -19
160 lines not on this page · raw message
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 51/131 x86/KVM: Make sure KVM_VCPU_FLUSH_TLB flag is not missed
In reply to Greg Kroah-HartmanFrom: Boris Ostrovsky <[email protected]>
commit b043138246a41064527cf019a3d51d9f015e9796 upstream.
There is a potential race in record_steal_time() between setting host-local vcpu->arch.st.steal.preempted to zero (i.e. clearing KVM_VCPU_PREEMPTED) and propagating this value to the guest with kvm_write_guest_cached(). Between those two events the guest may still see KVM_VCPU_PREEMPTED in its copy of kvm_steal_time, set KVM_VCPU_FLUSH_TLB and assume that hypervisor will do the right thing. Which it won't.
Instad of copying, we should map kvm_steal_time and that will guarantee atomicity of accesses to @preempted.
This is part of CVE-2019-3016.
--- arch/x86/kvm/x86.c | 49 +++++++++++++++++++++++++++------------------- 1 file changed, 29 insertions(+), 20 deletions(-)
arch/x86/kvm/x86.c +29 -20
@@ -2397,43 +2397,45 @@ static void kvm_vcpu_flush_tlb(struct kvm_vcpu *vcpu, bool invalidate_gpa)static void record_steal_time (struct kvm_vcpu *vcpu) { +struct kvm_host_map map; +struct kvm_steal_time *st; +if (!(vcpu->arch.st.msr_val &KVM_MSR_ENABLED ))return ; -if (unlikely (kvm_read_guest_cached (vcpu->kvm, &vcpu->arch.st.stime, - &vcpu->arch.st.steal,sizeof (struct kvm_steal_time )))) +/* -EAGAIN is returned in atomic context so we can just return. */ +if (kvm_map_gfn (vcpu, vcpu->arch.st.msr_val >>PAGE_SHIFT , + &map, &vcpu->arch.st.cache, false))return ; + st = map.hva + +offset_in_page (vcpu->arch.st.msr_val &KVM_STEAL_VALID_BITS ); +/* * Doing a TLB flush here, on the guest's behalf, can avoid * expensive IPIs. */ -if (xchg (&vcpu->arch.st.steal.preempted,0 ) &KVM_VCPU_FLUSH_TLB ) +if (xchg (&st->preempted,0 ) &KVM_VCPU_FLUSH_TLB )kvm_vcpu_flush_tlb (vcpu, false); -if (vcpu->arch.st.steal.version &1 ) - vcpu->arch.st.steal.version +=1 ;/* first time write, random junk */ + vcpu->arch.st.steal.preempted =0 ; - vcpu->arch.st.steal.version +=1 ; +if (st->version &1 ) + st->version +=1 ;/* first time write, random junk */ -kvm_write_guest_cached (vcpu->kvm, &vcpu->arch.st.stime, - &vcpu->arch.st.steal,sizeof (struct kvm_steal_time )); + st->version +=1 ;smp_wmb (); - vcpu->arch.st.steal.steal += current->sched_info.run_delay - + st->steal += current->sched_info.run_delay - vcpu->arch.st.last_steal; vcpu->arch.st.last_steal = current->sched_info.run_delay; -kvm_write_guest_cached (vcpu->kvm, &vcpu->arch.st.stime, - &vcpu->arch.st.steal,sizeof (struct kvm_steal_time )); -smp_wmb (); - vcpu->arch.st.steal.version +=1 ; + st->version +=1 ; -kvm_write_guest_cached (vcpu->kvm, &vcpu->arch.st.stime, - &vcpu->arch.st.steal,sizeof (struct kvm_steal_time )); +kvm_unmap_gfn (vcpu, &map, &vcpu->arch.st.cache, true, false); }int kvm_set_msr_common (struct kvm_vcpu *vcpu,struct msr_data *msr_info)
@@ -3272,18 +3274,25 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)static void kvm_steal_time_set_preempted (struct kvm_vcpu *vcpu) { +struct kvm_host_map map; +struct kvm_steal_time *st; +if (!(vcpu->arch.st.msr_val &KVM_MSR_ENABLED ))return ;if (vcpu->arch.st.steal.preempted)return ; - vcpu->arch.st.steal.preempted =KVM_VCPU_PREEMPTED ; +if (kvm_map_gfn (vcpu, vcpu->arch.st.msr_val >>PAGE_SHIFT , &map, + &vcpu->arch.st.cache, true)) +return ; + + st = map.hva + +offset_in_page (vcpu->arch.st.msr_val &KVM_STEAL_VALID_BITS ); + + st->preempted = vcpu->arch.st.steal.preempted =KVM_VCPU_PREEMPTED ; -kvm_write_guest_offset_cached (vcpu->kvm, &vcpu->arch.st.stime, - &vcpu->arch.st.steal.preempted, - offsetof(struct kvm_steal_time , preempted), -sizeof (vcpu->arch.st.steal.preempted)); +kvm_unmap_gfn (vcpu, &map, &vcpu->arch.st.cache, true, true); }void kvm_arch_vcpu_put (struct kvm_vcpu *vcpu)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 52/131 x86/KVM: Clean up hosts steal time structure
In reply to Greg Kroah-HartmanFrom: Boris Ostrovsky <[email protected]>
commit a6bd811f1209fe1c64c9f6fd578101d6436c6b6e upstream.
Now that we are mapping kvm_steal_time from the guest directly we don't need keep a copy of it in kvm_vcpu_arch.st. The same is true for the stime field.
This is part of CVE-2019-3016.
--- arch/x86/include/asm/kvm_host.h | 3 +-- arch/x86/kvm/x86.c | 11 +++-------- 2 files changed, 4 insertions(+), 10 deletions(-)
arch/x86/include/asm/kvm_host.h +1 -2
@@ -622,10 +622,9 @@ struct kvm_vcpu_arch {bool pvclock_set_guest_stopped_request;struct { +u8 preempted;u64 msr_val;u64 last_steal; -struct gfn_to_hva_cache stime; -struct kvm_steal_time steal;struct gfn_to_pfn_cache cache; } st;
arch/x86/kvm/x86.c +3 -8
@@ -2418,7 +2418,7 @@ static void record_steal_time(struct kvm_vcpu *vcpu)if (xchg (&st->preempted,0 ) &KVM_VCPU_FLUSH_TLB )kvm_vcpu_flush_tlb (vcpu, false); - vcpu->arch.st.steal.preempted =0 ; + vcpu->arch.st.preempted =0 ;if (st->version &1 ) st->version +=1 ;/* first time write, random junk */
@@ -2577,11 +2577,6 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)if (data &KVM_STEAL_RESERVED_MASK )return 1 ; -if (kvm_gfn_to_hva_cache_init (vcpu->kvm, &vcpu->arch.st.stime, - data &KVM_STEAL_VALID_BITS , -sizeof (struct kvm_steal_time ))) -return 1 ; - vcpu->arch.st.msr_val = data;if (!(data &KVM_MSR_ENABLED ))
@@ -3280,7 +3275,7 @@ static void kvm_steal_time_set_preempted(struct kvm_vcpu *vcpu)if (!(vcpu->arch.st.msr_val &KVM_MSR_ENABLED ))return ; -if (vcpu->arch.st.steal.preempted) +if (vcpu->arch.st.preempted)return ; if (kvm_map_gfn(vcpu, vcpu->arch.st.msr_val >> PAGE_SHIFT, &map,
@@ -3290,7 +3285,7 @@ static void kvm_steal_time_set_preempted(struct kvm_vcpu *vcpu) st = map.hva +offset_in_page (vcpu->arch.st.msr_val &KVM_STEAL_VALID_BITS ); - st->preempted = vcpu->arch.st.steal.preempted =KVM_VCPU_PREEMPTED ; + st->preempted = vcpu->arch.st.preempted =KVM_VCPU_PREEMPTED ;kvm_unmap_gfn (vcpu, &map, &vcpu->arch.st.cache, true, true); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 53/131 cxgb4: fix adapter crash due to wrong MC size
In reply to Greg Kroah-HartmanFrom: Vishal Kulkarni <[email protected]>
[ Upstream commit ce222748078592afb51b810dc154531aeba4f512 ]
In the absence of MC1, the size calculation function cudbg_mem_region_size() was returing wrong MC size and resulted in adapter crash. This patch adds new argument to cudbg_mem_region_size() which will have actual size and returns error to caller in the absence of MC1.
--- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 27 ++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-)
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c +20 -7
@@ -1065,9 +1065,9 @@ static void cudbg_t4_fwcache(struct cudb } } -static unsigned long cudbg_mem_region_size (struct cudbg_init *pdbg_init, -struct cudbg_error *cudbg_err, -u8 mem_type) +static int cudbg_mem_region_size (struct cudbg_init *pdbg_init, +struct cudbg_error *cudbg_err, +u8 mem_type,unsigned long *region_size) {struct adapter *padap = pdbg_init->adap;struct cudbg_meminfo mem_info;
@@ -1076,15 +1076,23 @@ static unsigned long cudbg_mem_region_simemset (&mem_info,0 ,sizeof (struct cudbg_meminfo )); rc =cudbg_fill_meminfo (padap, &mem_info); -if (rc) +if (rc) { + cudbg_err->sys_err = rc;return rc; + }cudbg_t4_fwcache (pdbg_init, cudbg_err); rc =cudbg_meminfo_get_mem_index (padap, &mem_info, mem_type, &mc_idx); -if (rc) +if (rc) { + cudbg_err->sys_err = rc;return rc; + } + +if (region_size) + *region_size = mem_info.avail[mc_idx].limit - + mem_info.avail[mc_idx].base; -return mem_info.avail[mc_idx].limit - mem_info.avail[mc_idx].base; +return 0 ; } static int cudbg_collect_mem_region(struct cudbg_init *pdbg_init,
@@ -1092,7 +1100,12 @@ static int cudbg_collect_mem_region(stru struct cudbg_error *cudbg_err, u8 mem_type) { -unsigned long size =cudbg_mem_region_size (pdbg_init, cudbg_err, mem_type); +unsigned long size =0 ; +int rc; + + rc =cudbg_mem_region_size (pdbg_init, cudbg_err, mem_type, &size); +if (rc) +return rc;return cudbg_read_fw_mem (pdbg_init, dbg_buff, mem_type, size, cudbg_err);
Greg Kroah-Hartman
maintainerPATCH 54/131 cxgb4: fix large delays in PTP synchronization
In reply to Greg Kroah-HartmanFrom: Rahul Lakkireddy <[email protected]>
[ Upstream commit bd019427bf3623ee3c7d2845cf921bbf4c14846c ]
Fetching PTP sync information from mailbox is slow and can take up to 10 milliseconds. Reduce this unnecessary delay by directly reading the information from the corresponding registers.
--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 27 +++++-------------------- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 3 ++ 2 files changed, 9 insertions(+), 21 deletions(-)
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c +6 -21
@@ -311,32 +311,17 @@ static int cxgb4_ptp_adjtime(struct ptp_*/ static int cxgb4_ptp_gettime (struct ptp_clock_info *ptp,struct timespec64 *ts) { -struct adapter *adapter = (struct adapter *)container_of (ptp, - struct adapter, ptp_clock_info); -struct fw_ptp_cmd c; + struct adapter *adapter = container_of(ptp, struct adapter, + ptp_clock_info);u64 ns; -int err; -memset (&c,0 ,sizeof (c)); - c.op_to_portid =cpu_to_be32 (FW_CMD_OP_V (FW_PTP_CMD ) | -FW_CMD_REQUEST_F | -FW_CMD_READ_F | -FW_PTP_CMD_PORTID_V (0 )); - c.retval_len16 =cpu_to_be32 (FW_CMD_LEN16_V (sizeof (c) /16 )); - c.u.ts.sc =FW_PTP_SC_GET_TIME ; - - err =t4_wr_mbox (adapter, adapter->mbox, &c,sizeof (c), &c); -if (err <0 ) { -dev_err (adapter->pdev_dev, -"PTP: %s error %d\n" , __func__, -err); -return err; - } + ns =t4_read_reg (adapter,T5_PORT_REG (0 ,MAC_PORT_PTP_SUM_LO_A )); + ns |= (u64 )t4_read_reg (adapter, +T5_PORT_REG (0 ,MAC_PORT_PTP_SUM_HI_A )) <<32 ;/* convert to timespec*/ - ns =be64_to_cpu (c.u.ts.tm); *ts =ns_to_timespec64 (ns); - -return err; +return 0 ; }/**
drivers/net/ethernet/chelsio/cxgb4/t4_regs.h +3 -0
@@ -1896,6 +1896,9 @@#define MAC_PORT_CFG2_A 0x818 +#define MAC_PORT_PTP_SUM_LO_A 0x990 +#define MAC_PORT_PTP_SUM_HI_A 0x994 +#define MPS_CMN_CTL_A 0x9000#define COUNTPAUSEMCRX_S 5
Greg Kroah-Hartman
maintainerPATCH 55/131 ipv6: fix restrict IPV6_ADDRFORM operation
In reply to Greg Kroah-HartmanFrom: John Haxby <[email protected]>
[ Upstream commit 82c9ae440857840c56e05d4fb1427ee032531346 ]
Commit b6f6118901d1 ("ipv6: restrict IPV6_ADDRFORM operation") fixed a problem found by syzbot an unfortunate logic error meant that it also broke IPV6_ADDRFORM.
Rearrange the checks so that the earlier test is just one of the series of checks made before moving the socket from IPv6 to IPv4.
--- net/ipv6/ipv6_sockglue.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
net/ipv6/ipv6_sockglue.c +6 -7
@@ -185,15 +185,14 @@ static int do_ipv6_setsockopt(struct soc retv = -EBUSY ;break ; } - }else if (sk->sk_protocol ==IPPROTO_TCP ) { -if (sk->sk_prot != &tcpv6_prot) { - retv = -EBUSY ; -break ; - } -break ; - }else { + } +if (sk->sk_protocol ==IPPROTO_TCP && + sk->sk_prot != &tcpv6_prot) { + retv = -EBUSY ;break ; } +if (sk->sk_protocol !=IPPROTO_TCP ) +break ;if (sk->sk_state !=TCP_ESTABLISHED ) { retv = -ENOTCONN ;break ;
Greg Kroah-Hartman
maintainerPATCH 56/131 macsec: avoid to set wrong mtu
In reply to Greg Kroah-HartmanFrom: Taehee Yoo <[email protected]>
[ Upstream commit 7f327080364abccf923fa5a5b24e038eb0ba1407 ]
When a macsec interface is created, the mtu is calculated with the lower interface's mtu value.
If the mtu of lower interface is lower than the length, which is needed by macsec interface, macsec's mtu value will be overflowed. So, if the lower interface's mtu is too low, macsec interface's mtu should be set to 0.
Test commands:
ip link add dummy0 mtu 10 type dummy
ip link add macsec0 link dummy0 type macsec
ip link show macsec0
Before:
11: macsec0@dummy0: <BROADCAST,MULTICAST,M-DOWN> mtu 4294967274
After:
11: macsec0@dummy0: <BROADCAST,MULTICAST,M-DOWN> mtu 0
--- drivers/net/macsec.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/net/macsec.c +8 -4
@@ -3238,11 +3238,11 @@ static int macsec_newlink(struct net *ne struct netlink_ext_ack *extack) {struct macsec_dev *macsec =macsec_priv (dev); +rx_handler_func_t *rx_handler; +u8 icv_len =DEFAULT_ICV_LEN ;struct net_device *real_dev; -int err; +int err, mtu;sci_t sci; -u8 icv_len =DEFAULT_ICV_LEN ; -rx_handler_func_t *rx_handler;if (!tb[IFLA_LINK ])return -EINVAL ;
@@ -3258,7 +3258,11 @@ static int macsec_newlink(struct net *neif (data && data[IFLA_MACSEC_ICV_LEN ]) icv_len =nla_get_u8 (data[IFLA_MACSEC_ICV_LEN ]); - dev->mtu = real_dev->mtu - icv_len -macsec_extra_len (true); + mtu = real_dev->mtu - icv_len -macsec_extra_len (true); +if (mtu <0 ) + dev->mtu =0 ; +else + dev->mtu = mtu; rx_handler =rtnl_dereference (real_dev->rx_handler);if (rx_handler && rx_handler != macsec_handle_frame)
Greg Kroah-Hartman
maintainerPATCH 57/131 macvlan: fix null dereference in macvlan_device_event()
In reply to Greg Kroah-HartmanFrom: Taehee Yoo <[email protected]>
[ Upstream commit 4dee15b4fd0d61ec6bbd179238191e959d34cf7a ]
In the macvlan_device_event(), the list_first_entry_or_null() is used. This function could return null pointer if there is no node. But, the macvlan module doesn't check the null pointer.
So, null-ptr-deref would occur.
bond0
|
+----+-----+
| |
macvlan0 macvlan1
| |
dummy0 dummy1The problem scenario.
If dummy1 is removed,
1. ->dellink() of dummy1 is called.
2. NETDEV_UNREGISTER of dummy1 notification is sent to macvlan module.
3. ->dellink() of macvlan1 is called.
4. NETDEV_UNREGISTER of macvlan1 notification is sent to bond module.
5. __bond_release_one() is called and it internally calls dev_set_mac_address().
6. dev_set_mac_address() calls the ->ndo_set_mac_address() of macvlan1, which is macvlan_set_mac_address().
7. macvlan_set_mac_address() calls the dev_set_mac_address() with dummy1.
8. NETDEV_CHANGEADDR of dummy1 is sent to macvlan module.
9. In the macvlan_device_event(), it calls list_first_entry_or_null(). At this point, dummy1 and macvlan1 were removed.
So, list_first_entry_or_null() will return NULL.
Test commands:
ip netns add nst
ip netns exec nst ip link add bond0 type bond for i in {0..10}
do
ip netns exec nst ip link add dummy$i type dummy ip netns exec nst ip link add macvlan$i link dummy$i \
type macvlan mode passthru
ip netns exec nst ip link set macvlan$i master bond0
done
ip netns del nst
Splat looks like:
[ 40.585687][ T146] general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP DEI [ 40.587249][ T146] KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] [ 40.588342][ T146] CPU: 1 PID: 146 Comm: kworker/u8:2 Not tainted 5.7.0-rc1+ #532 [ 40.589299][ T146] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 40.590469][ T146] Workqueue: netns cleanup_net [ 40.591045][ T146] RIP: 0010:macvlan_device_event+0x4e2/0x900 [macvlan] [ 40.591905][ T146] Code: 00 00 00 00 00 fc ff df 80 3c 06 00 0f 85 45 02 00 00 48 89 da 48 b8 00 00 00 00 00 fc ff d2 [ 40.594126][ T146] RSP: 0018:ffff88806116f4a0 EFLAGS: 00010246 [ 40.594783][ T146] RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000000 [ 40.595653][ T146] RDX: 0000000000000000 RSI: ffff88806547ddd8 RDI: ffff8880540f1360 [ 40.596495][ T146] RBP: ffff88804011a808 R08: fffffbfff4fb8421 R09: fffffbfff4fb8421 [ 40.597377][ T146] R10: ffffffffa7dc2107 R11: 0000000000000000 R12: 0000000000000008 [ 40.598186][ T146] R13: ffff88804011a000 R14: ffff8880540f1000 R15: 1ffff1100c22de9a [ 40.599012][ T146] FS: 0000000000000000(0000) GS:ffff888067800000(0000) knlGS:0000000000000000 [ 40.600004][ T146] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 40.600665][ T146] CR2: 00005572d3a807b8 CR3: 000000005fcf4003 CR4: 00000000000606e0 [ 40.601485][ T146] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 40.602461][ T146] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 40.603443][ T146] Call Trace: [ 40.603871][ T146] ? nf_tables_dump_setelem+0xa0/0xa0 [nf_tables] [ 40.604587][ T146] ? macvlan_uninit+0x100/0x100 [macvlan] [ 40.605212][ T146] ? __module_text_address+0x13/0x140 [ 40.605842][ T146] notifier_call_chain+0x90/0x160 [ 40.606477][ T146] dev_set_mac_address+0x28e/0x3f0 [ 40.607117][ T146] ? netdev_notify_peers+0xc0/0xc0 [ 40.607762][ T146] ? __module_text_address+0x13/0x140 [ 40.608440][ T146] ? notifier_call_chain+0x90/0x160 [ 40.609097][ T146] ? dev_set_mac_address+0x1f0/0x3f0 [ 40.609758][ T146] dev_set_mac_address+0x1f0/0x3f0 [ 40.610402][ T146] ? __local_bh_enable_ip+0xe9/0x1b0 [ 40.611071][ T146] ? bond_hw_addr_flush+0x77/0x100 [bonding] [ 40.611823][ T146] ? netdev_notify_peers+0xc0/0xc0 [ 40.612461][ T146] ? bond_hw_addr_flush+0x77/0x100 [bonding] [ 40.613213][ T146] ? bond_hw_addr_flush+0x77/0x100 [bonding] [ 40.613963][ T146] ? __local_bh_enable_ip+0xe9/0x1b0 [ 40.614631][ T146] ? bond_time_in_interval.isra.31+0x90/0x90 [bonding] [ 40.615484][ T146] ? __bond_release_one+0x9f0/0x12c0 [bonding] [ 40.616230][ T146] __bond_release_one+0x9f0/0x12c0 [bonding] [ 40.616949][ T146] ? bond_enslave+0x47c0/0x47c0 [bonding] [ 40.617642][ T146] ? lock_downgrade+0x730/0x730 [ 40.618218][ T146] ? check_flags.part.42+0x450/0x450 [ 40.618850][ T146] ? __mutex_unlock_slowpath+0xd0/0x670 [ 40.619519][ T146] ? trace_hardirqs_on+0x30/0x180 [ 40.620117][ T146] ? wait_for_completion+0x250/0x250 [ 40.620754][ T146] bond_netdev_event+0x822/0x970 [bonding] [ 40.621460][ T146] ? __module_text_address+0x13/0x140 [ 40.622097][ T146] notifier_call_chain+0x90/0x160 [ 40.622806][ T146] rollback_registered_many+0x660/0xcf0 [ 40.623522][ T146] ? netif_set_real_num_tx_queues+0x780/0x780 [ 40.624290][ T146] ? notifier_call_chain+0x90/0x160 [ 40.624957][ T146] ? netdev_upper_dev_unlink+0x114/0x180 [ 40.625686][ T146] ? __netdev_adjacent_dev_unlink_neighbour+0x30/0x30 [ 40.626421][ T146] ? mutex_is_locked+0x13/0x50 [ 40.627016][ T146] ? unregister_netdevice_queue+0xf2/0x240 [ 40.627663][ T146] unregister_netdevice_many.part.134+0x13/0x1b0 [ 40.628362][ T146] default_device_exit_batch+0x2d9/0x390 [ 40.628987][ T146] ? unregister_netdevice_many+0x40/0x40 [ 40.629615][ T146] ? dev_change_net_namespace+0xcb0/0xcb0 [ 40.630279][ T146] ? prepare_to_wait_exclusive+0x2e0/0x2e0 [ 40.630943][ T146] ? ops_exit_list.isra.9+0x97/0x140 [ 40.631554][ T146] cleanup_net+0x441/0x890
[ ... ]
--- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/macvlan.c +1 -1
@@ -1676,7 +1676,7 @@ static int macvlan_device_event(struct n struct macvlan_dev, list); -if (macvlan_sync_address (vlan->dev, dev->dev_addr)) +if (vlan &&macvlan_sync_address (vlan->dev, dev->dev_addr))return NOTIFY_BAD ;break ;
Greg Kroah-Hartman
maintainerPATCH 58/131 net: bcmgenet: correct per TX/RX ring statistics
In reply to Greg Kroah-HartmanFrom: Doug Berger <[email protected]>
[ Upstream commit a6d0b83f25073bdf08b8547aeff961a62c6ab229 ]
The change to track net_device_stats per ring to better support SMP missed updating the rx_dropped member.
The ndo_get_stats method is also needed to combine the results for ethtool statistics (-S) before filling in the ethtool structure.
--- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/broadcom/genet/bcmgenet.c +3 -0
@@ -998,6 +998,8 @@ static void bcmgenet_get_ethtool_stats(sif (netif_running (dev))bcmgenet_update_mib_counters (priv); + dev->netdev_ops->ndo_get_stats (dev); +for (i =0 ; i <BCMGENET_STATS_LEN ; i++) {const struct bcmgenet_stats *s;char *p;
@@ -3211,6 +3213,7 @@ static struct net_device_stats *bcmgenet dev->stats.rx_packets = rx_packets; dev->stats.rx_errors = rx_errors; dev->stats.rx_missed_errors = rx_errors; + dev->stats.rx_dropped = rx_dropped;return &dev->stats; }
Greg Kroah-Hartman
maintainerPATCH 59/131 net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node
In reply to Greg Kroah-HartmanFrom: Xiyu Yang <[email protected]>
[ Upstream commit d03f228470a8c0a22b774d1f8d47071e0de4f6dd ]
nr_add_node() invokes nr_neigh_get_dev(), which returns a local reference of the nr_neigh object to "nr_neigh" with increased refcnt.
When nr_add_node() returns, "nr_neigh" becomes invalid, so the refcount should be decreased to keep refcount balanced.
The issue happens in one normal path of nr_add_node(), which forgets to decrease the refcnt increased by nr_neigh_get_dev() and causes a refcnt leak. It should decrease the refcnt before the function returns like other normal paths do.
Fix this issue by calling nr_neigh_put() before the nr_add_node() returns.
--- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+)
net/netrom/nr_route.c +1 -0
@@ -211,6 +211,7 @@ static int __must_check nr_add_node(ax25/* refcount initialized at 1 */ spin_unlock_bh (&nr_node_list_lock); +nr_neigh_put (nr_neigh);return 0 ; }nr_node_lock (nr_node);
Greg Kroah-Hartman
maintainerPATCH 60/131 net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array
In reply to Greg Kroah-HartmanFrom: Marc Zyngier <[email protected]>
[ Upstream commit f0212a5ebfa6cd789ab47666b9cc169e6e688732 ]
Running with KASAN on a VIM3L systems leads to the following splat when probing the Ethernet device:
==================================================================
BUG: KASAN: global-out-of-bounds in _get_maxdiv+0x74/0xd8
Read of size 4 at addr ffffa000090615f4 by task systemd-udevd/139
CPU: 1 PID: 139 Comm: systemd-udevd Tainted: G E 5.7.0-rc1-00101-g8624b7577b9c #781
Hardware name: amlogic w400/w400, BIOS 2020.01-rc5 03/12/2020
Call trace:
dump_backtrace+0x0/0x2a0
show_stack+0x20/0x30
dump_stack+0xec/0x148
print_address_description.isra.12+0x70/0x35c
__kasan_report+0xfc/0x1d4
kasan_report+0x4c/0x68
__asan_load4+0x9c/0xd8
_get_maxdiv+0x74/0xd8
clk_divider_bestdiv+0x74/0x5e0
clk_divider_round_rate+0x80/0x1a8
clk_core_determine_round_nolock.part.9+0x9c/0xd0
clk_core_round_rate_nolock+0xf0/0x108
clk_hw_round_rate+0xac/0xf0
clk_factor_round_rate+0xb8/0xd0
clk_core_determine_round_nolock.part.9+0x9c/0xd0
clk_core_round_rate_nolock+0xf0/0x108
clk_core_round_rate_nolock+0xbc/0x108
clk_core_set_rate_nolock+0xc4/0x2e8
clk_set_rate+0x58/0xe0
meson8b_dwmac_probe+0x588/0x72c [dwmac_meson8b]
platform_drv_probe+0x78/0xd8
really_probe+0x158/0x610
driver_probe_device+0x140/0x1b0
device_driver_attach+0xa4/0xb0
__driver_attach+0xcc/0x1c8
bus_for_each_dev+0xf4/0x168
driver_attach+0x3c/0x50
bus_add_driver+0x238/0x2e8
driver_register+0xc8/0x1e8
__platform_driver_register+0x88/0x98
meson8b_dwmac_driver_init+0x28/0x1000 [dwmac_meson8b]
do_one_initcall+0xa8/0x328
do_init_module+0xe8/0x368
load_module+0x3300/0x36b0
__do_sys_finit_module+0x120/0x1a8
__arm64_sys_finit_module+0x4c/0x60
el0_svc_common.constprop.2+0xe4/0x268
do_el0_svc+0x98/0xa8
el0_svc+0x24/0x68
el0_sync_handler+0x12c/0x318
el0_sync+0x158/0x180
The buggy address belongs to the variable:
div_table.63646+0x34/0xfffffffffffffa40 [dwmac_meson8b]
Memory state around the buggy address:
ffffa00009061480: fa fa fa fa 00 00 00 01 fa fa fa fa 00 00 00 00
ffffa00009061500: 05 fa fa fa fa fa fa fa 00 04 fa fa fa fa fa fa
>ffffa00009061580: 00 03 fa fa fa fa fa fa 00 00 00 00 00 00 fa fa
^
ffffa00009061600: fa fa fa fa 00 01 fa fa fa fa fa fa 01 fa fa fa
ffffa00009061680: fa fa fa fa 00 01 fa fa fa fa fa fa 04 fa fa fa
==================================================================Digging into this indeed shows that the clock divider array is lacking a final fence, and that the clock subsystems goes in the weeds. Oh well.
Let's add the empty structure that indicates the end of the array.
--- drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c +1 -0
@@ -125,6 +125,7 @@ static int meson8b_init_rgmii_tx_clk(str { .div = 5, .val = 5, }, { .div = 6, .val = 6, }, { .div = 7, .val = 7, }, + { /* end of array */ } }; clk_configs = devm_kzalloc(dev, sizeof(*clk_configs), GFP_KERNEL);
Greg Kroah-Hartman
maintainerPATCH 61/131 net/x25: Fix x25_neigh refcnt leak when receiving frame
In reply to Greg Kroah-HartmanFrom: Xiyu Yang <[email protected]>
[ Upstream commit f35d12971b4d814cdb2f659d76b42f0c545270b6 ]
x25_lapb_receive_frame() invokes x25_get_neigh(), which returns a reference of the specified x25_neigh object to "nb" with increased refcnt.
When x25_lapb_receive_frame() returns, local variable "nb" becomes invalid, so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in one path of x25_lapb_receive_frame(). When pskb_may_pull() returns false, the function forgets to decrease the refcnt increased by x25_get_neigh(), causing a refcnt leak.
Fix this issue by calling x25_neigh_put() when pskb_may_pull() returns false.
--- net/x25/x25_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/x25/x25_dev.c +3 -1
@@ -120,8 +120,10 @@ int x25_lapb_receive_frame(struct sk_buf goto drop; } -if (!pskb_may_pull (skb,1 )) +if (!pskb_may_pull (skb,1 )) { +x25_neigh_put (nb);return 0 ; + }switch (skb->data[0 ]) {
Greg Kroah-Hartman
maintainerPATCH 62/131 sched: etf: do not assume all sockets are full blown
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit a1211bf9a7774706722ba3b18c6157d980319f79 ]
skb->sk does not always point to a full blown socket, we need to use sk_fullsock() before accessing fields which only make sense on full socket.
BUG: KASAN: use-after-free in report_sock_error+0x286/0x300 net/sched/sch_etf.c:141 Read of size 1 at addr ffff88805eb9b245 by task syz-executor.5/9630 CPU: 1 PID: 9630 Comm: syz-executor.5 Not tainted 5.7.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: <IRQ> __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x188/0x20d lib/dump_stack.c:118 print_address_description.constprop.0.cold+0xd3/0x315 mm/kasan/report.c:382 __kasan_report.cold+0x35/0x4d mm/kasan/report.c:511 kasan_report+0x33/0x50 mm/kasan/common.c:625 report_sock_error+0x286/0x300 net/sched/sch_etf.c:141 etf_enqueue_timesortedlist+0x389/0x740 net/sched/sch_etf.c:170 __dev_xmit_skb net/core/dev.c:3710 [inline] __dev_queue_xmit+0x154a/0x30a0 net/core/dev.c:4021 neigh_hh_output include/net/neighbour.h:499 [inline] neigh_output include/net/neighbour.h:508 [inline] ip6_finish_output2+0xfb5/0x25b0 net/ipv6/ip6_output.c:117 __ip6_finish_output+0x442/0xab0 net/ipv6/ip6_output.c:143 ip6_finish_output+0x34/0x1f0 net/ipv6/ip6_output.c:153 NF_HOOK_COND include/linux/netfilter.h:296 [inline] ip6_output+0x239/0x810 net/ipv6/ip6_output.c:176 dst_output include/net/dst.h:435 [inline] NF_HOOK include/linux/netfilter.h:307 [inline] NF_HOOK include/linux/netfilter.h:301 [inline] ip6_xmit+0xe1a/0x2090 net/ipv6/ip6_output.c:280 tcp_v6_send_synack+0x4e7/0x960 net/ipv6/tcp_ipv6.c:521 tcp_rtx_synack+0x10d/0x1a0 net/ipv4/tcp_output.c:3916 inet_rtx_syn_ack net/ipv4/inet_connection_sock.c:669 [inline] reqsk_timer_handler+0x4c2/0xb40 net/ipv4/inet_connection_sock.c:763 call_timer_fn+0x1ac/0x780 kernel/time/timer.c:1405 expire_timers kernel/time/timer.c:1450 [inline] __run_timers kernel/time/timer.c:1774 [inline] __run_timers kernel/time/timer.c:1741 [inline] run_timer_softirq+0x623/0x1600 kernel/time/timer.c:1787 __do_softirq+0x26c/0x9f7 kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x192/0x1d0 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:546 [inline] smp_apic_timer_interrupt+0x19e/0x600 arch/x86/kernel/apic/apic.c:1140 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:829 </IRQ> RIP: 0010:des_encrypt+0x157/0x9c0 lib/crypto/des.c:792 Code: 85 22 06 00 00 41 31 dc 41 8b 4d 04 44 89 e2 41 83 e4 3f 4a 8d 3c a5 60 72 72 88 81 e2 3f 3f 3f 3f 48 89 f8 48 c1 e8 03 31 d9 <0f> b6 34 28 48 89 f8 c1 c9 04 83 e0 07 83 c0 03 40 38 f0 7c 09 40 RSP: 0018:ffffc90003b5f6c0 EFLAGS: 00000282 ORIG_RAX: ffffffffffffff13 RAX: 1ffffffff10e4e55 RBX: 00000000d2f846d0 RCX: 00000000d2f846d0 RDX: 0000000012380612 RSI: ffffffff839863ca RDI: ffffffff887272a8 RBP: dffffc0000000000 R08: ffff888091d0a380 R09: 0000000000800081 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000012 R13: ffff8880a8ae8078 R14: 00000000c545c93e R15: 0000000000000006 cipher_crypt_one crypto/cipher.c:75 [inline] crypto_cipher_encrypt_one+0x124/0x210 crypto/cipher.c:82 crypto_cbcmac_digest_update+0x1b5/0x250 crypto/ccm.c:830 crypto_shash_update+0xc4/0x120 crypto/shash.c:119 shash_ahash_update+0xa3/0x110 crypto/shash.c:246 crypto_ahash_update include/crypto/hash.h:547 [inline] hash_sendmsg+0x518/0xad0 crypto/algif_hash.c:102 sock_sendmsg_nosec net/socket.c:652 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:672 ____sys_sendmsg+0x308/0x7e0 net/socket.c:2362 ___sys_sendmsg+0x100/0x170 net/socket.c:2416 __sys_sendmmsg+0x195/0x480 net/socket.c:2506 __do_sys_sendmmsg net/socket.c:2535 [inline] __se_sys_sendmmsg net/socket.c:2532 [inline] __x64_sys_sendmmsg+0x99/0x100 net/socket.c:2532 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 RIP: 0033:0x45c829 Code: 0d b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f6d9528ec78 EFLAGS: 00000246 ORIG_RAX: 0000000000000133 RAX: ffffffffffffffda RBX: 00000000004fc080 RCX: 000000000045c829 RDX: 0000000000000001 RSI: 0000000020002640 RDI: 0000000000000004 RBP: 000000000078bf00 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff R13: 00000000000008d7 R14: 00000000004cb7aa R15: 00007f6d9528f6d4
--- net/sched/sch_etf.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
net/sched/sch_etf.c +4 -3
@@ -77,7 +77,7 @@ static bool is_packet_valid(struct Qdiscstruct sock *sk = nskb->sk;ktime_t now; -if (!sk) +if (!sk || !sk_fullsock (sk))return false;if (!sock_flag (sk,SOCK_TXTIME ))
@@ -129,8 +129,9 @@ static void report_sock_error(struct sk_struct sock_exterr_skb *serr;struct sk_buff *clone;ktime_t txtime = skb->tstamp; +struct sock *sk = skb->sk; -if (!skb->sk || !(skb->sk->sk_txtime_report_errors)) +if (!sk || !sk_fullsock (sk) || !(sk->sk_txtime_report_errors))return ; clone =skb_clone (skb,GFP_ATOMIC );
@@ -146,7 +147,7 @@ static void report_sock_error(struct sk_ serr->ee.ee_data = (txtime >>32 );/* high part of tstamp */ serr->ee.ee_info = txtime;/* low part of tstamp */ -if (sock_queue_err_skb (skb->sk, clone)) +if (sock_queue_err_skb (sk, clone))kfree_skb (clone); }
Greg Kroah-Hartman
maintainerPATCH 63/131 tcp: cache line align MAX_TCP_HEADER
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 9bacd256f1354883d3c1402655153367982bba49 ]
TCP stack is dumb in how it cooks its output packets.
Depending on MAX_HEADER value, we might chose a bad ending point for the headers.
If we align the end of TCP headers to cache line boundary, we make sure to always use the smallest number of cache lines, which always help.
--- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/tcp.h +1 -1
@@ -53,7 +53,7 @@ extern struct inet_hashinfo tcp_hashinfoextern struct percpu_counter tcp_orphan_count;void tcp_time_wait (struct sock *sk,int state,int timeo); -#define MAX_TCP_HEADER (128 + MAX_HEADER) +#define MAX_TCP_HEADER L1_CACHE_ALIGN(128 + MAX_HEADER)#define MAX_TCP_OPTION_SPACE 40#define TCP_MIN_SND_MSS 48#define TCP_MIN_GSO_SIZE (TCP_MIN_SND_MSS - MAX_TCP_OPTION_SPACE)
Greg Kroah-Hartman
maintainerPATCH 64/131 team: fix hang in team_mode_get()
In reply to Greg Kroah-HartmanFrom: Taehee Yoo <[email protected]>
[ Upstream commit 1c30fbc76b8f0c07c92a8ca4cd7c456612e17eb5 ]
When team mode is changed or set, the team_mode_get() is called to check whether the mode module is inserted or not. If the mode module is not inserted, it calls the request_module().
In the request_module(), it creates a child process, which is the "modprobe" process and waits for the done of the child process. At this point, the following locks were used. down_read(&cb_lock()); by genl_rcv()
genl_lock(); by genl_rcv_msc()
rtnl_lock(); by team_nl_cmd_options_set()
mutex_lock(&team->lock); by team_nl_team_get()Concurrently, the team module could be removed by rmmod or "modprobe -r" The __exit function of team module is team_module_exit(), which calls team_nl_fini() and it tries to acquire following locks.
down_write(&cb_lock);
genl_lock();Because of the genl_lock() and cb_lock, this process can't be finished earlier than request_module() routine.
The problem secenario.
CPU0 CPU1team_mode_get
request_module()
modprobe -r team_mode_roundrobin
team <--(B)
modprobe team <--(A)
team_mode_roundrobin
By request_module(), the "modprobe team_mode_roundrobin" command will be executed. At this point, the modprobe process will decide that the team module should be inserted before team_mode_roundrobin. Because the team module is being removed.
By the module infrastructure, the same module insert/remove operations can't be executed concurrently.
So, (A) waits for (B) but (B) also waits for (A) because of locks. So that the hang occurs at this point.
Test commands:
while :
do
teamd -d &
killall teamd &
modprobe -rv team_mode_roundrobin &
done
The approach of this patch is to hold the reference count of the team module if the team module is compiled as a module. If the reference count of the team module is not zero while request_module() is being called, the team module will not be removed at that moment.
So that the above scenario could not occur.
--- drivers/net/team/team.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/team/team.c +4 -0
@@ -475,6 +475,9 @@ static const struct team_mode *team_modestruct team_mode_item *mitem;const struct team_mode *mode =NULL ; +if (!try_module_get (THIS_MODULE )) +return NULL ; +spin_lock (&mode_list_lock); mitem =__find_mode (kind);if (!mitem) {
@@ -490,6 +493,7 @@ static const struct team_mode *team_mode }spin_unlock (&mode_list_lock); +module_put (THIS_MODULE );return mode; }
Greg Kroah-Hartman
maintainerPATCH 65/131 vrf: Fix IPv6 with qdisc and xfrm
In reply to Greg Kroah-HartmanFrom: David Ahern <[email protected]>
[ Upstream commit a53c102872ad6e34e1518e25899dc9498c27f8b1 ]
When a qdisc is attached to the VRF device, the packet goes down the ndo xmit function which is setup to send the packet back to the VRF driver which does a lookup to send the packet out. The lookup in the VRF driver is not considering xfrm policies. Change it to use ip6_dst_lookup_flow rather than ip6_route_output.
--- drivers/net/vrf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/vrf.c +2 -2
@@ -192,8 +192,8 @@ static netdev_tx_t vrf_process_v6_outbou fl6.flowi6_proto = iph->nexthdr; fl6.flowi6_flags =FLOWI_FLAG_SKIP_NH_OIF ; - dst =ip6_route_output (net,NULL , &fl6); -if (dst == dst_null) + dst =ip6_dst_lookup_flow (net,NULL , &fl6,NULL ); +if (IS_ERR (dst) || dst == dst_null) goto err;skb_dst_drop (skb);
Greg Kroah-Hartman
maintainerPATCH 66/131 net: dsa: b53: Lookup VID in ARL searches when VLAN is enabled
In reply to Greg Kroah-HartmanFrom: Florian Fainelli <[email protected]>
[ Upstream commit 2e97b0cd1651a270f3a3fcf42115c51f3284c049 ]
When VLAN is enabled, and an ARL search is issued, we also need to compare the full {MAC,VID} tuple before returning a successful search result.
--- drivers/net/dsa/b53/b53_common.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/dsa/b53/b53_common.c +3 -0
@@ -1284,6 +1284,9 @@ static int b53_arl_read(struct b53_deviccontinue ;if ((mac_vid &ARLTBL_MAC_MASK ) != mac)continue ; +if (dev->vlan_enabled && + ((mac_vid >>ARLTBL_VID_S ) &ARLTBL_VID_MASK ) != vid) +continue ; *idx = i; }
Greg Kroah-Hartman
maintainerPATCH 67/131 net: dsa: b53: Fix ARL register definitions
In reply to Greg Kroah-HartmanFrom: Florian Fainelli <[email protected]>
[ Upstream commit c2e77a18a7ed65eb48f6e389b6a59a0fd753646a ]
The ARL {MAC,VID} tuple and the forward entry were off by 0x10 bytes, which means that when we read/wrote from/to ARL bin index 0, we were actually accessing the ARLA_RWCTRL register.
--- drivers/net/dsa/b53/b53_regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/dsa/b53/b53_regs.h +2 -2
@@ -304,7 +304,7 @@* * BCM5325 and BCM5365 share most definitions below */ -#define B53_ARLTBL_MAC_VID_ENTRY (n) (0x10 * (n)) +#define B53_ARLTBL_MAC_VID_ENTRY (n) ((0x10 * (n)) + 0x10)#define ARLTBL_MAC_MASK 0xffffffffffffULL#define ARLTBL_VID_S 48#define ARLTBL_VID_MASK_25 0xff
@@ -316,7 +316,7 @@#define ARLTBL_VALID_25 BIT(63)/* ARL Table Data Entry N Registers (32 bit) */ -#define B53_ARLTBL_DATA_ENTRY (n) ((0x10 * (n)) + 0x08) +#define B53_ARLTBL_DATA_ENTRY (n) ((0x10 * (n)) + 0x18)#define ARLTBL_DATA_PORT_ID_MASK 0x1ff#define ARLTBL_TC (tc) ((3 & tc) << 11)#define ARLTBL_AGE BIT(14)
Greg Kroah-Hartman
maintainerPATCH 68/131 net: dsa: b53: Rework ARL bin logic
In reply to Greg Kroah-HartmanFrom: Florian Fainelli <[email protected]>
[ Upstream commit 6344dbde6a27d10d16246d734b968f84887841e2 ]
When asking the ARL to read a MAC address, we will get a number of bins returned in a single read. Out of those bins, there can essentially be 3 states:
- all bins are full, we have no space left, and we can either replace an existing address or return that full condition
- the MAC address was found, then we need to return its bin index and modify that one, and only that one
- the MAC address was not found and we have a least one bin free, we use that bin index location then
The code would unfortunately fail on all counts.
--- drivers/net/dsa/b53/b53_common.c | 30 ++++++++++++++++++++++++++---- drivers/net/dsa/b53/b53_regs.h | 3 +++ 2 files changed, 29 insertions(+), 4 deletions(-)
drivers/net/dsa/b53/b53_common.c +26 -4
@@ -1262,6 +1262,7 @@ static int b53_arl_read(struct b53_devic u16 vid, struct b53_arl_entry *ent, u8 *idx, bool is_valid) { +DECLARE_BITMAP (free_bins ,B53_ARLTBL_MAX_BIN_ENTRIES );unsigned int i;int ret;
@@ -1269,6 +1270,8 @@ static int b53_arl_read(struct b53_devicif (ret)return ret; +bitmap_zero (free_bins, dev->num_arl_entries); +/* Read the bins */ for (i =0 ; i < dev->num_arl_entries; i++) {u64 mac_vid;
@@ -1280,16 +1283,24 @@ static int b53_arl_read(struct b53_devic B53_ARLTBL_DATA_ENTRY(i), &fwd_entry);b53_arl_to_entry (ent, mac_vid, fwd_entry); -if (!(fwd_entry &ARLTBL_VALID )) +if (!(fwd_entry &ARLTBL_VALID )) { +set_bit (i, free_bins);continue ; + }if ((mac_vid &ARLTBL_MAC_MASK ) != mac)continue ;if (dev->vlan_enabled && ((mac_vid >>ARLTBL_VID_S ) &ARLTBL_VID_MASK ) != vid)continue ; *idx = i; +return 0 ; } +if (bitmap_weight (free_bins, dev->num_arl_entries) ==0 ) +return -ENOSPC ; + + *idx =find_first_bit (free_bins, dev->num_arl_entries); +return -ENOENT ; }
@@ -1319,10 +1330,21 @@ static int b53_arl_op(struct b53_deviceif (op)return ret; -/* We could not find a matching MAC, so reset to a new entry */ -if (ret) { +switch (ret) { +case -ENOSPC : +dev_dbg (dev->dev,"{%pM,%.4d} no space left in ARL\n" , + addr, vid); +return is_valid ? ret :0 ; +case -ENOENT : +/* We could not find a matching MAC, so reset to a new entry */ +dev_dbg (dev->dev,"{%pM,%.4d} not found, using idx: %d\n" , + addr, vid, idx); fwd_entry =0 ; - idx =1 ; +break ; +default : +dev_dbg (dev->dev,"{%pM,%.4d} found, using idx: %d\n" , + addr, vid, idx); +break ; }memset (&ent,0 ,sizeof (ent));
drivers/net/dsa/b53/b53_regs.h +3 -0
@@ -323,6 +323,9 @@#define ARLTBL_STATIC BIT(15)#define ARLTBL_VALID BIT(16) +/* Maximum number of bin entries in the ARL for all switches */ +#define B53_ARLTBL_MAX_BIN_ENTRIES 4 +/* ARL Search Control Register (8 bit) */ #define B53_ARL_SRCH_CTL 0x50#define B53_ARL_SRCH_CTL_25 0x20
Greg Kroah-Hartman
maintainerPATCH 69/131 net: dsa: b53: b53_arl_rw_op() needs to select IVL or SVL
In reply to Greg Kroah-HartmanFrom: Florian Fainelli <[email protected]>
[ Upstream commit 64fec9493f7dc9bdd7233bcfe98985c45bd0e3c1 ]
Flip the IVL_SVL_SELECT bit correctly based on the VLAN enable status, the default is to perform Shared VLAN learning instead of Individual learning.
--- drivers/net/dsa/b53/b53_common.c | 4 ++++ drivers/net/dsa/b53/b53_regs.h | 1 + 2 files changed, 5 insertions(+)
drivers/net/dsa/b53/b53_common.c +4 -0
@@ -1253,6 +1253,10 @@ static int b53_arl_rw_op(struct b53_devi reg |=ARLTBL_RW ; else reg &= ~ARLTBL_RW; +if (dev->vlan_enabled) + reg &= ~ARLTBL_IVL_SVL_SELECT ; +else + reg |=ARLTBL_IVL_SVL_SELECT ;b53_write8 (dev,B53_ARLIO_PAGE ,B53_ARLTBL_RW_CTRL , reg);return b53_arl_op_wait (dev);
drivers/net/dsa/b53/b53_regs.h +1 -0
@@ -292,6 +292,7 @@/* ARL Table Read/Write Register (8 bit) */ #define B53_ARLTBL_RW_CTRL 0x00#define ARLTBL_RW BIT(0) +#define ARLTBL_IVL_SVL_SELECT BIT(6)#define ARLTBL_START_DONE BIT(7)/* MAC Address Index Register (48 bit) */
Greg Kroah-Hartman
maintainerPATCH 70/131 xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish
In reply to Greg Kroah-HartmanFrom: David Ahern <[email protected]>
[ Upstream commit 0c922a4850eba2e668f73a3f1153196e09abb251 ]
IPSKB_XFRM_TRANSFORMED and IP6SKB_XFRM_TRANSFORMED are skb flags set by xfrm code to tell other skb handlers that the packet has been passed through the xfrm output functions. Simplify the code and just always set them rather than conditionally based on netfilter enabled thus making the flag available for other users.
--- net/ipv4/xfrm4_output.c | 2 -- net/ipv6/xfrm6_output.c | 2 -- 2 files changed, 4 deletions(-)
net/ipv4/xfrm4_output.c +0 -2
@@ -77,9 +77,7 @@ int xfrm4_output_finish(struct sock *sk, {memset (IPCB (skb),0 ,sizeof (*IPCB (skb))); -#ifdef CONFIG_NETFILTER IPCB (skb)->flags |=IPSKB_XFRM_TRANSFORMED ; -#endif return xfrm_output (sk, skb); }
net/ipv6/xfrm6_output.c +0 -2
@@ -130,9 +130,7 @@ int xfrm6_output_finish(struct sock *sk, {memset (IP6CB (skb),0 ,sizeof (*IP6CB (skb))); -#ifdef CONFIG_NETFILTER IP6CB (skb)->flags |=IP6SKB_XFRM_TRANSFORMED ; -#endif return xfrm_output (sk, skb); }
Greg Kroah-Hartman
maintainerPATCH 71/131 vrf: Check skb for XFRM_TRANSFORMED flag
In reply to Greg Kroah-HartmanFrom: David Ahern <[email protected]>
[ Upstream commit 16b9db1ce34ff00d6c18e82825125cfef0cdfb13 ]
To avoid a loop with qdiscs and xfrms, check if the skb has already gone through the qdisc attached to the VRF device and then to the xfrm layer. If so, no need for a second redirect.
--- drivers/net/vrf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/vrf.c +4 -2
@@ -478,7 +478,8 @@ static struct sk_buff *vrf_ip6_out(strucif (rt6_need_strict (&ipv6_hdr (skb)->daddr))return skb; -if (qdisc_tx_is_default (vrf_dev)) +if (qdisc_tx_is_default (vrf_dev) || +IP6CB (skb)->flags &IP6SKB_XFRM_TRANSFORMED )return vrf_ip6_out_direct (vrf_dev, sk, skb);return vrf_ip6_out_redirect (vrf_dev, skb);
@@ -692,7 +693,8 @@ static struct sk_buff *vrf_ip_out(struct ipv4_is_lbcast(ip_hdr(skb)->daddr))return skb; -if (qdisc_tx_is_default (vrf_dev)) +if (qdisc_tx_is_default (vrf_dev) || +IPCB (skb)->flags &IPSKB_XFRM_TRANSFORMED )return vrf_ip_out_direct (vrf_dev, sk, skb);return vrf_ip_out_redirect (vrf_dev, skb);
Greg Kroah-Hartman
maintainerPATCH 72/131 mlxsw: Fix some IS_ERR() vs NULL bugs
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit c391eb8366ae052d571bb2841f1ccb4d39f3ceb8 ]
The mlxsw_sp_acl_rulei_create() function is supposed to return an error pointer from mlxsw_afa_block_create(). The problem is that these functions both return NULL instead of error pointers. Half the callers expect NULL and half expect error pointers so it could lead to a NULL dereference on failure.
This patch changes both of them to return error pointers and changes all the callers which checked for NULL to check for IS_ERR() instead.
--- drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c | 4 ++-- drivers/net/ethernet/mellanox/mlxsw/spectrum2_acl_tcam.c | 4 ++-- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 3 ++- drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c +2 -2
@@ -316,7 +316,7 @@ struct mlxsw_afa_block *mlxsw_afa_block_ block =kzalloc (sizeof (*block),GFP_KERNEL );if (!block) -return NULL ; +return ERR_PTR (-ENOMEM );INIT_LIST_HEAD (&block->resource_list); block->afa = mlxsw_afa;
@@ -344,7 +344,7 @@ err_second_set_create:mlxsw_afa_set_destroy (block->first_set); err_first_set_create:kfree (block); -return NULL ; +return ERR_PTR (-ENOMEM ); }EXPORT_SYMBOL (mlxsw_afa_block_create);
drivers/net/ethernet/mellanox/mlxsw/spectrum2_acl_tcam.c +2 -2
@@ -88,8 +88,8 @@ static int mlxsw_sp2_acl_tcam_init(struc* to be written using PEFA register to all indexes for all regions. */ afa_block =mlxsw_afa_block_create (mlxsw_sp->afa); -if (!afa_block) { - err = -ENOMEM ; +if (IS_ERR (afa_block)) { + err =PTR_ERR (afa_block); goto err_afa_block; } err =mlxsw_afa_block_continue (afa_block);
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c +2 -1
@@ -442,7 +442,8 @@ mlxsw_sp_acl_rulei_create(struct mlxsw_s rulei =kzalloc (sizeof (*rulei),GFP_KERNEL );if (!rulei) -return NULL ; +return ERR_PTR (-ENOMEM ); + rulei->act_block =mlxsw_afa_block_create (acl->mlxsw_sp->afa);if (IS_ERR (rulei->act_block)) { err =PTR_ERR (rulei->act_block);
drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c +2 -2
@@ -199,8 +199,8 @@ mlxsw_sp_mr_tcam_afa_block_create(structint err; afa_block =mlxsw_afa_block_create (mlxsw_sp->afa); -if (!afa_block) -return ERR_PTR (-ENOMEM ); +if (IS_ERR (afa_block)) +return afa_block; err =mlxsw_afa_block_append_allocated_counter (afa_block, counter_index);
Greg Kroah-Hartman
maintainerPATCH 73/131 KEYS: Avoid false positive ENOMEM error on key read
In reply to Greg Kroah-HartmanFrom: Waiman Long <[email protected]>
[ Upstream commit 4f0882491a148059a52480e753b7f07fc550e188 ]
By allocating a kernel buffer with a user-supplied buffer length, it is possible that a false positive ENOMEM error may be returned because the user-supplied length is just too large even if the system do have enough memory to hold the actual key data.
Moreover, if the buffer length is larger than the maximum amount of memory that can be returned by kmalloc() (2^(MAX_ORDER-1) number of pages), a warning message will also be printed.
To reduce this possibility, we set a threshold (PAGE_SIZE) over which we do check the actual key length first before allocating a buffer of the right size to hold it. The threshold is arbitrary, it is just used to trigger a buffer length check. It does not limit the actual key length as long as there is enough memory to satisfy the memory request.
To further avoid large buffer allocation failure due to page fragmentation, kvmalloc() is used to allocate the buffer so that vmapped pages can be used when there is not a large enough contiguous set of pages available for allocation.
In the extremely unlikely scenario that the key keeps on being changed and made longer (still <= buflen) in between 2 __keyctl_read_key() calls, the __keyctl_read_key() calling loop in keyctl_read_key() may have to be iterated a large number of times, but definitely not infinite.
--- security/keys/internal.h | 12 +++++++++ security/keys/keyctl.c | 58 +++++++++++++++++++++++++++++----------- 2 files changed, 55 insertions(+), 15 deletions(-)
security/keys/internal.h +12 -0
@@ -20,6 +20,8 @@#include <linux/keyctl.h> #include <linux/refcount.h> #include <linux/compat.h> +#include <linux/mm.h> +#include <linux/vmalloc.h> struct iovec ;
@@ -305,4 +307,14 @@ static inline void key_check(const struct key *key)#endif +/* +* Helper function to clear and free a kvmalloc'ed memory object. +*/ +static inline void __kvzfree (const void *addr,size_t len) +{ +if (addr) { +memset ((void *)addr,0 , len); +kvfree (addr); + } +}#endif /* _INTERNAL_H */
security/keys/keyctl.c +43 -15
88 lines not on this page · raw message
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 74/131 ALSA: hda: Remove ASUS ROG Zenith from the blacklist
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit a8cf44f085ac12c0b5b8750ebb3b436c7f455419 ]
The commit 3c6fd1f07ed0 ("ALSA: hda: Add driver blacklist") added a new blacklist for the devices that are known to have empty codecs, and one of the entries was ASUS ROG Zenith II (PCI SSID 1043:874f). However, it turned out that the very same PCI SSID is used for the previous model that does have the valid HD-audio codecs and the change broke the sound on it.
This patch reverts the corresponding entry as a temporary solution. Although Zenith II and co will see get the empty HD-audio bus again, it'd be merely resource wastes and won't affect the functionality, so it's no end of the world. We'll need to address this later, e.g. by either switching to DMI string matching or using PCI ID & SSID pairs.
--- sound/pci/hda/hda_intel.c | 1 - 1 file changed, 1 deletion(-)
sound/pci/hda/hda_intel.c +0 -1
@@ -2215,7 +2215,6 @@ static const struct hdac_io_ops pci_hda_io_ops = {* should be ignored from the beginning. */ static const struct snd_pci_quirk driver_blacklist[] = { -SND_PCI_QUIRK (0x1043 ,0x874f ,"ASUS ROG Zenith II / Strix" ,0 ),SND_PCI_QUIRK (0x1462 ,0xcb59 ,"MSI TRX40 Creator" ,0 ),SND_PCI_QUIRK (0x1462 ,0xcb60 ,"MSI TRX40" ,0 ), {}
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 75/131 ALSA: usb-audio: Add static mapping table for ALC1220-VB-based mobos
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit a43c1c41bc5145971d06edc42a6b1e8faa0e2bc3 ]
TRX40 mobos from MSI and others with ALC1220-VB USB-audio device need yet more quirks for the proper control names.
This patch provides the mapping table for those boards, correcting the FU names for volume and mute controls as well as the terminal names for jack controls. It also improves build_connector_control() not to add the directional suffix blindly if the string is given from the mapping table.
With this patch applied, the new UCM profiles will be effective.
--- sound/usb/mixer.c | 12 +++++++++--- sound/usb/mixer_maps.c | 24 +++++++++++++++++++++--- sound/usb/quirks-table.h | 14 ++++++++++++++ 3 files changed, 44 insertions(+), 6 deletions(-)
sound/usb/mixer.c +9 -3
@@ -1770,8 +1770,10 @@ static void build_connector_control(struct usb_mixer_interface *mixer, {struct snd_kcontrol *kctl;struct usb_mixer_elem_info *cval; +const struct usbmix_name_map *map; -if (check_ignored_ctl (find_map (imap, term->id,0 ))) + map =find_map (imap, term->id,0 ); +if (check_ignored_ctl (map))return ; cval =kzalloc (sizeof (*cval),GFP_KERNEL );
@@ -1803,8 +1805,12 @@ static void build_connector_control(struct usb_mixer_interface *mixer,usb_mixer_elem_info_free (cval);return ; } -get_connector_control_name (mixer, term, is_input, kctl->id.name, -sizeof (kctl->id.name)); + +if (check_mapped_name (map, kctl->id.name,sizeof (kctl->id.name))) +strlcat (kctl->id.name," Jack" ,sizeof (kctl->id.name)); +else +get_connector_control_name (mixer, term, is_input, kctl->id.name, +sizeof (kctl->id.name)); kctl->private_free = snd_usb_mixer_elem_free;snd_usb_mixer_add_control (&cval->head, kctl); }
sound/usb/mixer_maps.c +21 -3
@@ -373,6 +373,24 @@ static const struct usbmix_name_map asus_rog_map[] = { {} }; +/* TRX40 mobos with Realtek ALC1220-VB */ +static const struct usbmix_name_map trx40_mobo_map[] = { + {18 ,NULL },/* OT, IEC958 - broken response, disabled */ + {19 ,NULL ,12 },/* FU, Input Gain Pad - broken response, disabled */ + {16 ,"Speaker" },/* OT */ + {22 ,"Speaker Playback" },/* FU */ + {7 ,"Line" },/* IT */ + {19 ,"Line Capture" },/* FU */ + {17 ,"Front Headphone" },/* OT */ + {23 ,"Front Headphone Playback" },/* FU */ + {8 ,"Mic" },/* IT */ + {20 ,"Mic Capture" },/* FU */ + {9 ,"Front Mic" },/* IT */ + {21 ,"Front Mic Capture" },/* FU */ + {24 ,"IEC958 Playback" },/* FU */ + {} +}; +/* * Control map entries */
@@ -494,7 +512,7 @@ static struct usbmix_ctl_map usbmix_ctl_maps[] = { }, {/* Gigabyte TRX40 Aorus Pro WiFi */ .id = USB_ID(0x0414, 0xa002), - .map = asus_rog_map, + .map = trx40_mobo_map, }, {/* ASUS ROG Zenith II */ .id = USB_ID(0x0b05, 0x1916),
@@ -506,11 +524,11 @@ static struct usbmix_ctl_map usbmix_ctl_maps[] = { }, {/* MSI TRX40 Creator */ .id = USB_ID(0x0db0, 0x0d64), - .map = asus_rog_map, + .map = trx40_mobo_map, }, {/* MSI TRX40 */ .id = USB_ID(0x0db0, 0x543d), - .map = asus_rog_map, + .map = trx40_mobo_map, }, { 0 } /* terminator */ };
sound/usb/quirks-table.h +14 -0
@@ -3400,4 +3400,18 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"), } }, +#define ALC1220_VB_DESKTOP (vend, prod) { \ + USB_DEVICE(vend, prod), \ + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { \ + .vendor_name = "Realtek", \ + .product_name = "ALC1220-VB-DT", \ + .profile_name = "Realtek-ALC1220-VB-Desktop", \ + .ifnum = QUIRK_NO_INTERFACE \ + } \ +} +ALC1220_VB_DESKTOP (0x0414 ,0xa002 ),/* Gigabyte TRX40 Aorus Pro WiFi */ +ALC1220_VB_DESKTOP (0x0db0 ,0x0d64 ),/* MSI TRX40 Creator */ +ALC1220_VB_DESKTOP (0x0db0 ,0x543d ),/* MSI TRX40 */ +#undef ALC1220_VB_DESKTOP + #undef USB_DEVICE_VENDOR_SPEC
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 76/131 ALSA: usb-audio: Add connector notifier delegation
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit fef66ae73a611e84c8b4b74ff6f805ec5f113477 ]
It turned out that ALC1220-VB USB-audio device gives the interrupt event to some PCM terminals while those don't allow the connector state request but only the actual I/O terminals return the request. The recent commit 7dc3c5a0172e ("ALSA: usb-audio: Don't create jack controls for PCM terminals") excluded those phantom terminals, so those events are ignored, too.
My first thought was that this could be easily deduced from the associated terminals, but some of them have even no associate terminal ID, hence it's not too trivial to figure out.
Since the number of such terminals are small and limited, this patch implements another quirk table for the simple mapping of the connectors. It's not really scalable, but let's hope that there will be not many such funky devices in future.
--- sound/usb/mixer.c | 25 +++++++++++++++++++++++++ sound/usb/mixer.h | 10 ++++++++++ sound/usb/mixer_maps.c | 13 +++++++++++++ 3 files changed, 48 insertions(+)
sound/usb/mixer.c +25 -0
@@ -3115,6 +3115,7 @@ static int snd_usb_mixer_controls(struct usb_mixer_interface *mixer)if (map->id == state.chip->usb_id) { state.map = map->map; state.selector_map = map->selector_map; + mixer->connector_map = map->connector_map; mixer->ignore_ctl_error |= map->ignore_ctl_error;break ; }
@@ -3196,10 +3197,32 @@ static int snd_usb_mixer_controls(struct usb_mixer_interface *mixer)return 0 ; } +static int delegate_notify (struct usb_mixer_interface *mixer,int unitid, +u8 *control,u8 *channel) +{ +const struct usbmix_connector_map *map = mixer->connector_map; + +if (!map) +return unitid; + +for (; map->id; map++) { +if (map->id == unitid) { +if (control && map->control) + *control = map->control; +if (channel && map->channel) + *channel = map->channel; +return map->delegated_id; + } + } +return unitid; +} +void snd_usb_mixer_notify_id (struct usb_mixer_interface *mixer,int unitid) {struct usb_mixer_elem_list *list; + unitid =delegate_notify (mixer, unitid,NULL ,NULL ); +for_each_mixer_elem (list, mixer, unitid) {struct usb_mixer_elem_info *info =mixer_elem_list_to_info (list);
@@ -3269,6 +3292,8 @@ static void snd_usb_mixer_interrupt_v2(struct usb_mixer_interface *mixer,return ; } + unitid =delegate_notify (mixer, unitid, &control, &channel); +for_each_mixer_elem (list, mixer, unitid) count++;
sound/usb/mixer.h +10 -0
@@ -4,6 +4,13 @@#include <sound/info.h> +struct usbmix_connector_map { +u8 id; +u8 delegated_id; +u8 control; +u8 channel; +}; +struct usb_mixer_interface {struct snd_usb_audio *chip;struct usb_host_interface *hostif;
@@ -16,6 +23,9 @@ struct usb_mixer_interface {/* the usb audio specification version this interface complies to */ int protocol; +/* optional connector delegation map */ +const struct usbmix_connector_map *connector_map; +/* Sound Blaster remote control stuff */ const struct rc_config *rc_cfg;u32 rc_code;
sound/usb/mixer_maps.c +13 -0
@@ -41,6 +41,7 @@ struct usbmix_ctl_map {u32 id;const struct usbmix_name_map *map;const struct usbmix_selector_map *selector_map; +const struct usbmix_connector_map *connector_map;int ignore_ctl_error; };
@@ -391,6 +392,15 @@ static const struct usbmix_name_map trx40_mobo_map[] = { {} }; +static const struct usbmix_connector_map trx40_mobo_connector_map[] = { + {10 ,16 },/* (Back) Speaker */ + {11 ,17 },/* Front Headphone */ + {13 ,7 },/* Line */ + {14 ,8 },/* Mic */ + {15 ,9 },/* Front Mic */ + {} +}; +/* * Control map entries */
@@ -513,6 +523,7 @@ static struct usbmix_ctl_map usbmix_ctl_maps[] = { {/* Gigabyte TRX40 Aorus Pro WiFi */ .id = USB_ID(0x0414, 0xa002), .map = trx40_mobo_map, + .connector_map = trx40_mobo_connector_map, }, {/* ASUS ROG Zenith II */ .id = USB_ID(0x0b05, 0x1916),
@@ -525,10 +536,12 @@ static struct usbmix_ctl_map usbmix_ctl_maps[] = { {/* MSI TRX40 Creator */ .id = USB_ID(0x0db0, 0x0d64), .map = trx40_mobo_map, + .connector_map = trx40_mobo_connector_map, }, {/* MSI TRX40 */ .id = USB_ID(0x0db0, 0x543d), .map = trx40_mobo_map, + .connector_map = trx40_mobo_connector_map, }, { 0 } /* terminator */ };
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 77/131 iio: core: remove extra semi-colon from devm_iio_device_register() macro
In reply to Greg Kroah-HartmanFrom: Lars Engebretsen <[email protected]>
commit a07479147be03d2450376ebaff9ea1a0682f25d6 upstream.
This change removes the semi-colon from the devm_iio_device_register() macro which seems to have been added by accident.
--- include/linux/iio/iio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/iio/iio.h +1 -1
@@ -599,7 +599,7 @@ void iio_device_unregister(struct iio_de* 0 on success, negative error number on failure. */ #define devm_iio_device_register (dev, indio_dev) \ - __devm_iio_device_register((dev), (indio_dev), THIS_MODULE); + __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)int __devm_iio_device_register (struct device *dev,struct iio_dev *indio_dev,struct module *this_mod);void devm_iio_device_unregister (struct device *dev,struct iio_dev *indio_dev);
Greg Kroah-Hartman
maintainerPATCH 78/131 iio: st_sensors: rely on odr mask to know if odr can be set
In reply to Greg Kroah-HartmanFrom: Lary Gibaud <[email protected]>
commit e450e07c14abae563ad13b064cbce9fdccc6bc8d upstream.
Indeed, relying on addr being not 0 cannot work because some device have their register to set odr at address 0. As a matter of fact, if the odr can be set, then there is a mask.
Sensors with ODR register at address 0 are: lsm303dlh, lsm303dlhc, lsm303dlm
--- drivers/iio/common/st_sensors/st_sensors_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/st_sensors/st_sensors_core.c +1 -1
@@ -93,7 +93,7 @@ int st_sensors_set_odr(struct iio_dev *istruct st_sensor_odr_avl odr_out = {0 ,0 };struct st_sensor_data *sdata =iio_priv (indio_dev); -if (!sdata->sensor_settings->odr.addr) +if (!sdata->sensor_settings->odr.mask)return 0 ; err =st_sensors_match_odr (sdata->sensor_settings, odr, &odr_out);
Greg Kroah-Hartman
maintainerPATCH 79/131 iio: adc: stm32-adc: fix sleep in atomic context
In reply to Greg Kroah-HartmanFrom: Olivier Moysan <[email protected]>
commit e2042d2936dfc84e9c600fe9b9d0039ca0e54b7d upstream.
This commit fixes the following error:
"BUG: sleeping function called from invalid context at kernel/irq/chip.c"
In DMA mode suppress the trigger irq handler, and make the buffer transfers directly in DMA callback, instead.
--- drivers/iio/adc/stm32-adc.c | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-)
drivers/iio/adc/stm32-adc.c +28 -3
@@ -1308,8 +1308,30 @@ static unsigned int stm32_adc_dma_residustatic void stm32_adc_dma_buffer_done (void *data) {struct iio_dev *indio_dev = data; +struct stm32_adc *adc =iio_priv (indio_dev); +int residue =stm32_adc_dma_residue (adc); + +/* +* In DMA mode the trigger services of IIO are not used +* (e.g. no call to iio_trigger_poll). +* Calling irq handler associated to the hardware trigger is not +* relevant as the conversions have already been done. Data +* transfers are performed directly in DMA callback instead. +* This implementation avoids to call trigger irq handler that +* may sleep, in an atomic context (DMA irq handler context). +*/ +dev_dbg (&indio_dev->dev,"%s bufi=%d\n" , __func__, adc->bufi); + +while (residue >= indio_dev->scan_bytes) { +u16 *buffer = (u16 *)&adc->rx_buf[adc->bufi]; -iio_trigger_poll_chained (indio_dev->trig); +iio_push_to_buffers (indio_dev, buffer); + + residue -= indio_dev->scan_bytes; + adc->bufi += indio_dev->scan_bytes; +if (adc->bufi >= adc->rx_buf_sz) + adc->bufi =0 ; + } }static int stm32_adc_dma_start (struct iio_dev *indio_dev)
@@ -1703,6 +1725,7 @@ static int stm32_adc_probe(struct platfo {struct iio_dev *indio_dev;struct device *dev = &pdev->dev; +irqreturn_t (*handler)(int irq,void *p) =NULL ;struct stm32_adc *adc;int ret;
@@ -1785,9 +1808,11 @@ static int stm32_adc_probe(struct platfoif (ret <0 ) goto err_clk_disable; +if (!adc->dma_chan) + handler = &stm32_adc_trigger_handler; + ret =iio_triggered_buffer_setup (indio_dev, - &iio_pollfunc_store_time, - &stm32_adc_trigger_handler, + &iio_pollfunc_store_time, handler, &stm32_adc_buffer_setup_ops);if (ret) {dev_err (&pdev->dev,"buffer setup failed\n" );
Greg Kroah-Hartman
maintainerPATCH 80/131 iio: xilinx-xadc: Fix ADC-B powerdown
In reply to Greg Kroah-HartmanFrom: Lars-Peter Clausen <[email protected]>
commit e44ec7794d88f918805d700240211a9ec05ed89d upstream.
The check for shutting down the second ADC is inverted. This causes it to be powered down when it should be enabled. As a result channels that are supposed to be handled by the second ADC return invalid conversion results.
--- drivers/iio/adc/xilinx-xadc-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/adc/xilinx-xadc-core.c +3 -2
@@ -723,13 +723,14 @@ static int xadc_power_adc_b(struct xadc {uint16_t val; +/* Powerdown the ADC-B when it is not needed. */ switch (seq_mode) {case XADC_CONF1_SEQ_SIMULTANEOUS :case XADC_CONF1_SEQ_INDEPENDENT : - val =XADC_CONF2_PD_ADC_B ; + val =0 ;break ;default : - val =0 ; + val =XADC_CONF2_PD_ADC_B ;break ; }
Greg Kroah-Hartman
maintainerPATCH 81/131 iio: xilinx-xadc: Fix clearing interrupt when enabling trigger
In reply to Greg Kroah-HartmanFrom: Lars-Peter Clausen <[email protected]>
commit f954b098fbac4d183219ce5b42d76d6df2aed50a upstream.
When enabling the trigger and unmasking the end-of-sequence (EOS) interrupt the EOS interrupt should be cleared from the status register. Otherwise it is possible that it was still set from a previous capture. If that is the case the interrupt would fire immediately even though no conversion has been done yet and stale data is being read from the device.
The old code only clears the interrupt if the interrupt was previously unmasked. Which does not make much sense since the interrupt is always masked at this point and in addition masking the interrupt does not clear the interrupt from the status register. So the clearing needs to be done unconditionally.
--- drivers/iio/adc/xilinx-xadc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/xilinx-xadc-core.c +1 -1
@@ -675,7 +675,7 @@ static int xadc_trigger_set_state(structspin_lock_irqsave (&xadc->lock, flags);xadc_read_reg (xadc,XADC_AXI_REG_IPIER , &val); -xadc_write_reg (xadc,XADC_AXI_REG_IPISR , val &XADC_AXI_INT_EOS ); +xadc_write_reg (xadc,XADC_AXI_REG_IPISR ,XADC_AXI_INT_EOS );if (state) val |=XADC_AXI_INT_EOS ;else
Greg Kroah-Hartman
maintainerPATCH 82/131 iio: xilinx-xadc: Fix sequencer configuration for aux channels in simultaneous mode
In reply to Greg Kroah-HartmanFrom: Lars-Peter Clausen <[email protected]>
commit 8bef455c8b1694547ee59e8b1939205ed9d901a6 upstream.
The XADC has two internal ADCs. Depending on the mode it is operating in either one or both of them are used. The device manual calls this continuous (one ADC) and simultaneous (both ADCs) mode.
The meaning of the sequencing register for the aux channels changes depending on the mode.
In continuous mode each bit corresponds to one of the 16 aux channels. And the single ADC will convert them one by one in order.
In simultaneous mode the aux channels are split into two groups the first 8 channels are assigned to the first ADC and the other 8 channels to the second ADC. The upper 8 bits of the sequencing register are unused and the lower 8 bits control both ADCs. This means a bit needs to be set if either the corresponding channel from the first group or the second group (or both) are set.
Currently the driver does not have the special handling required for simultaneous mode. Add it.
--- drivers/iio/adc/xilinx-xadc-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/iio/adc/xilinx-xadc-core.c +10 -0
@@ -799,6 +799,16 @@ static int xadc_preenable(struct iio_devif (ret) goto err; +/* +* In simultaneous mode the upper and lower aux channels are samples at +* the same time. In this mode the upper 8 bits in the sequencer +* register are don't care and the lower 8 bits control two channels +* each. As such we must set the bit if either the channel in the lower +* group or the upper group is enabled. +*/ +if (seq_mode ==XADC_CONF1_SEQ_SIMULTANEOUS ) + scan_mask = ((scan_mask >>8 ) | scan_mask) &0xff0000 ; + ret =xadc_write_adc_reg (xadc,XADC_REG_SEQ (1 ), scan_mask >>16 );if (ret) goto err;
Greg Kroah-Hartman
maintainerPATCH 83/131 iio: xilinx-xadc: Make sure not exceed maximum samplerate
In reply to Greg Kroah-HartmanFrom: Lars-Peter Clausen <[email protected]>
commit 3b7f9dbb827ce8680b98490215e698b6079a9ec5 upstream.
The XADC supports a samplerate of up to 1MSPS. Unfortunately the hardware does not have a FIFO, which means it generates an interrupt for each conversion sequence. At one 1MSPS this creates an interrupt storm that causes the system to soft-lock.
For this reason the driver limits the maximum samplerate to 150kSPS. Currently this check is only done when setting a new samplerate. But it is also possible that the initial samplerate configured in the FPGA bitstream exceeds the limit.
In this case when starting to capture data without first changing the samplerate the system can overload.
To prevent this check the currently configured samplerate in the probe function and reduce it to the maximum if necessary.
--- drivers/iio/adc/xilinx-xadc-core.c | 78 ++++++++++++++++++++++++++++--------- 1 file changed, 60 insertions(+), 18 deletions(-)
drivers/iio/adc/xilinx-xadc-core.c +60 -18
@@ -103,6 +103,16 @@ static const unsigned int XADC_ZYNQ_UNMA#define XADC_FLAGS_BUFFERED BIT(0) +/* +* The XADC hardware supports a samplerate of up to 1MSPS. Unfortunately it does +* not have a hardware FIFO. Which means an interrupt is generated for each +* conversion sequence. At 1MSPS sample rate the CPU in ZYNQ7000 is completely +* overloaded by the interrupts that it soft-lockups. For this reason the driver +* limits the maximum samplerate 150kSPS. At this rate the CPU is fairly busy, +* but still responsive. +*/ +#define XADC_MAX_SAMPLERATE 150000 +static void xadc_write_reg (struct xadc *xadc,unsigned int reg,uint32_t val) {
@@ -835,11 +845,27 @@ static const struct iio_buffer_setup_ops .postdisable = &xadc_postdisable, }; +static int xadc_read_samplerate (struct xadc *xadc) +{ +unsigned int div; +uint16_t val16; +int ret; + + ret =xadc_read_adc_reg (xadc,XADC_REG_CONF2 , &val16); +if (ret) +return ret; + + div = (val16 &XADC_CONF2_DIV_MASK ) >>XADC_CONF2_DIV_OFFSET ; +if (div <2 ) + div =2 ; + +return xadc_get_dclk_rate (xadc) / div /26 ; +} +static int xadc_read_raw (struct iio_dev *indio_dev,struct iio_chan_spec const *chan,int *val,int *val2,long info) {struct xadc *xadc =iio_priv (indio_dev); -unsigned int div;uint16_t val16;int ret;
@@ -892,41 +918,31 @@ static int xadc_read_raw(struct iio_dev *val = -((273150 <<12 ) /503975 );return IIO_VAL_INT ;case IIO_CHAN_INFO_SAMP_FREQ : - ret =xadc_read_adc_reg (xadc,XADC_REG_CONF2 , &val16); -if (ret) + ret =xadc_read_samplerate (xadc); +if (ret <0 )return ret; - div = (val16 &XADC_CONF2_DIV_MASK ) >>XADC_CONF2_DIV_OFFSET ; -if (div <2 ) - div =2 ; - - *val =xadc_get_dclk_rate (xadc) / div /26 ; - + *val = ret;return IIO_VAL_INT ;default :return -EINVAL ; } } -static int xadc_write_raw (struct iio_dev *indio_dev, -struct iio_chan_spec const *chan,int val,int val2,long info) +static int xadc_write_samplerate (struct xadc *xadc,int val) { -struct xadc *xadc =iio_priv (indio_dev);unsigned long clk_rate =xadc_get_dclk_rate (xadc);unsigned int div;if (!clk_rate)return -EINVAL ; -if (info !=IIO_CHAN_INFO_SAMP_FREQ ) -return -EINVAL ; -if (val <=0 )return -EINVAL ;/* Max. 150 kSPS */ -if (val >150000 ) - val =150000 ; +if (val >XADC_MAX_SAMPLERATE ) + val =XADC_MAX_SAMPLERATE ; val *=26 ;
@@ -939,7 +955,7 @@ static int xadc_write_raw(struct iio_dev* limit. */ div = clk_rate / val; -if (clk_rate / div /26 >150000 ) +if (clk_rate / div /26 >XADC_MAX_SAMPLERATE ) div++;if (div <2 ) div =2 ;
@@ -950,6 +966,17 @@ static int xadc_write_raw(struct iio_dev div << XADC_CONF2_DIV_OFFSET); } +static int xadc_write_raw (struct iio_dev *indio_dev, +struct iio_chan_spec const *chan,int val,int val2,long info) +{ +struct xadc *xadc =iio_priv (indio_dev); + +if (info !=IIO_CHAN_INFO_SAMP_FREQ ) +return -EINVAL ; + +return xadc_write_samplerate (xadc, val); +} +static const struct iio_event_spec xadc_temp_events[] = { { .type =IIO_EV_TYPE_THRESH ,
@@ -1237,6 +1264,21 @@ static int xadc_probe(struct platform_deif (ret) goto err_free_samplerate_trigger; +/* +* Make sure not to exceed the maximum samplerate since otherwise the +* resulting interrupt storm will soft-lock the system. +*/ +if (xadc->ops->flags &XADC_FLAGS_BUFFERED ) { + ret =xadc_read_samplerate (xadc); +if (ret <0 ) + goto err_free_samplerate_trigger; +if (ret >XADC_MAX_SAMPLERATE ) { + ret =xadc_write_samplerate (xadc,XADC_MAX_SAMPLERATE ); +if (ret <0 ) + goto err_free_samplerate_trigger; + } + } + ret =request_irq (xadc->irq, xadc->ops->interrupt_handler,0 ,dev_name (&pdev->dev), indio_dev);if (ret)
Greg Kroah-Hartman
maintainerPATCH 84/131 fs/namespace.c: fix mountpoint reference counter race
In reply to Greg Kroah-HartmanFrom: Piotr Krysiuk <[email protected]>
A race condition between threads updating mountpoint reference counter affects longterm releases 4.4.220, 4.9.220, 4.14.177 and 4.19.118.
The mountpoint reference counter corruption may occur when:
* one thread increments m_count member of struct mountpoint [under namespace_sem, but not holding mount_lock] pivot_root()
* another thread simultaneously decrements the same m_count [under mount_lock, but not holding namespace_sem] put_mountpoint()
unhash_mnt()
umount_mnt()
mntput_no_expire()
To fix this race condition, grab mount_lock before updating m_count in pivot_root().
Reference: CVE-2020-12114
--- fs/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
@@ -3142,8 +3142,8 @@ SYSCALL_DEFINE2(pivot_root, const char _/* make certain new is below the root */ if (!is_path_reachable (new_mnt, new.dentry, &root)) goto out4; - root_mp->m_count++;/* pin it so it won't go away */ lock_mount_hash (); + root_mp->m_count++;/* pin it so it won't go away */ detach_mnt (new_mnt, &parent_path);detach_mnt (root_mnt, &root_parent);if (root_mnt->mnt.mnt_flags &MNT_LOCKED ) {
Greg Kroah-Hartman
maintainerPATCH 85/131 USB: sisusbvga: Change port variable from signed to unsigned
In reply to Greg Kroah-HartmanFrom: Changming Liu <[email protected]>
commit 2df7405f79ce1674d73c2786fe1a8727c905d65b upstream.
Change a bunch of arguments of wrapper functions which pass signed integer to an unsigned integer which might cause undefined behaviors when sign integer overflow.
--- drivers/usb/misc/sisusbvga/sisusb.c | 20 ++++++++++---------- drivers/usb/misc/sisusbvga/sisusb_init.h | 14 +++++++------- 2 files changed, 17 insertions(+), 17 deletions(-)
drivers/usb/misc/sisusbvga/sisusb.c +10 -10
@@ -1199,18 +1199,18 @@ static int sisusb_read_mem_bulk(struct s/* High level: Gfx (indexed) register access */ #ifdef INCL_SISUSB_CON -int sisusb_setreg (struct sisusb_usb_data *sisusb,int port,u8 data) +int sisusb_setreg (struct sisusb_usb_data *sisusb,u32 port,u8 data) {return sisusb_write_memio_byte (sisusb,SISUSB_TYPE_IO , port, data); } -int sisusb_getreg (struct sisusb_usb_data *sisusb,int port,u8 *data) +int sisusb_getreg (struct sisusb_usb_data *sisusb,u32 port,u8 *data) {return sisusb_read_memio_byte (sisusb,SISUSB_TYPE_IO , port, data); }#endif -int sisusb_setidxreg (struct sisusb_usb_data *sisusb,int port, +int sisusb_setidxreg (struct sisusb_usb_data *sisusb,u32 port,u8 index,u8 data) {int ret;
@@ -1220,7 +1220,7 @@ int sisusb_setidxreg(struct sisusb_usb_dreturn ret; } -int sisusb_getidxreg (struct sisusb_usb_data *sisusb,int port, +int sisusb_getidxreg (struct sisusb_usb_data *sisusb,u32 port,u8 index,u8 *data) {int ret;
@@ -1230,7 +1230,7 @@ int sisusb_getidxreg(struct sisusb_usb_dreturn ret; } -int sisusb_setidxregandor (struct sisusb_usb_data *sisusb,int port,u8 idx, +int sisusb_setidxregandor (struct sisusb_usb_data *sisusb,u32 port,u8 idx,u8 myand,u8 myor) {int ret;
@@ -1245,7 +1245,7 @@ int sisusb_setidxregandor(struct sisusb_ }static int sisusb_setidxregmask (struct sisusb_usb_data *sisusb, -int port,u8 idx,u8 data,u8 mask) +u32 port,u8 idx,u8 data,u8 mask) {int ret;u8 tmp;
@@ -1258,13 +1258,13 @@ static int sisusb_setidxregmask(struct sreturn ret; } -int sisusb_setidxregor (struct sisusb_usb_data *sisusb,int port, +int sisusb_setidxregor (struct sisusb_usb_data *sisusb,u32 port,u8 index,u8 myor) {return sisusb_setidxregandor (sisusb, port, index,0xff , myor); } -int sisusb_setidxregand (struct sisusb_usb_data *sisusb,int port, +int sisusb_setidxregand (struct sisusb_usb_data *sisusb,u32 port,u8 idx,u8 myand) {return sisusb_setidxregandor (sisusb, port, idx, myand,0x00 );
@@ -2787,8 +2787,8 @@ static loff_t sisusb_lseek(struct file *static int sisusb_handle_command (struct sisusb_usb_data *sisusb,struct sisusb_command *y,unsigned long arg) { -int retval, port, length; -u32 address; +int retval, length; +u32 port, address;/* All our commands require the device * to be initialized.
drivers/usb/misc/sisusbvga/sisusb_init.h +7 -7
@@ -812,17 +812,17 @@ static const struct SiS_VCLKData SiSUSB_int SiSUSBSetMode (struct SiS_Private *SiS_Pr,unsigned short ModeNo);int SiSUSBSetVESAMode (struct SiS_Private *SiS_Pr,unsigned short VModeNo); -extern int sisusb_setreg (struct sisusb_usb_data *sisusb,int port,u8 data); -extern int sisusb_getreg (struct sisusb_usb_data *sisusb,int port,u8 * data); -extern int sisusb_setidxreg (struct sisusb_usb_data *sisusb,int port, +extern int sisusb_setreg (struct sisusb_usb_data *sisusb,u32 port,u8 data); +extern int sisusb_getreg (struct sisusb_usb_data *sisusb,u32 port,u8 * data); +extern int sisusb_setidxreg (struct sisusb_usb_data *sisusb,u32 port,u8 index,u8 data); -extern int sisusb_getidxreg (struct sisusb_usb_data *sisusb,int port, +extern int sisusb_getidxreg (struct sisusb_usb_data *sisusb,u32 port,u8 index,u8 * data); -extern int sisusb_setidxregandor (struct sisusb_usb_data *sisusb,int port, +extern int sisusb_setidxregandor (struct sisusb_usb_data *sisusb,u32 port,u8 idx,u8 myand,u8 myor); -extern int sisusb_setidxregor (struct sisusb_usb_data *sisusb,int port, +extern int sisusb_setidxregor (struct sisusb_usb_data *sisusb,u32 port,u8 index,u8 myor); -extern int sisusb_setidxregand (struct sisusb_usb_data *sisusb,int port, +extern int sisusb_setidxregand (struct sisusb_usb_data *sisusb,u32 port,u8 idx,u8 myand);void sisusb_delete (struct kref *kref);
Greg Kroah-Hartman
maintainerPATCH 86/131 USB: Add USB_QUIRK_DELAY_CTRL_MSG and USB_QUIRK_DELAY_INIT for Corsair K70 RGB RAPIDFIRE
In reply to Greg Kroah-HartmanFrom: Jonathan Cox <[email protected]>
commit be34a5854b4606bd7a160ad3cb43415d623596c7 upstream.
The Corsair K70 RGB RAPIDFIRE needs the USB_QUIRK_DELAY_INIT and USB_QUIRK_DELAY_CTRL_MSG to function or it will randomly not respond on boot, just like other Corsair keyboards
--- drivers/usb/core/quirks.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/usb/core/quirks.c +4 -0
@@ -430,6 +430,10 @@ static const struct usb_device_id usb_qu/* Corsair K70 LUX */ { USB_DEVICE(0x1b1c, 0x1b36), .driver_info = USB_QUIRK_DELAY_INIT }, + /* Corsair K70 RGB RAPDIFIRE */ + { USB_DEVICE(0x1b1c, 0x1b38), .driver_info = USB_QUIRK_DELAY_INIT | + USB_QUIRK_DELAY_CTRL_MSG }, + /* MIDI keyboard WORLDE MINI */ { USB_DEVICE(0x1c75, 0x0204), .driver_info = USB_QUIRK_CONFIG_INTF_STRINGS },
Greg Kroah-Hartman
maintainerPATCH 87/131 USB: early: Handle AMDs spec-compliant identifiers, too
In reply to Greg Kroah-HartmanFrom: Jann Horn <[email protected]>
commit 7dbdb53d72a51cea9b921d9dbba54be00752212a upstream.
This fixes a bug that causes the USB3 early console to freeze after printing a single line on AMD machines because it can't parse the Transfer TRB properly.
The spec at
https://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/extensible-host-controler-interface-usb-xhci.pdf
says in section "4.5.1 Device Context Index" that the Context Index, also known as Endpoint ID according to
section "1.6 Terms and Abbreviations", is normally computed as DCI = (Endpoint Number * 2) + Direction, which matches the current definitions of XDBC_EPID_OUT and XDBC_EPID_IN.
However, the numbering in a Debug Capability Context data structure is supposed to be different:
Section "7.6.3.2 Endpoint Contexts and Transfer Rings" explains that a Debug Capability Context data structure has the endpoints mapped to indices 0 and 1.
Change XDBC_EPID_OUT/XDBC_EPID_IN to the spec-compliant values, add XDBC_EPID_OUT_INTEL/XDBC_EPID_IN_INTEL with Intel's incorrect values, and let xdbc_handle_tx_event() handle both.
I have verified that with this patch applied, the USB3 early console works on both an Intel and an AMD machine.
--- drivers/usb/early/xhci-dbc.c | 8 ++++---- drivers/usb/early/xhci-dbc.h | 18 ++++++++++++++++-- 2 files changed, 20 insertions(+), 6 deletions(-)
drivers/usb/early/xhci-dbc.c +4 -4
@@ -735,19 +735,19 @@ static void xdbc_handle_tx_event(structcase COMP_USB_TRANSACTION_ERROR :case COMP_STALL_ERROR :default : -if (ep_id ==XDBC_EPID_OUT ) +if (ep_id ==XDBC_EPID_OUT || ep_id ==XDBC_EPID_OUT_INTEL ) xdbc.flags |=XDBC_FLAGS_OUT_STALL ; -if (ep_id ==XDBC_EPID_IN ) +if (ep_id ==XDBC_EPID_IN || ep_id ==XDBC_EPID_IN_INTEL ) xdbc.flags |=XDBC_FLAGS_IN_STALL ;xdbc_trace ("endpoint %d stalled\n" , ep_id);break ; } -if (ep_id ==XDBC_EPID_IN ) { +if (ep_id ==XDBC_EPID_IN || ep_id ==XDBC_EPID_IN_INTEL ) { xdbc.flags &= ~XDBC_FLAGS_IN_PROCESS ;xdbc_bulk_transfer (NULL ,XDBC_MAX_PACKET , true); - }else if (ep_id ==XDBC_EPID_OUT ) { + }else if (ep_id ==XDBC_EPID_OUT || ep_id ==XDBC_EPID_OUT_INTEL ) { xdbc.flags &= ~XDBC_FLAGS_OUT_PROCESS ; }else {xdbc_trace ("invalid endpoint id %d\n" , ep_id);
drivers/usb/early/xhci-dbc.h +16 -2
@@ -120,8 +120,22 @@ struct xdbc_ring {u32 cycle_state; }; -#define XDBC_EPID_OUT 2 -#define XDBC_EPID_IN 3 +/* +* These are the "Endpoint ID" (also known as "Context Index") values for the +* OUT Transfer Ring and the IN Transfer Ring of a Debug Capability Context data +* structure. +* According to the "eXtensible Host Controller Interface for Universal Serial +* Bus (xHCI)" specification, section "7.6.3.2 Endpoint Contexts and Transfer +* Rings", these should be 0 and 1, and those are the values AMD machines give +* you; but Intel machines seem to use the formula from section "4.5.1 Device +* Context Index", which is supposed to be used for the Device Context only. +* Luckily the values from Intel don't overlap with those from AMD, so we can +* just test for both. +*/ +#define XDBC_EPID_OUT 0 +#define XDBC_EPID_IN 1 +#define XDBC_EPID_OUT_INTEL 2 +#define XDBC_EPID_IN_INTEL 3struct xdbc_state {u16 vendor;
Greg Kroah-Hartman
maintainerPATCH 89/131 USB: hub: Fix handling of connect changes during sleep
In reply to Greg Kroah-HartmanFrom: Alan Stern <[email protected]>
commit 9f952e26295d977dbfc6fedeaf8c4f112c818d37 upstream.
Commit 8099f58f1ecd ("USB: hub: Don't record a connect-change event during reset-resume") wasn't very well conceived. The problem it tried to fix was that if a connect-change event occurred while the system was asleep (such as a device disconnecting itself from the bus when it is suspended and then reconnecting when it resumes) requiring a reset-resume during the system wakeup transition, the hub port's change_bit entry would remain set afterward. This would cause the hub driver to believe another connect-change event had occurred after the reset-resume, which was wrong and would lead the driver to send unnecessary requests to the device (which could interfere with a firmware update).
The commit tried to fix this by not setting the change_bit during the wakeup. But this was the wrong thing to do; it means that when a device is unplugged while the system is asleep, the hub driver doesn't realize anything has happened: The change_bit flag which would tell it to handle the disconnect event is clear.
The commit needs to be reverted and the problem fixed in a different way. Fortunately an alternative solution was noted in the commit's
Changelog: We can continue to set the change_bit entry in hub_activate() but then clear it when a reset-resume occurs. That way the the hub driver will see the change_bit when a device is disconnected but won't see it when the device is still present.
That's what this patch does.
--- drivers/usb/core/hub.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/usb/core/hub.c +14 -0
@@ -1196,6 +1196,11 @@ static void hub_activate(struct usb_hub#ifdef CONFIG_PM udev->reset_resume =1 ;#endif +/* Don't set the change_bits when the device +* was powered off. +*/ +if (test_bit (port1, hub->power_bits)) +set_bit (port1, hub->change_bits); }else {/* The power session is gone; tell hub_wq */
@@ -3051,6 +3056,15 @@ static int check_port_resume_type(structif (portchange &USB_PORT_STAT_C_ENABLE )usb_clear_port_feature (hub->hdev, port1,USB_PORT_FEAT_C_ENABLE ); + +/* +* Whatever made this reset-resume necessary may have +* turned on the port1 bit in hub->change_bits. But after +* a successful reset-resume we want the bit to be clear; +* if it was on it would indicate that something happened +* following the reset-resume. +*/ +clear_bit (port1, hub->change_bits); }return status;
Greg Kroah-Hartman
maintainerPATCH 90/131 vmalloc: fix remap_vmalloc_range() bounds checks
In reply to Greg Kroah-HartmanFrom: Jann Horn <[email protected]>
commit bdebd6a2831b6fab69eb85cee74a8ba77f1a1cc2 upstream.
remap_vmalloc_range() has had various issues with the bounds checks it promises to perform ("This function checks that addr is a valid vmalloc'ed area, and that it is big enough to cover the vma") over time, e.g.:
- not detecting pgoff<<PAGE_SHIFT overflow
- not detecting (pgoff<<PAGE_SHIFT)+usize overflow
- not checking whether addr and addr+(pgoff<<PAGE_SHIFT) are the same vmalloc allocation
- comparing a potentially wildly out-of-bounds pointer with the end of the vmalloc region
In particular, since commit fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY"), unprivileged users can cause kernel null pointer dereferences by calling mmap() on a BPF map with a size that is bigger than the distance from the start of the BPF map to the end of the address space.
This could theoretically be used as a kernel ASLR bypass, by using whether mmap() with a given offset oopses or returns an error code to perform a binary search over the possible address range.
To allow remap_vmalloc_range_partial() to verify that addr and addr+(pgoff<<PAGE_SHIFT) are in the same vmalloc region, pass the offset to remap_vmalloc_range_partial() instead of adding it to the pointer in remap_vmalloc_range().
In remap_vmalloc_range_partial(), fix the check against get_vm_area_size() by using size comparisons instead of pointer comparisons, and add checks for pgoff.
--- fs/proc/vmcore.c | 5 +++-- include/linux/vmalloc.h | 2 +- mm/vmalloc.c | 16 +++++++++++++--- samples/vfio-mdev/mdpy.c | 2 +- 4 files changed, 18 insertions(+), 7 deletions(-)
fs/proc/vmcore.c +3 -2
@@ -250,7 +250,8 @@ static int vmcoredd_mmap_dumps(struct vmif (start < offset + dump->size) { tsz =min (offset + (u64 )dump->size - start, (u64 )size); buf = dump->buf + start - offset; -if (remap_vmalloc_range_partial (vma, dst, buf, tsz)) { +if (remap_vmalloc_range_partial (vma, dst, buf,0 , + tsz)) { ret = -EFAULT ; goto out_unlock; }
@@ -607,7 +608,7 @@ static int mmap_vmcore(struct file *file tsz =min (elfcorebuf_sz + elfnotes_sz - (size_t )start, size); kaddr = elfnotes_buf + start - elfcorebuf_sz - vmcoredd_orig_sz;if (remap_vmalloc_range_partial (vma, vma->vm_start + len, - kaddr, tsz)) + kaddr,0 , tsz)) goto fail; size -= tsz;
include/linux/vmalloc.h +1 -1
@@ -103,7 +103,7 @@ extern void vunmap(const void *addr);extern int remap_vmalloc_range_partial (struct vm_area_struct *vma,unsigned long uaddr,void *kaddr, -unsigned long size); +unsigned long pgoff,unsigned long size);extern int remap_vmalloc_range (struct vm_area_struct *vma,void *addr,unsigned long pgoff);
mm/vmalloc.c +13 -3
@@ -31,6 +31,7 @@#include <linux/compiler.h> #include <linux/llist.h> #include <linux/bitops.h> +#include <linux/overflow.h> #include <linux/uaccess.h> #include <asm/tlbflush.h>
@@ -2228,6 +2229,7 @@ finished:* @vma: vma to cover * @uaddr: target user address to start at * @kaddr: virtual address of vmalloc kernel memory +* @pgoff: offset from @kaddr to start at * @size: size of map area * * Returns: 0 for success, -Exxx on failure
@@ -2240,9 +2242,15 @@ finished:* Similar to remap_pfn_range() (see mm/memory.c) */ int remap_vmalloc_range_partial (struct vm_area_struct *vma,unsigned long uaddr, -void *kaddr,unsigned long size) +void *kaddr,unsigned long pgoff, +unsigned long size) {struct vm_struct *area; +unsigned long off; +unsigned long end_index; + +if (check_shl_overflow (pgoff,PAGE_SHIFT , &off)) +return -EINVAL ; size =PAGE_ALIGN (size);
@@ -2256,8 +2264,10 @@ int remap_vmalloc_range_partial(struct vif (!(area->flags &VM_USERMAP ))return -EINVAL ; -if (kaddr + size > area->addr +get_vm_area_size (area)) +if (check_add_overflow (size, off, &end_index) || + end_index >get_vm_area_size (area))return -EINVAL ; + kaddr += off; do { struct page *page = vmalloc_to_page(kaddr);
@@ -2296,7 +2306,7 @@ int remap_vmalloc_range(struct vm_area_s unsigned long pgoff) {return remap_vmalloc_range_partial (vma, vma->vm_start, - addr + (pgoff <<PAGE_SHIFT ), + addr, pgoff, vma->vm_end - vma->vm_start); }EXPORT_SYMBOL (remap_vmalloc_range);
samples/vfio-mdev/mdpy.c +1 -1
@@ -418,7 +418,7 @@ static int mdpy_mmap(struct mdev_devicereturn -EINVAL ;return remap_vmalloc_range_partial (vma, vma->vm_start, - mdev_state->memblk, + mdev_state->memblk,0 , vma->vm_end - vma->vm_start); }
Greg Kroah-Hartman
maintainerPATCH 91/131 mm/hugetlb: fix a addressing exception caused by huge_pte_offset
In reply to Greg Kroah-HartmanFrom: Longpeng <[email protected]>
commit 3c1d7e6ccb644d517a12f73a7ff200870926f865 upstream.
Our machine encountered a panic(addressing exception) after run for a long time and the calltrace is:
RIP: hugetlb_fault+0x307/0xbe0
RSP: 0018:ffff9567fc27f808 EFLAGS: 00010286
RAX: e800c03ff1258d48 RBX: ffffd3bb003b69c0 RCX: e800c03ff1258d48
RDX: 17ff3fc00eda72b7 RSI: 00003ffffffff000 RDI: e800c03ff1258d48
RBP: ffff9567fc27f8c8 R08: e800c03ff1258d48 R09: 0000000000000080
R10: ffffaba0704c22a8 R11: 0000000000000001 R12: ffff95c87b4b60d8
R13: 00005fff00000000 R14: 0000000000000000 R15: ffff9567face8074
FS: 00007fe2d9ffb700(0000) GS:ffff956900e40000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffd3bb003b69c0 CR3: 000000be67374000 CR4: 00000000003627e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
follow_hugetlb_page+0x175/0x540
__get_user_pages+0x2a0/0x7e0
__get_user_pages_unlocked+0x15d/0x210
__gfn_to_pfn_memslot+0x3c5/0x460 [kvm]
try_async_pf+0x6e/0x2a0 [kvm]
tdp_page_fault+0x151/0x2d0 [kvm]
...
kvm_arch_vcpu_ioctl_run+0x330/0x490 [kvm]
kvm_vcpu_ioctl+0x309/0x6d0 [kvm]
do_vfs_ioctl+0x3f0/0x540
SyS_ioctl+0xa1/0xc0
system_call_fastpath+0x22/0x27For 1G hugepages, huge_pte_offset() wants to return NULL or pudp, but it may return a wrong 'pmdp' if there is a race. Please look at the following code snippet:
...
pud = pud_offset(p4d, addr);
if (sz != PUD_SIZE && pud_none(*pud))
return NULL;
/* hugepage or swap? */
if (pud_huge(*pud) || !pud_present(*pud))
return (pte_t *)pud;
pmd = pmd_offset(pud, addr);
if (sz != PMD_SIZE && pmd_none(*pmd))
return NULL;
/* hugepage or swap? */
if (pmd_huge(*pmd) || !pmd_present(*pmd))
return (pte_t *)pmd;
...The following sequence would trigger this bug:
- CPU0: sz = PUD_SIZE and *pud = 0 , continue
- CPU0: "pud_huge(*pud)" is false
- CPU1: calling hugetlb_no_page and set *pud to xxxx8e7(PRESENT)
- CPU0: "!pud_present(*pud)" is false, continue
- CPU0: pmd = pmd_offset(pud, addr) and maybe return a wrong pmdp
However, we want CPU0 to return NULL or pudp in this case.
We must make sure there is exactly one dereference of pud and pmd.
--- mm/hugetlb.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
mm/hugetlb.c +8 -6
@@ -4820,8 +4820,8 @@ pte_t *huge_pte_offset(struct mm_struct {pgd_t *pgd;p4d_t *p4d; -pud_t *pud; -pmd_t *pmd; +pud_t *pud, pud_entry; +pmd_t *pmd, pmd_entry; pgd =pgd_offset (mm, addr);if (!pgd_present (*pgd))
@@ -4831,17 +4831,19 @@ pte_t *huge_pte_offset(struct mm_structreturn NULL ; pud =pud_offset (p4d, addr); -if (sz !=PUD_SIZE &&pud_none (*pud)) + pud_entry =READ_ONCE (*pud); +if (sz !=PUD_SIZE &&pud_none (pud_entry))return NULL ;/* hugepage or swap? */ -if (pud_huge (*pud) || !pud_present (*pud)) +if (pud_huge (pud_entry) || !pud_present (pud_entry))return (pte_t *)pud; pmd =pmd_offset (pud, addr); -if (sz !=PMD_SIZE &&pmd_none (*pmd)) + pmd_entry =READ_ONCE (*pmd); +if (sz !=PMD_SIZE &&pmd_none (pmd_entry))return NULL ;/* hugepage or swap? */ -if (pmd_huge (*pmd) || !pmd_present (*pmd)) +if (pmd_huge (pmd_entry) || !pmd_present (pmd_entry))return (pte_t *)pmd;return NULL ;
Greg Kroah-Hartman
maintainerPATCH 92/131 mm/ksm: fix NULL pointer dereference when KSM zero page is enabled
In reply to Greg Kroah-HartmanFrom: Muchun Song <[email protected]>
commit 56df70a63ed5d989c1d36deee94cae14342be6e9 upstream.
find_mergeable_vma() can return NULL. In this case, it leads to a crash when we access vm_mm(its offset is 0x40) later in write_protect_page. And this case did happen on our server. The following call trace is captured in kernel 4.19 with the following patch applied and KSM zero page enabled on our server.
commit e86c59b1b12d ("mm/ksm: improve deduplication of zero pages with colouring")
So add a vma check to fix it.
BUG: unable to handle kernel NULL pointer dereference at 0000000000000040
Oops: 0000 [#1] SMP NOPTI
CPU: 9 PID: 510 Comm: ksmd Kdump: loaded Tainted: G OE 4.19.36.bsk.9-amd64 #4.19.36.bsk.9
RIP: try_to_merge_one_page+0xc7/0x760
Code: 24 58 65 48 33 34 25 28 00 00 00 89 e8 0f 85 a3 06 00 00 48 83 c4
60 5b 5d 41 5c 41 5d 41 5e 41 5f c3 48 8b 46 08 a8 01 75 b8 <49>
8b 44 24 40 4c 8d 7c 24 20 b9 07 00 00 00 4c 89 e6 4c 89 ff 48
RSP: 0018:ffffadbdd9fffdb0 EFLAGS: 00010246
RAX: ffffda83ffd4be08 RBX: ffffda83ffd4be40 RCX: 0000002c6e800000
RDX: 0000000000000000 RSI: ffffda83ffd4be40 RDI: 0000000000000000
RBP: ffffa11939f02ec0 R08: 0000000094e1a447 R09: 00000000abe76577
R10: 0000000000000962 R11: 0000000000004e6a R12: 0000000000000000
R13: ffffda83b1e06380 R14: ffffa18f31f072c0 R15: ffffda83ffd4be40
FS: 0000000000000000(0000) GS:ffffa0da43b80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000040 CR3: 0000002c77c0a003 CR4: 00000000007626e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
ksm_scan_thread+0x115e/0x1960
kthread+0xf5/0x130
ret_from_fork+0x1f/0x30--- mm/ksm.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
mm/ksm.c +10 -2
@@ -2106,8 +2106,16 @@ static void cmp_and_merge_page(struct padown_read (&mm->mmap_sem); vma =find_mergeable_vma (mm, rmap_item->address); - err =try_to_merge_one_page (vma, page, -ZERO_PAGE (rmap_item->address)); +if (vma) { + err =try_to_merge_one_page (vma, page, +ZERO_PAGE (rmap_item->address)); + }else { +/* +* If the vma is out of date, we do not need to +* continue. +*/ + err =0 ; + }up_read (&mm->mmap_sem);/* * In case of failure, the page was not really empty, so we
Greg Kroah-Hartman
maintainerPATCH 93/131 tools/vm: fix cross-compile build
In reply to Greg Kroah-HartmanFrom: Lucas Stach <[email protected]>
commit cf01699ee220c38099eb3e43ce3d10690c8b7060 upstream.
Commit 7ed1c1901fe5 ("tools: fix cross-compile var clobbering") moved the setup of the CC variable to tools/scripts/Makefile.include to make the behavior consistent across all the tools Makefiles.
As the vm tools missed the include we end up with the wrong CC in a cross-compiling evironment.
--- tools/vm/Makefile | 2 ++ 1 file changed, 2 insertions(+)
tools/vm/Makefile +2 -0
@@ -1,6 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 # Makefile for vm tools # +include ../scripts/Makefile.include + TARGETS=page-types slabinfo page_owner_sort LIB_DIR = ../lib/api
Greg Kroah-Hartman
maintainerPATCH 94/131 ALSA: usx2y: Fix potential NULL dereference
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
commit 7686e3485253635c529cdd5f416fc640abaf076f upstream.
The error handling code in usX2Y_rate_set() may hit a potential NULL dereference when an error occurs before allocating all us->urb[]. Add a proper NULL check for fixing the corner case.
--- sound/usb/usx2y/usbusx2yaudio.c | 2 ++ 1 file changed, 2 insertions(+)
sound/usb/usx2y/usbusx2yaudio.c +2 -0
@@ -695,6 +695,8 @@ static int usX2Y_rate_set(struct usX2Yde us->submitted =2 *NOOF_SETRATE_URBS ;for (i =0 ; i <NOOF_SETRATE_URBS ; ++i) {struct urb *urb = us->urb[i]; +if (!urb) +continue ;if (urb->status) {if (!err) err = -ENODEV ;
Greg Kroah-Hartman
maintainerPATCH 95/131 ALSA: hda/realtek - Fix unexpected init_amp override
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
commit 67791202c5e069cf2ba51db0718d56c634709e78 upstream.
The commit 1c76aa5fb48d ("ALSA: hda/realtek - Allow skipping spec->init_amp detection") changed the way to assign spec->init_amp field that specifies the way to initialize the amp. Along with the change, the commit also replaced a few fixups that set spec->init_amp in HDA_FIXUP_ACT_PROBE with HDA_FIXUP_ACT_PRE_PROBE. This was rather aligning to the other fixups, and not supposed to change the actual behavior.
However, this change turned out to cause a regression on FSC S7020, which hit exactly the above. The reason was that there is still one place that overrides spec->init_amp after HDA_FIXUP_ACT_PRE_PROBE call, namely in alc_ssid_check().
This patch fixes the regression by adding the proper spec->init_amp override check, i.e. verifying whether it's still ALC_INIT_UNDEFINED.
--- sound/pci/hda/patch_realtek.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
sound/pci/hda/patch_realtek.c +5 -3
@@ -801,9 +801,11 @@ static void alc_ssid_check(struct hda_co {if (!alc_subsystem_id (codec, ports)) {struct alc_spec *spec = codec->spec; -codec_dbg (codec, -"realtek: Enable default setup for auto mode as fallback\n" ); - spec->init_amp =ALC_INIT_DEFAULT ; +if (spec->init_amp ==ALC_INIT_UNDEFINED ) { +codec_dbg (codec, +"realtek: Enable default setup for auto mode as fallback\n" ); + spec->init_amp =ALC_INIT_DEFAULT ; + } } }
Greg Kroah-Hartman
maintainerPATCH 96/131 ALSA: hda/realtek - Add new codec supported for ALC245
In reply to Greg Kroah-HartmanFrom: Kailang Yang <[email protected]>
commit 7fbdcd8301a84c09cebfa64f1317a6dafeec9188 upstream.
Enable new codec supported for ALC245.
--- sound/pci/hda/patch_realtek.c | 3 +++ 1 file changed, 3 insertions(+)
sound/pci/hda/patch_realtek.c +3 -0
@@ -380,6 +380,7 @@ static void alc_fill_eapd_coef(struct hdcase 0x10ec0233 :case 0x10ec0235 :case 0x10ec0236 : +case 0x10ec0245 :case 0x10ec0255 :case 0x10ec0256 :case 0x10ec0257 :
@@ -7792,6 +7793,7 @@ static int patch_alc269(struct hda_codec spec->gen.mixer_nid =0 ;break ;case 0x10ec0215 : +case 0x10ec0245 :case 0x10ec0285 :case 0x10ec0289 : spec->codec_variant =ALC269_TYPE_ALC215 ;
@@ -8913,6 +8915,7 @@ static const struct hda_device_id snd_hdHDA_CODEC_ENTRY (0x10ec0234 ,"ALC234" , patch_alc269),HDA_CODEC_ENTRY (0x10ec0235 ,"ALC233" , patch_alc269),HDA_CODEC_ENTRY (0x10ec0236 ,"ALC236" , patch_alc269), +HDA_CODEC_ENTRY (0x10ec0245 ,"ALC245" , patch_alc269),HDA_CODEC_ENTRY (0x10ec0255 ,"ALC255" , patch_alc269),HDA_CODEC_ENTRY (0x10ec0256 ,"ALC256" , patch_alc269), HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
Greg Kroah-Hartman
maintainerPATCH 97/131 ALSA: usb-audio: Fix usb audio refcnt leak when getting spdif
In reply to Greg Kroah-HartmanFrom: Xiyu Yang <[email protected]>
commit 59e1947ca09ebd1cae147c08c7c41f3141233c84 upstream.
snd_microii_spdif_default_get() invokes snd_usb_lock_shutdown(), which increases the refcount of the snd_usb_audio object "chip".
When snd_microii_spdif_default_get() returns, local variable "chip" becomes invalid, so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in several exception handling paths of snd_microii_spdif_default_get(). When those error scenarios occur such as usb_ifnum_to_if() returns NULL, the function forgets to decrease the refcnt increased by snd_usb_lock_shutdown(), causing a refcnt leak.
Fix this issue by jumping to "end" label when those error scenarios occur.
--- sound/usb/mixer_quirks.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
sound/usb/mixer_quirks.c +8 -4
@@ -1519,11 +1519,15 @@ static int snd_microii_spdif_default_get/* use known values for that card: interface#1 altsetting#1 */ iface =usb_ifnum_to_if (chip->dev,1 ); -if (!iface || iface->num_altsetting <2 ) -return -EINVAL ; +if (!iface || iface->num_altsetting <2 ) { + err = -EINVAL ; + goto end; + } alts = &iface->altsetting[1 ]; -if (get_iface_desc (alts)->bNumEndpoints <1 ) -return -EINVAL ; +if (get_iface_desc (alts)->bNumEndpoints <1 ) { + err = -EINVAL ; + goto end; + } ep =get_endpoint (alts,0 )->bEndpointAddress; err = snd_usb_ctl_msg(chip->dev,
Greg Kroah-Hartman
maintainerPATCH 98/131 ALSA: usb-audio: Filter out unsupported sample rates on Focusrite devices
In reply to Greg Kroah-HartmanFrom: Alexander Tsoy <[email protected]>
commit 1c826792586f526a5a5cd21d55aad388f5bb0b23 upstream.
Many Focusrite devices supports a limited set of sample rates per altsetting. These includes audio interfaces with ADAT ports:
- Scarlett 18i6, 18i8 1st gen, 18i20 1st gen;
- Scarlett 18i8 2nd gen, 18i20 2nd gen;
- Scarlett 18i8 3rd gen, 18i20 3rd gen;
- Clarett 2Pre USB, 4Pre USB, 8Pre USB.
Maximum rate is exposed in the last 4 bytes of Format Type descriptor which has a non-standard bLength = 10.
--- sound/usb/format.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+)
sound/usb/format.c +52 -0
@@ -238,6 +238,52 @@ static int parse_audio_format_rates_v1(s }/* +* Many Focusrite devices supports a limited set of sampling rates per +* altsetting. Maximum rate is exposed in the last 4 bytes of Format Type +* descriptor which has a non-standard bLength = 10. +*/ +static bool focusrite_valid_sample_rate (struct snd_usb_audio *chip, +struct audioformat *fp, +unsigned int rate) +{ +struct usb_interface *iface; +struct usb_host_interface *alts; +unsigned char *fmt; +unsigned int max_rate; + + iface =usb_ifnum_to_if (chip->dev, fp->iface); +if (!iface) +return true; + + alts = &iface->altsetting[fp->altset_idx]; + fmt =snd_usb_find_csint_desc (alts->extra, alts->extralen, +NULL ,UAC_FORMAT_TYPE ); +if (!fmt) +return true; + +if (fmt[0 ] ==10 ) {/* bLength */ + max_rate =combine_quad (&fmt[6 ]); + +/* Validate max rate */ +if (max_rate !=48000 && + max_rate !=96000 && + max_rate !=192000 && + max_rate !=384000 ) { + +usb_audio_info (chip, +"%u:%d : unexpected max rate: %u\n" , + fp->iface, fp->altsetting, max_rate); + +return true; + } + +return rate <= max_rate; + } + +return true; +} + +/* * Helper function to walk the array of sample rate triplets reported by * the device. The problem is that we need to parse whole array first to * get to know how many sample rates we have to expect.
@@ -273,6 +319,11 @@ static int parse_uac2_sample_rate_range( }for (rate = min; rate <= max; rate += res) { +/* Filter out invalid rates on Focusrite devices */ +if (USB_ID_VENDOR (chip->usb_id) ==0x1235 && + !focusrite_valid_sample_rate (chip, fp, rate)) + goto skip_rate; +if (fp->rate_table) fp->rate_table[nr_rates] = rate;if (!fp->rate_min || rate < fp->rate_min)
@@ -287,6 +338,7 @@ static int parse_uac2_sample_rate_range(break ; } +skip_rate:/* avoid endless loop */ if (res ==0 )break ;
Greg Kroah-Hartman
maintainerPATCH 99/131 tpm/tpm_tis: Free IRQ if probing fails
In reply to Greg Kroah-HartmanFrom: Jarkko Sakkinen <[email protected]>
commit b160c94be5d2816b62c8ac338605668304242959 upstream.
Call disable_interrupts() if we have to revert to polling in order not to unnecessarily reserve the IRQ for the life-cycle of the driver.
--- drivers/char/tpm/tpm_tis_core.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/char/tpm/tpm_tis_core.c +7 -1
@@ -437,6 +437,9 @@ static void disable_interrupts(struct tpu32 intmask;int rc; +if (priv->irq ==0 ) +return ; + rc =tpm_tis_read32 (priv,TPM_INT_ENABLE (priv->locality), &intmask);if (rc <0 ) intmask =0 ;
@@ -984,9 +987,12 @@ int tpm_tis_core_init(struct device *devif (irq) {tpm_tis_probe_irq_single (chip, intmask,IRQF_SHARED , irq); -if (!(chip->flags &TPM_CHIP_FLAG_IRQ )) +if (!(chip->flags &TPM_CHIP_FLAG_IRQ )) {dev_err (&chip->dev,FW_BUG "TPM interrupt not working, polling instead\n" ); + +disable_interrupts (chip); + } }else {tpm_tis_probe_irq (chip, intmask); }
Greg Kroah-Hartman
maintainerPATCH 100/131 tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()
In reply to Greg Kroah-HartmanFrom: George Wilson <[email protected]>
commit eba5cf3dcb844c82f54d4a857e124824e252206d upstream.
tpm_ibmvtpm_send() can fail during PowerVM Live Partition Mobility resume with an H_CLOSED return from ibmvtpm_send_crq(). The PAPR says, 'The "partner partition suspended" transport event disables the associated CRQ such that any H_SEND_CRQ hcall() to the associated CRQ returns H_Closed until the CRQ has been explicitly enabled using the H_ENABLE_CRQ hcall.' This patch adds a check in tpm_ibmvtpm_send() for an H_CLOSED return from ibmvtpm_send_crq() and in that case calls tpm_ibmvtpm_resume() and retries the ibmvtpm_send_crq() once.
--- drivers/char/tpm/tpm_ibmvtpm.c | 136 ++++++++++++++++++++++------------------- 1 file changed, 73 insertions(+), 63 deletions(-)
drivers/char/tpm/tpm_ibmvtpm.c +73 -63
@@ -1,5 +1,5 @@/* -* Copyright (C) 2012 IBM Corporation +* Copyright (C) 2012-2020 IBM Corporation * * Author: Ashley Lai <[email protected]> *
@@ -141,6 +141,64 @@ static int tpm_ibmvtpm_recv(struct tpm_c }/** +* ibmvtpm_crq_send_init - Send a CRQ initialize message +* @ibmvtpm: vtpm device struct +* +* Return: +* 0 on success. +* Non-zero on failure. +*/ +static int ibmvtpm_crq_send_init (struct ibmvtpm_dev *ibmvtpm) +{ +int rc; + + rc =ibmvtpm_send_crq_word (ibmvtpm->vdev,INIT_CRQ_CMD ); +if (rc !=H_SUCCESS ) +dev_err (ibmvtpm->dev, +"%s failed rc=%d\n" , __func__, rc); + +return rc; +} + +/** +* tpm_ibmvtpm_resume - Resume from suspend +* +* @dev: device struct +* +* Return: Always 0. +*/ +static int tpm_ibmvtpm_resume (struct device *dev) +{ +struct tpm_chip *chip =dev_get_drvdata (dev); +struct ibmvtpm_dev *ibmvtpm =dev_get_drvdata (&chip->dev); +int rc =0 ; + +do { +if (rc) +msleep (100 ); + rc =plpar_hcall_norets (H_ENABLE_CRQ , + ibmvtpm->vdev->unit_address); + }while (rc ==H_IN_PROGRESS || rc ==H_BUSY ||H_IS_LONG_BUSY (rc)); + +if (rc) { +dev_err (dev,"Error enabling ibmvtpm rc=%d\n" , rc); +return rc; + } + + rc =vio_enable_interrupts (ibmvtpm->vdev); +if (rc) { +dev_err (dev,"Error vio_enable_interrupts rc=%d\n" , rc); +return rc; + } + + rc =ibmvtpm_crq_send_init (ibmvtpm); +if (rc) +dev_err (dev,"Error send_init rc=%d\n" , rc); + +return rc; +} + +/** * tpm_ibmvtpm_send() - Send a TPM command * @chip: tpm chip struct * @buf: buffer contains data to send
@@ -153,6 +211,7 @@ static int tpm_ibmvtpm_recv(struct tpm_cstatic int tpm_ibmvtpm_send (struct tpm_chip *chip,u8 *buf,size_t count) {struct ibmvtpm_dev *ibmvtpm =dev_get_drvdata (&chip->dev); +bool retry = true;int rc, sig;if (!ibmvtpm->rtce_buf) {
@@ -186,18 +245,27 @@ static int tpm_ibmvtpm_send(struct tpm_c*/ ibmvtpm->tpm_processing_cmd = true; +again: rc =ibmvtpm_send_crq (ibmvtpm->vdev,IBMVTPM_VALID_CMD ,VTPM_TPM_COMMAND , count, ibmvtpm->rtce_dma_handle);if (rc !=H_SUCCESS ) { +/* +* H_CLOSED can be returned after LPM resume. Call +* tpm_ibmvtpm_resume() to re-enable the CRQ then retry +* ibmvtpm_send_crq() once before failing. +*/ +if (rc ==H_CLOSED && retry) { +tpm_ibmvtpm_resume (ibmvtpm->dev); + retry = false; + goto again; + }dev_err (ibmvtpm->dev,"tpm_ibmvtpm_send failed rc=%d\n" , rc); - rc =0 ; ibmvtpm->tpm_processing_cmd = false; - }else - rc =0 ; + }spin_unlock (&ibmvtpm->rtce_lock); -return rc; +return 0 ; }static void tpm_ibmvtpm_cancel (struct tpm_chip *chip)
@@ -276,26 +344,6 @@ static int ibmvtpm_crq_send_init_complet }/** -* ibmvtpm_crq_send_init - Send a CRQ initialize message -* @ibmvtpm: vtpm device struct -* -* Return: -* 0 on success. -* Non-zero on failure. -*/ -static int ibmvtpm_crq_send_init (struct ibmvtpm_dev *ibmvtpm) -{ -int rc; - - rc =ibmvtpm_send_crq_word (ibmvtpm->vdev,INIT_CRQ_CMD ); -if (rc !=H_SUCCESS ) -dev_err (ibmvtpm->dev, -"ibmvtpm_crq_send_init failed rc=%d\n" , rc); - -return rc; -} - -/** * tpm_ibmvtpm_remove - ibm vtpm remove entry point * @vdev: vio device struct *
@@ -407,44 +455,6 @@ static int ibmvtpm_reset_crq(struct ibmv ibmvtpm->crq_dma_handle, CRQ_RES_BUF_SIZE); } -/** -* tpm_ibmvtpm_resume - Resume from suspend -* -* @dev: device struct -* -* Return: Always 0. -*/ -static int tpm_ibmvtpm_resume (struct device *dev) -{ -struct tpm_chip *chip =dev_get_drvdata (dev); -struct ibmvtpm_dev *ibmvtpm =dev_get_drvdata (&chip->dev); -int rc =0 ; - -do { -if (rc) -msleep (100 ); - rc =plpar_hcall_norets (H_ENABLE_CRQ , - ibmvtpm->vdev->unit_address); - }while (rc ==H_IN_PROGRESS || rc ==H_BUSY ||H_IS_LONG_BUSY (rc)); - -if (rc) { -dev_err (dev,"Error enabling ibmvtpm rc=%d\n" , rc); -return rc; - } - - rc =vio_enable_interrupts (ibmvtpm->vdev); -if (rc) { -dev_err (dev,"Error vio_enable_interrupts rc=%d\n" , rc); -return rc; - } - - rc =ibmvtpm_crq_send_init (ibmvtpm); -if (rc) -dev_err (dev,"Error send_init rc=%d\n" , rc); - -return rc; -} -static bool tpm_ibmvtpm_req_canceled (struct tpm_chip *chip,u8 status) {return (status ==0 );
Greg Kroah-Hartman
maintainerPATCH 101/131 KVM: s390: Return last valid slot if approx index is out-of-bounds
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
commit 97daa028f3f621adff2c4f7b15fe0874e5b5bd6c upstream.
Return the index of the last valid slot from gfn_to_memslot_approx() if its binary search loop yielded an out-of-bounds index. The index can be out-of-bounds if the specified gfn is less than the base of the lowest memslot (which is also the last valid memslot).
Note, the sole caller, kvm_s390_get_cmma(), ensures used_slots is non-zero.
Message-Id: <[email protected]>
--- arch/s390/kvm/kvm-s390.c | 3 +++ 1 file changed, 3 insertions(+)
arch/s390/kvm/kvm-s390.c +3 -0
@@ -1666,6 +1666,9 @@ static int gfn_to_memslot_approx(struct start = slot +1 ; } +if (start >= slots->used_slots) +return slots->used_slots -1 ; +if (gfn >= memslots[start].base_gfn && gfn < memslots[start].base_gfn + memslots[start].npages) {atomic_set (&slots->lru_slot, start);
Greg Kroah-Hartman
maintainerPATCH 102/131 KVM: Check validity of resolved slot when searching memslots
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
commit b6467ab142b708dd076f6186ca274f14af379c72 upstream.
Check that the resolved slot (somewhat confusingly named 'start') is a valid/allocated slot before doing the final comparison to see if the specified gfn resides in the associated slot. The resolved slot can be invalid if the binary search loop terminated because the search index was incremented beyond the number of used slots.
This bug has existed since the binary search algorithm was introduced, but went unnoticed because KVM statically allocated memory for the max number of slots, i.e. the access would only be truly out-of-bounds if all possible slots were allocated and the specified gfn was less than the base of the lowest memslot. Commit 36947254e5f98 ("KVM: Dynamically size memslot array based on number of used slots") eliminated the "all possible slots allocated" condition and made the bug embarrasingly easy to hit.
Message-Id: <[email protected]>
--- include/linux/kvm_host.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/kvm_host.h +1 -1
@@ -999,7 +999,7 @@ search_memslots(struct kvm_memslots *slo start = slot +1 ; } -if (gfn >= memslots[start].base_gfn && +if (start < slots->used_slots && gfn >= memslots[start].base_gfn && gfn < memslots[start].base_gfn + memslots[start].npages) {atomic_set (&slots->lru_slot, start);return &memslots[start];
Greg Kroah-Hartman
maintainerPATCH 103/131 KVM: VMX: Enable machine check support for 32bit targets
In reply to Greg Kroah-HartmanFrom: Uros Bizjak <[email protected]>
commit fb56baae5ea509e63c2a068d66a4d8ea91969fca upstream.
There is no reason to limit the use of do_machine_check to 64bit targets. MCE handling works for both target familes.
Message-Id: <[email protected]>
--- arch/x86/kvm/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/vmx.c +1 -1
@@ -7015,7 +7015,7 @@ static int handle_rmode_exception(struct*/ static void kvm_machine_check (void ) { -#if defined(CONFIG_X86_MCE ) && defined(CONFIG_X86_64 ) +#if defined(CONFIG_X86_MCE )struct pt_regs regs = { .cs =3 ,/* Fake ring 3 no matter what the guest ran on */ .flags = X86_EFLAGS_IF,
Greg Kroah-Hartman
maintainerPATCH 104/131 tty: hvc: fix buffer overflow during hvc_alloc().
In reply to Greg Kroah-HartmanFrom: Andrew Melnychenko <[email protected]>
commit 9a9fc42b86c06120744555fea43fdcabe297c656 upstream.
If there is a lot(more then 16) of virtio-console devices or virtio_console module is reloaded
- buffers 'vtermnos' and 'cons_ops' are overflowed.
In older kernels it overruns spinlock which leads to kernel freezing:
https://bugzilla.redhat.com/show_bug.cgi?id=1786239
To reproduce the issue, you can try simple script that loads/unloads module. Something like this:
while [ 1 ]
do
modprobe virtio_console
sleep 2
modprobe -r virtio_console
sleep 2
done
Description of problem:
Guest get 'Call Trace' when loading module "virtio_console" and unloading it frequently - clearly reproduced on kernel-4.18.0:
[ 81.498208] ------------[ cut here ]------------ [ 81.499263] pvqspinlock: lock 0xffffffff92080020 has corrupted value 0xc0774ca0! [ 81.501000] WARNING: CPU: 0 PID: 785 at kernel/locking/qspinlock_paravirt.h:500 __pv_queued_spin_unlock_slowpath+0xc0/0xd0 [ 81.503173] Modules linked in: virtio_console fuse xt_CHECKSUM ipt_MASQUERADE xt_conntrack ipt_REJECT nft_counter nf_nat_tftp nft_objref nf_conntrack_tftp tun bridge stp llc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_tables_set nft_chain_nat_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 nft_chain_route_ipv6 nft_chain_nat_ipv4 nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack nft_chain_route_ipv4 ip6_tables nft_compat ip_set nf_tables nfnetlink sunrpc bochs_drm drm_vram_helper ttm drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm i2c_piix4 pcspkr crct10dif_pclmul crc32_pclmul joydev ghash_clmulni_intel ip_tables xfs libcrc32c sd_mod sg ata_generic ata_piix virtio_net libata crc32c_intel net_failover failover serio_raw virtio_scsi dm_mirror dm_region_hash dm_log dm_mod [last unloaded: virtio_console] [ 81.517019] CPU: 0 PID: 785 Comm: kworker/0:2 Kdump: loaded Not tainted 4.18.0-167.el8.x86_64 #1 [ 81.518639] Hardware name: Red Hat KVM, BIOS 1.12.0-5.scrmod+el8.2.0+5159+d8aa4d83 04/01/2014 [ 81.520205] Workqueue: events control_work_handler [virtio_console] [ 81.521354] RIP: 0010:__pv_queued_spin_unlock_slowpath+0xc0/0xd0 [ 81.522450] Code: 07 00 48 63 7a 10 e8 bf 64 f5 ff 66 90 c3 8b 05 e6 cf d6 01 85 c0 74 01 c3 8b 17 48 89 fe 48 c7 c7 38 4b 29 91 e8 3a 6c fa ff <0f> 0b c3 0f 0b 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 48 [ 81.525830] RSP: 0018:ffffb51a01ffbd70 EFLAGS: 00010282 [ 81.526798] RAX: 0000000000000000 RBX: 0000000000000010 RCX: 0000000000000000 [ 81.528110] RDX: ffff9e66f1826480 RSI: ffff9e66f1816a08 RDI: ffff9e66f1816a08 [ 81.529437] RBP: ffffffff9153ff10 R08: 000000000000026c R09: 0000000000000053 [ 81.530732] R10: 0000000000000000 R11: ffffb51a01ffbc18 R12: ffff9e66cd682200 [ 81.532133] R13: ffffffff9153ff10 R14: ffff9e6685569500 R15: ffff9e66cd682000 [ 81.533442] FS: 0000000000000000(0000) GS:ffff9e66f1800000(0000) knlGS:0000000000000000 [ 81.534914] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 81.535971] CR2: 00005624c55b14d0 CR3: 00000003a023c000 CR4: 00000000003406f0 [ 81.537283] Call Trace: [ 81.537763] __raw_callee_save___pv_queued_spin_unlock_slowpath+0x11/0x20 [ 81.539011] .slowpath+0x9/0xe [ 81.539585] hvc_alloc+0x25e/0x300 [ 81.540237] init_port_console+0x28/0x100 [virtio_console] [ 81.541251] handle_control_message.constprop.27+0x1c4/0x310 [virtio_console] [ 81.542546] control_work_handler+0x70/0x10c [virtio_console] [ 81.543601] process_one_work+0x1a7/0x3b0 [ 81.544356] worker_thread+0x30/0x390 [ 81.545025] ? create_worker+0x1a0/0x1a0 [ 81.545749] kthread+0x112/0x130 [ 81.546358] ? kthread_flush_work_fn+0x10/0x10 [ 81.547183] ret_from_fork+0x22/0x40 [ 81.547842] ---[ end trace aa97649bd16c8655 ]--- [ 83.546539] general protection fault: 0000 [#1] SMP NOPTI [ 83.547422] CPU: 5 PID: 3225 Comm: modprobe Kdump: loaded Tainted: G W --------- - - 4.18.0-167.el8.x86_64 #1 [ 83.549191] Hardware name: Red Hat KVM, BIOS 1.12.0-5.scrmod+el8.2.0+5159+d8aa4d83 04/01/2014 [ 83.550544] RIP: 0010:__pv_queued_spin_lock_slowpath+0x19a/0x2a0 [ 83.551504] Code: c4 c1 ea 12 41 be 01 00 00 00 4c 8d 6d 14 41 83 e4 03 8d 42 ff 49 c1 e4 05 48 98 49 81 c4 40 a5 02 00 4c 03 24 c5 60 48 34 91 <49> 89 2c 24 b8 00 80 00 00 eb 15 84 c0 75 0a 41 0f b6 54 24 14 84 [ 83.554449] RSP: 0018:ffffb51a0323fdb0 EFLAGS: 00010202 [ 83.555290] RAX: 000000000000301c RBX: ffffffff92080020 RCX: 0000000000000001 [ 83.556426] RDX: 000000000000301d RSI: 0000000000000000 RDI: 0000000000000000 [ 83.557556] RBP: ffff9e66f196a540 R08: 000000000000028a R09: ffff9e66d2757788 [ 83.558688] R10: 0000000000000000 R11: 0000000000000000 R12: 646e61725f770b07 [ 83.559821] R13: ffff9e66f196a554 R14: 0000000000000001 R15: 0000000000180000 [ 83.560958] FS: 00007fd5032e8740(0000) GS:ffff9e66f1940000(0000) knlGS:0000000000000000 [ 83.562233] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 83.563149] CR2: 00007fd5022b0da0 CR3: 000000038c334000 CR4: 00000000003406e0
--- drivers/tty/hvc/hvc_console.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-)
drivers/tty/hvc/hvc_console.c +14 -9
@@ -302,10 +302,6 @@ int hvc_instantiate(uint32_t vtermno, in vtermnos[index] = vtermno; cons_ops[index] = ops; -/* reserve all indices up to and including this index */ -if (last_hvc < index) - last_hvc = index; -/* check if we need to re-register the kernel console */ hvc_check_console (index);
@@ -960,13 +956,22 @@ struct hvc_struct *hvc_alloc(uint32_t vt cons_ops[i] == hp->ops)break ; -/* no matching slot, just use a counter */ -if (i >=MAX_NR_HVC_CONSOLES ) - i = ++last_hvc; +if (i >=MAX_NR_HVC_CONSOLES ) { + +/* find 'empty' slot for console */ +for (i =0 ; i <MAX_NR_HVC_CONSOLES && vtermnos[i] !=-1 ; i++) { + } + +/* no matching slot, just use a counter */ +if (i ==MAX_NR_HVC_CONSOLES ) + i = ++last_hvc +MAX_NR_HVC_CONSOLES ; + } hp->index = i; - cons_ops[i] = ops; - vtermnos[i] = vtermno; +if (i <MAX_NR_HVC_CONSOLES ) { + cons_ops[i] = ops; + vtermnos[i] = vtermno; + }list_add_tail (&(hp->next), &hvc_structs);mutex_unlock (&hvc_structs_mutex);
Greg Kroah-Hartman
maintainerPATCH 105/131 tty: rocket, avoid OOB access
In reply to Greg Kroah-HartmanFrom: Jiri Slaby <[email protected]>
commit 7127d24372bf23675a36edc64d092dc7fd92ebe8 upstream.
init_r_port can access pc104 array out of bounds. pc104 is a 2D array defined to have 4 members. Each member has 8 submembers.
* we can have more than 4 (PCI) boards, i.e. [board] can be OOB
* line is not modulo-ed by anything, so the first line on the second board can be 4, on the 3rd 12 or alike (depending on previously registered boards). It's zero only on the first line of the first board. So even [line] can be OOB, quite soon (with the 2nd registered board already).
This code is broken for ages, so just avoid the OOB accesses and don't try to fix it as we would need to find out the correct line number. Use the default: RS232, if we are out.
Generally, if anyone needs to set the interface types, a module parameter is past the last thing that should be used for this purpose. The parameters' description says it's for ISA cards anyway.
--- drivers/tty/rocket.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)
drivers/tty/rocket.c +14 -11
@@ -632,18 +632,21 @@ init_r_port(int board, int aiop, int chatty_port_init (&info->port); info->port.ops = &rocket_port_ops; info->flags &= ~ROCKET_MODE_MASK ; -switch (pc104[board][line]) { -case 422 : - info->flags |=ROCKET_MODE_RS422 ; -break ; -case 485 : - info->flags |=ROCKET_MODE_RS485 ; -break ; -case 232 : -default : +if (board <ARRAY_SIZE (pc104) && line <ARRAY_SIZE (pc104_1)) +switch (pc104[board][line]) { +case 422 : + info->flags |=ROCKET_MODE_RS422 ; +break ; +case 485 : + info->flags |=ROCKET_MODE_RS485 ; +break ; +case 232 : +default : + info->flags |=ROCKET_MODE_RS232 ; +break ; + } +else info->flags |=ROCKET_MODE_RS232 ; -break ; - } info->intmask =RXF_TRIG |TXFIFO_MT |SRC_INT |DELTA_CD |DELTA_CTS |DELTA_DSR ;if (sInitChan (ctlp, &info->channel, aiop, chan) ==0 ) {
Greg Kroah-Hartman
maintainerPATCH 106/131 usb-storage: Add unusual_devs entry for JMicron JMS566
In reply to Greg Kroah-HartmanFrom: Alan Stern <[email protected]>
commit 94f9c8c3c404ee1f7aaff81ad4f24aec4e34a78b upstream.
Cyril Roelandt reports that his JMicron JMS566 USB-SATA bridge fails to handle WRITE commands with the FUA bit set, even though it claims to support FUA. (Oddly enough, a later version of the same bridge, version 2.03 as opposed to 1.14, doesn't claim to support FUA. Also oddly, the bridge _does_ support FUA when using the UAS transport instead of the Bulk-Only transport -- but this device was blacklisted for uas in commit bc3bdb12bbb3 ("usb-storage: Disable UAS on JMicron SATA enclosure") for apparently unrelated reasons.)
This patch adds a usb-storage unusual_devs entry with the BROKEN_FUA flag. This allows the bridge to work properly with usb-storage.
--- drivers/usb/storage/unusual_devs.h | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_devs.h +7 -0
@@ -2323,6 +2323,13 @@ UNUSUAL_DEV( 0x3340, 0xffff, 0x0000, 0x USB_SC_DEVICE,USB_PR_DEVICE,NULL, US_FL_MAX_SECTORS_64 ), +/* Reported by Cyril Roelandt <[email protected]> */ +UNUSUAL_DEV (0x357d ,0x7788 ,0x0114 ,0x0114 , +"JMicron" , +"USB to ATA/ATAPI Bridge" , +USB_SC_DEVICE ,USB_PR_DEVICE ,NULL , +US_FL_BROKEN_FUA ), +/* Reported by Andrey Rahmatullin <[email protected]> */ UNUSUAL_DEV( 0x4102, 0x1020, 0x0100, 0x0100, "iRiver",
Greg Kroah-Hartman
maintainerPATCH 107/131 audit: check the length of userspace generated audit records
In reply to Greg Kroah-HartmanFrom: Paul Moore <[email protected]>
commit 763dafc520add02a1f4639b500c509acc0ea8e5b upstream.
Commit 756125289285 ("audit: always check the netlink payload length in audit_receive_msg()") fixed a number of missing message length checks, but forgot to check the length of userspace generated audit records. The good news is that you need CAP_AUDIT_WRITE to submit userspace audit records, which is generally only given to trusted processes, so the impact should be limited.
--- kernel/audit.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/audit.c +3 -0
@@ -1331,6 +1331,9 @@ static int audit_receive_msg(struct sk_b case AUDIT_FIRST_USER_MSG2 ... AUDIT_LAST_USER_MSG2:if (!audit_enabled && msg_type !=AUDIT_USER_AVC )return 0 ; +/* exit early if there isn't at least one character to print */ +if (data_len <2 ) +return -EINVAL ; err =audit_filter (msg_type,AUDIT_FILTER_USER );if (err ==1 ) {/* match or error */
Greg Kroah-Hartman
maintainerPATCH 108/131 ASoC: dapm: fixup dapm kcontrol widget
In reply to Greg Kroah-HartmanFrom: Gyeongtaek Lee <[email protected]>
commit ebf1474745b4373fdde0fcf32d9d1f369b50b212 upstream.
snd_soc_dapm_kcontrol widget which is created by autodisable control should contain correct on_val, mask and shift because it is set when the widget is powered and changed value is applied on registers by following code in dapm_seq_run_coalesced().
mask |= w->mask << w->shift; if (w->power) value |= w->on_val << w->shift; else value |= w->off_val << w->shift;
Shift on the mask in dapm_kcontrol_data_alloc() is removed to prevent double shift.
And, on_val in dapm_kcontrol_set_value() is modified to get correct value in the dapm_seq_run_coalesced().
--- sound/soc/soc-dapm.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)
sound/soc/soc-dapm.c +17 -3
@@ -410,7 +410,7 @@ static int dapm_kcontrol_data_alloc(strumemset (&template,0 ,sizeof (template)); template.reg = e->reg; - template.mask = e->mask << e->shift_l; + template.mask = e->mask; template.shift = e->shift_l; template.off_val =snd_soc_enum_item_to_val (e,0 ); template.on_val = template.off_val;
@@ -536,8 +536,22 @@ static bool dapm_kcontrol_set_value(consif (data->value == value)return false; -if (data->widget) - data->widget->on_val = value; +if (data->widget) { +switch (dapm_kcontrol_get_wlist (kcontrol)->widgets[0 ]->id) { +case snd_soc_dapm_switch: +case snd_soc_dapm_mixer: +case snd_soc_dapm_mixer_named_ctl: + data->widget->on_val = value & data->widget->mask; +break ; +case snd_soc_dapm_demux: +case snd_soc_dapm_mux: + data->widget->on_val = value >> data->widget->shift; +break ; +default : + data->widget->on_val = value; +break ; + } + } data->value = value;
Greg Kroah-Hartman
maintainerPATCH 109/131 iwlwifi: pcie: actually release queue memory in TVQM
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
commit b98b33d5560a2d940f3b80f6768a6177bf3dfbc0 upstream.
The iwl_trans_pcie_dyn_txq_free() function only releases the frames that may be left on the queue by calling iwl_pcie_gen2_txq_unmap(), but doesn't actually free the DMA ring or byte-count tables for the queue. This leads to pretty large memory leaks (at least before my queue size improvements), in particular in monitor/sniffer mode on channel hopping since this happens on every channel change.
This was also now more evident after the move to a DMA pool for the byte count tables, showing messages such as
BUG iwlwifi:bc (...): Objects remaining in iwlwifi:bc on __kmem_cache_shutdown()
This fixes https://bugzilla.kernel.org/show_bug.cgi?id=206811.
--- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c +3 -0
@@ -1231,6 +1231,9 @@ void iwl_trans_pcie_dyn_txq_free(structiwl_pcie_gen2_txq_unmap (trans, queue); +iwl_pcie_gen2_txq_free_memory (trans, trans_pcie->txq[queue]); + trans_pcie->txq[queue] =NULL ; +IWL_DEBUG_TX_QUEUES (trans,"Deactivate queue %d\n" , queue); }
Greg Kroah-Hartman
maintainerPATCH 110/131 iwlwifi: mvm: beacon statistics shouldnt go backwards
In reply to Greg Kroah-HartmanFrom: Mordechay Goodstein <[email protected]>
commit 290d5e4951832e39d10f4184610dbf09038f8483 upstream.
We reset statistics also in case that we didn't reassoc so in this cases keep last beacon counter.
--- drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/wireless/intel/iwlwifi/mvm/rx.c +9 -0
@@ -587,6 +587,7 @@ void iwl_mvm_rx_rx_mpdu(struct iwl_mvm *struct iwl_mvm_stat_data {struct iwl_mvm *mvm; +__le32 flags;__le32 mac_id;u8 beacon_filter_average_energy;void *general;
@@ -630,6 +631,13 @@ static void iwl_mvm_stat_iterator(void * } } +/* make sure that beacon statistics don't go backwards with TCM +* request to clear statistics +*/ +if (le32_to_cpu (data->flags) &IWL_STATISTICS_REPLY_FLG_CLEAR ) + mvmvif->beacon_stats.accu_num_beacons += + mvmvif->beacon_stats.num_beacons; +if (mvmvif->id != id)return ;
@@ -790,6 +798,7 @@ void iwl_mvm_handle_rx_statistics(struct flags = stats->flag; } + data.flags = flags;iwl_mvm_rx_stats_check_trigger (mvm, pkt);
Greg Kroah-Hartman
maintainerPATCH 111/131 ARM: imx: provide v7_cpu_resume() only on ARM_CPU_SUSPEND=y
In reply to Greg Kroah-HartmanFrom: Ahmad Fatoum <[email protected]>
commit f1baca8896ae18e12c45552a4c4ae2086aa7e02c upstream.
512a928affd5 ("ARM: imx: build v7_cpu_resume() unconditionally") introduced an unintended linker error for i.MX6 configurations that have ARM_CPU_SUSPEND=n which can happen if neither CONFIG_PM, CONFIG_CPU_IDLE, nor ARM_PSCI_FW are selected.
Fix this by having v7_cpu_resume() compiled only when cpu_resume() it calls is available as well.
The C declaration for the function remains unguarded to avoid future code inadvertently using a stub and introducing a regression to the bug the original commit fixed.
--- arch/arm/mach-imx/Makefile | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/mach-imx/Makefile +2 -0
@@ -89,8 +89,10 @@ AFLAGS_suspend-imx6.o :=-Wa,-march=armv7 obj-$(CONFIG_SOC_IMX6) += suspend-imx6.o obj-$(CONFIG_SOC_IMX53) += suspend-imx53.o endif +ifeq ($(CONFIG_ARM_CPU_SUSPEND),y) AFLAGS_resume-imx6.o :=-Wa,-march=armv7-a obj-$(CONFIG_SOC_IMX6) += resume-imx6.o +endif obj-$(CONFIG_SOC_IMX6) += pm-imx6.o obj-$(CONFIG_SOC_IMX1) += mach-imx1.o
Greg Kroah-Hartman
maintainerPATCH 112/131 powerpc/setup_64: Set cache-line-size based on cache-block-size
In reply to Greg Kroah-HartmanFrom: Chris Packham <[email protected]>
commit 94c0b013c98583614e1ad911e8795ca36da34a85 upstream.
If {i,d}-cache-block-size is set and {i,d}-cache-line-size is not, use the block-size value for both. Per the devicetree spec cache-line-size is only needed if it differs from the block size.
Originally the code would fallback from block size to line size. An error message was printed if both properties were missing.
Later the code was refactored to use clearer names and logic but it inadvertently made line size a required property, meaning on systems without a line size property we fall back to the default from the cputable.
On powernv (OPAL) platforms, since the introduction of device tree CPU features (5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")), that has led to the wrong value being used, as the fallback value is incorrect for Power8/Power9 CPUs.
The incorrect values flow through to the VDSO and also to the sysconf values, SC_LEVEL1_ICACHE_LINESIZE etc.
--- arch/powerpc/kernel/setup_64.c | 2 ++ 1 file changed, 2 insertions(+)
arch/powerpc/kernel/setup_64.c +2 -0
@@ -518,6 +518,8 @@ static bool __init parse_cache_info(stru lsizep =of_get_property (np, propnames[3 ],NULL );if (bsizep ==NULL ) bsizep = lsizep; +if (lsizep ==NULL ) + lsizep = bsizep;if (lsizep !=NULL ) lsize =be32_to_cpu (*lsizep);if (bsizep !=NULL )
Greg Kroah-Hartman
maintainerPATCH 113/131 staging: comedi: dt2815: fix writing hi byte of analog output
In reply to Greg Kroah-HartmanFrom: Ian Abbott <[email protected]>
commit ed87d33ddbcd9a1c3b5ae87995da34e6f51a862c upstream.
The DT2815 analog output command is 16 bits wide, consisting of the 12-bit sample value in bits 15 to 4, the channel number in bits 3 to 1, and a voltage or current selector in bit 0. Both bytes of the 16-bit command need to be written in turn to a single 8-bit data register. However, the driver currently only writes the low 8-bits. It is broken and appears to have always been broken.
Electronic copies of the DT2815 User's Manual seem impossible to find online, but looking at the source code, a best guess for the sequence the driver intended to use to write the analog output command is as follows:
1. Wait for the status register to read 0x00.
2. Write the low byte of the command to the data register.
3. Wait for the status register to read 0x80.
4. Write the high byte of the command to the data register.
Step 4 is missing from the driver. Add step 4 to (hopefully) fix the driver.
Also add a "FIXME" comment about setting bit 0 of the low byte of the command. Supposedly, it is used to choose between voltage output and current output, but the current driver always sets it to 1.
--- drivers/staging/comedi/drivers/dt2815.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/staging/comedi/drivers/dt2815.c +3 -0
@@ -92,6 +92,7 @@ static int dt2815_ao_insn(struct comedi_int ret;for (i =0 ; i < insn->n; i++) { +/* FIXME: lo bit 0 chooses voltage output or current output */ lo = ((data[i] &0x0f ) <<4 ) | (chan <<1 ) |0x01 ; hi = (data[i] &0xff0 ) >>4 ;
@@ -105,6 +106,8 @@ static int dt2815_ao_insn(struct comedi_if (ret)return ret; +outb (hi, dev->iobase +DT2815_DATA ); + devpriv->ao_readback[chan] = data[i]; }return i;
Greg Kroah-Hartman
maintainerPATCH 114/131 staging: comedi: Fix comedi_device refcnt leak in comedi_open
In reply to Greg Kroah-HartmanFrom: Xiyu Yang <[email protected]>
commit 332e0e17ad49e084b7db670ef43b5eb59abd9e34 upstream.
comedi_open() invokes comedi_dev_get_from_minor(), which returns a reference of the COMEDI device to "dev" with increased refcount.
When comedi_open() returns, "dev" becomes invalid, so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in one exception handling path of comedi_open(). When "cfp" allocation is failed, the refcnt increased by comedi_dev_get_from_minor() is not decreased, causing a refcnt leak.
Fix this issue by calling comedi_dev_put() on this error path when "cfp" allocation is failed.
--- drivers/staging/comedi/comedi_fops.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/comedi/comedi_fops.c +3 -1
@@ -2594,8 +2594,10 @@ static int comedi_open(struct inode *ino } cfp =kzalloc (sizeof (*cfp),GFP_KERNEL ); -if (!cfp) +if (!cfp) { +comedi_dev_put (dev);return -ENOMEM ; + } cfp->dev = dev;
Greg Kroah-Hartman
maintainerPATCH 115/131 vt: dont hardcode the mem allocation upper bound
In reply to Greg Kroah-HartmanFrom: Nicolas Pitre <[email protected]>
commit 2717769e204e83e65b8819c5e2ef3e5b6639b270 upstream.
The code in vc_do_resize() bounds the memory allocation size to avoid exceeding MAX_ORDER down the kzalloc() call chain and generating a runtime warning triggerable from user space. However, not only is it unwise to use a literal value here, but MAX_ORDER may also be configurable based on CONFIG_FORCE_MAX_ZONEORDER.
Let's use KMALLOC_MAX_SIZE instead.
Note that prior commit bb1107f7c605 ("mm, slab: make sure that KMALLOC_MAX_SIZE will fit into MAX_ORDER") the KMALLOC_MAX_SIZE value could not be relied upon.
--- drivers/tty/vt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/vt/vt.c +1 -1
@@ -1209,7 +1209,7 @@ static int vc_do_resize(struct tty_strucif (new_cols == vc->vc_cols && new_rows == vc->vc_rows)return 0 ; -if (new_screen_size > (4 <<20 )) +if (new_screen_size >KMALLOC_MAX_SIZE )return -EINVAL ; newscreen =kzalloc (new_screen_size,GFP_USER );if (!newscreen)
Greg Kroah-Hartman
maintainerPATCH 116/131 vt: dont use kmalloc() for the unicode screen buffer
In reply to Greg Kroah-HartmanFrom: Nicolas Pitre <[email protected]>
commit 9a98e7a80f95378c9ee0c644705e3b5aa54745f1 upstream.
Even if the actual screen size is bounded in vc_do_resize(), the unicode buffer is still a little more than twice the size of the glyph buffer and may exceed MAX_ORDER down the kmalloc() path. This can be triggered from user space.
Since there is no point having a physically contiguous buffer here, let's avoid the above issue as well as reducing pressure on high order allocations by using vmalloc() instead.
--- drivers/tty/vt/vt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/tty/vt/vt.c +3 -2
@@ -81,6 +81,7 @@#include <linux/errno.h> #include <linux/kd.h> #include <linux/slab.h> +#include <linux/vmalloc.h> #include <linux/major.h> #include <linux/mm.h> #include <linux/console.h>
@@ -350,7 +351,7 @@ static struct uni_screen *vc_uniscr_allo/* allocate everything in one go */ memsize = cols * rows *sizeof (char32_t ); memsize += rows *sizeof (char32_t *); - p =kmalloc (memsize,GFP_KERNEL ); + p =vmalloc (memsize);if (!p)return NULL ;
@@ -366,7 +367,7 @@ static struct uni_screen *vc_uniscr_allostatic void vc_uniscr_set (struct vc_data *vc,struct uni_screen *new_uniscr) { -kfree (vc->vc_uni_screen); +vfree (vc->vc_uni_screen); vc->vc_uni_screen = new_uniscr; }
Greg Kroah-Hartman
maintainerPATCH 117/131 staging: vt6656: Dont set RCR_MULTICAST or RCR_BROADCAST by default.
In reply to Greg Kroah-HartmanFrom: Malcolm Priestley <[email protected]>
commit 0f8240bfc070033a4823b19883efd3d38c7735cc upstream.
mac80211/users control whether multicast is on or off don't enable it by default.
Fixes an issue when multicast/broadcast is always on allowing other beacons through in power save.
--- drivers/staging/vt6656/main_usb.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/vt6656/main_usb.c +2 -6
@@ -780,15 +780,11 @@ static void vnt_configure(struct ieee802 {struct vnt_private *priv = hw->priv;u8 rx_mode =0 ; -int rc; *total_flags &=FIF_ALLMULTI |FIF_OTHER_BSS |FIF_BCN_PRBRESP_PROMISC ; - rc =vnt_control_in (priv,MESSAGE_TYPE_READ ,MAC_REG_RCR , -MESSAGE_REQUEST_MACREG ,sizeof (u8), &rx_mode); - -if (!rc) - rx_mode =RCR_MULTICAST |RCR_BROADCAST ; +vnt_control_in (priv,MESSAGE_TYPE_READ ,MAC_REG_RCR , +MESSAGE_REQUEST_MACREG ,sizeof (u8), &rx_mode);dev_dbg (&priv->usb->dev,"rx mode in = %x\n" , rx_mode);
Greg Kroah-Hartman
maintainerPATCH 118/131 staging: vt6656: Fix calling conditions of vnt_set_bss_mode
In reply to Greg Kroah-HartmanFrom: Malcolm Priestley <[email protected]>
commit 664ba5180234593b4b8517530e8198bf2f7359e2 upstream.
vnt_set_bss_mode needs to be called on all changes to BSS_CHANGED_BASIC_RATES, BSS_CHANGED_ERP_PREAMBLE and BSS_CHANGED_ERP_SLOT
Remove all other calls and vnt_update_ifs which is called in vnt_set_bss_mode.
Fixes an issue that preamble mode is not being updated correctly.
--- drivers/staging/vt6656/main_usb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vt6656/main_usb.c +4 -4
@@ -595,8 +595,6 @@ static int vnt_add_interface(struct ieee priv->op_mode = vif->type; -vnt_set_bss_mode (priv); -/* LED blink on TX */ vnt_mac_set_led (priv,LEDSTS_STS ,LEDSTS_INTER );
@@ -683,7 +681,6 @@ static void vnt_bss_info_changed(struct priv->basic_rates = conf->basic_rates;vnt_update_top_rates (priv); -vnt_set_bss_mode (priv);dev_dbg (&priv->usb->dev,"basic rates %x\n" , conf->basic_rates); }
@@ -712,11 +709,14 @@ static void vnt_bss_info_changed(struct priv->short_slot_time = false;vnt_set_short_slot_time (priv); -vnt_update_ifs (priv);vnt_set_vga_gain_offset (priv, priv->bb_vga[0 ]);vnt_update_pre_ed_threshold (priv, false); } +if (changed & (BSS_CHANGED_BASIC_RATES |BSS_CHANGED_ERP_PREAMBLE | +BSS_CHANGED_ERP_SLOT )) +vnt_set_bss_mode (priv); +if (changed &BSS_CHANGED_TXPOWER )vnt_rf_setpower (priv, priv->current_rate, conf->chandef.chan->hw_value);
Greg Kroah-Hartman
maintainerPATCH 119/131 staging: vt6656: Fix drivers TBTT timing counter.
In reply to Greg Kroah-HartmanFrom: Malcolm Priestley <[email protected]>
commit 09057742af98a39ebffa27fac4f889dc873132de upstream.
The drivers TBTT counter is not synchronized with mac80211 timestamp.
Reorder the functions and use vnt_update_next_tbtt to do the final synchronize.
--- drivers/staging/vt6656/main_usb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/vt6656/main_usb.c +6 -3
@@ -740,12 +740,15 @@ static void vnt_bss_info_changed(structvnt_mac_reg_bits_on (priv,MAC_REG_TFTCTL ,TFTCTL_TSFCNTREN ); -vnt_adjust_tsf (priv, conf->beacon_rate->hw_value, - conf->sync_tsf, priv->current_tsf); -vnt_mac_set_beacon_interval (priv, conf->beacon_int);vnt_reset_next_tbtt (priv, conf->beacon_int); + +vnt_adjust_tsf (priv, conf->beacon_rate->hw_value, + conf->sync_tsf, priv->current_tsf); + +vnt_update_next_tbtt (priv, + conf->sync_tsf, conf->beacon_int); }else {vnt_clear_current_tsf (priv);
Greg Kroah-Hartman
maintainerPATCH 120/131 staging: vt6656: Fix pairwise key entry save.
In reply to Greg Kroah-HartmanFrom: Malcolm Priestley <[email protected]>
commit 0b59f10b1d8fe8d50944f21f5d403df9303095a8 upstream.
The problem is that the group key was saved as VNT_KEY_DEFAULTKEY was over written by the VNT_KEY_GROUP_ADDRESS index.
mac80211 could not clear the mac_addr in the default key.
The VNT_KEY_DEFAULTKEY is not necesscary so remove it and set as VNT_KEY_GROUP_ADDRESS.
mac80211 can clear any key using vnt_mac_disable_keyentry.
--- drivers/staging/vt6656/key.c | 14 +++----------- drivers/staging/vt6656/main_usb.c | 6 +++++- 2 files changed, 8 insertions(+), 12 deletions(-)
drivers/staging/vt6656/key.c +3 -11
@@ -81,9 +81,6 @@ static int vnt_set_keymode(struct ieee80case VNT_KEY_PAIRWISE : key_mode |= mode; key_inx =4 ; -/* Don't save entry for pairwise key for station mode */ -if (priv->op_mode ==NL80211_IFTYPE_STATION ) -clear_bit (entry, &priv->key_entry_inuse);break ;default :return -EINVAL ;
@@ -107,7 +104,6 @@ static int vnt_set_keymode(struct ieee80int vnt_set_keys (struct ieee80211_hw *hw,struct ieee80211_sta *sta,struct ieee80211_vif *vif,struct ieee80211_key_conf *key) { -struct ieee80211_bss_conf *conf = &vif->bss_conf;struct vnt_private *priv = hw->priv;u8 *mac_addr =NULL ;u8 key_dec_mode =0 ;
@@ -149,16 +145,12 @@ int vnt_set_keys(struct ieee80211_hw *hw key->flags |=IEEE80211_KEY_FLAG_GENERATE_IV ; } -if (key->flags &IEEE80211_KEY_FLAG_PAIRWISE ) { +if (key->flags &IEEE80211_KEY_FLAG_PAIRWISE )vnt_set_keymode (hw, mac_addr, key,VNT_KEY_PAIRWISE , key_dec_mode, true); - }else { -vnt_set_keymode (hw, mac_addr, key,VNT_KEY_DEFAULTKEY , +else +vnt_set_keymode (hw, mac_addr, key,VNT_KEY_GROUP_ADDRESS , key_dec_mode, true); -vnt_set_keymode (hw, (u8 *)conf->bssid, key, -VNT_KEY_GROUP_ADDRESS , key_dec_mode, true); - } -return 0 ; }
drivers/staging/vt6656/main_usb.c +5 -1
@@ -828,8 +828,12 @@ static int vnt_set_key(struct ieee80211_return -EOPNOTSUPP ;break ;case DISABLE_KEY : -if (test_bit (key->hw_key_idx, &priv->key_entry_inuse)) +if (test_bit (key->hw_key_idx, &priv->key_entry_inuse)) {clear_bit (key->hw_key_idx, &priv->key_entry_inuse); + +vnt_mac_disable_keyentry (priv, key->hw_key_idx); + } +default :break ; }
Greg Kroah-Hartman
maintainerPATCH 121/131 staging: vt6656: Power save stop wake_up_count wrap around.
In reply to Greg Kroah-HartmanFrom: Malcolm Priestley <[email protected]>
commit ea81c3486442f4643fc9825a2bb1b430b829bccd upstream.
conf.listen_interval can sometimes be zero causing wake_up_count to wrap around up to many beacons too late causing CTRL-EVENT-BEACON-LOSS as in.
wpa_supplicant[795]: message repeated 45 times: [..CTRL-EVENT-BEACON-LOSS ]
--- drivers/staging/vt6656/int.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6656/int.c +2 -1
@@ -143,7 +143,8 @@ void vnt_int_process_data(struct vnt_pri priv->wake_up_count = priv->hw->conf.listen_interval; - --priv->wake_up_count; +if (priv->wake_up_count) + --priv->wake_up_count;/* Turn on wake up to listen next beacon */ if (priv->wake_up_count ==1 )
Greg Kroah-Hartman
maintainerPATCH 122/131 cdc-acm: close race betrween suspend() and acm_softint
In reply to Greg Kroah-HartmanFrom: Oliver Neukum <[email protected]>
commit 0afccd7601514c4b83d8cc58c740089cc447051d upstream.
Suspend increments a counter, then kills the URBs, then kills the scheduled work. The scheduled work, however, may reschedule the URBs. Fix this by having the work check the counter.
--- drivers/usb/class/cdc-acm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/class/cdc-acm.c +3 -3
@@ -563,14 +563,14 @@ static void acm_softint(struct work_stru struct acm *acm = container_of(work, struct acm, work);if (test_bit (EVENT_RX_STALL , &acm->flags)) { -if (!(usb_autopm_get_interface (acm->data))) { +smp_mb ();/* against acm_suspend() */ +if (!acm->susp_count) {for (i =0 ; i < acm->rx_buflimit; i++)usb_kill_urb (acm->read_urbs[i]);usb_clear_halt (acm->dev, acm->in);acm_submit_read_urbs (acm,GFP_KERNEL ); -usb_autopm_put_interface (acm->data); +clear_bit (EVENT_RX_STALL , &acm->flags); } -clear_bit (EVENT_RX_STALL , &acm->flags); }if (test_and_clear_bit (EVENT_TTY_WAKEUP , &acm->flags))
Greg Kroah-Hartman
maintainerPATCH 123/131 cdc-acm: introduce a cool down
In reply to Greg Kroah-HartmanFrom: Oliver Neukum <[email protected]>
commit a4e7279cd1d19f48f0af2a10ed020febaa9ac092 upstream.
Immediate submission in case of a babbling device can lead to a busy loop. Introducing a delayed work.
--- drivers/usb/class/cdc-acm.c | 30 ++++++++++++++++++++++++++++-- drivers/usb/class/cdc-acm.h | 5 ++++- 2 files changed, 32 insertions(+), 3 deletions(-)
drivers/usb/class/cdc-acm.c +28 -2
@@ -412,9 +412,12 @@ static void acm_ctrl_irq(struct urb *urb exit: retval =usb_submit_urb (urb,GFP_ATOMIC ); -if (retval && retval != -EPERM ) +if (retval && retval != -EPERM && retval != -ENODEV )dev_err (&acm->control->dev,"%s - usb_submit_urb failed: %d\n" , __func__, retval); +else +dev_vdbg (&acm->control->dev, +"control resubmission terminated %d\n" , retval); }static int acm_submit_read_urb (struct acm *acm,int index,gfp_t mem_flags)
@@ -430,6 +433,8 @@ static int acm_submit_read_urb(struct acdev_err (&acm->data->dev,"urb %d failed submission with %d\n" , index, res); + }else { +dev_vdbg (&acm->data->dev,"intended failure %d\n" , res); }set_bit (index, &acm->read_urbs_free);return res;
@@ -472,6 +477,7 @@ static void acm_read_bulk_callback(strucint status = urb->status;bool stopped = false;bool stalled = false; +bool cooldown = false;dev_vdbg (&acm->data->dev,"got urb %d, len %d, status %d\n" , rb->index, urb->actual_length, status);
@@ -498,6 +504,14 @@ static void acm_read_bulk_callback(struc __func__, status); stopped = true;break ; +case -EOVERFLOW : +case -EPROTO : +dev_dbg (&acm->data->dev, +"%s - cooling babbling device\n" , __func__); +usb_mark_last_busy (acm->dev); +set_bit (rb->index, &acm->urbs_in_error_delay); + cooldown = true; +break ;default : dev_dbg(&acm->data->dev, "%s - nonzero urb status received: %d\n",
@@ -519,9 +533,11 @@ static void acm_read_bulk_callback(struc*/ smp_mb__after_atomic (); -if (stopped || stalled) { +if (stopped || stalled || cooldown) {if (stalled)schedule_work (&acm->work); +else if (cooldown) +schedule_delayed_work (&acm->dwork,HZ /2 );return ; }
@@ -573,6 +589,12 @@ static void acm_softint(struct work_stru } } +if (test_and_clear_bit (ACM_ERROR_DELAY , &acm->flags)) { +for (i =0 ; i <ACM_NR ; i++) +if (test_and_clear_bit (i, &acm->urbs_in_error_delay)) +acm_submit_read_urb (acm, i,GFP_NOIO ); + } +if (test_and_clear_bit (EVENT_TTY_WAKEUP , &acm->flags))tty_port_tty_wakeup (&acm->port); }
@@ -1365,6 +1387,7 @@ made_compressed_probe: acm->readsize = readsize; acm->rx_buflimit = num_rx_buf;INIT_WORK (&acm->work, acm_softint); +INIT_DELAYED_WORK (&acm->dwork, acm_softint);init_waitqueue_head (&acm->wioctl);spin_lock_init (&acm->write_lock);spin_lock_init (&acm->read_lock);
@@ -1574,6 +1597,7 @@ static void acm_disconnect(struct usb_inacm_kill_urbs (acm);cancel_work_sync (&acm->work); +cancel_delayed_work_sync (&acm->dwork);tty_unregister_device (acm_tty_driver, acm->minor);
@@ -1616,6 +1640,8 @@ static int acm_suspend(struct usb_interfacm_kill_urbs (acm);cancel_work_sync (&acm->work); +cancel_delayed_work_sync (&acm->dwork); + acm->urbs_in_error_delay =0 ;return 0 ; }
drivers/usb/class/cdc-acm.h +4 -1
@@ -108,8 +108,11 @@ struct acm {unsigned long flags;# define EVENT_TTY_WAKEUP 0# define EVENT_RX_STALL 1 +# define ACM_ERROR_DELAY 3 +unsigned long urbs_in_error_delay;/* these need to be restarted after a delay */ struct usb_cdc_line_coding line;/* bits, stop, parity */ -struct work_struct work;/* work queue entry for line discipline waking up */ +struct work_struct work;/* work queue entry for various purposes*/ +struct delayed_work dwork;/* for cool downs needed in error recovery */ unsigned int ctrlin;/* input control lines (DCD, DSR, RI, break, overruns) */ unsigned int ctrlout;/* output control lines (DTR, RTS) */ struct async_icount iocount;/* counters for control line changes */
Greg Kroah-Hartman
maintainerPATCH 124/131 UAS: no use logging any details in case of ENODEV
In reply to Greg Kroah-HartmanFrom: Oliver Neukum <[email protected]>
commit 5963dec98dc52d52476390485f07a29c30c6a582 upstream.
Once a device is gone, the internal state does not matter anymore. There is no need to spam the logs.
--- drivers/usb/storage/uas.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/storage/uas.c +3 -0
@@ -190,6 +190,9 @@ static void uas_log_cmd_state(struct scsstruct uas_cmd_info *ci = (void *)&cmnd->SCp;struct uas_cmd_info *cmdinfo = (void *)&cmnd->SCp; +if (status == -ENODEV )/* too late */ +return ; + scmd_printk(KERN_INFO, cmnd, "%s %d uas-tag %d inflight:%s%s%s%s%s%s%s%s%s%s%s%s ", prefix, status, cmdinfo->uas_tag,
Greg Kroah-Hartman
maintainerPATCH 125/131 UAS: fix deadlock in error handling and PM flushing work
In reply to Greg Kroah-HartmanFrom: Oliver Neukum <[email protected]>
commit f6cc6093a729ede1ff5658b493237c42b82ba107 upstream.
A SCSI error handler and block runtime PM must not allocate memory with GFP_KERNEL. Furthermore they must not wait for tasks allocating memory with GFP_KERNEL.
That means that they cannot share a workqueue with arbitrary tasks.
Fix this for UAS using a private workqueue.
--- drivers/usb/storage/uas.c | 43 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-)
drivers/usb/storage/uas.c +40 -3
@@ -81,6 +81,19 @@ static void uas_free_streams(struct uas_static void uas_log_cmd_state (struct scsi_cmnd *cmnd,const char *prefix,int status); +/* +* This driver needs its own workqueue, as we need to control memory allocation. +* +* In the course of error handling and power management uas_wait_for_pending_cmnds() +* needs to flush pending work items. In these contexts we cannot allocate memory +* by doing block IO as we would deadlock. For the same reason we cannot wait +* for anything allocating memory not heeding these constraints. +* +* So we have to control all work items that can be on the workqueue we flush. +* Hence we cannot share a queue and need our own. +*/ +static struct workqueue_struct *workqueue; +static void uas_do_work (struct work_struct *work) { struct uas_dev_info *devinfo =
@@ -109,7 +122,7 @@ static void uas_do_work(struct work_struif (!err) cmdinfo->state &= ~IS_IN_WORK_LIST ;else -schedule_work (&devinfo->work); +queue_work (workqueue, &devinfo->work); } out:spin_unlock_irqrestore (&devinfo->lock, flags);
@@ -134,7 +147,7 @@ static void uas_add_work(struct uas_cmd_lockdep_assert_held (&devinfo->lock); cmdinfo->state |=IS_IN_WORK_LIST ; -schedule_work (&devinfo->work); +queue_work (workqueue, &devinfo->work); }static void uas_zap_pending (struct uas_dev_info *devinfo,int result)
@@ -1236,7 +1249,31 @@ static struct usb_driver uas_driver = { .id_table = uas_usb_ids, }; -module_usb_driver (uas_driver); +static int __init uas_init (void ) +{ +int rv; + + workqueue =alloc_workqueue ("uas" ,WQ_MEM_RECLAIM ,0 ); +if (!workqueue) +return -ENOMEM ; + + rv =usb_register (&uas_driver); +if (rv) { +destroy_workqueue (workqueue); +return -ENOMEM ; + } + +return 0 ; +} + +static void __exit uas_exit(void) +{ +usb_deregister (&uas_driver); +destroy_workqueue (workqueue); +} + +module_init (uas_init); +module_exit (uas_exit);MODULE_LICENSE ("GPL" ); MODULE_AUTHOR(
Greg Kroah-Hartman
maintainerPATCH 126/131 usb: dwc3: gadget: Fix request completion check
In reply to Greg Kroah-HartmanFrom: Thinh Nguyen <[email protected]>
commit 49e0590e3a60e75b493e5df879e216e5073c7663 upstream.
A request may not be completed because not all the TRBs are prepared for it. This happens when we run out of available TRBs. When some TRBs are completed, the driver needs to prepare the rest of the TRBs for the request. The check dwc3_gadget_ep_request_completed() shouldn't be checking the amount of data received but rather the number of pending TRBs. Revise this request completion check.
--- drivers/usb/dwc3/gadget.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/usb/dwc3/gadget.c +2 -10
@@ -2280,14 +2280,7 @@ static int dwc3_gadget_ep_reclaim_trb_listatic bool dwc3_gadget_ep_request_completed (struct dwc3_request *req) { -/* -* For OUT direction, host may send less than the setup -* length. Return true for all OUT requests. -*/ -if (!req->direction) -return true; - -return req->request.actual == req->request.length; +return req->num_pending_sgs ==0 ; } static int dwc3_gadget_ep_cleanup_completed_request(struct dwc3_ep *dep,
@@ -2311,8 +2304,7 @@ static int dwc3_gadget_ep_cleanup_comple req->request.actual = req->request.length - req->remaining; -if (!dwc3_gadget_ep_request_completed (req) || - req->num_pending_sgs) { +if (!dwc3_gadget_ep_request_completed (req)) {__dwc3_gadget_kick_transfer (dep); goto out; }
Greg Kroah-Hartman
maintainerPATCH 127/131 usb: f_fs: Clear OS Extended descriptor counts to zero in ffs_data_reset()
In reply to Greg Kroah-HartmanFrom: Udipto Goswami <[email protected]>
commit 1c2e54fbf1da5e5445a0ab132c862b02ccd8d230 upstream.
For userspace functions using OS Descriptors, if a function also supplies Extended Property descriptors currently the counts and lengths stored in the ms_os_descs_ext_prop_{count,name_len,data_len} variables are not getting reset to 0 during an unbind or when the epfiles are closed. If the same function is re-bound and the descriptors are re-written, this results in those count/length variables to monotonically increase causing the VLA allocation in _ffs_func_bind() to grow larger and larger at each bind/unbind cycle and eventually fail to allocate.
Fix this by clearing the ms_os_descs_ext_prop count & lengths to 0 in ffs_data_reset().
--- drivers/usb/gadget/function/f_fs.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/usb/gadget/function/f_fs.c +4 -0
@@ -1737,6 +1737,10 @@ static void ffs_data_reset(struct ffs_da ffs->state =FFS_READ_DESCRIPTORS ; ffs->setup_state =FFS_NO_SETUP ; ffs->flags =0 ; + + ffs->ms_os_descs_ext_prop_count =0 ; + ffs->ms_os_descs_ext_prop_name_len =0 ; + ffs->ms_os_descs_ext_prop_data_len =0 ; }
Greg Kroah-Hartman
maintainerPATCH 128/131 xhci: prevent bus suspend if a roothub port detected a over-current condition
In reply to Greg Kroah-HartmanFrom: Mathias Nyman <[email protected]>
commit e9fb08d617bfae5471d902112667d0eeb9dee3c4 upstream.
Suspending the bus and host controller while a port is in a over-current condition may halt the host.
Also keep the roothub running if over-current is active.
--- drivers/usb/host/xhci-hub.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/usb/host/xhci-hub.c +9 -0
@@ -1481,6 +1481,8 @@ int xhci_hub_status_data(struct usb_hcd }if ((temp &PORT_RC )) reset_change = true; +if (temp &PORT_OC ) + status =1 ; }if (!status && !reset_change) {xhci_dbg (xhci,"%s: stopping port polling.\n" , __func__);
@@ -1546,6 +1548,13 @@ retry: port_index); goto retry; } +/* bail out if port detected a over-current condition */ +if (t1 &PORT_OC ) { + bus_state->bus_suspended =0 ; +spin_unlock_irqrestore (&xhci->lock, flags); +xhci_dbg (xhci,"Bus suspend bailout, port over-current detected\n" ); +return -EBUSY ; + }/* suspend ports in U0, or bail out for new connect changes */ if ((t1 &PORT_PE ) && (t1 &PORT_PLS_MASK ) ==XDEV_U0 ) {if ((t1 &PORT_CSC ) && wake_enabled) {
Greg Kroah-Hartman
maintainerPATCH 129/131 serial: sh-sci: Make sure status register SCxSR is read in correct sequence
In reply to Greg Kroah-HartmanFrom: Kazuhiro Fujita <[email protected]>
commit 3dc4db3662366306e54ddcbda4804acb1258e4ba upstream.
For SCIF and HSCIF interfaces the SCxSR register holds the status of data that is to be read next from SCxRDR register, But where as for SCIFA and SCIFB interfaces SCxSR register holds status of data that is previously read from SCxRDR register.
This patch makes sure the status register is read depending on the port types so that errors are caught accordingly.
--- drivers/tty/serial/sh-sci.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/tty/serial/sh-sci.c +9 -2
@@ -873,9 +873,16 @@ static void sci_receive_chars(struct uartty_insert_flip_char (tport, c,TTY_NORMAL ); }else {for (i =0 ; i < count; i++) { -char c =serial_port_in (port, SCxRDR); +char c; - status =serial_port_in (port, SCxSR); +if (port->type ==PORT_SCIF || + port->type ==PORT_HSCIF ) { + status =serial_port_in (port, SCxSR); + c =serial_port_in (port, SCxRDR); + }else { + c =serial_port_in (port, SCxRDR); + status =serial_port_in (port, SCxSR); + }if (uart_handle_sysrq_char (port, c)) { count--; i--;continue ;
Greg Kroah-Hartman
maintainerPATCH 130/131 xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT
In reply to Greg Kroah-HartmanFrom: kaixuxia <[email protected]>
commit bc56ad8c74b8588685c2875de0df8ab6974828ef upstream.
When performing rename operation with RENAME_WHITEOUT flag, we will hold AGF lock to allocate or free extents in manipulating the dirents firstly, and then doing the xfs_iunlink_remove() call last to hold AGI lock to modify the tmpfile info, so we the lock order AGI->AGF.
The big problem here is that we have an ordering constraint on AGF and AGI locking - inode allocation locks the AGI, then can allocate a new extent for new inodes, locking the AGF after the AGI. Hence the ordering that is imposed by other parts of the code is AGI before AGF. So we get an ABBA deadlock between the AGI and AGF here.
Process A:
Call trace: ? __schedule+0x2bd/0x620 schedule+0x33/0x90 schedule_timeout+0x17d/0x290 __down_common+0xef/0x125 ? xfs_buf_find+0x215/0x6c0 [xfs] down+0x3b/0x50 xfs_buf_lock+0x34/0xf0 [xfs] xfs_buf_find+0x215/0x6c0 [xfs] xfs_buf_get_map+0x37/0x230 [xfs] xfs_buf_read_map+0x29/0x190 [xfs] xfs_trans_read_buf_map+0x13d/0x520 [xfs] xfs_read_agf+0xa6/0x180 [xfs] ? schedule_timeout+0x17d/0x290 xfs_alloc_read_agf+0x52/0x1f0 [xfs] xfs_alloc_fix_freelist+0x432/0x590 [xfs] ? down+0x3b/0x50 ? xfs_buf_lock+0x34/0xf0 [xfs] ? xfs_buf_find+0x215/0x6c0 [xfs] xfs_alloc_vextent+0x301/0x6c0 [xfs] xfs_ialloc_ag_alloc+0x182/0x700 [xfs] ? _xfs_trans_bjoin+0x72/0xf0 [xfs] xfs_dialloc+0x116/0x290 [xfs] xfs_ialloc+0x6d/0x5e0 [xfs] ? xfs_log_reserve+0x165/0x280 [xfs] xfs_dir_ialloc+0x8c/0x240 [xfs] xfs_create+0x35a/0x610 [xfs] xfs_generic_create+0x1f1/0x2f0 [xfs] ...
Process B:
Call trace: ? __schedule+0x2bd/0x620 ? xfs_bmapi_allocate+0x245/0x380 [xfs] schedule+0x33/0x90 schedule_timeout+0x17d/0x290 ? xfs_buf_find+0x1fd/0x6c0 [xfs] __down_common+0xef/0x125 ? xfs_buf_get_map+0x37/0x230 [xfs] ? xfs_buf_find+0x215/0x6c0 [xfs] down+0x3b/0x50 xfs_buf_lock+0x34/0xf0 [xfs] xfs_buf_find+0x215/0x6c0 [xfs] xfs_buf_get_map+0x37/0x230 [xfs] xfs_buf_read_map+0x29/0x190 [xfs] xfs_trans_read_buf_map+0x13d/0x520 [xfs] xfs_read_agi+0xa8/0x160 [xfs] xfs_iunlink_remove+0x6f/0x2a0 [xfs] ? current_time+0x46/0x80 ? xfs_trans_ichgtime+0x39/0xb0 [xfs] xfs_rename+0x57a/0xae0 [xfs] xfs_vn_rename+0xe4/0x150 [xfs] ...
In this patch we move the xfs_iunlink_remove() call to before acquiring the AGF lock to preserve correct AGI/AGF locking order.
[Minor massage required due to upstream change making xfs_bumplink() a void function where as in the 4.19.y tree the return value is checked, even though it is always zero. Only change was to the last code block removed by the patch. Functionally equivalent to upstream.]
--- fs/xfs/xfs_inode.c | 85 ++++++++++++++++++++++++++--------------------------- 1 file changed, 42 insertions(+), 43 deletions(-)
fs/xfs/xfs_inode.c +42 -43
@@ -2949,7 +2949,8 @@ xfs_rename( spaceres);/* -* Set up the target. +* Check for expected errors before we dirty the transaction +* so we can return an error without a transaction abort. */ if (target_ip ==NULL ) {/*
@@ -2961,6 +2962,46 @@ xfs_rename(if (error) goto out_trans_cancel; } + }else { +/* +* If target exists and it's a directory, check that whether +* it can be destroyed. +*/ +if (S_ISDIR (VFS_I (target_ip)->i_mode) && + (!xfs_dir_isempty (target_ip) || + (VFS_I (target_ip)->i_nlink >2 ))) { + error = -EEXIST ; + goto out_trans_cancel; + } + } + +/* +* Directory entry creation below may acquire the AGF. Remove +* the whiteout from the unlinked list first to preserve correct +* AGI/AGF locking order. This dirties the transaction so failures +* after this point will abort and log recovery will clean up the +* mess. +* +* For whiteouts, we need to bump the link count on the whiteout +* inode. After this point, we have a real link, clear the tmpfile +* state flag from the inode so it doesn't accidentally get misused +* in future. +*/ +if (wip) { +ASSERT (VFS_I (wip)->i_nlink ==0 ); + error =xfs_iunlink_remove (tp, wip); +if (error) + goto out_trans_cancel; + +xfs_bumplink (tp, wip); +xfs_trans_log_inode (tp, wip,XFS_ILOG_CORE ); +VFS_I (wip)->i_state &= ~I_LINKABLE ; + } + +/* +* Set up the target. +*/ +if (target_ip ==NULL ) {/* * If target does not exist and the rename crosses * directories, adjust the target directory link count
@@ -2981,22 +3022,6 @@ xfs_rename( } }else {/* target_ip != NULL */ /* -* If target exists and it's a directory, check that both -* target and source are directories and that target can be -* destroyed, or that neither is a directory. -*/ -if (S_ISDIR (VFS_I (target_ip)->i_mode)) { -/* -* Make sure target dir is empty. -*/ -if (!(xfs_dir_isempty (target_ip)) || - (VFS_I (target_ip)->i_nlink >2 )) { - error = -EEXIST ; - goto out_trans_cancel; - } - } - -/* * Link the source inode under the target name. * If the source inode is a directory and we are moving * it across directories, its ".." entry will be
@@ -3086,32 +3111,6 @@ xfs_rename(if (error) goto out_trans_cancel; -/* -* For whiteouts, we need to bump the link count on the whiteout inode. -* This means that failures all the way up to this point leave the inode -* on the unlinked list and so cleanup is a simple matter of dropping -* the remaining reference to it. If we fail here after bumping the link -* count, we're shutting down the filesystem so we'll never see the -* intermediate state on disk. -*/ -if (wip) { -ASSERT (VFS_I (wip)->i_nlink ==0 ); - error =xfs_bumplink (tp, wip); -if (error) - goto out_trans_cancel; - error =xfs_iunlink_remove (tp, wip); -if (error) - goto out_trans_cancel; -xfs_trans_log_inode (tp, wip,XFS_ILOG_CORE ); - -/* -* Now we have a real link, clear the "I'm a tmpfile" state -* flag from the inode so it doesn't accidentally get misused in -* future. -*/ -VFS_I (wip)->i_state &= ~I_LINKABLE ; - } -xfs_trans_ichgtime (tp, src_dp,XFS_ICHGTIME_MOD |XFS_ICHGTIME_CHG );xfs_trans_log_inode (tp, src_dp,XFS_ILOG_CORE );if (new_parent)
Greg Kroah-Hartman
maintainerPATCH 131/131 s390/mm: fix page table upgrade vs 2ndary address mode accesses
In reply to Greg Kroah-HartmanFrom: Christian Borntraeger <[email protected]>
commit 316ec154810960052d4586b634156c54d0778f74 upstream.
A page table upgrade in a kernel section that uses secondary address mode will mess up the kernel instructions as follows:
Consider the following scenario: two threads are sharing memory. On CPU1 thread 1 does e.g. strnlen_user(). That gets to
old_fs = enable_sacf_uaccess();
len = strnlen_user_srst(src, size);
and
" la %2,0(%1)\n"
" la %3,0(%0,%1)\n"
" slgr %0,%0\n"
" sacf 256\n"
"0: srst %3,%2\n"in strnlen_user_srst(). At that point we are in secondary space mode, control register 1 points to kernel page table and instruction fetching happens via c1, rather than usual c13. Interrupts are not disabled, for obvious reasons.
On CPU2 thread 2 does MAP_FIXED mmap(), forcing the upgrade of page table from 3-level to e.g. 4-level one. We'd allocated new top-level table, set it up and now we hit this:
notify = 1;
spin_unlock_bh(&mm->page_table_lock);
}
if (notify)
on_each_cpu(__crst_table_upgrade, mm, 0);OK, we need to actually change over to use of new page table and we need that to happen in all threads that are currently running. Which happens to include the thread 1. IPI is delivered and we have static void __crst_table_upgrade(void *arg)
{
struct mm_struct *mm = arg;
if (current->active_mm == mm)
set_user_asce(mm);
__tlb_flush_local();
}
run on CPU1. That does
static inline void set_user_asce(struct mm_struct *mm)
{
S390_lowcore.user_asce = mm->context.asce;
OK, user page table address updated...
__ctl_load(S390_lowcore.user_asce, 1, 1);
... and control register 1 set to it.
clear_cpu_flag(CIF_ASCE_PRIMARY);
}IPI is run in home space mode, so it's fine - insns are fetched using c13, which always points to kernel page table. But as soon as we return from the interrupt, previous PSW is restored, putting CPU1 back into secondary space mode, at which point we no longer get the kernel instructions from the kernel mapping.
The fix is to only fixup the control registers that are currently in use for user processes during the page table update. We must also disable interrupts in enable_sacf_uaccess to synchronize the cr and thread.mm_segment updates against the on_each-cpu.
--- arch/s390/lib/uaccess.c | 4 ++++ arch/s390/mm/pgalloc.c | 16 ++++++++++++++-- 2 files changed, 18 insertions(+), 2 deletions(-)
arch/s390/lib/uaccess.c +4 -0
@@ -64,10 +64,13 @@ mm_segment_t enable_sacf_uaccess(void) {mm_segment_t old_fs;unsigned long asce, cr; +unsigned long flags; old_fs = current->thread.mm_segment;if (old_fs &1 )return old_fs; +/* protect against a concurrent page table upgrade */ +local_irq_save (flags); current->thread.mm_segment |=1 ; asce = S390_lowcore.kernel_asce;if (likely (old_fs ==USER_DS )) {
@@ -83,6 +86,7 @@ mm_segment_t enable_sacf_uaccess(void)__ctl_load (asce,7 ,7 );set_cpu_flag (CIF_ASCE_SECONDARY ); } +local_irq_restore (flags);return old_fs; }EXPORT_SYMBOL (enable_sacf_uaccess);
arch/s390/mm/pgalloc.c +14 -2
@@ -72,8 +72,20 @@ static void __crst_table_upgrade(void *a {struct mm_struct *mm = arg; -if (current->active_mm == mm) -set_user_asce (mm); +/* we must change all active ASCEs to avoid the creation of new TLBs */ +if (current->active_mm == mm) { + S390_lowcore.user_asce = mm->context.asce; +if (current->thread.mm_segment ==USER_DS ) { +__ctl_load (S390_lowcore.user_asce,1 ,1 ); +/* Mark user-ASCE present in CR1 */ +clear_cpu_flag (CIF_ASCE_PRIMARY ); + } +if (current->thread.mm_segment ==USER_DS_SACF ) { +__ctl_load (S390_lowcore.user_asce,7 ,7 ); +/* enable_sacf_uaccess does all or nothing */ +WARN_ON (!test_cpu_flag (CIF_ASCE_SECONDARY )); + } + }__tlb_flush_local (); }
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.119 release. There are 131 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 30 Apr 2020 18:20:45 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.119-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Hello Greg,
Quoted 8 lines
From: [email protected] <[email protected]> On Behalf Of Greg Kroah-Hartman
Sent: 28 April 2020 19:24This is the start of the stable review cycle for the 4.19.119 release. There are 131 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
No build/boot issues seen for CIP configs for Linux 4.19.119-rc1 (3fc812d65db6).
Build/test pipeline/logs: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/pipelines/140770244
GitLab CI pipeline: https://gitlab.com/cip-project/cip-testing/linux-cip-pipelines/-/blob/master/trees/linux-4.19.y.yml
Relevant LAVA jobs: https://lava.ciplatform.org/scheduler/alljobs?length=25&search=3fc812#table
Kind regards, Chris
Quoted 577 lines
Responses should be made by Thu, 30 Apr 2020 18:20:45 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-
4.19.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:Greg Kroah-Hartman <[email protected]>
Linux 4.19.119-rc1Christian Borntraeger <[email protected]>
s390/mm: fix page table upgrade vs 2ndary address mode accesseskaixuxia <[email protected]>
xfs: Fix deadlock between AGI and AGF withRENAME_WHITEOUTKazuhiro Fujita <[email protected]>
serial: sh-sci: Make sure status register SCxSR is read in correct sequenceMathias Nyman <[email protected]>
xhci: prevent bus suspend if a roothub port detected a over-current conditionUdipto Goswami <[email protected]>
usb:f_fs: Clear OS Extended descriptor counts to zero inffs_data_reset()Thinh Nguyen <[email protected]>
usb: dwc3: gadget: Fix request completion checkOliver Neukum <[email protected]>
UAS: fix deadlock in error handling and PM flushing workOliver Neukum <[email protected]>
UAS: no use logging any details in case of ENODEVOliver Neukum <[email protected]>
cdc-acm: introduce a cool downOliver Neukum <[email protected]>
cdc-acm: close race betrweensuspend()andacm_softintMalcolm Priestley <[email protected]>
staging: vt6656: Power save stopwake_up_countwrap around.Malcolm Priestley <[email protected]>
staging: vt6656: Fix pairwise key entry save.Malcolm Priestley <[email protected]>
staging: vt6656: Fix drivers TBTT timing counter.Malcolm Priestley <[email protected]>
staging: vt6656: Fix calling conditions ofvnt_set_bss_modeMalcolm Priestley <[email protected]>
staging: vt6656: Don't setRCR_MULTICASTorRCR_BROADCASTby default.Nicolas Pitre <[email protected]>
vt: don't usekmalloc()for the unicode screen bufferNicolas Pitre <[email protected]>
vt: don't hardcode the mem allocation upper boundXiyu Yang <[email protected]>
staging: comedi: Fixcomedi_devicerefcnt leak incomedi_openIan Abbott <[email protected]>
staging: comedi: dt2815: fix writing hi byte of analog outputChris Packham <[email protected]>
powerpc/setup_64: Set cache-line-size based on cache-block-sizeAhmad Fatoum <[email protected]>
ARM: imx: providev7_cpu_resume()only on ARM_CPU_SUSPEND=yMordechay Goodstein <[email protected]>
iwlwifi: mvm: beacon statistics shouldn't go backwardsJohannes Berg <[email protected]>
iwlwifi: pcie: actually release queue memory in TVQMGyeongtaek Lee <[email protected]>
ASoC: dapm: fixup dapm kcontrol widgetPaul Moore <[email protected]>
audit: check the length of userspace generated audit recordsAlan Stern <[email protected]>
usb-storage: Addunusual_devsentry for JMicron JMS566Jiri Slaby <[email protected]>
tty: rocket, avoid OOB accessAndrew Melnychenko <[email protected]>
tty: hvc: fix buffer overflow duringhvc_alloc().Uros Bizjak <[email protected]>
KVM: VMX: Enable machine check support for 32bit targetsSean Christopherson <[email protected]>
KVM: Check validity of resolved slot when searching memslotsSean Christopherson <[email protected]>
KVM: s390: Return last valid slot if approx index is out-of-boundsGeorge Wilson <[email protected]>
tpm: ibmvtpm: retry onH_CLOSEDintpm_ibmvtpm_send()Jarkko Sakkinen <[email protected]>
tpm/tpm_tis: Free IRQ if probing failsAlexander Tsoy <[email protected]>
ALSA: usb-audio: Filter out unsupported sample rates on Focusrite devicesXiyu Yang <[email protected]>
ALSA: usb-audio: Fix usb audio refcnt leak when getting spdifKailang Yang <[email protected]>
ALSA: hda/realtek - Add new codec supported for ALC245Takashi Iwai <[email protected]>
ALSA: hda/realtek - Fix unexpectedinit_ampoverrideTakashi Iwai <[email protected]>
ALSA: usx2y: Fix potential NULL dereferenceLucas Stach <[email protected]>
tools/vm: fix cross-compile buildMuchun Song <[email protected]>
mm/ksm: fix NULL pointer dereference when KSM zero page is enabledLongpeng <[email protected]>
mm/hugetlb: fix a addressing exception caused byhuge_pte_offsetJann Horn <[email protected]>
vmalloc: fixremap_vmalloc_range()bounds checksAlan Stern <[email protected]>
USB: hub: Fix handling of connect changes during sleepAlan Stern <[email protected]>
USB: core: Fix free-while-in-use bug in the USB S-GlibraryJann Horn <[email protected]>
USB: early: Handle AMD's spec-compliant identifiers, tooJonathan Cox <[email protected]>
USB: AddUSB_QUIRK_DELAY_CTRL_MSGandUSB_QUIRK_DELAY_INITfor
Corsair K70 RGB RAPIDFIREChangming Liu <[email protected]>
USB: sisusbvga: Change port variable from signed to unsignedPiotr Krysiuk <[email protected]>
fs/namespace.c: fix mountpoint reference counter raceLars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Make sure not exceed maximum samplerateLars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Fix sequencer configuration for aux channels in simultaneous
modeLars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Fix clearing interrupt when enabling triggerLars-Peter Clausen <[email protected]>
iio: xilinx-xadc: Fix ADC-B powerdownOlivier Moysan <[email protected]>
iio: adc: stm32-adc: fix sleep in atomic contextLary Gibaud <[email protected]>
iio:st_sensors: rely on odr mask to know if odr can be setLars Engebretsen <[email protected]>
iio: core: remove extra semi-colon fromdevm_iio_device_register()macroTakashi Iwai <[email protected]>
ALSA: usb-audio: Add connector notifier delegationTakashi Iwai <[email protected]>
ALSA: usb-audio: Add static mapping table for ALC1220-VB-based mobosTakashi Iwai <[email protected]>
ALSA: hda: Remove ASUS ROG Zenith from the blacklistWaiman Long <[email protected]>
KEYS: Avoid false positive ENOMEM error on key readDan Carpenter <[email protected]>
mlxsw: Fix someIS_ERR()vs NULL bugsDavid Ahern <[email protected]>
vrf: Check skb forXFRM_TRANSFORMEDflagDavid Ahern <[email protected]>
xfrm: Always setXFRM_TRANSFORMEDin xfrm{4,6}_output_finishFlorian Fainelli <[email protected]>
net: dsa: b53:b53_arl_rw_op()needs to select IVL or SVLFlorian Fainelli <[email protected]>
net: dsa: b53: Rework ARL bin logicFlorian Fainelli <[email protected]>
net: dsa: b53: Fix ARL register definitionsFlorian Fainelli <[email protected]>
net: dsa: b53: Lookup VID in ARL searches when VLAN is enabledDavid Ahern <[email protected]>
vrf: Fix IPv6 with qdisc and xfrmTaehee Yoo <[email protected]>
team: fix hang inteam_mode_get()Eric Dumazet <[email protected]>
tcp: cache line alignMAX_TCP_HEADEREric Dumazet <[email protected]>
sched: etf: do not assume all sockets are full blownXiyu Yang <[email protected]>
net/x25: Fixx25_neighrefcnt leak when receiving frameMarc Zyngier <[email protected]>
net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock arrayXiyu Yang <[email protected]>
net: netrom: Fix potentialnr_neighrefcnt leak innr_add_nodeDoug Berger <[email protected]>
net: bcmgenet: correct per TX/RX ring statisticsTaehee Yoo <[email protected]>
macvlan: fix null dereference inmacvlan_device_event()Taehee Yoo <[email protected]>
macsec: avoid to set wrong mtuJohn Haxby <[email protected]>
ipv6: fix restrictIPV6_ADDRFORMoperationRahul Lakkireddy <[email protected]>
cxgb4: fix large delays in PTP synchronizationVishal Kulkarni <[email protected]>
cxgb4: fix adapter crash due to wrong MC sizeBoris Ostrovsky <[email protected]>
x86/KVM: Clean up host's steal time structureBoris Ostrovsky <[email protected]>
x86/KVM: Make sureKVM_VCPU_FLUSH_TLBflag is not missedBoris Ostrovsky <[email protected]>
x86/kvm: Cache gfn to pfn translationBoris Ostrovsky <[email protected]>
x86/kvm: Introduce kvm_(un)map_gfn()KarimAllah Ahmed <[email protected]>
KVM: Properly check if "page" is valid inkvm_vcpu_unmapChristian Borntraeger <[email protected]>
kvm: fix compile on s390 part 2Paolo Bonzini <[email protected]>
kvm: fix compilation on s390Paolo Bonzini <[email protected]>
kvm: fix compilation on aarch64KarimAllah Ahmed <[email protected]>
KVM: Introduce a new guest mapping APISean Christopherson <[email protected]>
KVM: nVMX: Always syncGUEST_BNDCFGSwhen it comes from vmcs01Sean Christopherson <[email protected]>
KVM: VMX: Zero out *all* general purpose registers after VM-ExitRandall Huang <[email protected]>
f2fs: fix to avoid memory leakage inf2fs_listxattrCengiz Can <[email protected]>
blktrace: fix dereference after null checkJan Kara <[email protected]>
blktrace: Protect q->blk_trace with RCUSabrina Dubroca <[email protected]>
net:ipv6_stub: useip6_dst_lookup_flowinstead ofip6_dst_lookupSabrina Dubroca <[email protected]>
net: ipv6: add net argument toip6_dst_lookup_flowHeiner Kallweit <[email protected]>
PCI/ASPM: Allow re-enabling Clock PMMurthy Bhat <[email protected]>
scsi: smartpqi: fix call trace in device discoveryHalil Pasic <[email protected]>
virtio-blk: improve virtqueue error toBLK_STSSteven Rostedt (VMware) <[email protected]>
tracing/selftests: Turn off timeout settingYongqiang Sun <[email protected]>
drm/amd/display: Not doing optimize bandwidth if flip pending.Kai-Heng Feng <[email protected]>
xhci: Ensure link state is U3 after settingUSB_SS_PORT_LS_U3Hans de Goede <[email protected]>
ASoC: Intel:bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tabletJiri Olsa <[email protected]>
perf/core: Disable page faults when getting phys addressFlorian Fainelli <[email protected]>
pwm: bcm2835: Dynamically allocate baseGeert Uytterhoeven <[email protected]>
pwm: renesas-tpu: Fix late Runtime PM enablementNicholas Piggin <[email protected]>
Revert "powerpc/64:irq_workavoid interrupt when called with hardware irqs
enabled"Evan Green <[email protected]>
loop: Better discard support for block devicesCornelia Huck <[email protected]>
s390/cio: avoid duplicated 'ADD' ueventsMauro Carvalho Chehab <[email protected]>
kconfig: qconf: Fix a few alignment issuesVasily Averin <[email protected]>
ipc/util.c:sysvipc_find_ipc()should increase position indexEric Biggers <[email protected]>
selftests: kmod: fix handling test numbers above 9Vasily Averin <[email protected]>
kernel/gcov/fs.c:gcov_seq_next()should increase position indexSagi Grimberg <[email protected]>
nvme: fix deadlock caused by ANA update wrong lockingHans de Goede <[email protected]>
ASoC: Intel: atom: Take the drv->lock mutex before calling
sst_send_slot_map()Wu Bo <[email protected]>
scsi: iscsi: Report unbind session event when the target has been removedGeert Uytterhoeven <[email protected]>
pwm: rcar: Fix late Runtime PM enablementYan, Zheng <[email protected]>
ceph: don't skip updating wanted caps when cap is staleQiujun Huang <[email protected]>
ceph: returnceph_mdsc_do_request()errors from__get_parent()James Smart <[email protected]>
scsi: lpfc: Fix crash in target side cable pulls hittingWAIT_FOR_UNREGJames Smart <[email protected]>
scsi: lpfc: Fix kasan slab-out-of-bounds error inlpfc_unreg_loginTero Kristo <[email protected]>
watchdog: resetlast_hw_keepalivetime at startCatalin Marinas <[email protected]>
arm64: Silence clang warning on mismatched value/register sizesJames Morse <[email protected]>
arm64: compat: Workaround Neoverse-N1 #1542419 for compat user-spaceJames Morse <[email protected]>
arm64: Fake the IminLine size on systems affected by Neoverse-N1 #1542419James Morse <[email protected]>
arm64: errata: Hide CTR_EL0.DIC on systems affected by Neoverse-N1
#1542419Marc Zyngier <[email protected]>
arm64: Add part number for Neoverse N1Jeremy Sowden <[email protected]>
vti4: removed duplicate log message.Wei Yongjun <[email protected]>
crypto: mxs-dcp - make symbols 'sha1_null_hash' and 'sha256_null_hash'
staticMartin KaFai Lau <[email protected]>
bpftool: Fix printing incorrect pointer inbtf_dump_ptrRob Clark <[email protected]>
drm/msm: Use the correctdma_synccalls harderDmitry Monakhov <[email protected]>
ext4: fixextent_statusfragmentation for plain files-------------
Diffstat:
Documentation/arm64/silicon-errata.txt | 1 + Makefile | 4 +- arch/arm/mach-imx/Makefile | 2 + arch/arm64/Kconfig | 16 +++ arch/arm64/include/asm/cache.h | 3 +- arch/arm64/include/asm/cpucaps.h | 3 +- arch/arm64/include/asm/cputype.h | 2 + arch/arm64/kernel/cpu_errata.c | 22 +++ arch/arm64/kernel/sys_compat.c | 11 ++ arch/arm64/kernel/traps.c | 9 ++ arch/powerpc/kernel/setup_64.c | 2 + arch/powerpc/kernel/time.c | 44 ++---- arch/s390/kvm/kvm-s390.c | 3 + arch/s390/lib/uaccess.c | 4 + arch/s390/mm/pgalloc.c | 16 ++- arch/x86/include/asm/kvm_host.h | 4 +- arch/x86/kvm/vmx.c | 27 ++-- arch/x86/kvm/x86.c | 66 +++++---- drivers/block/loop.c | 42 ++++-- drivers/block/virtio_blk.c | 9 +- drivers/char/tpm/tpm_ibmvtpm.c | 136 ++++++++++--------- drivers/char/tpm/tpm_tis_core.c | 8 +- drivers/crypto/mxs-dcp.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 23 ++++ drivers/gpu/drm/msm/msm_gem.c | 4 +- drivers/iio/adc/stm32-adc.c | 31 ++++- drivers/iio/adc/xilinx-xadc-core.c | 95 ++++++++++--- drivers/iio/common/st_sensors/st_sensors_core.c | 2 +- drivers/infiniband/core/addr.c | 7 +- drivers/infiniband/sw/rxe/rxe_net.c | 8 +- drivers/net/dsa/b53/b53_common.c | 37 ++++- drivers/net/dsa/b53/b53_regs.h | 8 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 3 + drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 27 +++- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 27 +--- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 3 + drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 11 +- .../mellanox/mlxsw/core_acl_flex_actions.c | 4 +- .../ethernet/mellanox/mlxsw/spectrum2_acl_tcam.c | 4 +- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 3 +- .../net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c | 4 +- .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 1 + drivers/net/geneve.c | 4 +- drivers/net/macsec.c | 12 +- drivers/net/macvlan.c | 2 +- drivers/net/team/team.c | 4 + drivers/net/vrf.c | 10 +- drivers/net/vxlan.c | 8 +- drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 9 ++ drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 3 + drivers/nvme/host/multipath.c | 4 +- drivers/pci/pcie/aspm.c | 18 ++- drivers/pwm/pwm-bcm2835.c | 1 + drivers/pwm/pwm-rcar.c | 10 +- drivers/pwm/pwm-renesas-tpu.c | 9 +- drivers/s390/cio/device.c | 13 +- drivers/scsi/lpfc/lpfc_nvme.c | 14 +- drivers/scsi/lpfc/lpfc_sli.c | 2 + drivers/scsi/scsi_transport_iscsi.c | 4 +- drivers/scsi/smartpqi/smartpqi_sas_transport.c | 2 +- drivers/staging/comedi/comedi_fops.c | 4 +- drivers/staging/comedi/drivers/dt2815.c | 3 + drivers/staging/vt6656/int.c | 3 +- drivers/staging/vt6656/key.c | 14 +- drivers/staging/vt6656/main_usb.c | 31 +++-- drivers/tty/hvc/hvc_console.c | 23 ++-- drivers/tty/rocket.c | 25 ++-- drivers/tty/serial/sh-sci.c | 13 +- drivers/tty/vt/vt.c | 7 +- drivers/usb/class/cdc-acm.c | 36 ++++- drivers/usb/class/cdc-acm.h | 5 +- drivers/usb/core/hub.c | 14 ++ drivers/usb/core/message.c | 9 +- drivers/usb/core/quirks.c | 4 + drivers/usb/dwc3/gadget.c | 12 +- drivers/usb/early/xhci-dbc.c | 8 +- drivers/usb/early/xhci-dbc.h | 18 ++- drivers/usb/gadget/function/f_fs.c | 4 + drivers/usb/host/xhci-hub.c | 20 ++- drivers/usb/misc/sisusbvga/sisusb.c | 20 +-- drivers/usb/misc/sisusbvga/sisusb_init.h | 14 +- drivers/usb/storage/uas.c | 46 ++++++- drivers/usb/storage/unusual_devs.h | 7 + drivers/watchdog/watchdog_dev.c | 1 + fs/ceph/caps.c | 8 +- fs/ceph/export.c | 5 + fs/ext4/extents.c | 47 ++++--- fs/f2fs/xattr.c | 15 ++- fs/namespace.c | 2 +- fs/proc/vmcore.c | 5 +- fs/xfs/xfs_inode.c | 85 ++++++------ include/linux/blkdev.h | 2 +- include/linux/blktrace_api.h | 18 ++- include/linux/iio/iio.h | 2 +- include/linux/kvm_host.h | 35 ++++- include/linux/kvm_types.h | 9 +- include/linux/vmalloc.h | 2 +- include/net/addrconf.h | 6 +- include/net/ipv6.h | 2 +- include/net/tcp.h | 2 +- ipc/util.c | 2 +- kernel/audit.c | 3 + kernel/events/core.c | 9 +- kernel/gcov/fs.c | 2 +- kernel/trace/blktrace.c | 117 +++++++++++----- mm/hugetlb.c | 14 +- mm/ksm.c | 12 +- mm/vmalloc.c | 16 ++- net/dccp/ipv6.c | 6 +- net/ipv4/ip_vti.c | 4 +- net/ipv4/xfrm4_output.c | 2 - net/ipv6/addrconf_core.c | 11 +- net/ipv6/af_inet6.c | 4 +- net/ipv6/datagram.c | 2 +- net/ipv6/inet6_connection_sock.c | 4 +- net/ipv6/ip6_output.c | 8 +- net/ipv6/ipv6_sockglue.c | 13 +- net/ipv6/raw.c | 2 +- net/ipv6/syncookies.c | 2 +- net/ipv6/tcp_ipv6.c | 4 +- net/ipv6/xfrm6_output.c | 2 - net/l2tp/l2tp_ip6.c | 2 +- net/mpls/af_mpls.c | 7 +- net/netrom/nr_route.c | 1 + net/sched/sch_etf.c | 7 +- net/sctp/ipv6.c | 4 +- net/tipc/udp_media.c | 9 +- net/x25/x25_dev.c | 4 +- samples/vfio-mdev/mdpy.c | 2 +- scripts/kconfig/qconf.cc | 13 +- security/keys/internal.h | 12 ++ security/keys/keyctl.c | 58 +++++--- sound/pci/hda/hda_intel.c | 1 - sound/pci/hda/patch_realtek.c | 11 +- sound/soc/intel/atom/sst-atom-controls.c | 2 + sound/soc/intel/boards/bytcr_rt5640.c | 11 ++ sound/soc/soc-dapm.c | 20 ++- sound/usb/format.c | 52 +++++++ sound/usb/mixer.c | 37 ++++- sound/usb/mixer.h | 10 ++ sound/usb/mixer_maps.c | 37 ++++- sound/usb/mixer_quirks.c | 12 +- sound/usb/quirks-table.h | 14 ++ sound/usb/usx2y/usbusx2yaudio.c | 2 + tools/bpf/bpftool/btf_dumper.c | 2 +- tools/testing/selftests/ftrace/settings | 1 + tools/testing/selftests/kmod/kmod.sh | 13 +- tools/vm/Makefile | 2 + virt/kvm/kvm_main.c | 149 ++++++++++++++++++++- 149 files changed, 1591 insertions(+), 598 deletions(-)
Jon Hunter
maintainerQuoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.119 release. There are 131 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 30 Apr 2020 18:20:45 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.119-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
All tests are passing for Tegra ...
Test results for stable-v4.19:
11 builds: 11 pass, 0 fail
22 boots: 22 pass, 0 fail
32 tests: 32 pass, 0 failLinux version: 4.19.119-rc1-g3fc812d65db6
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04Cheers
Jon
Signature · 1 line
nvpublic
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.119 release. There are 131 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 30 Apr 2020 18:20:45 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.119-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 4.19.119-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.19.y
git commit: 3fc812d65db6b5ad19f0ef548492a25ba2a276bc
git describe: v4.19.118-132-g3fc812d65db6b
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.118-132-g3fc812d65db6b
No regressions (compared to build v4.19.118)
No fixes (compared to build v4.19.118)
Ran 32114 total tests in the following environments and test suites.
Environmnts
--------------
- dragonboard-410c
- hi6220-hikey
- i386
- juno-r2
- juno-r2-compat
- juno-r2-kasan
- nxp-ls2088
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15
- x86
- x86-kasan
Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* kselftest/drivers
* kselftest/filesystems
* libgpiod
* linux-log-parser
* perf
* network-basic-tests
* kselftest/net
* kselftest/networking
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* spectre-meltdown-checker-test
* v4l2-compliance
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-native/drivers
* kselftest-vsyscall-mode-native/filesystems
* kselftest-vsyscall-mode-native/net
* kselftest-vsyscall-mode-native/networking
* kselftest-vsyscall-mode-none
* kselftest-vsyscall-mode-none/drivers
* kselftest-vsyscall-mode-none/filesystems
* kselftest-vsyscall-mode-none/net
* kselftest-vsyscall-mode-none/networking
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.119 release. There are 131 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 30 Apr 2020 18:20:45 +0000. Anything received after that time might be too late.
Build results:
total: 155 pass: 155 fail: 0 Qemu test results: total: 418 pass: 418 fail: 0
Guenter