Skip to contentSkip to conversation

svm: Fix nmi hlt test to fail test correctly

PATCH Applied Cathy Avery 2 participants 2 messages Apr 28, 2020 – May 4, 2020 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 svm: Fix nmi hlt test to fail test correctly

The last test does not return vmmcall on fail resulting in passing the entire test.

---
 x86/svm_tests.c | 1 +
 1 file changed, 1 insertion(+)
x86/svm_tests.c +1 -0
index 2b84e4d..65008ba 100644
@@ -1480,6 +1480,7 @@ static void nmi_hlt_test(struct svm_test *test)
     if (!nmi_fired) {
         report(nmi_fired, "intercepted pending NMI not dispatched");
         set_test_stage(test, -1);
+        vmmcall();
     }
 
     set_test_stage(test, 3);
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw
Quoted 14 lines · Cathy Avery

The last test does not return vmmcall on fail resulting in passing the entire test.

---
 x86/svm_tests.c | 1 +
 1 file changed, 1 insertion(+)
x86/svm_tests.c +0 -0
index 2b84e4d..65008ba 100644

x86/svm_tests.c static void nmi_hlt_test(struct svm_test *test) · line 1486

Quoted 7 lines
x86/svm_tests.c +1 -0
@@ -1480,6 +1480,7 @@ static void nmi_hlt_test(struct svm_test *test)
     if (!nmi_fired) {
         report(nmi_fired, "intercepted pending NMI not dispatched");
         set_test_stage(test, -1);
+        vmmcall();
     }
 
     set_test_stage(test, 3);

Queued, thanks.

Paolo