devlink: add support for DEVLINK_CMD_REGION_NEW
Subsystems (2)
PATCH v3 1/1 devlink: add support for DEVLINK_CMD_REGION_NEW
Add support to request that a new snapshot be taken immediately for a devlink region. To avoid confusion, the desired snapshot id must be provided.
Note that if a region does not support snapshots on demand, the kernel will reject the request with -EOPNOTSUP.
--- devlink/devlink.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
devlink/devlink.c +20 -0
@@ -6362,10 +6362,27 @@ static int cmd_region_read(struct dl *dl)return err; } +static int cmd_region_snapshot_new (struct dl *dl) +{ +struct nlmsghdr *nlh; +int err; + + nlh =mnlg_msg_prepare (dl->nlg,DEVLINK_CMD_REGION_NEW , +NLM_F_REQUEST |NLM_F_ACK ); + + err =dl_argv_parse_put (nlh, dl,DL_OPT_HANDLE_REGION | +DL_OPT_REGION_SNAPSHOT_ID ,0 ); +if (err) +return err; + +return _mnlg_socket_sndrcv (dl->nlg, nlh,NULL ,NULL ); +} +static void cmd_region_help (void ) {pr_err ("Usage: devlink region show [ DEV/REGION ]\n" );pr_err (" devlink region del DEV/REGION snapshot SNAPSHOT_ID\n" ); +pr_err (" devlink region new DEV/REGION snapshot SNAPSHOT_ID\n" );pr_err (" devlink region dump DEV/REGION [ snapshot SNAPSHOT_ID ]\n" );pr_err (" devlink region read DEV/REGION [ snapshot SNAPSHOT_ID ] address ADDRESS length LENGTH\n" ); }
@@ -6389,6 +6406,9 @@ static int cmd_region(struct dl *dl) }else if (dl_argv_match (dl,"read" )) {dl_arg_inc (dl);return cmd_region_read (dl); + }else if (dl_argv_match (dl,"new" )) { +dl_arg_inc (dl); +return cmd_region_snapshot_new (dl); }pr_err ("Command \"%s\" not found\n" ,dl_argv (dl));return -ENOENT ;
Signature · 1 line
2.25.2
Jakub Kicinski
maintainerQuoted 8 lines · On Tue, 28 Apr 2020 13:43:24 -0700 Jacob Keller wrote:
Add support to request that a new snapshot be taken immediately for a devlink region. To avoid confusion, the desired snapshot id must be provided.
Note that if a region does not support snapshots on demand, the kernel will reject the request with
-EOPNOTSUP.Signed-off-by Jacob Keller <[email protected]>
Quoted 8 lines · Tue, Apr 28, 2020 at 10:43:24PM CEST, [email protected] wrote:
Add support to request that a new snapshot be taken immediately for a devlink region. To avoid confusion, the desired snapshot id must be provided.
Note that if a region does not support snapshots on demand, the kernel will reject the request with
-EOPNOTSUP.Signed-off-by Jacob Keller <[email protected]>
Quoted 8 lines · On Tue, 28 Apr 2020 13:43:24 -0700 Jacob Keller <[email protected]>…
Add support to request that a new snapshot be taken immediately for a devlink region. To avoid confusion, the desired snapshot id must be provided.
Note that if a region does not support snapshots on demand, the kernel will reject the request with
-EOPNOTSUP.Signed-off-by Jacob Keller <[email protected]>
Looks good applied.