sun6i: dsi: fix gcc-4.8
PATCH 1/1 sun6i: dsi: fix gcc-4.8
Older compilers warn about initializers with incorrect curly braces:
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_enable':drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces around initializer [-Werror=missing-braces]
union phy_configure_opts opts = { 0 };
^drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: (near initialization for 'opts.mipi_dphy') [-Werror=missing-braces]
Use the GNU empty initializer extension to avoid this.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +1 -1
@@ -718,7 +718,7 @@ static void sun6i_dsi_encoder_enable(struct drm_encoder *encoder)struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;struct sun6i_dsi *dsi =encoder_to_sun6i_dsi (encoder);struct mipi_dsi_device *device = dsi->device; -union phy_configure_opts opts = {0 }; +union phy_configure_opts opts = { };struct phy_configure_opts_mipi_dphy *cfg = &opts.mipi_dphy;u16 delay;int err;
Signature · 6 lines
2.26.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 10 lines · Arnd Bergmann
Older compilers warn about initializers with incorrect curly braces:
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_enable':drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces around initializer [-Werror=missing-braces]union phy_configure_opts opts = { 0 }; ^
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: (near initialization for 'opts.mipi_dphy') [-Werror=missing-braces]Use the GNU empty initializer extension to avoid this.
Looks good to me:
But maybe use the drm/sun4i: dsi: prefix instead (granted, it wasn't used in the commit being fixed).
Cheers,
Paul
Quoted 22 lines
Fixes bb3b6fcb6849 ("sun6i: dsi: Convert to generic phy handling")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +1
-1@@ -718,7 +718,7 @@ static void sun6i_dsi_encoder_enable(struct drm_encoder *encoder)struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;struct sun6i_dsi *dsi =encoder_to_sun6i_dsi (encoder);struct mipi_dsi_device *device = dsi->device; -union phy_configure_opts opts = {0 }; +union phy_configure_opts opts = { };struct phy_configure_opts_mipi_dphy *cfg = &opts.mipi_dphy;u16 delay;int err;Signature · 1 line
2.26.0
Signature · 3 lines
Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Maxime Ripard
AppliedQuoted 5 lines · Arnd Bergmann
Older compilers warn about initializers with incorrect curly braces:
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_enable':drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces around initializer [-Werror=missing-braces]
Quoted 8 lines
union phy_configure_opts opts = { 0 }; ^
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: (near initialization for 'opts.mipi_dphy') [-Werror=missing-braces]Use the GNU empty initializer extension to avoid this.
Fixes bb3b6fcb6849 ("sun6i: dsi: Convert to generic phy handling")Signed-off-by Arnd Bergmann <[email protected]>
Applied, thanks!
Maxime