Skip to contentSkip to conversation

dm: core: Reorder include files in read.c

PATCH New Stefan Roese 2 participants 5 messages Apr 29, 2020 – May 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm: core: Reorder include files in read.c

Including the assembler headers before including common.h etc leads to compilation errors upon MIPS64 based platforms using OF_LIVE. This patch reorders the include files to the "correct" oder.

---
 drivers/core/read.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/core/read.c +3 -3
index 47b8e03446..8e65dd2d50 100644
@@ -4,12 +4,12 @@
  * Written by Simon Glass <[email protected]>
  */
 
-#include <asm/types.h>
-#include <asm/io.h>
 #include <common.h>
 #include <dm.h>
-#include <mapmem.h>
 #include <dm/of_access.h>
+#include <mapmem.h>
+#include <asm/types.h>
+#include <asm/io.h>
 
 int dev_read_u32(const struct udevice *dev, const char *propname, u32 *outp)
 {
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 dm: core: Reorder include files in read.c

Quoted 10 lines · Stefan Roese

Including the assembler headers before including common.h etc leads to compilation errors upon MIPS64 based platforms using OF_LIVE. This patch reorders the include files to the "correct" oder.

---
 drivers/core/read.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
#2 lore raw

PATCH 1/1 dm: core: Reorder include files in read.c

Hi Simon,

Quoted 6 lines · Simon Glass
Quoted 5 lines · Stefan Roese

Including the assembler headers before including common.h etc leads to compilation errors upon MIPS64 based platforms using OF_LIVE. This patch reorders the include files to the "correct" oder.

Quoted 8 lines
Quoted 5 lines
---
  drivers/core/read.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Just a short reminder about this patch, as its needed for the base Octeon (MIPS) support, I'm currently working on. Otherwise, usage of OF_LIVE is not possible.

Thanks,
Stefan

#3 lore raw

PATCH 1/1 dm: core: Reorder include files in read.c

Hi Stefan,

OK. Feel free to pull it in if you like as you have my review tag.

Regards,
SImon

Quoted 26 lines · Stefan Roese

Hi Simon,

Quoted 6 lines · Simon Glass
Quoted 5 lines · Stefan Roese

Including the assembler headers before including common.h etc leads to compilation errors upon MIPS64 based platforms using OF_LIVE. This patch reorders the include files to the "correct" oder.

Quoted 8 lines
Quoted 5 lines
---
  drivers/core/read.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Just a short reminder about this patch, as its needed for the base Octeon (MIPS) support, I'm currently working on. Otherwise, usage of OF_LIVE is not possible.

Thanks,
Stefan

#4 lore raw

PATCH 1/1 dm: core: Reorder include files in read.c

Hi Simon,

Quoted 1 line · Simon Glass

OK. Feel free to pull it in if you like as you have my review tag.

Thanks Simon. Since Daniel will be the one pulling the Octeon patchset once we've reached the necessary ack's, he now knows that he can pull this one as well. But this will take a few more versions most likely. Perhaps this patch has landed in mainline until then.

Thanks,
Stefan

Quoted 30 lines

Regards,
SImon

Quoted 26 lines · Stefan Roese

Hi Simon,

Quoted 6 lines · Simon Glass
Quoted 5 lines · Stefan Roese

Including the assembler headers before including common.h etc leads to compilation errors upon MIPS64 based platforms using OF_LIVE. This patch reorders the include files to the "correct" oder.

Quoted 8 lines
Quoted 5 lines
---
   drivers/core/read.c | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)

Just a short reminder about this patch, as its needed for the base Octeon (MIPS) support, I'm currently working on. Otherwise, usage of OF_LIVE is not possible.

Thanks,
Stefan

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de