video: cfb_console: Fix 64 bits support problem
PATCH 1/1 video: cfb_console: Fix 64 bits support problem
From: Ye Li <[email protected]>
There are some integer to pointer convert. To support 64 bits system, change the unsigned int to unsigned long.
Signed-off-by Ye Li <[email protected]>
Signed-off-by Peng Fan <[email protected]>
--- drivers/video/cfb_console.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/video/cfb_console.c +6 -6
@@ -1179,9 +1179,9 @@ static int display_rle8_bitmap(struct bmp_image *img, int xoff, int yoff, y =__le32_to_cpu (img->header.height) -1 ; ncolors =__le32_to_cpu (img->header.colors_used); bpp =VIDEO_PIXEL_SIZE ; - fbp = (unsigned char *) ((unsigned int ) video_fb_address + - (y + yoff) *VIDEO_LINE_LEN + - xoff * bpp); + fbp = (unsigned char *)((unsigned long )video_fb_address + + (y + yoff) *VIDEO_LINE_LEN + + xoff * bpp); bm = (uchar *) img +__le32_to_cpu (img->header.data_offset);
@@ -1234,7 +1234,7 @@ static int display_rle8_bitmap(struct bmp_image *img, int xoff, int yoff, x =0 ; y--; fbp = (unsigned char *) - ((unsigned int ) video_fb_address + + ((unsigned long )video_fb_address + (y + yoff) *VIDEO_LINE_LEN + xoff * bpp);continue ;
@@ -1247,7 +1247,7 @@ static int display_rle8_bitmap(struct bmp_image *img, int xoff, int yoff, x += bm[2 ]; y -= bm[3 ]; fbp = (unsigned char *) - ((unsigned int ) video_fb_address + + ((unsigned long )video_fb_address + (y + yoff) *VIDEO_LINE_LEN + xoff * bpp); bm +=4 ;
@@ -2026,7 +2026,7 @@ static int cfg_video_init(void)if (pGD ==NULL )return -1 ; - video_fb_address = (void *)VIDEO_FB_ADRS ; + video_fb_address = (void *)(unsigned long )VIDEO_FB_ADRS ; cfb_do_flush_cache =cfb_fb_is_in_dram () &&dcache_status ();
Signature · 1 line
2.16.4
PATCH 1/1 video: cfb_console: Fix 64 bits support problem
Hi Peng,
Quoted 4 lines · On Wed, 29 Apr 2020 11:45:14 +0800 Peng Fan peng.fan at nxp.com wrote:
From: Ye Li <[email protected]>
There are some integer to pointer convert. To support 64 bits system, change the unsigned int to unsigned long.
cfb_console is obsolete and shouldn't be used. Why are you not using DM_VIDEO based drivers (video-uclass/vidconsole-uclass)?
--
Anatolij