support/testing: add package/test_mender.py
PATCH 1/1 support/testing: add package/test_mender.py
Create a test to check Mender client at runtime.
The aim of this test is:
- to check the correct execution of simple Mender commands,
in a minimal environment;
- to validate there is no missing dependencies for runtime.
This test is not a board integration test for Mender, including well-configured bootloader, partitioning, ...
Check:
- the daemon is started;
- the current 'artifact name' (name of the image or update) of the active partition is read, without error.
For that, we need to fake (see the 'overlay' directory):
- some bootloader environment variables;
- the name of an update.
--- .gitlab-ci.yml | 1 + support/testing/tests/package/test_mender.py | 38 +++++++++++++++++++ .../rootfs-overlay/etc/mender/artifact_info | 1 + .../rootfs-overlay/usr/bin/fw_printenv | 6 +++ 4 files changed, 46 insertions(+) create mode 100644 support/testing/tests/package/test_mender.py create mode 100644 support/testing/tests/package/test_mender/rootfs-overlay/etc/mender/artifact_info create mode 100755 support/testing/tests/package/test_mender/rootfs-overlay/usr/bin/fw_printenv
.gitlab-ci.yml +1 -0
@@ -520,6 +520,7 @@ tests.package.test_rust.TestRustBin: { extends: .runtime_test } tests.package.test_syslog_ng.TestSyslogNg: { extends: .runtime_test } tests.package.test_tmux.TestTmux: { extends: .runtime_test } tests.package.test_turbolua.TestLuajitTurbolua: { extends: .runtime_test } +tests.package.test_mender.TestMender: { extends: .runtime_test } tests.toolchain.test_external.TestExternalToolchainBuildrootMusl: { extends: .runtime_test } tests.toolchain.test_external.TestExternalToolchainBuildrootuClibc: { extends: .runtime_test } tests.toolchain.test_external.TestExternalToolchainCCache: { extends: .runtime_test }
support/testing/tests/package/test_mender.py new file +38 -0
@@ -0,0 +1,38 @@ +import os + +import infra.basetest + + +class TestMender(infra.basetest.BRTest): + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ + """ + BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y + BR2_PACKAGE_MENDER=y + BR2_TARGET_ROOTFS_CPIO=y + BR2_ROOTFS_OVERLAY="{}" + """.format( + # overlay to add a fake 'fw_printenv', used by Mender + infra.filepath("tests/package/test_mender/rootfs-overlay")) + + def test_run(self): + cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") + self.emulator.boot(arch="armv5", + kernel="builtin", + options=["-initrd", cpio_file]) + self.emulator.login() + + # Check if the 'mender' binaries are correctly installed + self.assertRunOk("ls /usr/bin/mender") + self.assertRunOk("ls /etc/mender/mender.conf") + self.assertRunOk("ls /etc/init.d/S42mender") + + # Check if the Daemon is running + self.assertRunOk("ls /var/run/mender.pid") + self.assertRunOk("ps aux | egrep [m]ender") + + # Check if a simple Mender command is correctly executed + self.assertRunOk("mender -log-level debug -show-artifact") + self.assertRunOk("mender -log-level debug -show-artifact | grep 'RUNTIME_TEST_ARTIFACT_NAME'") + cmd = "mender -show-artifact 2>&1 | grep -i 'err'" # Check if no 'error' among the traces + _, exit_code = self.emulator.run(cmd) + self.assertEqual(exit_code, 1)
support/testing/tests/package/test_mender/rootfs-overlay/etc/mender/artifact_info new file +1 -0
@@ -0,0 +1 @@ +artifact_name=RUNTIME_TEST_ARTIFACT_NAME
support/testing/tests/package/test_mender/rootfs-overlay/usr/bin/fw_printenv new file +6 -0
@@ -0,0 +1,6 @@ +#!/bin/sh + +# Fake 'fw_printenv' because UBoot is not installed: print some plausible 'key-value' +echo "bootcount=0" +echo "mender_boot_part=rootfs" +echo "upgrade_available=0"
Signature · 1 line
2.20.1
PATCH 1/1 support/testing: add package/test_mender.py
Hello Mikael,
I'd be really interested to have some feedback from Angelo and/or Adam (who work with/use Mender).
support/testing/tests/package/test_mender.py line 9
Quoted 4 lines · On Wed, 29 Apr 2020 15:19:54 +0200 Mikael Bourhis-Cloarec…
support/testing/tests/package/test_mender.py new file +4
-0+class TestMender(infra.basetest.BRTest): + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ + """ + BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
Is this needed ?
Quoted 8 lines
support/testing/tests/package/test_mender.py new file +8
-0+ BR2_PACKAGE_MENDER=y + BR2_TARGET_ROOTFS_CPIO=y + BR2_ROOTFS_OVERLAY="{}" + """.format( + # overlay to add a fake 'fw_printenv', used by Mender + infra.filepath("tests/package/test_mender/rootfs-overlay")) + + def test_run(self):
support/testing/tests/package/test_mender.py line 27
Quoted 10 lines
support/testing/tests/package/test_mender.py new file +10
-0+ cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") + self.emulator.boot(arch="armv5", + kernel="builtin", + options=["-initrd", cpio_file]) + self.emulator.login() + + # Check if the 'mender' binaries are correctly installed + self.assertRunOk("ls /usr/bin/mender") + self.assertRunOk("ls /etc/mender/mender.conf") + self.assertRunOk("ls /etc/init.d/S42mender")
I am not sure these particular checks are really that useful. Checking that Mender is started and works is IMO enough.
So overall, I have pretty minor comments, the test looks good to me. It would obviously be nicer to have a more complete test, but this is much, much more difficult to implement.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com