Skip to contentSkip to conversation

i915/gem_sync:Corrected legacy Dynamic test case name

PATCH In review Arjun Melkaveri 4 participants 6 messages Apr 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i915/gem_sync:Corrected legacy Dynamic test case name

Test case for legacy and new engines is same, when listed out. adding "legacy" in front of test case name to differentiate it.

Cc Chris Wilson <[email protected]>
Cc Ursulin Tvrtko <[email protected]>
---
 tests/i915/gem_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/i915/gem_sync.c +1 -1
index b50ad4f2..fd200e50 100644
@@ -1189,7 +1189,7 @@ igt_main
 
 	/* Legacy for selecting rings. */
 	for_each_test(t, individual) {
-		igt_subtest_with_dynamic_f("%s", t->name) {
+		igt_subtest_with_dynamic_f("legacy-%s", t->name) {
 			for (const struct intel_execution_engine *l = intel_execution_engines; l->name; l++) {
 				igt_dynamic_f("%s", l->name) {
 					t->func(fd, eb_ring(l),
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

Quoting Arjun Melkaveri (2020-04-30 11:36:12)

Quoted 2 lines

Test case for legacy and new engines is same, when listed out. adding "legacy" in front of test case name to differentiate it.

Hmm, --run idle tests both, and --run idle -dyn rcs0 works, this would seem to be a _feature_.

But maybe Petri wants to be super strict for some reason or another. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by
#2 lore raw
Quoted 8 lines · Chris Wilson

Quoting Arjun Melkaveri (2020-04-30 11:36:12)

Quoted 2 lines

Test case for legacy and new engines is same, when listed out. adding "legacy" in front of test case name to differentiate it.

Hmm, --run idle tests both, and --run idle -dyn rcs0 works, this would seem to be a _feature_.

But maybe Petri wants to be super strict for some reason or another.

Tests both, but only one of them gets through to html.

Yes please,

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

Quoting Petri Latvala (2020-04-30 11:51:37)

Quoted 11 lines · Chris Wilson
Quoted 8 lines

Quoting Arjun Melkaveri (2020-04-30 11:36:12)

Quoted 2 lines

Test case for legacy and new engines is same, when listed out. adding "legacy" in front of test case name to differentiate it.

Hmm, --run idle tests both, and --run idle -dyn rcs0 works, this would seem to be a _feature_.

But maybe Petri wants to be super strict for some reason or another.

Tests both, but only one of them gets through to html.

And here I was hoping for some amalgamation in the presentation of results :)
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for i915/gem_sync:Corrected legacy Dynamic test case name

In reply to Arjun Melkaveri
== Series Details ==

== Series Details ==

Series: i915/gem_sync:Corrected legacy Dynamic test case name
URL : https://patchwork.freedesktop.org/series/76770/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8401 -> IGTPW_4519
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4519:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@debugfs_test@read_all_entries:
- fi-kbl-7500u: NOTRUN -> [{ABORT}][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/fi-kbl-7500u/igt@debugfs_test@read_all_entries.html

Known issues
------------

Here are the changes found in IGTPW_4519 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@i915_selftest@live@gem_contexts:
- fi-bwr-2160: [INCOMPLETE][2] ([i915#489]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/fi-bwr-2160/igt@i915_selftest@live@gem_contexts.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/fi-bwr-2160/igt@i915_selftest@live@gem_contexts.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489

Participating hosts (50 -> 41)
------------------------------

Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-x1275 fi-kbl-7560u fi-byt-clapper fi-bsw-nick

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5617 -> IGTPW_4519

CI-20190529: 20190529
CI_DRM_8401: 41fac0e3809be301af095c66e717eb9843b80212 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4519: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/index.html
IGT_5617: 807b26292a3f21057ef7865a4028d22c512590df @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Testlist changes ==

+igt@gem_sync@legacy-active
+igt@gem_sync@legacy-active-wakeup
+igt@gem_sync@legacy-default
+igt@gem_sync@legacy-double-wakeup
+igt@gem_sync@legacy-forked
+igt@gem_sync@legacy-forked-store
+igt@gem_sync@legacy-forked-switch
+igt@gem_sync@legacy-idle
+igt@gem_sync@legacy-many
+igt@gem_sync@legacy-store
+igt@gem_sync@legacy-switch
+igt@gem_sync@legacy-wakeup
-igt@gem_sync@active
-igt@gem_sync@active-wakeup
-igt@gem_sync@default
-igt@gem_sync@double-wakeup
-igt@gem_sync@forked
-igt@gem_sync@forked-store
-igt@gem_sync@forked-switch
-igt@gem_sync@idle
-igt@gem_sync@many
-igt@gem_sync@store
-igt@gem_sync@switch
-igt@gem_sync@wakeup

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for i915/gem_sync:Corrected legacy Dynamic test case name

In reply to Arjun Melkaveri
== Series Details ==

== Series Details ==

Series: i915/gem_sync:Corrected legacy Dynamic test case name
URL : https://patchwork.freedesktop.org/series/76770/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8401_full -> IGTPW_4519_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/index.html

Known issues
------------

Here are the changes found in IGTPW_4519_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-iclb3/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#54] / [i915#93] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl3/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#177] / [i915#52] / [i915#54])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-glk9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-glk4/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-ytiled:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#52] / [i915#54]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-glk4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-glk1/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled:
- shard-kbl: [PASS][11] -> [FAIL][12] ([fdo#108145] / [i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl6/igt@[email protected]
- shard-apl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [i915#52] / [i915#54] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl1/igt@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling:
- shard-apl: [PASS][15] -> [FAIL][16] ([i915#95]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl8/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#180] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-kbl: [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl2/igt@[email protected]
- shard-apl: [PASS][21] -> [FAIL][22] ([fdo#108145] / [i915#265] / [i915#95])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl7/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-kbl: [PASS][23] -> [FAIL][24] ([i915#1559] / [i915#93] / [i915#95])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl1/igt@[email protected]
- shard-apl: [PASS][25] -> [FAIL][26] ([i915#1559] / [i915#95])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl1/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109642] / [fdo#111068])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-iclb2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-iclb8/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-iclb2/igt@kms_psr@psr2_basic.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-iclb1/igt@kms_psr@psr2_basic.html

#### Possible fixes ####

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][31] ([i915#454]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-iclb4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen:
- shard-kbl: [FAIL][33] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][34] +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
- shard-glk: [FAIL][37] ([i915#52] / [i915#54]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-glk6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-glk1/igt@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@c-dp1}:
- shard-apl: [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl8/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-render:
- shard-glk: [FAIL][41] ([i915#49]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-render.html

* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- shard-apl: [FAIL][43] ([i915#1559] / [i915#95]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl1/igt@[email protected]
- shard-kbl: [FAIL][45] ([i915#1559] / [i915#93] / [i915#95]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl1/igt@[email protected]

* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][47] ([i915#173]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-iclb1/igt@kms_psr@no_drrs.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-iclb6/igt@kms_psr@no_drrs.html

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

#### Warnings ####

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][51] ([i915#95]) -> [FAIL][52] ([i915#1525] / [i915#95])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-apl8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-apl7/igt@[email protected]
- shard-kbl: [FAIL][53] ([i915#93] / [i915#95]) -> [FAIL][54] ([i915#64] / [i915#93] / [i915#95])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: [FAIL][55] ([fdo#108145] / [i915#265]) -> [FAIL][56] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8401/shard-kbl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/shard-kbl7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1525]: https://gitlab.freedesktop.org/drm/intel/issues/1525
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5617 -> IGTPW_4519
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_8401: 41fac0e3809be301af095c66e717eb9843b80212 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4519: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/index.html
IGT_5617: 807b26292a3f21057ef7865a4028d22c512590df @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4519/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev