x86: Add an indication of 32/64-bit to bdinfo
PATCH v4 6/7 x86: Add an indication of 32/64-bit to bdinfo
It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.
---
Changes in v4:
- Fix signed/unsigned mismatch in printf()
Changes in v3:
- Show bit width for all archs, use sizeof(void *)
Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo
cmd/bdinfo.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
cmd/bdinfo.c +20 -0
@@ -15,6 +15,11 @@DECLARE_GLOBAL_DATA_PTR ; +__maybe_unused void print_cpu_word_size (void ) +{ +printf ("%-12s= %u-bit\n" ,"Build" , (uint )sizeof (void *) *8 ); +} +__maybe_unused static void print_num (const char *name,ulong value) {
@@ -208,6 +213,8 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_baudrate ();print_num ("relocaddr" , gd->relocaddr);board_detail (); +print_cpu_word_size (); +return 0 ; }
@@ -227,6 +234,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }
@@ -252,6 +260,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_num ("fdt_blob" , (ulong )gd->fdt_blob);print_num ("new_fdt" , (ulong )gd->new_fdt);print_num ("fdt_size" , (ulong )gd->fdt_size); +print_cpu_word_size ();return 0 ; }
@@ -283,6 +292,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#endif print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }
@@ -294,6 +304,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_std_bdinfo (gd->bd);print_num ("relocaddr" , gd->relocaddr);print_num ("reloc off" , gd->reloc_off); +print_cpu_word_size ();return 0 ; }
@@ -354,6 +365,7 @@ static int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc,#endif if (gd->fdt_blob)print_num ("fdt_blob" , (ulong )gd->fdt_blob); +print_cpu_word_size ();return 0 ; }
@@ -368,6 +380,8 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_bi_flash (bd);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size (); +return 0 ; }
@@ -388,6 +402,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_mhz ("ethspeed" , bd->bi_ethspeed);#endif print_baudrate (); +print_cpu_word_size ();return 0 ; }
@@ -405,6 +420,8 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_LCD ) || defined(CONFIG_VIDEO )print_num ("FB base " , gd->fb_base);#endif +print_cpu_word_size (); +return 0 ; }
@@ -419,6 +436,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_bi_dram (bd);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }
@@ -435,6 +453,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_num ("reloc off" , gd->reloc_off);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }
@@ -448,6 +467,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_bi_mem (bd);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }
Signature · 1 line
2.26.2.526.g744177e7f7-goog
PATCH v4 6/7 x86: Add an indication of 32/64-bit to bdinfo
Quoted 5 lines · Simon Glass
It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.
Signed-off-by Simon Glass <[email protected]>Suggested-by Mark Kettenis <[email protected]>
Quoted 130 lines
---
Changes in v4:
- Fix signed/unsigned mismatch inprintf()Changes in v3:
- Show bit width for all archs, usesizeof(void *)Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfocmd/bdinfo.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)cmd/bdinfo.c +20
-0@@ -15,6 +15,11 @@DECLARE_GLOBAL_DATA_PTR ; +__maybe_unused void print_cpu_word_size (void ) +{ +printf ("%-12s= %u-bit\n" ,"Build" , (uint )sizeof (void *) *8 ); +} +__maybe_unused static void print_num (const char *name,ulong value) {@@ -208,6 +213,8 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_baudrate ();print_num ("relocaddr" , gd->relocaddr);board_detail (); +print_cpu_word_size (); +return 0 ; }@@ -227,6 +234,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }@@ -252,6 +260,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_num ("fdt_blob" , (ulong )gd->fdt_blob);print_num ("new_fdt" , (ulong )gd->new_fdt);print_num ("fdt_size" , (ulong )gd->fdt_size); +print_cpu_word_size ();return 0 ; }@@ -283,6 +292,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#endif print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }@@ -294,6 +304,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_std_bdinfo (gd->bd);print_num ("relocaddr" , gd->relocaddr);print_num ("reloc off" , gd->reloc_off); +print_cpu_word_size ();return 0 ; }@@ -354,6 +365,7 @@ static int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc,#endif if (gd->fdt_blob)print_num ("fdt_blob" , (ulong )gd->fdt_blob); +print_cpu_word_size ();return 0 ; }@@ -368,6 +380,8 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_bi_flash (bd);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size (); +return 0 ; }@@ -388,6 +402,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_mhz ("ethspeed" , bd->bi_ethspeed);#endif print_baudrate (); +print_cpu_word_size ();return 0 ; }@@ -405,6 +420,8 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_LCD ) || defined(CONFIG_VIDEO )print_num ("FB base " , gd->fb_base);#endif +print_cpu_word_size (); +return 0 ; }@@ -419,6 +436,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_bi_dram (bd);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }@@ -435,6 +453,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_num ("reloc off" , gd->reloc_off);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }@@ -448,6 +467,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_bi_mem (bd);print_eth_ip_addr ();print_baudrate (); +print_cpu_word_size ();return 0 ; }
PATCH v4 6/7 x86: Add an indication of 32/64-bit to bdinfo
Quoted 24 lines · Heinrich Schuchardt
Quoted 5 lines · Simon Glass
It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.
Signed-off-by Simon Glass <[email protected]>Suggested-by Mark Kettenis <[email protected]>Reviewed-by Heinrich Schuchardt <[email protected]>Quoted 14 lines
---
Changes in v4:
- Fix signed/unsigned mismatch inprintf()Changes in v3:
- Show bit width for all archs, usesizeof(void *)Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfocmd/bdinfo.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
PATCH v4 6/7 x86: Add an indication of 32/64-bit to bdinfo
Quoted 23 lines · Bin Meng
Quoted 21 lines · Heinrich Schuchardt
Quoted 5 lines · Simon Glass
It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.
Signed-off-by Simon Glass <[email protected]>Suggested-by Mark Kettenis <[email protected]>Reviewed-by Heinrich Schuchardt <[email protected]>Quoted 11 lines
---
Changes in v4:
- Fix signed/unsigned mismatch inprintf()Changes in v3:
- Show bit width for all archs, usesizeof(void *)Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
cmd/bdinfo.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)Reviewed-by Bin Meng <[email protected]>Tested-by Bin Meng <[email protected]>
applied to u-boot-x86, thanks!