Skip to contentSkip to conversation

drivers/iommu: properly export iommu_group_get_for_dev

PATCH In review Greg Kroah-Hartman 3 participants 5 messages Apr 30, 2020 – May 1, 2020 IOMMU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/iommu: properly export iommu_group_get_for_dev

In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers") a bunch of iommu symbols were exported, all with _GPL markings except iommu_group_get_for_dev(). That export should also be _GPL like the others.

Cc Will Deacon <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc John Garry <[email protected]>
Fixes a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
---
 drivers/iommu/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/iommu.c +1 -1
index 2b471419e26c..1ecbc8788fe7 100644
@@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
 
 	return group;
 }
-EXPORT_SYMBOL(iommu_group_get_for_dev);
+EXPORT_SYMBOL_GPL(iommu_group_get_for_dev);
 
 struct iommu_domain *iommu_group_default_domain(struct iommu_group *group)
 {
Signature · 1 line
2.26.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 19 lines · Greg Kroah-Hartman

In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers") a bunch of iommu symbols were exported, all with _GPL markings except iommu_group_get_for_dev(). That export should also be _GPL like the others.

Cc Will Deacon <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc John Garry <[email protected]>
Fixes a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
---
 drivers/iommu/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/iommu.c +0 -0
index 2b471419e26c..1ecbc8788fe7 100644

drivers/iommu/iommu.c struct iommu_group *iommu_group_get_for_dev(struct device *dev) · line 1434

Quoted 8 lines
drivers/iommu/iommu.c +1 -1
@@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
 
 	return group;
 }
-EXPORT_SYMBOL(iommu_group_get_for_dev);
+EXPORT_SYMBOL_GPL(iommu_group_get_for_dev);
 
 struct iommu_domain *iommu_group_default_domain(struct iommu_group *group)
 {

Thanks, not sure how I managed to screw this up in the original patch!

Joerg -- can you pick this one up please?

Cheers,

Will

maintainer
#2 lore raw
Quoted 5 lines · Will Deacon

Thanks, not sure how I managed to screw this up in the original patch!

Joerg -- can you pick this one up please?

Yes, will send it as a fix for 5.7, but note that this function will be unexported in 5.8.

Regards,

Joerg

maintainer
#3 lore raw
Quoted 9 lines · Joerg Roedel
Quoted 5 lines · Will Deacon

Thanks, not sure how I managed to screw this up in the original patch!

Joerg -- can you pick this one up please?

Yes, will send it as a fix for 5.7, but note that this function will be unexported in 5.8.

Thanks, Joerg.

Will

maintainer
#4 lore raw
In reply to Greg Kroah-Hartman
Quoted 5 lines · Greg Kroah-Hartman

In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers") a bunch of iommu symbols were exported, all with _GPL markings except iommu_group_get_for_dev(). That export should also be _GPL like the others.

Quoted 8 lines
Cc Will Deacon <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc John Garry <[email protected]>
Fixes a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
---
 drivers/iommu/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied for v5.7, thanks.

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu