Skip to contentSkip to conversation

hsdk/linux: backporting patch enabling CONFIG_USB

PATCH New Evgeniy Didin 2 participants 2 messages Apr 30, 2020 – May 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hsdk/linux: backporting patch enabling CONFIG_USB

With this commit we backporting critical Linux kernel patch which enables CONFIG_USB option for HSDK.

Cc Thomas Petazzoni <[email protected]>
Cc Eugeniy Paltsev <[email protected]>
Cc arc-buildroot at synopsys.com
---
 .../0001-ARC-plat-hsdk-fix-USB-regression.patch    | 39 ++++++++++++++++++++++
 configs/snps_archs38_hsdk_defconfig                |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 board/synopsys/hsdk/linux_patches/0001-ARC-plat-hsdk-fix-USB-regression.patch
board/synopsys/hsdk/linux_patches/0001-ARC-plat-hsdk-fix-USB-regression.patch new file +39 -0
new file mode 100644
index 0000000000..882d2c61df
@@ -0,0 +1,39 @@
+From 4c13ca86dcf80a8c705b1f3674ff43d318e970e0 Mon Sep 17 00:00:00 2001
+From: Eugeniy Paltsev <[email protected]>
+Date: Tue, 7 Apr 2020 23:06:42 +0300
+Subject: ARC: [plat-hsdk]: fix USB regression
+
+As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
+as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
+in its kconfig.
+The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
+reverse the dependencies between UDL and USB so UDL now depends on
+CONFIG_USB and not selects it. This introduces regression for ARC HSDK
+board as HSDK defconfig wasn't adjusted and now it misses USB support
+due to lack of CONFIG_USB enabled.
+
+Fix that.
+
+Cc: <[email protected]> # 5.6.x
+Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
+Signed-off-by: Eugeniy Paltsev <[email protected]>
+Signed-off-by: Vineet Gupta <[email protected]>
+---
+ arch/arc/configs/hsdk_defconfig | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
+index 0974226fab55..aa000075a575 100644
+--- a/arch/arc/configs/hsdk_defconfig
++++ b/arch/arc/configs/hsdk_defconfig
+@@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
+ CONFIG_DRM_ETNAVIV=y
+ CONFIG_FB=y
+ CONFIG_FRAMEBUFFER_CONSOLE=y
++CONFIG_USB=y
+ CONFIG_USB_EHCI_HCD=y
+ CONFIG_USB_EHCI_HCD_PLATFORM=y
+ CONFIG_USB_OHCI_HCD=y
+-- 
+cgit 1.2-0.3.lf.el7
+
configs/snps_archs38_hsdk_defconfig +1 -0
index af7cba6c2e..4a002cd69f 100644
@@ -14,6 +14,7 @@ BR2_SYSTEM_DHCP="eth0"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.6.3"
+BR2_LINUX_KERNEL_PATCH="board/synopsys/hsdk/linux_patches"
 BR2_LINUX_KERNEL_DEFCONFIG="hsdk"
 BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/synopsys/hsdk/linux.fragment"
 
Signature · 1 line
2.16.2
#1 lore raw

PATCH 1/1 hsdk/linux: backporting patch enabling CONFIG_USB

Evgeniy, All,

On 2020-04-30 19:37 +0300, Evgeniy Didin spake thusly:

Quoted 63 lines

With this commit we backporting critical Linux kernel patch which enables CONFIG_USB option for HSDK.

Cc Thomas Petazzoni <[email protected]>
Cc Eugeniy Paltsev <[email protected]>
Cc arc-buildroot at synopsys.com
---
 .../0001-ARC-plat-hsdk-fix-USB-regression.patch    | 39 ++++++++++++++++++++++
 configs/snps_archs38_hsdk_defconfig                |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 board/synopsys/hsdk/linux_patches/0001-ARC-plat-hsdk-fix-USB-regression.patch
board/synopsys/hsdk/linux_patches/0001-ARC-plat-hsdk-fix-USB-regression.patch new file +39 -0
new file mode 100644
index 0000000000..882d2c61df
@@ -0,0 +1,39 @@
+From 4c13ca86dcf80a8c705b1f3674ff43d318e970e0 Mon Sep 17 00:00:00 2001
+From: Eugeniy Paltsev <[email protected]>
+Date: Tue, 7 Apr 2020 23:06:42 +0300
+Subject: ARC: [plat-hsdk]: fix USB regression
+
+As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
+as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
+in its kconfig.
+The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
+reverse the dependencies between UDL and USB so UDL now depends on
+CONFIG_USB and not selects it. This introduces regression for ARC HSDK
+board as HSDK defconfig wasn't adjusted and now it misses USB support
+due to lack of CONFIG_USB enabled.
+
+Fix that.
+
+Cc: <[email protected]> # 5.6.x
+Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
+Signed-off-by: Eugeniy Paltsev <[email protected]>
+Signed-off-by: Vineet Gupta <[email protected]>
+---
+ arch/arc/configs/hsdk_defconfig | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
+index 0974226fab55..aa000075a575 100644
+--- a/arch/arc/configs/hsdk_defconfig
++++ b/arch/arc/configs/hsdk_defconfig
+@@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
+ CONFIG_DRM_ETNAVIV=y
+ CONFIG_FB=y
+ CONFIG_FRAMEBUFFER_CONSOLE=y
++CONFIG_USB=y
+ CONFIG_USB_EHCI_HCD=y
+ CONFIG_USB_EHCI_HCD_PLATFORM=y
+ CONFIG_USB_OHCI_HCD=y
+-- 
+cgit 1.2-0.3.lf.el7
+
configs/snps_archs38_hsdk_defconfig +0 -0
index af7cba6c2e..4a002cd69f 100644

configs/snps_archs38_hsdk_defconfig BR2_SYSTEM_DHCP="eth0" · line 19

Quoted 6 lines
configs/snps_archs38_hsdk_defconfig +1 -0
@@ -14,6 +14,7 @@ BR2_SYSTEM_DHCP="eth0"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.6.3"
+BR2_LINUX_KERNEL_PATCH="board/synopsys/hsdk/linux_patches"
 BR2_LINUX_KERNEL_DEFCONFIG="hsdk"
 BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/synopsys/hsdk/linux.fragment"

Why don't you simply add CONFIG_USB=y to the fragment instead?

Regards,
Yann E. MORIN.

Quoted 8 lines
Signature · 7 lines
-- 
2.16.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'