Skip to contentSkip to conversation

Bluetooth: Fix advertising handle is set to 0

PATCH In review Tedd Ho-Jeong An 2 participants 2 messages May 1, 2020

Subsystems (2)
Bluetooth drivers Bluetooth
lore
Share & tools
lore

Tedd Ho-Jeong An

author
#0 lore raw

PATCH v2 1/1 Bluetooth: Fix advertising handle is set to 0

From: Tedd Ho-Jeong An <[email protected]>

This patch fix the advertising handle is set to 0 regardless of actual instance value. The affected commands are LE Set Advertising Set Random Address, LE Set Extended Advertising Data, and LE Set Extended Scan Response Data commands.

Signed-off-by Tedd Ho-Jeong An <[email protected]>
---
 net/bluetooth/hci_request.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
net/bluetooth/hci_request.c +3 -3
index 9ea40106ef17..3f470f0e432c 100644
@@ -1447,7 +1447,7 @@ void __hci_req_update_scan_rsp_data(struct hci_request *req, u8 instance)
 		memcpy(hdev->scan_rsp_data, cp.data, sizeof(cp.data));
 		hdev->scan_rsp_data_len = len;
 
-		cp.handle = 0;
+		cp.handle = instance;
 		cp.length = len;
 		cp.operation = LE_SET_ADV_DATA_OP_COMPLETE;
 		cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG;

@@ -1591,7 +1591,7 @@ void __hci_req_update_adv_data(struct hci_request *req, u8 instance)
 		hdev->adv_data_len = len;
 
 		cp.length = len;
-		cp.handle = 0;
+		cp.handle = instance;
 		cp.operation = LE_SET_ADV_DATA_OP_COMPLETE;
 		cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG;
 

@@ -1876,7 +1876,7 @@ int __hci_req_setup_ext_adv_instance(struct hci_request *req, u8 instance)
 
 		memset(&cp, 0, sizeof(cp));
 
-		cp.handle = 0;
+		cp.handle = instance;
 		bacpy(&cp.bdaddr, &random_addr);
 
 		hci_req_add(req,
Signature · 1 line
2.25.4
maintainer
#1 lore raw

Hi Tedd,

Quoted 9 lines

This patch fix the advertising handle is set to 0 regardless of actual instance value. The affected commands are LE Set Advertising Set Random Address, LE Set Extended Advertising Data, and LE Set Extended Scan Response Data commands.

Signed-off-by Tedd Ho-Jeong An <[email protected]>

---
net/bluetooth/hci_request.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel