PCI/ERR: Allow Native AER/DPC using _OSC
Subsystems (2)
v3 cover PCI/ERR: Allow Native AER/DPC using _OSC
Hi Bjorn & Kuppuswamy,
I see a problem in the DPC ECN [1] to _OSC in that it doesn't give us a way to determine if firmware supports _OSC DPC negotation, and therefore how to handle DPC.
Here is the wording of the ECN that implies that Firmware without _OSC DPC negotiation support should have the OSPM rely on _OSC AER negotiation when determining DPC control:
PCIe Base Specification suggests that Downstream Port Containment may be controlled either by the Firmware or the Operating System. It also suggests that the Firmware retain ownership of Downstream Port Containment if it also owns AER. When the Firmware owns Downstream Port Containment, it is expected to use the new "Error Disconnect Recover" notification to alert OSPM of a Downstream Port Containment event.
In legacy platforms, as bits in _OSC are reserved prior to implementation, ACPI Root Bus enumeration will mark these Host Bridges as without Native DPC support, even though the specification implies it's expected that AER _OSC negotiation determines DPC control for these platforms. There seems to be a need for a way to determine if the DPC control bit in _OSC is supported and fallback on AER otherwise.
Currently portdrv assumes DPC control if the port has Native AER services:
static int get_port_device_capability(struct pci_dev *dev)
...
if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && pci_aer_available() && (pcie_ports_dpc_native || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC;
Newer firmware may not grant OSPM DPC control, if for instance, it expects to use Error Disconnect Recovery. However it looks like ACPI will use DPC services via the EDR driver, without binding the full DPC port service driver.
If we change portdrv to probe based on host->native_dpc and not AER, then we break instances with legacy firmware where OSPM will clear host->native_dpc solely due to _OSC bits being reserved:
struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,
...
if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL)) host_bridge->native_dpc = 0;
So my assumption instead is that host->native_dpc can be 0 and expect Native DPC services if AER is used. In other words, if and only if DPC probe is invoked from portdrv, then it needs to rely on the AER dependency. Otherwise it should be assumed that ACPI set up DPC via EDR. This covers legacy firmware.
However it seems like that could be trouble with newer firmware that might give OSPM control of AER but not DPC, and would result in both Native DPC and EDR being in effect.
Anyways here are two patches that give control of AER and DPC on the results of _OSC. They don't mess with the HEST parser as I expect those to be removed at some point. I need these for VMD support which doesn't even rely on _OSC, but I suspect this won't be the last effort as we detangle Firmware First.
[1] https://members.pcisig.com/wg/PCI-SIG/document/12888
Jon Derrick (2):
PCI/AER: Use _OSC to determine Firmware First before HEST PCI/DPC: Use _OSC to determine DPC support
drivers/pci/pcie/aer.c | 3 +++ drivers/pci/pcie/dpc.c | 3 --- drivers/pci/pcie/portdrv_core.c | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.3.1
PATCH v3 1/2 PCI/AER: Use _OSC to determine Firmware First before HEST
After a5bf8719af: "PCI/AER: Use only _OSC to determine AER ownership", _OSC is the primary determiner of ownership of Firmware First error handling rather than HEST.
ACPI Root Bus enumeration has been modified to flag Host Bridge devices as using Native AER when _OSC has been negotiated for AER services.
This patch ensures the PCI layers first uses the _OSC negotiated state by checking the Host Bridge's Native AER flag prior to HEST parsing.
--- drivers/pci/pcie/aer.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pci/pcie/aer.c +3 -0
@@ -314,6 +314,9 @@ int pcie_aer_get_firmware_first(struct pci_dev *dev)if (pcie_ports_native)return 0 ; +if (pci_find_host_bridge (dev->bus)->native_aer) +return 0 ; +if (!dev->__aer_firmware_first_valid)aer_set_firmware_first (dev);return dev->__aer_firmware_first;
Signature · 1 line
1.8.3.1
PATCH v3 2/2 PCI/DPC: Use _OSC to determine DPC support
In reply to Jon DerrickAfter a5bf8719af: "PCI/AER: Use only _OSC to determine AER ownership", _OSC is the primary determiner of ownership of Firmware First error handling rather than HEST.
With the addition of DPC to _OSC [1], OSPM is able to negotiate DPC services from Firmware. ACPI Root Bus enumeration sets the Host Bridge's Native DPC flag on negotiation of those service. This patch changes DPC probing to check DPC control as determined by _OSC, by checking the Host Bridge's Native DPC member.
As most older platforms won't have DPC negotiable by _OSC, this patch doesn't attempt to change behavior that assumes if OSPM has negotiated AER by _OSC, OSPM will also want DPC control.
[1] https://members.pcisig.com/wg/PCI-SIG/document/12888
--- drivers/pci/pcie/dpc.c | 3 --- drivers/pci/pcie/portdrv_core.c | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/pci/pcie/dpc.c +0 -3
@@ -284,9 +284,6 @@ static int dpc_probe(struct pcie_device *dev)int status;u16 ctl, cap; -if (pcie_aer_get_firmware_first (pdev) && !pcie_ports_dpc_native) -return -ENOTSUPP ; - status =devm_request_threaded_irq (device, dev->irq, dpc_irq, dpc_handler,IRQF_SHARED ,"pcie-dpc" , pdev);
drivers/pci/pcie/portdrv_core.c +2 -1
@@ -256,7 +256,8 @@ static int get_port_device_capability(struct pci_dev *dev)*/ if (pci_find_ext_capability (dev,PCI_EXT_CAP_ID_DPC ) &&pci_aer_available () && - (pcie_ports_dpc_native || (services &PCIE_PORT_SERVICE_AER ))) + (pcie_ports_dpc_native || host->native_dpc || + (services &PCIE_PORT_SERVICE_AER ))) services |=PCIE_PORT_SERVICE_DPC ; if (pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM ||
Signature · 1 line
1.8.3.1
Quoted 60 lines · Jon Derrick
Hi Bjorn & Kuppuswamy,
I see a problem in the DPC ECN [1] to
_OSCin that it doesn't give us a way to determine if firmware supports_OSCDPC negotation, and therefore how to handle DPC.Here is the wording of the ECN that implies that Firmware without
_OSCDPC negotiation support should have the OSPM rely on_OSCAER negotiation when determining DPC control:PCIe Base Specification suggests that Downstream Port Containment may be controlled either by the Firmware or the Operating System. It also suggests that the Firmware retain ownership of Downstream Port Containment if it also owns AER. When the Firmware owns Downstream Port Containment, it is expected to use the new "Error Disconnect Recover" notification to alert OSPM of a Downstream Port Containment event.
In legacy platforms, as bits in
_OSCare reserved prior to implementation, ACPI Root Bus enumeration will mark these Host Bridges as without Native DPC support, even though the specification implies it's expected that AER_OSCnegotiation determines DPC control for these platforms. There seems to be a need for a way to determine if the DPC control bit in_OSCis supported and fallback on AER otherwise.Currently portdrv assumes DPC control if the port has Native AER services:
static int
get_port_device_capability(struct pci_dev *dev)
...if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && pci_aer_available() && (pcie_ports_dpc_native || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC;Newer firmware may not grant OSPM DPC control, if for instance, it expects to use Error Disconnect Recovery. However it looks like ACPI will use DPC services via the EDR driver, without binding the full DPC port service driver.
If we change portdrv to probe based on
host->native_dpcand not AER, then we break instances with legacy firmware where OSPM will clearhost->native_dpcsolely due to_OSCbits being reserved:struct
pci_bus*acpi_pci_root_create(structacpi_pci_root*root,
...if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL)) host_bridge->native_dpc = 0;So my assumption instead is that
host->native_dpccan be 0 and expect Native DPC services if AER is used. In other words, if and only if DPC probe is invoked from portdrv, then it needs to rely on the AER dependency. Otherwise it should be assumed that ACPI set up DPC via EDR. This covers legacy firmware.However it seems like that could be trouble with newer firmware that might give OSPM control of AER but not DPC, and would result in both Native DPC and EDR being in effect.
Quoted 6 lines
Anyways here are two patches that give control of AER and DPC on the results of
_OSC. They don't mess with the HEST parser as I expect those to be removed at some point. I need these for VMD support which doesn't even rely on_OSC, but I suspect this won't be the last effort as we detangle Firmware First.
Hi Jon, I think we need to sort out the _OSC/FIRMWARE_FIRST patches from Alex and Sathy first, then see what needs to be done on top of those, so I'm going to push these off for a few days and they'll probably need a refresh.
Bjorn
Quoted 66 lines · Bjorn Helgaas
Quoted 65 lines · Jon Derrick
Hi Bjorn & Kuppuswamy,
I see a problem in the DPC ECN [1] to
_OSCin that it doesn't give us a way to determine if firmware supports_OSCDPC negotation, and therefore how to handle DPC.Here is the wording of the ECN that implies that Firmware without
_OSCDPC negotiation support should have the OSPM rely on_OSCAER negotiation when determining DPC control:PCIe Base Specification suggests that Downstream Port Containment may be controlled either by the Firmware or the Operating System. It also suggests that the Firmware retain ownership of Downstream Port Containment if it also owns AER. When the Firmware owns Downstream Port Containment, it is expected to use the new "Error Disconnect Recover" notification to alert OSPM of a Downstream Port Containment event.
In legacy platforms, as bits in
_OSCare reserved prior to implementation, ACPI Root Bus enumeration will mark these Host Bridges as without Native DPC support, even though the specification implies it's expected that AER_OSCnegotiation determines DPC control for these platforms. There seems to be a need for a way to determine if the DPC control bit in_OSCis supported and fallback on AER otherwise.Currently portdrv assumes DPC control if the port has Native AER services:
static int
get_port_device_capability(struct pci_dev *dev)
...if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && pci_aer_available() && (pcie_ports_dpc_native || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC;Newer firmware may not grant OSPM DPC control, if for instance, it expects to use Error Disconnect Recovery. However it looks like ACPI will use DPC services via the EDR driver, without binding the full DPC port service driver.
If we change portdrv to probe based on
host->native_dpcand not AER, then we break instances with legacy firmware where OSPM will clearhost->native_dpcsolely due to_OSCbits being reserved:struct
pci_bus*acpi_pci_root_create(structacpi_pci_root*root,
...if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL)) host_bridge->native_dpc = 0;So my assumption instead is that
host->native_dpccan be 0 and expect Native DPC services if AER is used. In other words, if and only if DPC probe is invoked from portdrv, then it needs to rely on the AER dependency. Otherwise it should be assumed that ACPI set up DPC via EDR. This covers legacy firmware.However it seems like that could be trouble with newer firmware that might give OSPM control of AER but not DPC, and would result in both Native DPC and EDR being in effect.
Anyways here are two patches that give control of AER and DPC on the results of
_OSC. They don't mess with the HEST parser as I expect those to be removed at some point. I need these for VMD support which doesn't even rely on_OSC, but I suspect this won't be the last effort as we detangle Firmware First.
Quoted 8 lines
Quoted 1 line
Hi Jon, I think we need to sort out the _OSC/FIRMWARE_FIRST patches from Alex and Sathy first, then see what needs to be done on top of those, so I'm going to push these off for a few days and they'll probably need a refresh.
Bjorn
Agreed, no need to merge now. Just wanted to bring up the DPC ambiguity, which I think was first addressed by dpc-native:
commit 35a0b2378c199d4f26e458b2ca38ea56aaf2d9b8
Author: Olof Johansson <[email protected]> Date: Wed Oct 23 12:22:05 2019 -0700
PCI/DPC: Add "pcie_ports=dpc-native" to allow DPC without AER control
Prior to eed85ff4c0da7 ("PCI/DPC: Enable DPC only if AER is available"), Linux handled DPC events regardless of whether firmware had granted it ownership of AER or DPC, e.g., via _OSC.
PCIe r5.0, sec 6.2.10, recommends that the OS link control of DPC to control of AER, so after eed85ff4c0da7, Linux handles DPC events only if it has control of AER.
On platforms that do not grant OS control of AER via _OSC, Linux DPC handling worked before eed85ff4c0da7 but not after.
To make Linux DPC handling work on those platforms the same way they did before, add a "pcie_ports=dpc-native" kernel parameter that makes Linux handle DPC events regardless of whether it has control of AER.
Thanks,
Jon
Quoted 100 lines · Jonathan Derrick
Quoted 66 lines · Bjorn Helgaas
Quoted 65 lines · Jon Derrick
Hi Bjorn & Kuppuswamy,
I see a problem in the DPC ECN [1] to
_OSCin that it doesn't give us a way to determine if firmware supports_OSCDPC negotation, and therefore how to handle DPC.Here is the wording of the ECN that implies that Firmware without
_OSCDPC negotiation support should have the OSPM rely on_OSCAER negotiation when determining DPC control:PCIe Base Specification suggests that Downstream Port Containment may be controlled either by the Firmware or the Operating System. It also suggests that the Firmware retain ownership of Downstream Port Containment if it also owns AER. When the Firmware owns Downstream Port Containment, it is expected to use the new "Error Disconnect Recover" notification to alert OSPM of a Downstream Port Containment event.
In legacy platforms, as bits in
_OSCare reserved prior to implementation, ACPI Root Bus enumeration will mark these Host Bridges as without Native DPC support, even though the specification implies it's expected that AER_OSCnegotiation determines DPC control for these platforms. There seems to be a need for a way to determine if the DPC control bit in_OSCis supported and fallback on AER otherwise.Currently portdrv assumes DPC control if the port has Native AER services:
static int
get_port_device_capability(struct pci_dev *dev)
...if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && pci_aer_available() && (pcie_ports_dpc_native || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC;Newer firmware may not grant OSPM DPC control, if for instance, it expects to use Error Disconnect Recovery. However it looks like ACPI will use DPC services via the EDR driver, without binding the full DPC port service driver.
If we change portdrv to probe based on
host->native_dpcand not AER, then we break instances with legacy firmware where OSPM will clearhost->native_dpcsolely due to_OSCbits being reserved:struct
pci_bus*acpi_pci_root_create(structacpi_pci_root*root,
...if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL)) host_bridge->native_dpc = 0;So my assumption instead is that
host->native_dpccan be 0 and expect Native DPC services if AER is used. In other words, if and only if DPC probe is invoked from portdrv, then it needs to rely on the AER dependency. Otherwise it should be assumed that ACPI set up DPC via EDR. This covers legacy firmware.However it seems like that could be trouble with newer firmware that might give OSPM control of AER but not DPC, and would result in both Native DPC and EDR being in effect.
Anyways here are two patches that give control of AER and DPC on the results of
_OSC. They don't mess with the HEST parser as I expect those to be removed at some point. I need these for VMD support which doesn't even rely on_OSC, but I suspect this won't be the last effort as we detangle Firmware First.Quoted 8 lines
Quoted 1 line
Hi Jon, I think we need to sort out the _OSC/FIRMWARE_FIRST patches from Alex and Sathy first, then see what needs to be done on top of those, so I'm going to push these off for a few days and they'll probably need a refresh.
Bjorn
Agreed, no need to merge now. Just wanted to bring up the DPC ambiguity, which I think was first addressed by dpc-native:
commit
35a0b2378c199d4f26e458b2ca38ea56aaf2d9b8Author: Olof Johansson <[email protected]> Date: Wed Oct 23 12:22:05 2019 -0700PCI/DPC: Add "pcie_ports=dpc-native" to allow DPC without AER control
Prior to
eed85ff4c0da7("PCI/DPC: Enable DPC only if AER is available"), Linux handled DPC events regardless of whether firmware had granted it ownership of AER or DPC, e.g., via_OSC.PCIe r5.0, sec 6.2.10, recommends that the OS link control of DPC to control of AER, so after
eed85ff4c0da7, Linux handles DPC events only if it has control of AER.On platforms that do not grant OS control of AER via
_OSC, Linux DPC handling worked beforeeed85ff4c0da7but not after.To make Linux DPC handling work on those platforms the same way they did before, add a "pcie_ports=dpc-native" kernel parameter that makes Linux handle DPC events regardless of whether it has control of AER.
Quoted 8 lines
[bhelgaas: commit log, move pcie_ports_dpc_native to drivers/pci/]Signed-off-by Olof Johansson <[email protected]>Signed-off-by Bjorn Helgaas <[email protected]>Thanks,
Jon
Hi Bjorn,
Are you still thinking about removing the HEST parser?
For VMD we still need the ability to bind DPC if native_dpc==1. I think if we can do that, this set should still pretty much still apply with a modification to patch 2 to allow matching pcie_ports_dpc_native in dpc_probe.
Jon
Quoted 114 lines · Jonathan
Quoted 104 lines · Jonathan Derrick
Quoted 74 lines · Bjorn Helgaas
Quoted 73 lines · Jon Derrick
Hi Bjorn & Kuppuswamy,
I see a problem in the DPC ECN [1] to
_OSCin that it doesn't give us a way to determine if firmware supports_OSCDPC negotation, and therefore how to handle DPC.Here is the wording of the ECN that implies that Firmware without
_OSCDPC negotiation support should have the OSPM rely on_OSCAER negotiation when determining DPC control:PCIe Base Specification suggests that Downstream Port Containment may be controlled either by the Firmware or the Operating System. It also suggests that the Firmware retain ownership of Downstream Port Containment if it also owns AER. When the Firmware owns Downstream Port Containment, it is expected to use the new "Error Disconnect Recover" notification to alert OSPM of a Downstream Port Containment event.
In legacy platforms, as bits in
_OSCare reserved prior to implementation, ACPI Root Bus enumeration will mark these Host Bridges as without Native DPC support, even though the specification implies it's expected that AER_OSCnegotiation determines DPC control for these platforms. There seems to be a need for a way to determine if the DPC control bit in_OSCis supported and fallback on AER otherwise.Currently portdrv assumes DPC control if the port has Native AER services:
static int
get_port_device_capability(struct pci_dev *dev)
...if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && pci_aer_available() && (pcie_ports_dpc_native || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC;Newer firmware may not grant OSPM DPC control, if for instance, it expects to use Error Disconnect Recovery. However it looks like ACPI will use DPC services via the EDR driver, without binding the full DPC port service driver.
If we change portdrv to probe based on
host->native_dpcand not AER, then we break instances with legacy firmware where OSPM will clearhost->native_dpcsolely due to_OSCbits being reserved:struct
pci_bus*acpi_pci_root_create(structacpi_pci_root*root,
...if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL)) host_bridge->native_dpc = 0;So my assumption instead is that
host->native_dpccan be 0 and expect Native DPC services if AER is used. In other words, if and only if DPC probe is invoked from portdrv, then it needs to rely on the AER dependency. Otherwise it should be assumed that ACPI set up DPC via EDR. This covers legacy firmware.However it seems like that could be trouble with newer firmware that might give OSPM control of AER but not DPC, and would result in both Native DPC and EDR being in effect.
Anyways here are two patches that give control of AER and DPC on the results of
_OSC. They don't mess with the HEST parser as I expect those to be removed at some point. I need these for VMD support which doesn't even rely on_OSC, but I suspect this won't be the last effort as we detangle Firmware First.Quoted 8 lines
Quoted 1 line
Hi Jon, I think we need to sort out the _OSC/FIRMWARE_FIRST patches from Alex and Sathy first, then see what needs to be done on top of those, so I'm going to push these off for a few days and they'll probably need a refresh.
Bjorn
Agreed, no need to merge now. Just wanted to bring up the DPC ambiguity, which I think was first addressed by dpc-native:
commit
35a0b2378c199d4f26e458b2ca38ea56aaf2d9b8Author: Olof Johansson <[email protected]> Date: Wed Oct 23 12:22:05 2019 -0700PCI/DPC: Add "pcie_ports=dpc-native" to allow DPC without AER control
Prior to
eed85ff4c0da7("PCI/DPC: Enable DPC only if AER is available"), Linux handled DPC events regardless of whether firmware had granted it ownership of AER or DPC, e.g., via_OSC.PCIe r5.0, sec 6.2.10, recommends that the OS link control of DPC to control of AER, so after
eed85ff4c0da7, Linux handles DPC events only if it has control of AER.On platforms that do not grant OS control of AER via
_OSC, Linux DPC handling worked beforeeed85ff4c0da7but not after.Quoted 8 lines
To make Linux DPC handling work on those platforms the same way they did before, add a "pcie_ports=dpc-native" kernel parameter that makes Linux handle DPC events regardless of whether it has control of AER.
[bhelgaas: commit log, move pcie_ports_dpc_native to drivers/pci/]Signed-off-by Olof Johansson <[email protected]>Signed-off-by Bjorn Helgaas <[email protected]>
Quoted 6 lines
Are you still thinking about removing the HEST parser?
For VMD we still need the ability to bind DPC if native_dpc==1. I think if we can do that, this set should still pretty much still apply with a modification to patch 2 to allow matching
pcie_ports_dpc_nativeindpc_probe.
Yes, I think we should remove the HEST firmware-first parsing, because IIRC the spec really doesn't specify any action the OS should take based on it. I was thinking Sathy might update the patch, and it fell off my radar.
Bjorn
Hi Bjorn, Derrick,
Quoted 122 lines · Bjorn Helgaas
Quoted 114 lines · Jonathan
Quoted 104 lines · Jonathan Derrick
Quoted 74 lines · Bjorn Helgaas
Quoted 73 lines · Jon Derrick
Hi Bjorn & Kuppuswamy,
I see a problem in the DPC ECN [1] to
_OSCin that it doesn't give us a way to determine if firmware supports_OSCDPC negotation, and therefore how to handle DPC.Here is the wording of the ECN that implies that Firmware without
_OSCDPC negotiation support should have the OSPM rely on_OSCAER negotiation when determining DPC control:PCIe Base Specification suggests that Downstream Port Containment may be controlled either by the Firmware or the Operating System. It also suggests that the Firmware retain ownership of Downstream Port Containment if it also owns AER. When the Firmware owns Downstream Port Containment, it is expected to use the new "Error Disconnect Recover" notification to alert OSPM of a Downstream Port Containment event.
In legacy platforms, as bits in
_OSCare reserved prior to implementation, ACPI Root Bus enumeration will mark these Host Bridges as without Native DPC support, even though the specification implies it's expected that AER_OSCnegotiation determines DPC control for these platforms. There seems to be a need for a way to determine if the DPC control bit in_OSCis supported and fallback on AER otherwise.Currently portdrv assumes DPC control if the port has Native AER services:
static int
get_port_device_capability(struct pci_dev *dev)
...if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && pci_aer_available() && (pcie_ports_dpc_native || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC;Newer firmware may not grant OSPM DPC control, if for instance, it expects to use Error Disconnect Recovery. However it looks like ACPI will use DPC services via the EDR driver, without binding the full DPC port service driver.
If we change portdrv to probe based on
host->native_dpcand not AER, then we break instances with legacy firmware where OSPM will clearhost->native_dpcsolely due to_OSCbits being reserved:struct
pci_bus*acpi_pci_root_create(structacpi_pci_root*root,
...if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL)) host_bridge->native_dpc = 0;So my assumption instead is that
host->native_dpccan be 0 and expect Native DPC services if AER is used. In other words, if and only if DPC probe is invoked from portdrv, then it needs to rely on the AER dependency. Otherwise it should be assumed that ACPI set up DPC via EDR. This covers legacy firmware.However it seems like that could be trouble with newer firmware that might give OSPM control of AER but not DPC, and would result in both Native DPC and EDR being in effect.
Anyways here are two patches that give control of AER and DPC on the results of
_OSC. They don't mess with the HEST parser as I expect those to be removed at some point. I need these for VMD support which doesn't even rely on_OSC, but I suspect this won't be the last effort as we detangle Firmware First.Quoted 8 lines
Quoted 1 line
Hi Jon, I think we need to sort out the _OSC/FIRMWARE_FIRST patches from Alex and Sathy first, then see what needs to be done on top of those, so I'm going to push these off for a few days and they'll probably need a refresh.
Bjorn
Agreed, no need to merge now. Just wanted to bring up the DPC ambiguity, which I think was first addressed by dpc-native:
commit
35a0b2378c199d4f26e458b2ca38ea56aaf2d9b8Author: Olof Johansson <[email protected]> Date: Wed Oct 23 12:22:05 2019 -0700PCI/DPC: Add "pcie_ports=dpc-native" to allow DPC without AER control
Prior to
eed85ff4c0da7("PCI/DPC: Enable DPC only if AER is available"), Linux handled DPC events regardless of whether firmware had granted it ownership of AER or DPC, e.g., via_OSC.PCIe r5.0, sec 6.2.10, recommends that the OS link control of DPC to control of AER, so after
eed85ff4c0da7, Linux handles DPC events only if it has control of AER.On platforms that do not grant OS control of AER via
_OSC, Linux DPC handling worked beforeeed85ff4c0da7but not after.Quoted 8 lines
To make Linux DPC handling work on those platforms the same way they did before, add a "pcie_ports=dpc-native" kernel parameter that makes Linux handle DPC events regardless of whether it has control of AER.
[bhelgaas: commit log, move pcie_ports_dpc_native to drivers/pci/]Signed-off-by Olof Johansson <[email protected]>Signed-off-by Bjorn Helgaas <[email protected]>Quoted 6 lines
Are you still thinking about removing the HEST parser?
For VMD we still need the ability to bind DPC if native_dpc==1. I think if we can do that, this set should still pretty much still apply with a modification to patch 2 to allow matching
pcie_ports_dpc_nativeindpc_probe.
Quoted 4 lines
Yes, I think we should remove the HEST firmware-first parsing, because IIRC the spec really doesn't specify any action the OS should take based on it. I was thinking Sathy might update the patch, and it fell off my radar.
Sorry for the delay.
I was just waiting to see whether we get any issues with merging following commit.
commit c100beb9ccfb98e2474586a4006483cbf770c823
Author: Alexandru Gagniuc <[email protected]> Date: Mon Apr 27 18:25:13 2020 -0500
PCI/AER: Use only _OSC to determine AER ownership
Since I did not see any email reporting any issues about it, I will work on follow up patch.
Quoted 3 lines
Bjorn