Skip to contentSkip to conversation

dt-bindings: net: add IPA iommus property

PATCH In review Alex Elder 1 participant 2 messages May 1, 2020 – May 4, 2020

Subsystems (4)
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH 1/1 dt-bindings: net: add IPA iommus property

The IPA accesses "IMEM" and main system memory through an SMMU, so its DT node requires an iommus property to define range of stream IDs it uses.

---
 Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +9 -1
index 140f15245654..7b749fc04c32 100644
@@ -20,7 +20,10 @@ description:
   The GSI is an integral part of the IPA, but it is logically isolated
   and has a distinct interrupt and a separately-defined address space.
 
-  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.
+  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.  See
+  iommu/iommu.txt and iommu/arm,smmu.yaml for more information about SMMU
+  bindings.
+
 
   - |
     --------             ---------
@@ -54,6 +57,9 @@ properties:
       - const: ipa-shared
       - const: gsi
 
+  iommus:
+    maxItems: 1
+
   clocks:
     maxItems: 1
 
@@ -126,6 +132,7 @@ properties:
 
 required:
   - compatible
+  - iommus
   - reg
   - clocks
   - interrupts
@@ -164,6 +171,7 @@ examples:
                 modem-init;
                 modem-remoteproc = <&mss_pil>;
 
+                iommus = <&apps_smmu 0x720 0x3>;
                 reg = <0 0x1e40000 0 0x7000>,
                         <0 0x1e47000 0 0x2000>,
                         <0 0x1e04000 0 0x2c000>;
Signature · 1 line
2.20.1
author
#1 lore raw
Quoted 5 lines · Alex Elder

The IPA accesses "IMEM" and main system memory through an SMMU, so its DT node requires an iommus property to define range of stream IDs it uses.

Please ignore this patch. I have reposted it as the first patch in a new series:
https://lore.kernel.org/netdev/[email protected]/

-Alex

Quoted 47 lines
---
  Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 +++++++++-
  1 file changed, 9 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +9 -1
index 140f15245654..7b749fc04c32 100644
@@ -20,7 +20,10 @@ description:
    The GSI is an integral part of the IPA, but it is logically isolated
    and has a distinct interrupt and a separately-defined address space.
 
-  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.
+  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.  See
+  iommu/iommu.txt and iommu/arm,smmu.yaml for more information about SMMU
+  bindings.
+
 
    - |
      --------             ---------
@@ -54,6 +57,9 @@ properties:
        - const: ipa-shared
        - const: gsi
 
+  iommus:
+    maxItems: 1
+
    clocks:
      maxItems: 1
 
@@ -126,6 +132,7 @@ properties:
 
  required:
    - compatible
+  - iommus
    - reg
    - clocks
    - interrupts
@@ -164,6 +171,7 @@ examples:
                  modem-init;
                  modem-remoteproc = <&mss_pil>;
 
+                iommus = <&apps_smmu 0x720 0x3>;
                  reg = <0 0x1e40000 0 0x7000>,
                          <0 0x1e47000 0 0x2000>,
                          <0 0x1e04000 0 0x2c000>;