main: fix get_optstring truncating output
PATCH 1/1 main: fix get_optstring truncating output
Without this patch, get_optstring returns optstring = +hvVcf:insNSI:d:aejuy. After this patch, get_optstring returns optstring = +hvVcf:insNSI:d:aejuypTt
This is due to optstring containing up to two chars per option, thus it was too short.
Signed-off-by Michael Braun <[email protected]>
--- src/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
src/main.c +3 -1
@@ -118,7 +118,7 @@ static const struct nft_opt nft_options[] = {static const char *get_optstring (void ) { -static char optstring[NR_NFT_OPTIONS +2 ]; +static char optstring[2 *NR_NFT_OPTIONS +2 ];if (!optstring[0 ]) {size_t i, j;
@@ -128,6 +128,8 @@ static const char *get_optstring(void) j +=snprintf (optstring + j,sizeof (optstring) - j,"%c%s" , nft_options[i].val, nft_options[i].arg ?":" :"" ); + +assert (j <sizeof (optstring)); }return optstring; }
Signature · 1 line
2.20.1
Quoted 5 lines · Michael Braun
Without this patch,
get_optstringreturns optstring = +hvVcf:insNSI:d:aejuy. After this patch,get_optstringreturns optstring = +hvVcf:insNSI:d:aejuypTtThis is due to optstring containing up to two chars per option, thus it was too short.
Applied, thanks.