Skip to contentSkip to conversation

mtd:rawnand: brcmnand: Fix PM resume crash

PATCH In review Kamal Dasu 3 participants 3 messages May 2, 2020 – May 19, 2020

Subsystems (3)
Memory technology devices (MTD) NAND flash Broadcom stb NAND flash driver
lore
Share & tools
lore

Kamal Dasu

author
#0 lore raw

PATCH 1/1 mtd:rawnand: brcmnand: Fix PM resume crash

This change fixes crash observed on PM resume. This bug was introduced in the change made for flash-edu support.

Fixes a5d53ad26a8b ("mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers")
Signed-off-by Kamal Dasu <[email protected]>
---
 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mtd/nand/raw/brcmnand/brcmnand.c +1 -2
index e4e3ceeac38f..8f9ffb46a09f 100644
@@ -2728,9 +2728,8 @@ static int brcmnand_resume(struct device *dev)
 		flash_dma_writel(ctrl, FLASH_DMA_ERROR_STATUS, 0);
 	}
 
-	if (has_edu(ctrl))
+	if (has_edu(ctrl)) {
 		ctrl->edu_config = edu_readl(ctrl, EDU_CONFIG);
-	else {
 		edu_writel(ctrl, EDU_CONFIG, ctrl->edu_config);
 		edu_readl(ctrl, EDU_CONFIG);
 		brcmnand_edu_init(ctrl);
Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#2 lore raw
Quoted 7 lines · Florian Fainelli
Quoted 3 lines · Kamal Dasu

This change fixes crash observed on PM resume. This bug was introduced in the change made for flash-edu support.

Quoted 7 lines
Quoted 3 lines
Fixes a5d53ad26a8b ("mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers")
Signed-off-by Kamal Dasu <[email protected]>
Acked-by Florian Fainelli <[email protected]>

--
Florian

Applied for fixes, thanks!

Signature · 2 lines
Thanks,
//richard