Skip to contentSkip to conversation

package/ne10: correct cpu feature comment dependency

PATCH New Baruch Siach 2 participants 2 messages May 2, 2020 – May 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/ne10: correct cpu feature comment dependency

Commit e845f9364c2b8 ("ne10: bump to v1.2.1") removed arm arch dependency from the comment. This comment is only relevant to arm. Restore the arm arch dependency.

Cc Cody Guldner <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/ne10/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/ne10/Config.in +1 -0
index 68cb7f4cb389..0e5a595dbed2 100644
@@ -17,4 +17,5 @@ config BR2_PACKAGE_NE10
 	  http://projectne10.github.io/Ne10/
 
 comment "ne10 needs a toolchain w/ neon"
+	depends on BR2_arm
 	depends on !BR2_PACKAGE_NE10_ARCH_SUPPORTS
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/ne10: correct cpu feature comment dependency

Baruch, All,

On 2020-05-02 23:53 +0300, Baruch Siach spake thusly:

Quoted 3 lines

Commit e845f9364c2b8 ("ne10: bump to v1.2.1") removed arm arch dependency from the comment. This comment is only relevant to arm. Restore the arm arch dependency.

Thanks for noticing. I've even taken a step further, and dropped the comment altogether. Indeed, this is an arch-related restriction, and there is nothign a user can do about that in Buildroot if the target has no NEON unit.

Applied to master with an extended commit log exlpaining why the comment is dropped.

Thanks!

Regards,
Yann E. MORIN.

Quoted 24 lines
Cc Cody Guldner <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/ne10/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/ne10/Config.in +1 -0
index 68cb7f4cb389..0e5a595dbed2 100644
@@ -17,4 +17,5 @@ config BR2_PACKAGE_NE10
 	  http://projectne10.github.io/Ne10/
 
 comment "ne10 needs a toolchain w/ neon"
+	depends on BR2_arm
 	depends on !BR2_PACKAGE_NE10_ARCH_SUPPORTS
Signature · 6 lines
2.26.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'