Skip to contentSkip to conversation

hw/ide/ahci: Log lost IRQs

PATCH In review Philippe Mathieu-Daudé 3 participants 4 messages May 4, 2020 – May 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/ide/ahci: Log lost IRQs

One might find interesting to look at AHCI IRQs.

---
 hw/ide/ahci.c | 1 +
 1 file changed, 1 insertion(+)
hw/ide/ahci.c +1 -0
index 13d91e109a..fc82cbd5f1 100644
@@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
 
 static void ahci_irq_set(void *opaque, int n, int level)
 {
+    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
 }
 
 static const IDEDMAOps ahci_dma_ops = {
Signature · 1 line
2.21.3
#1 lore raw

ping?

Quoted 20 lines · Philippe Mathieu-Daudé

One might find interesting to look at AHCI IRQs.

---
  hw/ide/ahci.c | 1 +
  1 file changed, 1 insertion(+)
hw/ide/ahci.c +1 -0
index 13d91e109a..fc82cbd5f1 100644
@@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
 
  static void ahci_irq_set(void *opaque, int n, int level)
  {
+    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
  }
 
  static const IDEDMAOps ahci_dma_ops = {
Reviewed-by Acked-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 13 lines · Philippe Mathieu-Daudé

One might find interesting to look at AHCI IRQs.

---
 hw/ide/ahci.c | 1 +
 1 file changed, 1 insertion(+)
hw/ide/ahci.c +0 -0
index 13d91e109a..fc82cbd5f1 100644

hw/ide/ahci.c static void ahci_cmd_done(IDEDMA *dma) · line 1515

Quoted 7 lines
hw/ide/ahci.c +1 -0
@@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
 
 static void ahci_irq_set(void *opaque, int n, int level)
 {
+    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
 }
 
 static const IDEDMAOps ahci_dma_ops = {

Sorry, just drowning in backlog. Thanks for the ping on IRC.

^ Feel free to take through trivial tree.

--js

#3 lore raw

Am 14.05.2020 um 22:20 hat John Snow geschrieben:

Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 13 lines

One might find interesting to look at AHCI IRQs.

---
 hw/ide/ahci.c | 1 +
 1 file changed, 1 insertion(+)
hw/ide/ahci.c +0 -0
index 13d91e109a..fc82cbd5f1 100644

hw/ide/ahci.c static void ahci_cmd_done(IDEDMA *dma) · line 1515

Quoted 7 lines
hw/ide/ahci.c +1 -0
@@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
 
 static void ahci_irq_set(void *opaque, int n, int level)
 {
+    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
 }
 
 static const IDEDMAOps ahci_dma_ops = {
Quoted 5 lines

Sorry, just drowning in backlog. Thanks for the ping on IRC.

^ Feel free to take through trivial tree.

I'll take it through the block tree then.

Kevin