Skip to contentSkip to conversation

cache: l2x0: Fix missing write to Auxiliary Control Register

PATCH New Ley Foon Tan 2 participants 2 messages May 4, 2020 – May 7, 2020 Standalone cache controller drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cache: l2x0: Fix missing write to Auxiliary Control Register

commit f62782fb2999 ("cache: l2x0: Fix write to incorrect shared-override bit")

Commit above removed writel to regs->pl310_aux_ctrl by accidentally, restore it back.

---
 drivers/cache/cache-l2x0.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/cache/cache-l2x0.c +2 -0
index 226824c2832e..a1556fbf1740 100644
@@ -36,6 +36,8 @@ static void l2c310_of_parse_and_init(struct udevice *dev)
 	if (dev_read_bool(dev, "arm,shared-override"))
 		saved_reg |= L310_SHARED_ATT_OVERRIDE_ENABLE;
 
+	writel(saved_reg, &regs->pl310_aux_ctrl);
+
 	saved_reg = readl(&regs->pl310_tag_latency_ctrl);
 	if (!dev_read_u32_array(dev, "arm,tag-latency", tag, 3))
 		saved_reg |= L310_LATENCY_CTRL_RD(tag[0] - 1) |
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 cache: l2x0: Fix missing write to Auxiliary Control Register

Quoted 7 lines · Ley Foon Tan

commit f62782fb2999 ("cache: l2x0: Fix write to incorrect shared-override bit")

Commit above removed writel to regs->pl310_aux_ctrl by accidentally, restore it back.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200507/cb1d30a4/attachment.sig>