f2fs: remove redundant check in f2fs_force_buffered_io
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: remove redundant check in f2fs_force_buffered_io
From: Daeho Jeong <[email protected]>
We already checked whether the file is compressed or not in f2fs_post_read_required(). So removed f2fs_compressed_file() in f2fs_force_buffered_io().
--- fs/f2fs/f2fs.h | 2 -- 1 file changed, 2 deletions(-)
fs/f2fs/f2fs.h +0 -2
@@ -4064,8 +4064,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,return true;if (f2fs_is_multi_device (sbi))return true; -if (f2fs_compressed_file (inode)) -return true;/* * for blkzoned device, fallback direct IO to buffered IO, so * all IOs can be serialized by log-structured write.
Signature · 1 line
2.26.2.526.g744177e7f7-goog
Chao Yu
maintainerQuoted 5 lines · Jaegeuk Kim
From: Daeho Jeong <[email protected]>
We already checked whether the file is compressed or not in
f2fs_post_read_required(). So removedf2fs_compressed_file()inf2fs_force_buffered_io().
Agreed, since I have sent similar patch before:
https://lkml.org/lkml/2020/3/24/1819
Just want to know what's the change of backport concern now.
Thanks,
Quoted 21 lines
Signed-off-by Daeho Jeong <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/f2fs.h | 2 -- 1 file changed, 2 deletions(-)fs/f2fs/f2fs.h +0
-2@@ -4064,8 +4064,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,return true;if (f2fs_is_multi_device (sbi))return true; -if (f2fs_compressed_file (inode)) -return true;/* * for blkzoned device, fallback direct IO to buffered IO, so * all IOs can be serialized by log-structured write.
Jaegeuk Kim
maintainerQuoted 10 lines · Chao Yu
Quoted 5 lines · Jaegeuk Kim
From: Daeho Jeong <[email protected]>
We already checked whether the file is compressed or not in
f2fs_post_read_required(). So removedf2fs_compressed_file()inf2fs_force_buffered_io().Agreed, since I have sent similar patch before:
Heh, as I couldn't find yours, I was actually waiting for you to point out. :)
Quoted 2 lines
Just want to know what's the change of backport concern now.
Old ICE support had to decouple f2fs_post_read_required() and f2fs_forced_buffered_io(). Now, I decide to manage this as we need to manage this for one kernel version only.
Thanks,
Quoted 24 lines
Thanks,
Quoted 21 lines
Signed-off-by Daeho Jeong <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/f2fs.h | 2 -- 1 file changed, 2 deletions(-)fs/f2fs/f2fs.h +0
-2@@ -4064,8 +4064,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,return true;if (f2fs_is_multi_device (sbi))return true; -if (f2fs_compressed_file (inode)) -return true;/* * for blkzoned device, fallback direct IO to buffered IO, so * all IOs can be serialized by log-structured write.
Quoted 8 lines · Jaegeuk Kim
Quoted 7 lines · Chao Yu
Quoted 5 lines · Jaegeuk Kim
From: Daeho Jeong <[email protected]>
We already checked whether the file is compressed or not in
f2fs_post_read_required(). So removedf2fs_compressed_file()inf2fs_force_buffered_io().
Quoted 5 lines
Quoted 3 lines
Agreed, since I have sent similar patch before:
Heh, as I couldn't find yours, I was actually waiting for you to point out. :)
Well, all patches sent to f2fs mailing list have been archived in lore.kernel.org/linux-f2fs-devel. :)
https://lore.kernel.org/linux-f2fs-devel/[email protected]/
Quoted 6 lines
Quoted 3 lines
Just want to know what's the change of backport concern now.
Old ICE support had to decouple
f2fs_post_read_required()andf2fs_forced_buffered_io(). Now, I decide to manage this as we
Copied.
Quoted 1 line
need to manage this for one kernel version only.
Okay, thanks for the explanation.
Thanks,
Quoted 35 lines
Thanks,
Quoted 10 lines
Thanks,
Quoted 7 lines
Signed-off-by Daeho Jeong <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/f2fs.h | 2 -- 1 file changed, 2 deletions(-)Quoted 14 lines
Quoted 6 lines
fs/f2fs/f2fs.h +0
-0fs/f2fs/f2fs.h static inline bool f2fs_force_buffered_io(struct inode *inode, · line 4069
Quoted 8 lines
fs/f2fs/f2fs.h +0
-2@@ -4064,8 +4064,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,return true;if (f2fs_is_multi_device (sbi))return true; -if (f2fs_compressed_file (inode)) -return true;/* * for blkzoned device, fallback direct IO to buffered IO, so * all IOs can be serialized by log-structured write. _______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
.