TI Ethernet PHY changes
Subsystems (3)
v4 cover TI Ethernet PHY changes
Hello
The addition of the DP83867 driver to uboot was done in a generic way that made it a bit difficult to bring in new PHY drivers. The difficulty came in the config flags and the phy_init function. The change is to make the flags and init for the DP83867 more specific to the DP83867 device to make way to add more TI PHYs to uBoot.
In addition the DP8382X PHY is a generic PHY driver that does not need any special handling to establish a link. Customers have requested that at the very least there be a way to know if the PHY attached is the PHY that is connected as "Generic PHY" is not really descriptive. These patches adds the registrations for TI Generic PHYs to associcate a TI PHY ID with a PHY name.
Porting PHY helper routines to set and clear bits to facilitate easier side porting of ethernet kernel drivers to uBoot.
Also fixed and added missing or kernel doc documentation in the phy.h file.
Dan
Dan Murphy (5):
net: phy: Add missing kernel doc to phy functions
net: phy: Fix kernel doc issues in phy.h
net: phy: Add helper routines to set and clear bits
net: phy: Add support for TI PHY init
net: phy: Add DP8382x phy registration to TI PHY init
configs/am65x_evm_a53_defconfig | 2 +- configs/am65x_hs_evm_a53_defconfig | 2 +- configs/dra7xx_evm_defconfig | 2 +- configs/dra7xx_hs_evm_defconfig | 2 +- configs/dra7xx_hs_evm_usb_defconfig | 2 +- configs/j721e_evm_a72_defconfig | 2 +- configs/j721e_hs_evm_a72_defconfig | 2 +- configs/k2g_evm_defconfig | 2 +- configs/xilinx_versal_virt_defconfig | 2 +- configs/xilinx_zynqmp_virt_defconfig | 2 +- drivers/net/phy/Kconfig | 15 ++++ drivers/net/phy/Makefile | 3 +- drivers/net/phy/dp83867.c | 3 +- drivers/net/phy/ti_phy_init.c | 101 ++++++++++++++++++++++++ drivers/net/phy/ti_phy_init.h | 15 ++++ include/phy.h | 112 ++++++++++++++++++++++++--- 16 files changed, 246 insertions(+), 23 deletions(-) create mode 100644 drivers/net/phy/ti_phy_init.c create mode 100644 drivers/net/phy/ti_phy_init.h
Signature · 1 line
2.25.1
PATCH v4 1/5 net: phy: Add missing kernel doc to phy functions
Add kernel doc to the phy_read/write utility functions in phy.h
--- include/phy.h | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
include/phy.h +39 -0
@@ -170,6 +170,13 @@ struct fixed_link {int asym_pause; }; +/** +* phy_read - Convenience function for reading a given PHY register +* @phydev: the phy_device struct +* @devad: The MMD to read from +* @regnum: register number to read +* @return: value for success or negative errno for failure +*/ static inline int phy_read (struct phy_device *phydev,int devad,int regnum) {struct mii_dev *bus = phydev->bus;
@@ -182,6 +189,14 @@ static inline int phy_read(struct phy_device *phydev, int devad, int regnum)return bus->read (bus, phydev->addr, devad, regnum); } +/** +* phy_write - Convenience function for writing a given PHY register +* @phydev: the phy_device struct +* @devad: The MMD to read from +* @regnum: register number to write +* @val: value to write to @regnum +* @return: 0 for success or negative errno for failure +*/ static inline int phy_write (struct phy_device *phydev,int devad,int regnum,u16 val) {
@@ -195,6 +210,13 @@ static inline int phy_write(struct phy_device *phydev, int devad, int regnum,return bus->write (bus, phydev->addr, devad, regnum, val); } +/** +* phy_mmd_start_indirect - Convenience function for writing MMD registers +* @phydev: the phy_device struct +* @devad: The MMD to read from +* @regnum: register number to write +* @return: None +*/ static inline void phy_mmd_start_indirect (struct phy_device *phydev,int devad,int regnum) {
@@ -209,6 +231,14 @@ static inline void phy_mmd_start_indirect(struct phy_device *phydev, int devad, (devad | MII_MMD_CTRL_NOINCR)); } +/** +* phy_read_mmd - Convenience function for reading a register +* from an MMD on a given PHY. +* @phydev: The phy_device struct +* @devad: The MMD to read from +* @regnum: The register on the MMD to read +* @return: Value for success or negative errno for failure +*/ static inline int phy_read_mmd (struct phy_device *phydev,int devad,int regnum) {
@@ -233,6 +263,15 @@ static inline int phy_read_mmd(struct phy_device *phydev, int devad,return phy_read (phydev,MDIO_DEVAD_NONE ,MII_MMD_DATA ); } +/** +* phy_write_mmd - Convenience function for writing a register +* on an MMD on a given PHY. +* @phydev: The phy_device struct +* @devad: The MMD to read from +* @regnum: The register on the MMD to read +* @val: value to write to @regnum +* @return: 0 for success or negative errno for failure +*/ static inline int phy_write_mmd (struct phy_device *phydev,int devad,int regnum,u16 val) {
Signature · 1 line
2.25.1
PATCH v4 1/5 net: phy: Add missing kernel doc to phy functions
Quoted 4 lines · Dan Murphy
Add kernel doc to the phy_read/write utility functions in
phy.hAcked-by Michal Simek <[email protected]>Signed-off-by Dan Murphy <[email protected]>
Applied to u-boot/next, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/a05eda32/attachment-0001.sig>
PATCH v4 2/5 net: phy: Fix kernel doc issues in phy.h
In reply to Dan MurphyFix kernel doc warnings in phy.h. Mostly the warnings were due to the return missing the semi-colon.
--- include/phy.h | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-)
include/phy.h +8 -11
@@ -314,26 +314,23 @@ static inline int is_10g_interface(phy_interface_t interface)/** * phy_init() - Initializes the PHY drivers -* * This function registers all available PHY drivers * -* @return 0 if OK, -ve on error +* @return: 0 if OK, -ve on error */ int phy_init (void );/** * phy_reset() - Resets the specified PHY -* * Issues a reset of the PHY and waits for it to complete * * @phydev: PHY to reset -* @return 0 if OK, -ve on error +* @return: 0 if OK, -ve on error */ int phy_reset (struct phy_device *phydev);/** * phy_find_by_mask() - Searches for a PHY on the specified MDIO bus -* * The function checks the PHY addresses flagged in phy_mask and returns a * phy_device pointer if it detects a PHY. * This function should only be called if just one PHY is expected to be present
@@ -343,7 +340,7 @@ int phy_reset(struct phy_device *phydev);* @bus: MII/MDIO bus to scan * @phy_mask: bitmap of PYH addresses to scan * @interface: type of MAC-PHY interface -* @return pointer to phy_device if a PHY is found, or NULL otherwise +* @return: pointer to phy_device if a PHY is found, or NULL otherwise */ struct phy_device *phy_find_by_mask (struct mii_dev *bus,unsigned phy_mask,phy_interface_t interface);
@@ -359,7 +356,6 @@ void phy_connect_dev(struct phy_device *phydev, struct udevice *dev);/** * phy_connect() - Creates a PHY device for the Ethernet interface -* * Creates a PHY device for the PHY at the given address, if one doesn't exist * already, and associates it with the Ethernet device. * The function may be called with addr <= 0, in this case addr value is ignored
@@ -371,7 +367,7 @@ void phy_connect_dev(struct phy_device *phydev, struct udevice *dev);* @addr: PHY address on MDIO bus * @dev: Ethernet device to associate to the PHY * @interface: type of MAC-PHY interface -* @return pointer to phy_device if a PHY is found, or NULL otherwise +* @return: pointer to phy_device if a PHY is found, or NULL otherwise */ struct phy_device *phy_connect(struct mii_dev *bus, int addr, struct udevice *dev,
@@ -395,7 +391,6 @@ void phy_connect_dev(struct phy_device *phydev, struct eth_device *dev);/** * phy_connect() - Creates a PHY device for the Ethernet interface -* * Creates a PHY device for the PHY@the given address, if one doesn't exist * already, and associates it with the Ethernet device. * The function may be called with addr <= 0, in this case addr value is ignored
@@ -407,7 +402,7 @@ void phy_connect_dev(struct phy_device *phydev, struct eth_device *dev);* @addr: PHY address on MDIO bus * @dev: Ethernet device to associate to the PHY * @interface: type of MAC-PHY interface -* @return pointer to phy_device if a PHY is found, or NULL otherwise +* @return: pointer to phy_device if a PHY is found, or NULL otherwise */ struct phy_device *phy_connect(struct mii_dev *bus, int addr, struct eth_device *dev,
@@ -467,7 +462,7 @@ int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id);* phy_get_interface_by_name() - Look up a PHY interface name * * @str: PHY interface name, e.g. "mii" -* @return PHY_INTERFACE_MODE_... value, or -1 if not found +* @return: PHY_INTERFACE_MODE_... value, or -1 if not found */ int phy_get_interface_by_name (const char *str);
@@ -475,6 +470,7 @@ int phy_get_interface_by_name(const char *str);* phy_interface_is_rgmii - Convenience function for testing if a PHY interface * is RGMII (all variants) * @phydev: the phy_device struct +* @return: true if MII bus is RGMII or false if it is not */ static inline bool phy_interface_is_rgmii (struct phy_device *phydev) {
@@ -486,6 +482,7 @@ static inline bool phy_interface_is_rgmii(struct phy_device *phydev)* phy_interface_is_sgmii - Convenience function for testing if a PHY interface * is SGMII (all variants) * @phydev: the phy_device struct +* @return: true if MII bus is SGMII or false if it is not */ static inline bool phy_interface_is_sgmii (struct phy_device *phydev) {
Signature · 1 line
2.25.1
PATCH v4 2/5 net: phy: Fix kernel doc issues in phy.h
Quoted 5 lines · Dan Murphy
Fix kernel doc warnings in
phy.h. Mostly the warnings were due to the return missing the semi-colon.Acked-by Michal Simek <[email protected]>Signed-off-by Dan Murphy <[email protected]>
Applied to u-boot/next, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/60e5a36c/attachment.sig>
PATCH v4 3/5 net: phy: Add helper routines to set and clear bits
In reply to Dan MurphyAdd phy_set/clear_bit helper routines so that ported drivers from the kernel can use these functions.
--- include/phy.h | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
include/phy.h +54 -0
@@ -296,6 +296,60 @@ static inline int phy_write_mmd(struct phy_device *phydev, int devad,return phy_write (phydev,MDIO_DEVAD_NONE ,MII_MMD_DATA , val); } +/** +* phy_set_bits_mmd - Convenience function for setting bits in a register +* on MMD +* @phydev: the phy_device struct +* @devad: the MMD containing register to modify +* @regnum: register number to modify +* @val: bits to set +* @return: 0 for success or negative errno for failure +*/ +static inline int phy_set_bits_mmd (struct phy_device *phydev,int devad, +u32 regnum,u16 val) +{ +int value, ret; + + value =phy_read_mmd (phydev, devad, regnum); +if (value <0 ) +return value; + + value |= val; + + ret =phy_write_mmd (phydev, devad, regnum, value); +if (ret <0 ) +return ret; + +return 0 ; +} + +/** +* phy_clear_bits_mmd - Convenience function for clearing bits in a register +* on MMD +* @phydev: the phy_device struct +* @devad: the MMD containing register to modify +* @regnum: register number to modify +* @val: bits to clear +* @return: 0 for success or negative errno for failure +*/ +static inline int phy_clear_bits_mmd (struct phy_device *phydev,int devad, +u32 regnum,u16 val) +{ +int value, ret; + + value =phy_read_mmd (phydev, devad, regnum); +if (value <0 ) +return value; + + value &= ~val; + + ret =phy_write_mmd (phydev, devad, regnum, value); +if (ret <0 ) +return ret; + +return 0 ; +} +#ifdef CONFIG_PHYLIB_10G extern struct phy_driver gen10g_driver;
Signature · 1 line
2.25.1
PATCH v4 3/5 net: phy: Add helper routines to set and clear bits
Quoted 5 lines · Dan Murphy
Add phy_set/clear_bit helper routines so that ported drivers from the kernel can use these functions.
Acked-by Michal Simek <[email protected]>Signed-off-by Dan Murphy <[email protected]>
Applied to u-boot/next, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/4daa8182/attachment.sig>
PATCH v4 4/5 net: phy: Add support for TI PHY init
In reply to Dan Murphyti_phy_init function was allocated to the DP83867 PHY. This function name is to generic for a specific PHY. The function can be moved to a TI specific file that can register all TI PHYs that are defined in the defconfig. The ti_phy_init file will contain all TI PHYs initialization so that only phy_ti_init can be called from the framework.
In addition to the above the config flag for the DP83867 needs to be changed in the Kconfig and dependent defconfig files. The config flag that was used for the DP83867 was also generic in nature so a more specific config flag for the DP83867 was created.
--- configs/am65x_evm_a53_defconfig | 2 +- configs/am65x_hs_evm_a53_defconfig | 2 +- configs/dra7xx_evm_defconfig | 2 +- configs/dra7xx_hs_evm_defconfig | 2 +- configs/dra7xx_hs_evm_usb_defconfig | 2 +- configs/j721e_evm_a72_defconfig | 2 +- configs/j721e_hs_evm_a72_defconfig | 2 +- configs/k2g_evm_defconfig | 2 +- configs/xilinx_versal_virt_defconfig | 2 +- configs/xilinx_zynqmp_virt_defconfig | 2 +- drivers/net/phy/Kconfig | 8 ++++++++ drivers/net/phy/Makefile | 3 ++- drivers/net/phy/dp83867.c | 3 ++- drivers/net/phy/ti_phy_init.c | 18 ++++++++++++++++++ drivers/net/phy/ti_phy_init.h | 15 +++++++++++++++ 15 files changed, 55 insertions(+), 12 deletions(-) create mode 100644 drivers/net/phy/ti_phy_init.c create mode 100644 drivers/net/phy/ti_phy_init.h
configs/am65x_evm_a53_defconfig +1 -1
@@ -101,7 +101,7 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_SPI_FLASH_MTD=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_PHY_FIXED=y CONFIG_DM_ETH=y CONFIG_E1000=y
configs/am65x_hs_evm_a53_defconfig +1 -1
@@ -103,7 +103,7 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_SPI_FLASH_MTD=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_PHY_FIXED=y CONFIG_DM_ETH=y CONFIG_E1000=y
configs/dra7xx_evm_defconfig +1 -1
@@ -86,7 +86,7 @@ CONFIG_DM_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000 CONFIG_SPI_FLASH_SPANSION=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y CONFIG_MII=y
configs/dra7xx_hs_evm_defconfig +1 -1
@@ -89,7 +89,7 @@ CONFIG_DM_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000 CONFIG_SPI_FLASH_SPANSION=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y CONFIG_MII=y
configs/dra7xx_hs_evm_usb_defconfig +1 -1
@@ -87,7 +87,7 @@ CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000 CONFIG_SPI_FLASH_BAR=y CONFIG_SPI_FLASH_SPANSION=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y CONFIG_MII=y
configs/j721e_evm_a72_defconfig +1 -1
@@ -124,7 +124,7 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_SPI_FLASH_MTD=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_PHY_FIXED=y CONFIG_DM_ETH=y CONFIG_TI_AM65_CPSW_NUSS=y
configs/j721e_hs_evm_a72_defconfig +1 -1
@@ -114,7 +114,7 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_SPI_FLASH_MTD=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_PHY_FIXED=y CONFIG_DM_ETH=y CONFIG_TI_AM65_CPSW_NUSS=y
configs/k2g_evm_defconfig +1 -1
@@ -58,7 +58,7 @@ CONFIG_PHYLIB=y CONFIG_PHY_MARVELL=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ8XXX=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_DM_ETH=y CONFIG_MII=y CONFIG_DRIVER_TI_KEYSTONE_NET=y
configs/xilinx_versal_virt_defconfig +1 -1
@@ -61,7 +61,7 @@ CONFIG_SPI_FLASH_WINBOND=y CONFIG_PHY_MARVELL=y CONFIG_PHY_NATSEMI=y CONFIG_PHY_REALTEK=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_PHY_VITESSE=y CONFIG_PHY_FIXED=y CONFIG_PHY_GIGE=y
configs/xilinx_zynqmp_virt_defconfig +1 -1
@@ -101,7 +101,7 @@ CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=y CONFIG_PHY_NATSEMI=y CONFIG_PHY_REALTEK=y -CONFIG_PHY_TI=y +CONFIG_PHY_TI_DP83867=y CONFIG_PHY_VITESSE=y CONFIG_PHY_XILINX_GMII2RGMII=y CONFIG_PHY_FIXED=y
drivers/net/phy/Kconfig +8 -0
@@ -243,6 +243,14 @@ config PHY_TERANETICS config PHY_TI bool "Texas Instruments Ethernet PHYs support" + ---help--- + Adds PHY registration support for TI PHYs. + +config PHY_TI_DP83867 + select PHY_TI + bool "Texas Instruments Ethernet DP83867 PHY support" + ---help--- + Adds support for the TI DP83867 1Gbit PHY. config PHY_VITESSE bool "Vitesse Ethernet PHYs support"
drivers/net/phy/Makefile +2 -1
@@ -25,7 +25,8 @@ obj-$(CONFIG_PHY_NATSEMI) += natsemi.o obj-$(CONFIG_PHY_REALTEK) += realtek.o obj-$(CONFIG_PHY_SMSC) += smsc.o obj-$(CONFIG_PHY_TERANETICS) += teranetics.o -obj-$(CONFIG_PHY_TI) += dp83867.o +obj-$(CONFIG_PHY_TI) += ti_phy_init.o +obj-$(CONFIG_PHY_TI_DP83867) += dp83867.o obj-$(CONFIG_PHY_XILINX) += xilinx_phy.o obj-$(CONFIG_PHY_XILINX_GMII2RGMII) += xilinx_gmii2rgmii.o obj-$(CONFIG_PHY_VITESSE) += vitesse.o
drivers/net/phy/dp83867.c +2 -1
@@ -12,6 +12,7 @@#include <dm.h> #include <dt-bindings/net/ti-dp83867.h> +#include "ti_phy_init.h" /* TI DP83867 */ #define DP83867_DEVADDR 0x1f
@@ -428,7 +429,7 @@ static struct phy_driver DP83867_driver = { .shutdown = &genphy_shutdown, }; -int phy_ti_init (void ) +int phy_dp83867_init (void ) {phy_register (&DP83867_driver);return 0 ;
drivers/net/phy/ti_phy_init.c new file +18 -0
@@ -0,0 +1,18 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* TI Generic PHY Init to register any TI Ethernet PHYs +* +* Author: Dan Murphy <[email protected]> +* +* Copyright (C) 2019-20 Texas Instruments Inc. +*/ + +#include "ti_phy_init.h" + +int phy_ti_init (void ) +{ +#ifdef CONFIG_PHY_TI_DP83867 +phy_dp83867_init (); +#endif +return 0 ; +}
drivers/net/phy/ti_phy_init.h new file +15 -0
@@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* TI Generic Ethernet PHY +* +* Author: Dan Murphy <[email protected]> +* +* Copyright (C) 2019-20 Texas Instruments Inc. +*/ + +#ifndef _TI_GEN_PHY_H +#define _TI_GEN_PHY_H + +int phy_dp83867_init (void ); + +#endif /* _TI_GEN_PHY_H */
Signature · 1 line
2.25.1
PATCH v4 4/5 net: phy: Add support for TI PHY init
Quoted 6 lines · Dan Murphy
ti_phy_initfunction was allocated to the DP83867 PHY. This function name is to generic for a specific PHY. The function can be moved to a TI specific file that can register all TI PHYs that are defined in the defconfig. Theti_phy_initfile will contain all TI PHYs initialization so that onlyphy_ti_initcan be called from the framework.
Quoted 7 lines
In addition to the above the config flag for the DP83867 needs to be changed in the
Kconfigand dependent defconfig files. The config flag that was used for the DP83867 was also generic in nature so a more specific config flag for the DP83867 was created.Acked-by Michal Simek <[email protected]>Signed-off-by Dan Murphy <[email protected]>
Applied to u-boot/next, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/d54c8ebd/attachment.sig>
PATCH v4 5/5 net: phy: Add DP8382x phy registration to TI PHY init
In reply to Dan MurphyAdd the DP8382X generic PHY registration to the TI PHY init file.
--- drivers/net/phy/Kconfig | 7 +++ drivers/net/phy/ti_phy_init.c | 83 +++++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+)
drivers/net/phy/Kconfig +7 -0
@@ -252,6 +252,13 @@ config PHY_TI_DP83867 ---help--- Adds support for the TI DP83867 1Gbit PHY. +config PHY_TI_GENERIC + select PHY_TI + bool "Texas Instruments Generic Ethernet PHYs support" + ---help--- + Adds support for Generic TI PHYs that don't need special handling but + the PHY name is associated with a PHY ID. + config PHY_VITESSE bool "Vitesse Ethernet PHYs support"
drivers/net/phy/ti_phy_init.c +83 -0
95 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH v4 5/5 net: phy: Add DP8382x phy registration to TI PHY init
Quoted 4 lines · Dan Murphy
Add the DP8382X generic PHY registration to the TI PHY init file.
Acked-by Michal Simek <[email protected]>Signed-off-by Dan Murphy <[email protected]>
Applied to u-boot/next, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/3ac8c15c/attachment.sig>
v4 cover TI Ethernet PHY changes
In reply to Dan MurphyBump to the series
Quoted 48 lines · Dan Murphy
Hello
The addition of the DP83867 driver to uboot was done in a generic way that made it a bit difficult to bring in new PHY drivers. The difficulty came in the config flags and the
phy_initfunction. The change is to make the flags and init for the DP83867 more specific to the DP83867 device to make way to add more TI PHYs to uBoot.In addition the DP8382X PHY is a generic PHY driver that does not need any special handling to establish a link. Customers have requested that at the very least there be a way to know if the PHY attached is the PHY that is connected as "Generic PHY" is not really descriptive. These patches adds the registrations for TI Generic PHYs to associcate a TI PHY ID with a PHY name.
Porting PHY helper routines to set and clear bits to facilitate easier side porting of ethernet kernel drivers to uBoot.
Also fixed and added missing or kernel doc documentation in the
phy.hfile.Dan
Dan Murphy (5):
net: phy: Add missing kernel doc to phy functions
net: phy: Fix kernel doc issues inphy.h
net: phy: Add helper routines to set and clear bits
net: phy: Add support for TI PHY init
net: phy: Add DP8382x phy registration to TI PHY initconfigs/am65x_evm_a53_defconfig | 2 +- configs/am65x_hs_evm_a53_defconfig | 2 +- configs/dra7xx_evm_defconfig | 2 +- configs/dra7xx_hs_evm_defconfig | 2 +- configs/dra7xx_hs_evm_usb_defconfig | 2 +- configs/j721e_evm_a72_defconfig | 2 +- configs/j721e_hs_evm_a72_defconfig | 2 +- configs/k2g_evm_defconfig | 2 +- configs/xilinx_versal_virt_defconfig | 2 +- configs/xilinx_zynqmp_virt_defconfig | 2 +- drivers/net/phy/Kconfig | 15 ++++ drivers/net/phy/Makefile | 3 +- drivers/net/phy/dp83867.c | 3 +- drivers/net/phy/ti_phy_init.c | 101 ++++++++++++++++++++++++ drivers/net/phy/ti_phy_init.h | 15 ++++ include/phy.h | 112 ++++++++++++++++++++++++--- 16 files changed, 246 insertions(+), 23 deletions(-)create mode 100644
drivers/net/phy/ti_phy_init.ccreate mode 100644drivers/net/phy/ti_phy_init.h
v4 cover TI Ethernet PHY changes
Did I miss the maintainer for this series?
Dan
Quoted 61 lines · Dan Murphy
Bump to the series
Quoted 58 lines · Dan Murphy
Hello
The addition of the DP83867 driver to uboot was done in a generic way that
made it a bit difficult to bring in new PHY drivers.? The difficulty came in the
config flags and thephy_initfunction.? The change is to make the flags and
init for the DP83867 more specific to the DP83867 device to make way to add
more TI PHYs to uBoot.In addition the DP8382X PHY is a generic PHY driver that does not need any
special handling to establish a link.? Customers have requested that at the very
least there be a way to know if the PHY attached is the PHY that is connected
as "Generic PHY" is not really descriptive.? These patches adds the registrations for TI Generic PHYs to associcate a TI PHY ID with a PHY name.Porting PHY helper routines to set and clear bits to facilitate easier side
porting of ethernet kernel drivers to uBoot.Also fixed and added missing or kernel doc documentation in the
phy.hfile.Dan
Dan Murphy (5):
?? net: phy: Add missing kernel doc to phy functions ?? net: phy: Fix kernel doc issues inphy.h
?? net: phy: Add helper routines to set and clear bits ?? net: phy: Add support for TI PHY init
?? net: phy: Add DP8382x phy registration to TI PHY init? configs/am65x_evm_a53_defconfig????? |?? 2 +- ? configs/am65x_hs_evm_a53_defconfig?? |?? 2 +- ? configs/dra7xx_evm_defconfig???????? |?? 2 +- ? configs/dra7xx_hs_evm_defconfig????? |?? 2 +- ? configs/dra7xx_hs_evm_usb_defconfig? |?? 2 +- ? configs/j721e_evm_a72_defconfig????? |?? 2 +- ? configs/j721e_hs_evm_a72_defconfig?? |?? 2 +- ? configs/k2g_evm_defconfig??????????? |?? 2 +- ? configs/xilinx_versal_virt_defconfig |?? 2 +- ? configs/xilinx_zynqmp_virt_defconfig |?? 2 +- ? drivers/net/phy/Kconfig????????????? |? 15 ++++ ? drivers/net/phy/Makefile???????????? |?? 3 +- ? drivers/net/phy/dp83867.c??????????? |?? 3 +- ? drivers/net/phy/ti_phy_init.c??????? | 101 ++++++++++++++++++++++++ ? drivers/net/phy/ti_phy_init.h??????? |? 15 ++++ ? include/phy.h??????????????????????? | 112 ++++++++++++++++++++++++---? 16 files changed, 246 insertions(+), 23 deletions(-) ? create mode 100644
drivers/net/phy/ti_phy_init.c? create mode 100644drivers/net/phy/ti_phy_init.h
v4 cover TI Ethernet PHY changes
In reply to Dan MurphyQuoted 45 lines · Dan Murphy
Hello
The addition of the DP83867 driver to uboot was done in a generic way that made it a bit difficult to bring in new PHY drivers. The difficulty came in the config flags and the
phy_initfunction. The change is to make the flags and init for the DP83867 more specific to the DP83867 device to make way to add more TI PHYs to uBoot.In addition the DP8382X PHY is a generic PHY driver that does not need any special handling to establish a link. Customers have requested that at the very least there be a way to know if the PHY attached is the PHY that is connected as "Generic PHY" is not really descriptive. These patches adds the registrations for TI Generic PHYs to associcate a TI PHY ID with a PHY name.
Porting PHY helper routines to set and clear bits to facilitate easier side porting of ethernet kernel drivers to uBoot.
Also fixed and added missing or kernel doc documentation in the
phy.hfile.Dan
Dan Murphy (5):
net: phy: Add missing kernel doc to phy functions
net: phy: Fix kernel doc issues inphy.h
net: phy: Add helper routines to set and clear bits
net: phy: Add support for TI PHY init
net: phy: Add DP8382x phy registration to TI PHY initconfigs/am65x_evm_a53_defconfig | 2 +- configs/am65x_hs_evm_a53_defconfig | 2 +- configs/dra7xx_evm_defconfig | 2 +- configs/dra7xx_hs_evm_defconfig | 2 +- configs/dra7xx_hs_evm_usb_defconfig | 2 +- configs/j721e_evm_a72_defconfig | 2 +- configs/j721e_hs_evm_a72_defconfig | 2 +- configs/k2g_evm_defconfig | 2 +- configs/xilinx_versal_virt_defconfig | 2 +- configs/xilinx_zynqmp_virt_defconfig | 2 +- drivers/net/phy/Kconfig | 15 ++++ drivers/net/phy/Makefile | 3 +- drivers/net/phy/dp83867.c | 3 +- drivers/net/phy/ti_phy_init.c | 101 ++++++++++++++++++++++++ drivers/net/phy/ti_phy_init.h | 15 ++++ include/phy.h | 112 ++++++++++++++++++++++++--- 16 files changed, 246 insertions(+), 23 deletions(-)
Quoted 3 lines
create mode 100644
drivers/net/phy/ti_phy_init.ccreate mode 100644drivers/net/phy/ti_phy_init.h
Signature · 2 lines
Best regards, grygorii