Skip to contentSkip to conversation

u-boot support for ODROID-C4

PATCH New Beniamino Galvani 3 participants 16 messages May 5, 2020 – Jul 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover u-boot support for ODROID-C4

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

 arch/arm/dts/Makefile                |   1 +
 arch/arm/dts/meson-sm1-odroid-c4.dts | 399 +++++++++++++++++++++++++++
 board/amlogic/odroid-c4/MAINTAINERS  |   6 +
 board/amlogic/odroid-c4/Makefile     |   3 +
 board/amlogic/odroid-c4/README       |  83 ++++++
 board/amlogic/odroid-c4/odroid-c4.c  |  17 ++
 configs/odroid-c4_defconfig          |  63 +++++
 7 files changed, 572 insertions(+)
 create mode 100644 arch/arm/dts/meson-sm1-odroid-c4.dts
 create mode 100644 board/amlogic/odroid-c4/MAINTAINERS
 create mode 100644 board/amlogic/odroid-c4/Makefile
 create mode 100644 board/amlogic/odroid-c4/README
 create mode 100644 board/amlogic/odroid-c4/odroid-c4.c
 create mode 100644 configs/odroid-c4_defconfig
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 arm: dts: import ODROID-C4 device tree

Import the device tree for ODROID-C4 as submitted in [1].

[1] https://lkml.org/lkml/2020/4/24/535

---
 arch/arm/dts/Makefile                |   1 +
 arch/arm/dts/meson-sm1-odroid-c4.dts | 399 +++++++++++++++++++++++++++
 2 files changed, 400 insertions(+)
 create mode 100644 arch/arm/dts/meson-sm1-odroid-c4.dts
arch/arm/dts/Makefile +1 -0
index 559d3ab6a7..70ea72dfaf 100644
@@ -161,6 +161,7 @@ dtb-$(CONFIG_ARCH_MESON) += \
 	meson-g12b-odroid-n2.dtb \
 	meson-g12b-a311d-khadas-vim3.dtb \
 	meson-sm1-khadas-vim3l.dtb \
+	meson-sm1-odroid-c4.dtb \
 	meson-sm1-sei610.dtb
 dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
 	tegra20-medcom-wide.dtb \
arch/arm/dts/meson-sm1-odroid-c4.dts new file +399 -0

399 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/2 boards: amlogic: add ODROID-C4 support

In reply to Beniamino Galvani

Introduce support for ODROID-C4, a single board computer manufactured by Hardkernel Co. Ltd with the following specifications:

- Amlogic S905X3 ARM Cortex-A55 quad-core SoC
- 4GiB DDR4 SDRAM
- Gigabit Ethernet (External Realtek RTL8211F PHY)
- 4 x USB 3.0 Host ports
- 1 x USB 2.0 OTG port
- HDMI 2.0
- eMMC
- SDcard
- 40-pin GPIO header
- Infrared receiver

---
 board/amlogic/odroid-c4/MAINTAINERS |  6 +++
 board/amlogic/odroid-c4/Makefile    |  3 ++
 board/amlogic/odroid-c4/README      | 83 +++++++++++++++++++++++++++++
 board/amlogic/odroid-c4/odroid-c4.c | 17 ++++++
 configs/odroid-c4_defconfig         | 63 ++++++++++++++++++++++
 5 files changed, 172 insertions(+)
 create mode 100644 board/amlogic/odroid-c4/MAINTAINERS
 create mode 100644 board/amlogic/odroid-c4/Makefile
 create mode 100644 board/amlogic/odroid-c4/README
 create mode 100644 board/amlogic/odroid-c4/odroid-c4.c
 create mode 100644 configs/odroid-c4_defconfig
board/amlogic/odroid-c4/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..ebc1a9efe5
@@ -0,0 +1,6 @@
+ODROID-C4
+M:	Beniamino Galvani <[email protected]>
+S:	Maintained
+L:	u-boot-amlogic at groups.io
+F:	board/amlogic/odroid-c4/
+F:	configs/odroid-c4_defconfig
board/amlogic/odroid-c4/Makefile new file +3 -0
new file mode 100644
index 0000000000..a0ca5fb242
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0+
+
+obj-y	:= odroid-c4.o
board/amlogic/odroid-c4/README new file +83 -0

83 lines not on this page · raw message

board/amlogic/odroid-c4/odroid-c4.c new file +17 -0
new file mode 100644
index 0000000000..14f1748fa0
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2016 BayLibre, SAS
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <asm/arch/eth.h>
+
+int misc_init_r(void)
+{
+	meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
+
+	meson_generate_serial_ethaddr();
+
+	return 0;
+}
configs/odroid-c4_defconfig new file +63 -0

63 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw

cover u-boot support for ODROID-C4

In reply to Beniamino Galvani

Hi Beniamino,

Quoted 3 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

Thanks for the patchset, I already have one in my test tree, by you did beat me by sending it to the list !

Quoted 5 lines

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree

The DT is not yet applied by kevin, thus I'll prefer waiting it to be accepted and merged in a stable linux tree to keep DT synced.

Quoted 1 line

boards: amlogic: add ODROID-C4 support

Please re-use the w400 board instead of adding a new board, there is no need for a new one until you'll need to add more functionalities.

I know meson_generate_serial_ethaddr() is absent from w400, I'll add it shortly.

Neil

Quoted 16 lines
 arch/arm/dts/Makefile                |   1 +
 arch/arm/dts/meson-sm1-odroid-c4.dts | 399 +++++++++++++++++++++++++++
 board/amlogic/odroid-c4/MAINTAINERS  |   6 +
 board/amlogic/odroid-c4/Makefile     |   3 +
 board/amlogic/odroid-c4/README       |  83 ++++++
 board/amlogic/odroid-c4/odroid-c4.c  |  17 ++
 configs/odroid-c4_defconfig          |  63 +++++
 7 files changed, 572 insertions(+)
 create mode 100644 arch/arm/dts/meson-sm1-odroid-c4.dts
 create mode 100644 board/amlogic/odroid-c4/MAINTAINERS
 create mode 100644 board/amlogic/odroid-c4/Makefile
 create mode 100644 board/amlogic/odroid-c4/README
 create mode 100644 board/amlogic/odroid-c4/odroid-c4.c
 create mode 100644 configs/odroid-c4_defconfig
#4 lore raw

cover u-boot support for ODROID-C4

Quoted 9 lines · Neil Armstrong

Hi Beniamino,

Quoted 3 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

Thanks for the patchset, I already have one in my test tree, by you did beat me by sending it to the list !

Oh, I didn't notice, sorry.

Quoted 8 lines
Quoted 4 lines

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree

The DT is not yet applied by kevin, thus I'll prefer waiting it to be accepted and merged in a stable linux tree to keep DT synced.

Quoted 6 lines
Quoted 1 line

boards: amlogic: add ODROID-C4 support

Please re-use the w400 board instead of adding a new board, there is no need for a new one until you'll need to add more functionalities.

I know meson_generate_serial_ethaddr() is absent from w400, I'll add it shortly.

Okay, I'll wait that the DT gets merged and then will resubmit using w400.

Thanks,
Beniamino

#5 lore raw

cover u-boot support for ODROID-C4

In reply to Beniamino Galvani

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

#6 lore raw

cover u-boot support for ODROID-C4

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

#7 lore raw

cover u-boot support for ODROID-C4

Hi Neil,

Quoted 25 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

Quoted 7 lines

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:F;RCY:0;EMMC:800;NAND:81;SD?:0;SD:0;READ:0;0.0;CHK:0; bl2_stage_init 0x01
bl2_stage_init 0x81
hw id: 0x0000 - pwm id 0x01
bl2_stage_init 0xc1
bl2_stage_init 0x02

no sdio debug board detected
L0:00000000
L1:00000703
L2:00008067
L3:15000020
S1:00000000
B2:20282000
B1:a0f83180

TE: 260148

BL2 Built : 22:54:32, Apr 28 2020. g12a ga659aac-dirty - changqing.gao at droid11

Board ID = 1
Set cpu clk to 24M
Set clk81 to 24M
Use GP1_pll as DSU clk.
DSU clk: 1200 Mhz
CPU clk: 1200 MHz
Set clk81 to 166.6M
DDR driver_vesion: LPDDR4_PHY_V_0_1_15 build time: Apr 28 2020 22:54:28 board id: 1
Load FIP HDR from SD, src: 0x00010200, des: 0xfffd0000, size:
0x00004000, part: 0
fw parse done
Load ddrfw from SD, src: 0x00030200, des: 0xfffd0000, size: 0x0000c000, part: 0 Load ddrfw from SD, src: 0x0002c200, des: 0xfffd0000, size: 0x00004000, part: 0 PIEI prepare done
fastboot data load
fastboot data verify
verify result: 255
Cfg max: 2, cur: 1. Board id: 255. Force loop cfg
DDR4 probe
ddr clk to 1320MHz
Load ddrfw from SD, src: 0x00014200, des: 0xfffd0000, size: 0x0000c000, part: 0

dmc_version 0001
Check phy result
INFO : End of initialization
INFO : End of read enable training
INFO : End of fine write leveling
INFO : End of read dq deskew training
INFO : End of MPR read delay center optimization
INFO : End of Write leveling coarse delay
INFO : End of write delay center optimization
INFO : End of read delay center optimization
INFO : End of max read latency training
INFO : Training has run successfully!
1D training succeed
Load ddrfw from SD, src: 0x00020200, des: 0xfffd0000, size: 0x0000c000, part: 0 Check phy result
INFO : End of initialization
INFO : End of 2D read delay Voltage center optimization
INFO : End of 2D write delay Voltage center optimization
INFO : Training has run successfully!

R0_RxClkDly_Margin==106 ps 9
R0_TxDqDly_Margi==118 ps 10

R1_RxClkDly_Margin==0 ps 0
R1_TxDqDly_Margi==0 ps 0

dwc_ddrphy_apb_wr((0<<20)|(2<<16)|(0<<12)|(0xb0):0001

soc_vref_reg_value 0x 0000004e 0000004e 0000004e 0000004d 0000004f 0000004e 0000004e 0000004f 0000004c 0000004d 0000004e 0000004c 0000004c 0000004e 0000004f 0000004e 00000050 0000004e 0000004d 0000004e 0000004e 0000004c 0000004d 0000004d 0000004d 0000004f 0000004f 0000004f 0000004d 0000004d 0000004d 0000004f dram_vref_reg_value 0x 00000021
2D training succeed
aml_ddr_fw_vesion: LPDDR4_PHY_V_0_1_15 build time: Jun 18 2019 20:29:43 auto size-- 65535DDR cs0 size: 2048MB
DDR cs1 size: 2048MB
DMC_DDR_CTRL: 00700024DDR size: 3928MB
cs0 DataBus test pass
cs1 DataBus test pass
cs0 AddrBus test pass
cs1 AddrBus test pass

non-sec scramble use zero key
ddr scramble enabled

100bdlr_step_size ps== 461
result report
boot times 0Enable ddr reg access
Load FIP HDR from SD, src: 0x00010200, des: 0x01700000, size:
0x00004000, part: 0
Load BL3X from SD, src: 0x0003c200, des: 0x0172c000, size: 0x00090000, part: 0 0.0;M3 CHK:0;cm4_sp_mode 0
MVN_1=0x00000000
MVN_2=0x00000000
[Image: g12a_v1.1.3386-3b31431 2019-05-21 10:41:54 luan.yuan at droid15-sz] OPS=0x10
ring efuse init
2b 0c 10 00 01 13 20 00 00 0f 36 30 43 57 50 50
[0.017319 Inits done]
secure task start!
high task start!
low task start!
run into bl31

NOTICE:  BL31: v1.3(release):4fc40b1
NOTICE:  BL31: Built : 15:57:33, May 22 2019
NOTICE:  BL31: G12A normal boot!
NOTICE:  BL31: BL33 decompress pass
ERROR:   Error initializing runtime service opteed_fast

U-Boot 2020.07-rc5-00076-g46e5b60e21 (Jun 30 2020 - 21:08:25 +0530) odroid-c4

Model: Hardkernel ODROID-C4
SoC:   Amlogic Meson SM1 (Unknown) Revision 2b:c (10:2)
DRAM:  3.8 GiB
MMC:   sd at ffe05000: 0, mmc at ffe07000: 1
stdio_add_devices: Video device failed (ret=-22)
In:    serial at 3000
Out:   serial at 3000
Err:   serial at 3000
Net:   Could not get PHY for ethernet@ff3f0000: addr 8

No ethernet found.

Hit any key to stop autoboot: 0

-Anand

#8 lore raw

cover u-boot support for ODROID-C4

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Quoted 134 lines

SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:F;RCY:0;EMMC:800;NAND:81;SD?:0;SD:0;READ:0;0.0;CHK:0; bl2_stage_init 0x01
bl2_stage_init 0x81
hw id: 0x0000 - pwm id 0x01
bl2_stage_init 0xc1
bl2_stage_init 0x02

no sdio debug board detected
L0:00000000
L1:00000703
L2:00008067
L3:15000020
S1:00000000
B2:20282000
B1:a0f83180

TE: 260148

BL2 Built : 22:54:32, Apr 28 2020. g12a ga659aac-dirty - changqing.gao at droid11

Board ID = 1
Set cpu clk to 24M
Set clk81 to 24M
Use GP1_pll as DSU clk.
DSU clk: 1200 Mhz
CPU clk: 1200 MHz
Set clk81 to 166.6M
DDR driver_vesion: LPDDR4_PHY_V_0_1_15 build time: Apr 28 2020 22:54:28 board id: 1
Load FIP HDR from SD, src: 0x00010200, des: 0xfffd0000, size:
0x00004000, part: 0
fw parse done
Load ddrfw from SD, src: 0x00030200, des: 0xfffd0000, size: 0x0000c000, part: 0 Load ddrfw from SD, src: 0x0002c200, des: 0xfffd0000, size: 0x00004000, part: 0 PIEI prepare done
fastboot data load
fastboot data verify
verify result: 255
Cfg max: 2, cur: 1. Board id: 255. Force loop cfg
DDR4 probe
ddr clk to 1320MHz
Load ddrfw from SD, src: 0x00014200, des: 0xfffd0000, size: 0x0000c000, part: 0

dmc_version 0001
Check phy result
INFO : End of initialization
INFO : End of read enable training
INFO : End of fine write leveling
INFO : End of read dq deskew training
INFO : End of MPR read delay center optimization
INFO : End of Write leveling coarse delay
INFO : End of write delay center optimization
INFO : End of read delay center optimization
INFO : End of max read latency training
INFO : Training has run successfully!
1D training succeed
Load ddrfw from SD, src: 0x00020200, des: 0xfffd0000, size: 0x0000c000, part: 0 Check phy result
INFO : End of initialization
INFO : End of 2D read delay Voltage center optimization
INFO : End of 2D write delay Voltage center optimization
INFO : Training has run successfully!

R0_RxClkDly_Margin==106 ps 9
R0_TxDqDly_Margi==118 ps 10

R1_RxClkDly_Margin==0 ps 0
R1_TxDqDly_Margi==0 ps 0

dwc_ddrphy_apb_wr((0<<20)|(2<<16)|(0<<12)|(0xb0):0001

soc_vref_reg_value 0x 0000004e 0000004e 0000004e 0000004d 0000004f 0000004e 0000004e 0000004f 0000004c 0000004d 0000004e 0000004c 0000004c 0000004e 0000004f 0000004e 00000050 0000004e 0000004d 0000004e 0000004e 0000004c 0000004d 0000004d 0000004d 0000004f 0000004f 0000004f 0000004d 0000004d 0000004d 0000004f dram_vref_reg_value 0x 00000021
2D training succeed
aml_ddr_fw_vesion: LPDDR4_PHY_V_0_1_15 build time: Jun 18 2019 20:29:43 auto size-- 65535DDR cs0 size: 2048MB
DDR cs1 size: 2048MB
DMC_DDR_CTRL: 00700024DDR size: 3928MB
cs0 DataBus test pass
cs1 DataBus test pass
cs0 AddrBus test pass
cs1 AddrBus test pass

non-sec scramble use zero key
ddr scramble enabled

100bdlr_step_size ps== 461
result report
boot times 0Enable ddr reg access
Load FIP HDR from SD, src: 0x00010200, des: 0x01700000, size:
0x00004000, part: 0
Load BL3X from SD, src: 0x0003c200, des: 0x0172c000, size: 0x00090000, part: 0 0.0;M3 CHK:0;cm4_sp_mode 0
MVN_1=0x00000000
MVN_2=0x00000000
[Image: g12a_v1.1.3386-3b31431 2019-05-21 10:41:54 luan.yuan at droid15-sz] OPS=0x10
ring efuse init
2b 0c 10 00 01 13 20 00 00 0f 36 30 43 57 50 50
[0.017319 Inits done]
secure task start!
high task start!
low task start!
run into bl31

NOTICE:  BL31: v1.3(release):4fc40b1
NOTICE:  BL31: Built : 15:57:33, May 22 2019
NOTICE:  BL31: G12A normal boot!
NOTICE:  BL31: BL33 decompress pass
ERROR:   Error initializing runtime service opteed_fast

U-Boot 2020.07-rc5-00076-g46e5b60e21 (Jun 30 2020 - 21:08:25 +0530) odroid-c4

Model: Hardkernel ODROID-C4
SoC:   Amlogic Meson SM1 (Unknown) Revision 2b:c (10:2)
DRAM:  3.8 GiB
MMC:   sd at ffe05000: 0, mmc at ffe07000: 1
stdio_add_devices: Video device failed (ret=-22)
In:    serial at 3000
Out:   serial at 3000
Err:   serial at 3000
Net:   Could not get PHY for ethernet at ff3f0000: addr 8

No ethernet found.

Hit any key to stop autoboot: 0

-Anand

#9 lore raw

cover u-boot support for ODROID-C4

Hi Neil,

Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Quoted 8 lines

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Thanks.

There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst
instead of *g12b*, it should be *g12a*

See below I get following build warning, which I fix locally,

./buildc4c.sh: line 78:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 81:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 84:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 87:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 90:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 92:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory

After that fix I am able to boot my board using eMMC and microSD card.

-Anand

#10 lore raw

cover u-boot support for ODROID-C4

Hi,

Quoted 85 lines · Anand Moon

Hi Neil,

Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Quoted 8 lines

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Thanks.

There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst
instead of *g12b*, it should be *g12a*

See below I get following build warning, which I fix locally,

./buildc4c.sh: line 78:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 81:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 84:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 87:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 90:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 92:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory

Quoted 1 line

After that fix I am able to boot my board using eMMC and microSD card.

Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo.

Neil

Quoted 3 lines

-Anand

#11 lore raw

cover u-boot support for ODROID-C4

Hi Neil,

Quoted 89 lines · Neil Armstrong

Hi,

Quoted 85 lines · Anand Moon

Hi Neil,

Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Quoted 8 lines

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Thanks.

There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst
instead of *g12b*, it should be *g12a*

See below I get following build warning, which I fix locally,

./buildc4c.sh: line 78:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 81:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 84:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 87:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 90:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 92:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory

Quoted 6 lines
Quoted 1 line

After that fix I am able to boot my board using eMMC and microSD card.

Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo.

Neil

Thanks, I see the same issue with random mac address just like N2.

-Anand

#12 lore raw

cover u-boot support for ODROID-C4

Quoted 92 lines · Anand Moon

Hi Neil,

Quoted 89 lines · Neil Armstrong

Hi,

Quoted 85 lines · Anand Moon

Hi Neil,

Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Quoted 8 lines

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Thanks.

There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst
instead of *g12b*, it should be *g12a*

See below I get following build warning, which I fix locally,

./buildc4c.sh: line 78:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 81:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 84:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 87:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 90:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 92:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

After that fix I am able to boot my board using eMMC and microSD card.

Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo.

Neil

Thanks, I see the same issue with random mac address just like N2.

Yes, my branch was not using the N2 board support with eFuses MAC readout, can you test my last patchset I just sent ? It should use the MAC from eFuses or generate an unique address with the SoC serial number.

Please apply the patch in [1] before the new Odroid-C4 serie.

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

Neil

Quoted 3 lines

-Anand

#13 lore raw

cover u-boot support for ODROID-C4

Hi Neil,

Quoted 98 lines · Neil Armstrong
Quoted 96 lines · Anand Moon

Hi Neil,

Quoted 93 lines · Neil Armstrong

Hi,

Quoted 85 lines · Anand Moon

Hi Neil,

Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Quoted 8 lines

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Thanks.

There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst
instead of *g12b*, it should be *g12a*

See below I get following build warning, which I fix locally,

./buildc4c.sh: line 78:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 81:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 84:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 87:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 90:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 92:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory

Quoted 1 line

After that fix I am able to boot my board using eMMC and microSD card.

Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

Neil

Thanks, I see the same issue with random mac address just like N2.

Yes, my branch was not using the N2 board support with eFuses MAC readout, can you test my last patchset I just sent ? It should use the MAC from eFuses or generate an unique address with the SoC serial number.

Thanks

Quoted 5 lines

Please apply the patch in [1] before the new Odroid-C4 serie.

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

Neil

I do not know the reason but your patches are not showing up on u-boot patchwork.

[0] https://patchwork.ozlabs.org/project/uboot/list/

-Anand

#14 lore raw

cover u-boot support for ODROID-C4

Quoted 114 lines · Anand Moon

Hi Neil,

Quoted 98 lines · Neil Armstrong
Quoted 96 lines · Anand Moon

Hi Neil,

Quoted 93 lines · Neil Armstrong

Hi,

Quoted 85 lines · Anand Moon

Hi Neil,

Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Quoted 8 lines

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Thanks.

There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst
instead of *g12b*, it should be *g12a*

See below I get following build warning, which I fix locally,

./buildc4c.sh: line 78:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 81:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 84:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 87:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 90:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 92:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory

Quoted 1 line

After that fix I am able to boot my board using eMMC and microSD card.

Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

Neil

Thanks, I see the same issue with random mac address just like N2.

Yes, my branch was not using the N2 board support with eFuses MAC readout, can you test my last patchset I just sent ? It should use the MAC from eFuses or generate an unique address with the SoC serial number.

Thanks

Quoted 2 lines

Please apply the patch in [1] before the new Odroid-C4 serie.

Quoted 8 lines
Quoted 3 lines

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

Neil

I do not know the reason but your patches are not showing up on u-boot patchwork.

[0] https://patchwork.ozlabs.org/project/uboot/list/

Good question !

Neil

Quoted 3 lines

-Anand

#15 lore raw

cover u-boot support for ODROID-C4

Hi Neil,

Quoted 120 lines · Neil Armstrong
Quoted 118 lines · Anand Moon

Hi Neil,

Quoted 98 lines · Neil Armstrong
Quoted 96 lines · Anand Moon

Hi Neil,

Quoted 93 lines · Neil Armstrong

Hi,

Quoted 85 lines · Anand Moon

Hi Neil,

Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Anand Moon

Hi Neil,

Quoted 29 lines · Neil Armstrong

Hi,

Quoted 15 lines · Anand Moon

Hi Beniamino,

Quoted 11 lines · Beniamino Galvani

Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
arm: dts: import ODROID-C4 device tree
boards: amlogic: add ODROID-C4 support

Quoted 5 lines

Can you respin this patches, I would like to see these get merged in the current u-boot release

-Anand

The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1]

Anand, is the MAC address stored stored the same way on the C4 ?

Quoted 7 lines
Quoted 3 lines

Neil

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC
Here are the logs.

The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI.

Quoted 8 lines

Can you test my custodian test branch with my C4 support patchset ?

https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test

This one is used in Armbian 5.4 release and our KernelCI lab.

Neil

Thanks.

There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst
instead of *g12b*, it should be *g12a*

See below I get following build warning, which I fix locally,

./buildc4c.sh: line 78:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 81:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 84:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 87:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 90:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory
./buildc4c.sh: line 92:
/home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a:
No such file or directory

Quoted 1 line

After that fix I am able to boot my board using eMMC and microSD card.

Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

Neil

Thanks, I see the same issue with random mac address just like N2.

Yes, my branch was not using the N2 board support with eFuses MAC readout, can you test my last patchset I just sent ? It should use the MAC from eFuses or generate an unique address with the SoC serial number.

Thanks

Quoted 5 lines

Please apply the patch in [1] before the new Odroid-C4 serie.

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstrong at baylibre.com/

Neil

Quoted 9 lines
Quoted 4 lines

I do not know the reason but your patches are not showing up on u-boot patchwork.

[0] https://patchwork.ozlabs.org/project/uboot/list/

Good question !

Neil

Now it's showing up on u-boot patchwork.

https://patchwork.ozlabs.org/project/uboot/list/?series=187096

-Anand