Skip to contentSkip to conversation

common/qat: fix stats update

PATCH Applied Adam Dybkowski 3 participants 3 messages May 6, 2020 – May 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/qat: fix stats update

This patch fixes enqueued and dequeued count statistics that should contain the numer of operations enqueued by the end user app instead of the total number of QAT requests - bigger in case of a multiple-request dynamic Huffman compression operation.

Fixes c13cecf60f12 ("compress/qat: support IM buffer too small operation")

---

Requires applying other patch first: http://patches.dpdk.org/patch/69765/

---
 drivers/common/qat/qat_qp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/common/qat/qat_qp.c +2 -2
index 098b99786..9d7091af3 100644
@@ -818,7 +818,7 @@ qat_enqueue_comp_op_burst(void *qp, void **ops, uint16_t nb_ops)
 kick_tail:
 	queue->tail = tail;
 	tmp_qp->enqueued += total_descriptors_built;
-	tmp_qp->stats.enqueued_count += total_descriptors_built;
+	tmp_qp->stats.enqueued_count += nb_ops_sent;
 	txq_write_tail(tmp_qp, queue);
 	return nb_ops_sent;
 }
@@ -880,7 +880,7 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 	}
 
 	tmp_qp->dequeued += fw_resp_counter;
-	tmp_qp->stats.dequeued_count += fw_resp_counter;
+	tmp_qp->stats.dequeued_count += op_resp_counter;
 
 	rx_queue->head = head;
 	if (rx_queue->nb_processed_responses > QAT_CSR_HEAD_WRITE_THRESH)
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Wednesday, May 6, 2020 12:30 PM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH] common/qat: fix stats update

Quoted 8 lines

This patch fixes enqueued and dequeued count statistics that should contain the numer of operations enqueued by the end user app instead of the total number of QAT requests - bigger in case of a multiple-request dynamic Huffman compression operation.

Fixes c13cecf60f12 ("compress/qat: support IM buffer too small operation")
Applied
#2 lore raw
Quoted 9 lines
Quoted 8 lines

This patch fixes enqueued and dequeued count statistics that should contain the numer of operations enqueued by the end user app instead of the total number of QAT requests - bigger in case of a multiple-request dynamic Huffman compression operation.

Fixes c13cecf60f12 ("compress/qat: support IM buffer too small operation")

Applied to dpdk-next-crypto

Thanks.