Skip to contentSkip to conversation

drm/mediatek: cleanup coding style in mediatek a bit

PATCH Applied Bernard Zhao 2 participants 3 messages May 6, 2020 – May 10, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/mediatek: cleanup coding style in mediatek a bit

This code change is to make code bit more readable.

---
 drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/mediatek/mtk_hdmi.c +4 -8
index ff43a3d80410..43e9876fd50c 100644
@@ -311,14 +311,10 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
 	u8 checksum;
 	int ctrl_frame_en = 0;
 
-	frame_type = *buffer;
-	buffer += 1;
-	frame_ver = *buffer;
-	buffer += 1;
-	frame_len = *buffer;
-	buffer += 1;
-	checksum = *buffer;
-	buffer += 1;
+	frame_type = *buffer++;
+	frame_ver = *buffer++;
+	frame_len = *buffer++;
+	checksum = *buffer++;
 	frame_data = buffer;
 
 	dev_dbg(hdmi->dev,
Signature · 1 line
2.26.2
maintainer Reviewed-by on v2 1/1
#1 lore raw

Hi, Bernard:

Bernard Zhao <[email protected]> 於 2020年5月6日 週三 下午8:34寫道:

Quoted 3 lines

This code change is to make code bit more readable.

Quoted 29 lines
---
 drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/mediatek/mtk_hdmi.c +4 -9
index ff43a3d80410..43e9876fd50c 100644
@@ -311,14 +311,10 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
        u8 checksum;
        int ctrl_frame_en = 0;
 
-       frame_type = *buffer;
-       buffer += 1;
-       frame_ver = *buffer;
-       buffer += 1;
-       frame_len = *buffer;
-       buffer += 1;
-       checksum = *buffer;
-       buffer += 1;
+       frame_type = *buffer++;
+       frame_ver = *buffer++;
+       frame_len = *buffer++;
+       checksum = *buffer++;
        frame_data = buffer;
 
        dev_dbg(hdmi->dev,
--
Quoted 2 lines

2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer Applied
#2 lore raw
In reply to Bernard Zhao

Hi, Bernard:

Bernard Zhao <[email protected]> 於 2020年5月6日 週三 下午8:34寫道:

Quoted 3 lines

This code change is to make code bit more readable.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang

Quoted 29 lines
---
 drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/mediatek/mtk_hdmi.c +4 -9
index ff43a3d80410..43e9876fd50c 100644
@@ -311,14 +311,10 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
        u8 checksum;
        int ctrl_frame_en = 0;
 
-       frame_type = *buffer;
-       buffer += 1;
-       frame_ver = *buffer;
-       buffer += 1;
-       frame_len = *buffer;
-       buffer += 1;
-       checksum = *buffer;
-       buffer += 1;
+       frame_type = *buffer++;
+       frame_ver = *buffer++;
+       frame_len = *buffer++;
+       checksum = *buffer++;
        frame_data = buffer;
 
        dev_dbg(hdmi->dev,
--
Quoted 2 lines

2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel