drm/mediatek: eliminate the magic number in array size
Subsystems (3)
PATCH 1/1 drm/mediatek: eliminate the magic number in array size
Eiminate the magic number in array size, there macro defines in hdmi.h.
--- drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/mediatek/mtk_hdmi.c +3 -3
@@ -982,7 +982,7 @@ static int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, struct drm_display_mode *mode) {struct hdmi_avi_infoframe frame; -u8 buffer[17 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_AVI_INFOFRAME_SIZE ];ssize_t err; err = drm_hdmi_avi_infoframe_from_display_mode(&frame,
@@ -1008,7 +1008,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi, const char *product) {struct hdmi_spd_infoframe frame; -u8 buffer[29 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_SPD_INFOFRAME_SIZE ];ssize_t err; err =hdmi_spd_infoframe_init (&frame, vendor, product);
@@ -1031,7 +1031,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi,static int mtk_hdmi_setup_audio_infoframe (struct mtk_hdmi *hdmi) {struct hdmi_audio_infoframe frame; -u8 buffer[14 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_AUDIO_INFOFRAME_SIZE ];ssize_t err; err =hdmi_audio_infoframe_init (&frame);
Signature · 7 lines
2.26.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, Bernard:
Bernard Zhao <[email protected]> 於 2020年5月6日 週三 下午8:43寫道:
Quoted 3 lines
Eiminate the magic number in array size, there macro defines in
hdmi.h.
Quoted 38 lines
Signed-off-by Bernard Zhao <[email protected]>--- drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/mediatek/mtk_hdmi.c +3
-4@@ -982,7 +982,7 @@ static int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, struct drm_display_mode *mode) {struct hdmi_avi_infoframe frame; -u8 buffer[17 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_AVI_INFOFRAME_SIZE ];ssize_t err; err = drm_hdmi_avi_infoframe_from_display_mode(&frame,@@ -1008,7 +1008,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi, const char *product) {struct hdmi_spd_infoframe frame; -u8 buffer[29 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_SPD_INFOFRAME_SIZE ];ssize_t err; err =hdmi_spd_infoframe_init (&frame, vendor, product);@@ -1031,7 +1031,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi,static int mtk_hdmi_setup_audio_infoframe (struct mtk_hdmi *hdmi) {struct hdmi_audio_infoframe frame; -u8 buffer[14 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_AUDIO_INFOFRAME_SIZE ];ssize_t err; err =hdmi_audio_infoframe_init (&frame); --
Quoted 2 lines
2.26.2
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi, Bernard:
Bernard Zhao <[email protected]> 於 2020年5月6日 週三 下午8:43寫道:
Quoted 3 lines
Eiminate the magic number in array size, there macro defines in
hdmi.h.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang
Quoted 38 lines
Signed-off-by Bernard Zhao <[email protected]>--- drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/mediatek/mtk_hdmi.c +3
-4@@ -982,7 +982,7 @@ static int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, struct drm_display_mode *mode) {struct hdmi_avi_infoframe frame; -u8 buffer[17 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_AVI_INFOFRAME_SIZE ];ssize_t err; err = drm_hdmi_avi_infoframe_from_display_mode(&frame,@@ -1008,7 +1008,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi, const char *product) {struct hdmi_spd_infoframe frame; -u8 buffer[29 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_SPD_INFOFRAME_SIZE ];ssize_t err; err =hdmi_spd_infoframe_init (&frame, vendor, product);@@ -1031,7 +1031,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi,static int mtk_hdmi_setup_audio_infoframe (struct mtk_hdmi *hdmi) {struct hdmi_audio_infoframe frame; -u8 buffer[14 ]; +u8 buffer[HDMI_INFOFRAME_HEADER_SIZE +HDMI_AUDIO_INFOFRAME_SIZE ];ssize_t err; err =hdmi_audio_infoframe_init (&frame); --
Quoted 2 lines
2.26.2
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel