Skip to contentSkip to conversation

(no subject)

Buildroot New Norbert Lange 2 participants 6 messages May 6, 2020 – May 9, 2020

lore
Share & tools
lore
#1 lore raw

PATCH v2 1/2 package/fakeroot: bump version to 1.24

---
 ...02-Select-TCP-when-lack-of-SYSV-IPC.patch} |  0
 ...nicate-check-return-status-of-msgrcv.patch | 46 -------------------
 package/fakeroot/fakeroot.hash                |  6 +--
 package/fakeroot/fakeroot.mk                  |  6 +--
 4 files changed, 5 insertions(+), 53 deletions(-)
 rename package/fakeroot/{0003-Select-TCP-when-lack-of-SYSV-IPC.patch => 0002-Select-TCP-when-lack-of-SYSV-IPC.patch} (100%)
 delete mode 100644 package/fakeroot/0002-communicate-check-return-status-of-msgrcv.patch
package/fakeroot/0002-Select-TCP-when-lack-of-SYSV-IPC.patch renamed from package/fakeroot/0003-Select-TCP-when-lack-of-SYSV-IPC.patch +0 -0
similarity index 100%
rename from package/fakeroot/0003-Select-TCP-when-lack-of-SYSV-IPC.patch
rename to package/fakeroot/0002-Select-TCP-when-lack-of-SYSV-IPC.patch
package/fakeroot/0002-communicate-check-return-status-of-msgrcv.patch deleted +0 -46

46 lines not on this page · raw message

package/fakeroot/fakeroot.hash +2 -4
index d1d959df6f..633bda0cb9 100644
@@ -1,6 +1,4 @@
-# From http://snapshot.debian.org/package/fakeroot/1.20.2-1/
-sha1	367040df07043edb630942b21939e493f3fad888	fakeroot_1.20.2.orig.tar.bz2
-# Calculated based on the hash above
-sha256	7c0a164d19db3efa9e802e0fc7cdfeff70ec6d26cdbdc4338c9c2823c5ea230c	fakeroot_1.20.2.orig.tar.bz2
+# From http://deb.debian.org/debian/pool/main/f/fakeroot/fakeroot_1.24-1.dsc
+sha256	2e045b3160370b8ab4d44d1f8d267e5d1d555f1bb522d650e7167b09477266ed	fakeroot_1.24.orig.tar.gz
 # License files, locally calculated
 sha256	fc82ca8b6fdb18d4e3e85cfd8ab58d1bcd3f1b29abe782895abd91d64763f8e7	COPYING
package/fakeroot/fakeroot.mk +3 -3
index 1be99071bf..39a6906182 100644
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-FAKEROOT_VERSION = 1.20.2
-FAKEROOT_SOURCE = fakeroot_$(FAKEROOT_VERSION).orig.tar.bz2
-FAKEROOT_SITE = http://snapshot.debian.org/archive/debian/20141005T221953Z/pool/main/f/fakeroot
+FAKEROOT_VERSION = 1.24
+FAKEROOT_SOURCE = fakeroot_$(FAKEROOT_VERSION).orig.tar.gz
+FAKEROOT_SITE = http://deb.debian.org/debian/pool/main/f/fakeroot
 
 HOST_FAKEROOT_DEPENDENCIES = host-acl
 # Force capabilities detection off
Signature · 1 line
2.26.2
#2 lore raw

PATCH v2 1/2 package/fakeroot: bump version to 1.24

Quoted 9 lines · On Wed, 6 May 2020 15:11:29 +0200 Norbert Lange <[email protected]> wrote:
---
 ...02-Select-TCP-when-lack-of-SYSV-IPC.patch} |  0
 ...nicate-check-return-status-of-msgrcv.patch | 46 -------------------
 package/fakeroot/fakeroot.hash                |  6 +--
 package/fakeroot/fakeroot.mk                  |  6 +--
 4 files changed, 5 insertions(+), 53 deletions(-)
 rename package/fakeroot/{0003-Select-TCP-when-lack-of-SYSV-IPC.patch => 0002-Select-TCP-when-lack-of-SYSV-IPC.patch} (100%)
 delete mode 100644 package/fakeroot/0002-communicate-check-return-status-of-msgrcv.patch

What happened to 0002-communicate-check-return-status-of-msgrcv.patch ? It is removed by your patch. Why?

Also, your PATCH 1/2 is a version bump, but PATCH 2/2 is a bug fix. Since Buildroot 2020.05-rc1 has now been released, we normally don't merge version bumps in master.

Could you clarify if the fchownat/fchmodat issue happens with the current version of fakeroot in Buildroot (1.20) ? Or only with the updated version 1.24 ? Can it be fixed with fakeroot 1.20 ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v2 1/2 package/fakeroot: bump version to 1.24

Am Sa., 9. Mai 2020 um 18:50 Uhr schrieb Thomas Petazzoni <[email protected]>:

Quoted 14 lines
Quoted 9 lines · On Wed, 6 May 2020 15:11:29 +0200 Norbert Lange <[email protected]> wrote:
---
 ...02-Select-TCP-when-lack-of-SYSV-IPC.patch} |  0
 ...nicate-check-return-status-of-msgrcv.patch | 46 -------------------
 package/fakeroot/fakeroot.hash                |  6 +--
 package/fakeroot/fakeroot.mk                  |  6 +--
 4 files changed, 5 insertions(+), 53 deletions(-)
 rename package/fakeroot/{0003-Select-TCP-when-lack-of-SYSV-IPC.patch => 0002-Select-TCP-when-lack-of-SYSV-IPC.patch} (100%)
 delete mode 100644 package/fakeroot/0002-communicate-check-return-status-of-msgrcv.patch
Quoted 2 lines

What happened to 0002-communicate-check-return-status-of-msgrcv.patch ? It is removed by your patch. Why?

Cause its included in that version

Quoted 8 lines

Also, your PATCH 1/2 is a version bump, but PATCH 2/2 is a bug fix. Since Buildroot 2020.05-rc1 has now been released, we normally don't merge version bumps in master.

Could you clarify if the fchownat/fchmodat issue happens with the current version of fakeroot in Buildroot (1.20) ? Or only with the updated version 1.24 ? Can it be fixed with fakeroot 1.20 ?

issue exist with both, could certainly be fixed in 1.20 separately, I just don't take much interest in fixing ~ 4 year versions by default.

Norbert

#4 lore raw

PATCH v2 1/2 package/fakeroot: bump version to 1.24

Quoted 4 lines · On Sat, 9 May 2020 23:29:22 +0200 Norbert Lange <[email protected]> wrote:
Quoted 2 lines

What happened to 0002-communicate-check-return-status-of-msgrcv.patch ? It is removed by your patch. Why?

Cause its included in that version

OK.

Quoted 6 lines
Quoted 3 lines

Could you clarify if the fchownat/fchmodat issue happens with the current version of fakeroot in Buildroot (1.20) ? Or only with the updated version 1.24 ? Can it be fixed with fakeroot 1.20 ?

issue exist with both, could certainly be fixed in 1.20 separately, I just don't take much interest in fixing ~ 4 year versions by default.

In the general case, I agree. But here we have already tagged -rc1, and we try to not merge version bumps so close to the release. And in the context of Buildroot, fakeroot is used by *everybody*, so any regression can cause issues to a significant number of users.

So I'd prefer to see the problem fixed for 1.20, so that we can apply the fix on master, and then have the version bump to 1.24 in next.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH v2 2/2 package/fakeroot: fix for fchownat/fchmodat

In reply to Norbert Lange

fakeroot does mask out necessary flags, instead pass through the flags that are supported by fstatat

Upstream BR: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959876

---
 package/fakeroot/0003_fix_fchownat.patch | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 package/fakeroot/0003_fix_fchownat.patch
package/fakeroot/0003_fix_fchownat.patch new file +24 -0
new file mode 100644
index 0000000000..d200654910
@@ -0,0 +1,24 @@
+Description: fix chownat/chmodat when pathname is empty
+ this forwards all supported flags to fstatat,
+ instead of masking them out and causing errors.
+
+--- a/libfakeroot.c
++++ b/libfakeroot.c
+@@ -886,7 +886,7 @@
+   /* If AT_SYMLINK_NOFOLLOW is set in the fchownat call it should
+      be when we stat it. */
+   INT_STRUCT_STAT st;
+-  r=INT_NEXT_FSTATAT(dir_fd, path, &st, (flags & AT_SYMLINK_NOFOLLOW));
++  r=INT_NEXT_FSTATAT(dir_fd, path, &st, (flags & (AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH | AT_NO_AUTOMOUNT)));
+
+   if(r)
+     return(r);
+@@ -1023,7 +1023,7 @@
+
+   /* If AT_SYMLINK_NOFOLLOW is set in the fchownat call it should
+      be when we stat it. */
+-  r=INT_NEXT_FSTATAT(dir_fd, path, &st, flags & AT_SYMLINK_NOFOLLOW);
++  r=INT_NEXT_FSTATAT(dir_fd, path, &st, flags & (AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH | AT_NO_AUTOMOUNT));
+
+   if(r)
+     return(r);
Signature · 1 line
2.26.2