media: gpio-ir-tx: improve precision of transmitted signal due to scheduling
Subsystems (3)
Sean Young
maintainerPATCH v2 1/2 media: gpio-ir-tx: improve precision of transmitted signal due to scheduling
usleep_range() may take longer than the max argument due to scheduling, especially under load. This is causing random errors in the transmitted IR. Remove the usleep_range() in favour of busy-looping with udelay().
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/gpio-ir-tx.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/media/rc/gpio-ir-tx.c +1 -6
@@ -79,13 +79,8 @@ static int gpio_ir_tx(struct rc_dev *dev, unsigned int *txbuf,// space edge =ktime_add_us (edge, txbuf[i]); delta =ktime_us_delta (edge,ktime_get ()); -if (delta >10 ) { -spin_unlock_irqrestore (&gpio_ir->lock, flags); -usleep_range (delta, delta +10 ); -spin_lock_irqsave (&gpio_ir->lock, flags); - }else if (delta >0 ) { +if (delta >0 )udelay (delta); - } }else {// pulse ktime_t last =ktime_add_us (edge, txbuf[i]);
Signature · 1 line
2.26.2
Sean Young
maintainerPATCH v2 2/2 media: gpio-ir-tx: allow transmission without carrier
Some IR protocols do not use a carrier.
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/gpio-ir-tx.c | 45 ++++++++++++++++++++++++++++++----- 1 file changed, 39 insertions(+), 6 deletions(-)
drivers/media/rc/gpio-ir-tx.c +39 -6
@@ -42,18 +42,40 @@ static int gpio_ir_tx_set_carrier(struct rc_dev *dev, u32 carrier) {struct gpio_ir *gpio_ir = dev->priv; -if (!carrier) -return -EINVAL ; - gpio_ir->carrier = carrier;return 0 ; } -static int gpio_ir_tx (struct rc_dev *dev,unsigned int *txbuf, -unsigned int count) +static void gpio_ir_tx_unmodulated (struct gpio_ir *gpio_ir,uint *txbuf, +uint count) +{ +unsigned long flags; +ktime_t edge; +s32 delta; +int i; + +spin_lock_irqsave (&gpio_ir->lock, flags); + + edge =ktime_get (); + +for (i =0 ; i < count; i++) { +gpiod_set_value (gpio_ir->gpio, !(i %2 )); + + edge =ktime_add_us (edge, txbuf[i]); + delta =ktime_us_delta (edge,ktime_get ()); +if (delta >0 ) +udelay (delta); + } + +gpiod_set_value (gpio_ir->gpio,0 ); + +spin_unlock_irqrestore (&gpio_ir->lock, flags); +} + +static void gpio_ir_tx_modulated (struct gpio_ir *gpio_ir,uint *txbuf, +uint count) { -struct gpio_ir *gpio_ir = dev->priv;unsigned long flags;ktime_t edge;/*
@@ -105,6 +127,17 @@ static int gpio_ir_tx(struct rc_dev *dev, unsigned int *txbuf, }spin_unlock_irqrestore (&gpio_ir->lock, flags); +} + +static int gpio_ir_tx (struct rc_dev *dev,unsigned int *txbuf, +unsigned int count) +{ +struct gpio_ir *gpio_ir = dev->priv; + +if (gpio_ir->carrier) +gpio_ir_tx_modulated (gpio_ir, txbuf, count); +else +gpio_ir_tx_unmodulated (gpio_ir, txbuf, count);return count; }
Signature · 1 line
2.26.2