Skip to contentSkip to conversation

Driver: hv: vmbus: drop a no long applicable comment

PATCH In review Wei Liu 2 participants 3 messages May 6, 2020 – May 7, 2020

Subsystems (2)
lore
Share & tools
lore

Wei Liu

author maintainer
#0 lore raw

PATCH 1/1 Driver: hv: vmbus: drop a no long applicable comment

None of the things mentioned in the comment is initialized in hv_init. They've been moved elsewhere.

---
 drivers/hv/vmbus_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/hv/vmbus_drv.c +0 -1
index 3a27f6c5f3de..7efdcadc335e 100644
@@ -1396,7 +1396,6 @@ static int vmbus_bus_init(void)
 {
 	int ret;
 
-	/* Hypervisor initialization...setup hypercall page..etc */
 	ret = hv_init();
 	if (ret != 0) {
 		pr_err("Unable to initialize the hypervisor - 0x%x\n", ret);
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

From: Wei Liu <[email protected]> Sent: Wednesday, May 6, 2020 9:08 AM

Quoted 22 lines

None of the things mentioned in the comment is initialized in hv_init. They've been moved elsewhere.

---
 drivers/hv/vmbus_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/hv/vmbus_drv.c +0 -2
index 3a27f6c5f3de..7efdcadc335e 100644
@@ -1396,7 +1396,6 @@ static int vmbus_bus_init(void)
 {
 	int ret;
 
-	/* Hypervisor initialization...setup hypercall page..etc */
 	ret = hv_init();
 	if (ret != 0) {
 		pr_err("Unable to initialize the hypervisor - 0x%x\n", ret);
--
Quoted 1 line

2.20.1

author maintainer Applied
#2 lore raw
Quoted 18 lines · Michael Kelley

From: Wei Liu <[email protected]> Sent: Wednesday, May 6, 2020 9:08 AM

Quoted 17 lines

None of the things mentioned in the comment is initialized in hv_init. They've been moved elsewhere.

---
 drivers/hv/vmbus_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/hv/vmbus_drv.c +0 -0
index 3a27f6c5f3de..7efdcadc335e 100644
@@ -1396,7 +1396,6 @@ static int vmbus_bus_init(void)
 {
 	int ret;
 
Quoted 9 lines
Quoted 6 lines
drivers/hv/vmbus_drv.c +0 -2
-	/* Hypervisor initialization...setup hypercall page..etc */
 	ret = hv_init();
 	if (ret != 0) {
 		pr_err("Unable to initialize the hypervisor - 0x%x\n", ret);
--

2.20.1

Thanks.

Applied to hyperv-next.