Revert "ASoC: Intel: Skylake: mark HDAudio codec support as deprecated."
Subsystems (3)
Cezary Rojewski
maintainerPATCH 1/1 Revert "ASoC: Intel: Skylake: mark HDAudio codec support as deprecated."
This reverts commit 02701b909c2fab4b49f9c9545ab921c9b2c7a768.
With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it.
--- sound/soc/intel/Kconfig | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
sound/soc/intel/Kconfig +3 -6
@@ -209,12 +209,9 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC bool "HDAudio codec support" help - This option broke audio on Linus' Skylake laptop in December 2018 - and the race conditions during the probe were not fixed since. - This option is DEPRECATED, all HDaudio codec support needs - to be handled by the SOF driver. - Distributions should not enable this option and there are no known - users of this capability. + If you have a Intel Skylake/Broxton/ApolloLake/KabyLake/ + GeminiLake or CannonLake platform with an HDaudio codec + then enable this option by saying Y config SND_SOC_INTEL_SKYLAKE_COMMON tristate
Signature · 1 line
2.17.1
Quoted 17 lines · Cezary Rojewski
This reverts commit
02701b909c2fab4b49f9c9545ab921c9b2c7a768.With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it.
Signed-off-by Cezary Rojewski <[email protected]>--- sound/soc/intel/Kconfig | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)sound/soc/intel/Kconfig +0
-0@@ -209,12 +209,9 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC bool "HDAudio codec support"
sound/soc/intel/Kconfig config SND_SOC_INTEL_SKYLAKE_SSP_CLK · line 214
Quoted 10 lines
sound/soc/intel/Kconfig +3
-6help - This option broke audio on Linus' Skylake laptop in December 2018 - and the race conditions during the probe were not fixed since. - This option is DEPRECATED, all HDaudio codec support needs - to be handled by the SOF driver. - Distributions should not enable this option and there are no known - users of this capability. + If you have a Intel Skylake/Broxton/ApolloLake/KabyLake/ + GeminiLake or CannonLake platform with an HDaudio codec + then enable this option by saying Y
Yes we need to change the help text now that the issues were fixed and UCM/topology are available, but I would be more comfortable if the text was aligned with your patch "[PATCH] ALSA: hda: Allow SST driver on SKL and KBL platforms with DMIC"
e.g. If you have a Intel Skylake or KabyLake plaforms with an HDaudio codec+DMIC configuration then enable this option by saying Y
Cezary Rojewski
maintainerQuoted 31 lines · Pierre-Louis Bossart
Quoted 19 lines · Cezary Rojewski
This reverts commit
02701b909c2fab4b49f9c9545ab921c9b2c7a768.With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it.
Signed-off-by Cezary Rojewski <[email protected]>---
sound/soc/intel/Kconfig| 9 +++------1 file changed, 3 insertions(+), 6 deletions(-)sound/soc/intel/Kconfig +0
-0@@ -209,12 +209,9 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLKconfig
SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
bool "HDAudio codec support"
help
- This option broke audio on Linus' Skylake laptop in December 2018Quoted 8 lines
- and the race conditions during the probe were not fixed since. - This option is DEPRECATED, all HDaudio codec support needs - to be handled by the SOF driver.
- Distributions should not enable this option and there are no known - users of this capability.
+ If you have a Intel Skylake/Broxton/ApolloLake/KabyLake/ + GeminiLake or CannonLake platform with an HDaudio codec + then enable this option by saying YYes we need to change the help text now that the issues were fixed and UCM/topology are available, but I would be more comfortable if the text was aligned with your patch "[PATCH] ALSA: hda: Allow SST driver on SKL and KBL platforms with DMIC"
Quoted 1 line
e.g. If you have a Intel Skylake or KabyLake plaforms with an HDaudio codec+DMIC configuration then enable this option by saying Y
Agreed. That makes patch a revert no longer, though. Re-sent as:
ASoC: Intel: Skylake: Update description for HDaudio kconfig
Thanks, Czarek