Skip to contentSkip to conversation

common/qat: fix coverity issue

PATCH Applied Adam Dybkowski 3 participants 3 messages May 6, 2020 – May 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/qat: fix coverity issue

This patch fixes Coverity issue #357770 by removing the non-essential check for NULL pointer.

Fixes c13cecf60f12 ("compress/qat: support IM buffer too small operation")
---
 drivers/common/qat/qat_qp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/qat/qat_qp.c +1 -1
index 64dfd85c4..60ef8bf0f 100644
@@ -864,7 +864,7 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 
 		resp_msg = (uint8_t *)rx_queue->base_addr + head;
 
-		if (ops != NULL && nb_fw_responses) {
+		if (nb_fw_responses) {
 			/* only move on to next op if one was ready to return
 			 * to API
 			 */
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Wednesday, May 6, 2020 10:31 PM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH] common/qat: fix coverity issue

Quoted 6 lines

This patch fixes Coverity issue #357770 by removing the non-essential check for NULL pointer.

Fixes c13cecf60f12 ("compress/qat: support IM buffer too small operation")
Applied
#2 lore raw
Quoted 7 lines
Quoted 6 lines

This patch fixes Coverity issue #357770 by removing the non-essential check for NULL pointer.

Fixes c13cecf60f12 ("compress/qat: support IM buffer too small operation")

The title should showcase the actual issue fixed and not the coverity issue

Changed the title as " common/qat: remove redundant check"

Applied to dpdk-next-crypto

Thanks.