Skip to contentSkip to conversation

EDAC/amd64: Dump registers before checking ECC

PATCH New Alexander Monakov 1 participant 1 message May 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC/amd64: Dump registers before checking ECC

Move dump_misc_regs earlier so decoded register contents are shown even if ECC cannot be enabled. The dump gives info such as number of memory controllers, so it serves as a sensible smoke-check even on platforms without ECC memory.

---

Hi,

I used this patch when testing EDAC on AMD Family 17h Model 60h CPU, which needs another patch (adding PCI ids) that I intend to send shortly. I think it would be useful to have this upstream.

 drivers/edac/amd64_edac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/edac/amd64_edac.c +2 -2
index f91f3bc1e0b2..1136500c5f53 100644
@@ -3533,6 +3533,8 @@ static int probe_one_instance(unsigned int nid)
 		goto err_enable;
 	}
 
+	dump_misc_regs(pvt);
+
 	if (!ecc_enabled(pvt)) {
 		ret = -ENODEV;
 
@@ -3559,8 +3561,6 @@ static int probe_one_instance(unsigned int nid)
 		goto err_enable;
 	}
 
-	dump_misc_regs(pvt);
-
 	return ret;
 
 err_enable:
Signature · 1 line
2.26.2