Skip to contentSkip to conversation

net: remove spurious declaration of tcp_default_init_rwnd()

PATCH Applied Maciej Żenczykowski 3 participants 3 messages May 7, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: remove spurious declaration of tcp_default_init_rwnd()

From: Maciej Żenczykowski <[email protected]>

it doesn't actually exist...

Test: builds and 'git grep tcp_default_init_rwnd' comes up empty

---
 include/net/tcp.h | 1 -
 1 file changed, 1 deletion(-)
include/net/tcp.h +0 -1
index dcf9a72eeaa6..64f84683feae 100644
@@ -1376,7 +1376,6 @@ static inline void tcp_sack_reset(struct tcp_options_received *rx_opt)
 	rx_opt->num_sacks = 0;
 }
 
-u32 tcp_default_init_rwnd(u32 mss);
 void tcp_cwnd_restart(struct sock *sk, s32 delta);
 
 static inline void tcp_slow_start_after_idle_check(struct sock *sk)
Signature · 1 line
2.26.2.526.g744177e7f7-goog
#1 lore raw
Quoted 16 lines · Maciej Żenczykowski

From: Maciej Żenczykowski <[email protected]>

it doesn't actually exist...

Test: builds and 'git grep tcp_default_init_rwnd' comes up empty

---
 include/net/tcp.h | 1 -
 1 file changed, 1 deletion(-)
include/net/tcp.h +0 -0
index dcf9a72eeaa6..64f84683feae 100644

include/net/tcp.h static inline void tcp_sack_reset(struct tcp_options_received *rx_opt) · line 1381

Quoted 7 lines
include/net/tcp.h +0 -1
@@ -1376,7 +1376,6 @@ static inline void tcp_sack_reset(struct tcp_options_received *rx_opt)
 	rx_opt->num_sacks = 0;
 }
 
-u32 tcp_default_init_rwnd(u32 mss);
 void tcp_cwnd_restart(struct sock *sk, s32 delta);
 
 static inline void tcp_slow_start_after_idle_check(struct sock *sk)

Right, we should have removed this at the time commit a337531b942b
("tcp: up initial rmem to 128KB and SYN rwin to around 64KB") went in.

Thanks !