Skip to contentSkip to conversation

Allow either FLATMEM or SPARSEMEM on the multiplatform build

PATCH In review Florian Fainelli 4 participants 30 messages May 6, 2020 – May 21, 2020 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

cover Allow either FLATMEM or SPARSEMEM on the multiplatform build

Hi all,

This patch series somehow got lost back in 2015, and while looking at the various patches that we are carrying in our BRCMSTB downstream kernel those two patches should have made it upstream.

It does not seem to me that much has changed since their original submissions back in 2015:

https://lkml.org/lkml/2015/6/4/755

where only the first patch made it to Russell's patch tracker.

Gregory Fong (1):
ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Kevin Cernekee (1):
ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

 arch/arm/Kconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH 1/2 ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

---
 arch/arm/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
arch/arm/Kconfig +0 -3
index 66a04f6f4775..5986277296c3 100644
@@ -1518,9 +1518,6 @@ config ARCH_HAS_HOLES_MEMORYMODEL
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-
 config HAVE_ARCH_PFN_VALID
 	def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

Quoted 10 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

Quoted 7 lines
Quoted 21 lines
---
 arch/arm/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
arch/arm/Kconfig +0 -3
index 66a04f6f4775..5986277296c3 100644
@@ -1518,9 +1518,6 @@ config ARCH_HAS_HOLES_MEMORYMODEL
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-
 config HAVE_ARCH_PFN_VALID
 	def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
 
Signature · 1 line
2.17.1
Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

In reply to Florian Fainelli
Quoted 9 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

No explanation why that is desirable.

arch/arm/Kconfig config ARCH_HAS_HOLES_MEMORYMODEL · line 1523

Quoted 3 lines
arch/arm/Kconfig +0 -3
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-

What this basically says is ARCH_SPARSEMEM_ENABLE=ARCH_SPARSEMEM_DEFAULT, which is exactly what we want for the non-multiplatform boards that select ARCH_SPARSEMEM_ENABLE - we _want_ them to default to sparsemem because that is what the platform requires.

For example, with RiscPC, which selects ARCH_SPARSEMEM_ENABLE, we have four banks of memory at 0x10000000, 0x14000000, 0x18000000 and 0x1c000000. These correspond with the two memory slots - the first two for the first slot, and the second two for the second slot. Each slot has two banks. The size of each memory bank depends on the size of the module.

Flatmem is completely unable to work with this setup if all banks are populated, and the first bank does not contain enough memory to allocate the struct page array. So, sparsemem is the only option there.

Hence, for these platforms, we want sparsemem and only sparsemem, not flatmem.

So, this patch which makes it possible to select flatmem is completely out of the question for these platforms.

Signature · 7 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#4 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

Quoted 8 lines · Russell King - ARM Linux admin
Quoted 7 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Quoted 4 lines
Quoted 2 lines

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

No explanation why that is desirable.

This was explained in the original submission out of which only the first patch landed upstream:

https://lkml.org/lkml/2015/6/4/756

Quoted 21 lines

arch/arm/Kconfig config ARCH_HAS_HOLES_MEMORYMODEL · line 1523

Quoted 4 lines
arch/arm/Kconfig +0 -3
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-

What this basically says is ARCH_SPARSEMEM_ENABLE=ARCH_SPARSEMEM_DEFAULT, which is exactly what we want for the non-multiplatform boards that select ARCH_SPARSEMEM_ENABLE - we _want_ them to default to sparsemem because that is what the platform requires.

For example, with RiscPC, which selects ARCH_SPARSEMEM_ENABLE, we have four banks of memory at 0x10000000, 0x14000000, 0x18000000 and 0x1c000000. These correspond with the two memory slots - the first two for the first slot, and the second two for the second slot. Each slot has two banks. The size of each memory bank depends on the size of the module.

Flatmem is completely unable to work with this setup if all banks are populated, and the first bank does not contain enough memory to allocate the struct page array. So, sparsemem is the only option there.

Quoted 5 lines

Hence, for these platforms, we want sparsemem and only sparsemem, not flatmem.

So, this patch which makes it possible to select flatmem is completely out of the question for these platforms.

OK.

Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#5 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

Quoted 14 lines · Florian Fainelli
Quoted 11 lines · Russell King - ARM Linux admin
Quoted 9 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

Quoted 6 lines
Quoted 1 line

No explanation why that is desirable.

This was explained in the original submission out of which only the first patch landed upstream:

https://lkml.org/lkml/2015/6/4/756

Sorry, I don't see where. The message you link to is for patch 1. I'd say that the reason only the first patch landed is because that's all I was happy with.

Signature · 7 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#6 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

Quoted 17 lines · Russell King - ARM Linux admin
Quoted 16 lines · Florian Fainelli
Quoted 12 lines · Russell King - ARM Linux admin
Quoted 9 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

No explanation why that is desirable.

Quoted 8 lines
Quoted 4 lines

This was explained in the original submission out of which only the first patch landed upstream:

https://lkml.org/lkml/2015/6/4/756

Sorry, I don't see where. The message you link to is for patch 1. I'd say that the reason only the first patch landed is because that's all I was happy with.

I misunderstood you as to why the whole patch series, but now understand you meant specifically this patch, let me try to dig up some of the history of this and see if I can provide a justification, else, it should be dropped.

Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#7 lore raw

PATCH 1/1 arm: use SPARSMEM_STATIC when SPARSEMEM is enabled (Was: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting)

In reply to Russell King - ARM Linux admin
Quoted 22 lines · Russell King - ARM Linux admin
Quoted 9 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

No explanation why that is desirable.

Review

Quoted 3 lines
(quoted diff) +0 -3
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-

What this basically says is ARCH_SPARSEMEM_ENABLE=ARCH_SPARSEMEM_DEFAULT, which is exactly what we want for the non-multiplatform boards that select ARCH_SPARSEMEM_ENABLE - we _want_ them to default to sparsemem because that is what the platform requires.

Quoted 6 lines

For example, with RiscPC, which selects ARCH_SPARSEMEM_ENABLE, we have four banks of memory at 0x10000000, 0x14000000, 0x18000000 and 0x1c000000. These correspond with the two memory slots - the first two for the first slot, and the second two for the second slot. Each slot has two banks. The size of each memory bank depends on the size of the module.

Out of curiosity I've run

make ARCH=arm rpc_defconfig
grep SPARSEMEM .config

and I was surprised to find out that it has

CONFIG_SPARSEMEM_EXTREME=y

Which would waste several kilibytes of memory for nothing. Here is the fix:

From 7097c114226b5b1b2fc6bb605bf0d7eae601cc7f Mon Sep 17 00:00:00 2001
From: Mike Rapoport <[email protected]>
Date: Thu, 7 May 2020 22:39:12 +0300
Subject: [PATCH] arm: use SPARSMEM_STATIC when SPARSEMEM is enabled

The commit 3e347261a80b5 ("[PATCH] sparsemem extreme implementation") made SPARSMEM_EXTREME the default option for configurations that enable SPARSEMEM.

For ARM systems with handful of memory banks SPARSEMEM_EXTREME is an overkill.

Ensure that SPARSMEM_STATIC is enabled in the configurations that use SPARSEMEM.

Fixes 3e347261a80b5 ("[PATCH] sparsemem extreme implementation")
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +1 -0
index 66a04f6f4775..c88a48d622fc 100644
@@ -1517,6 +1517,7 @@ config ARCH_HAS_HOLES_MEMORYMODEL
 
 config ARCH_SPARSEMEM_ENABLE
 	bool
+	select SPARSEMEM_STATIC
 
 config ARCH_SPARSEMEM_DEFAULT
 	def_bool ARCH_SPARSEMEM_ENABLE
Signature · 7 lines
2.25.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author Acked-by on v1 1/1
#8 lore raw

Re: [PATCH] arm: use SPARSMEM_STATIC when SPARSEMEM is enabled (Was: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting)

Quoted 51 lines · Mike Rapoport
Quoted 22 lines · Russell King - ARM Linux admin
Quoted 9 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

No explanation why that is desirable.

Review

Quoted 3 lines
(quoted diff) +0 -3
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-

What this basically says is ARCH_SPARSEMEM_ENABLE=ARCH_SPARSEMEM_DEFAULT, which is exactly what we want for the non-multiplatform boards that select ARCH_SPARSEMEM_ENABLE - we _want_ them to default to sparsemem because that is what the platform requires.

Quoted 6 lines

For example, with RiscPC, which selects ARCH_SPARSEMEM_ENABLE, we have four banks of memory at 0x10000000, 0x14000000, 0x18000000 and 0x1c000000. These correspond with the two memory slots - the first two for the first slot, and the second two for the second slot. Each slot has two banks. The size of each memory bank depends on the size of the module.

Out of curiosity I've run

make ARCH=arm rpc_defconfig
grep SPARSEMEM .config

and I was surprised to find out that it has

CONFIG_SPARSEMEM_EXTREME=y

Which would waste several kilibytes of memory for nothing. Here is the fix:

From 7097c114226b5b1b2fc6bb605bf0d7eae601cc7f Mon Sep 17 00:00:00 2001
From: Mike Rapoport <[email protected]>
Date: Thu, 7 May 2020 22:39:12 +0300
Subject: [PATCH] arm: use SPARSMEM_STATIC when SPARSEMEM is enabled

The commit 3e347261a80b5 ("[PATCH] sparsemem extreme implementation") made SPARSMEM_EXTREME the default option for configurations that enable SPARSEMEM.

Quoted 8 lines

For ARM systems with handful of memory banks SPARSEMEM_EXTREME is an overkill.

Ensure that SPARSMEM_STATIC is enabled in the configurations that use SPARSEMEM.

Fixes 3e347261a80b5 ("[PATCH] sparsemem extreme implementation")
Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#9 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

In reply to Russell King - ARM Linux admin
Quoted 13 lines · Russell King - ARM Linux admin
Quoted 9 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

No explanation why that is desirable.

Quoted 8 lines

Review

Quoted 3 lines
(quoted diff) +0 -3
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-

What this basically says is ARCH_SPARSEMEM_ENABLE=ARCH_SPARSEMEM_DEFAULT, which is exactly what we want for the non-multiplatform boards that select ARCH_SPARSEMEM_ENABLE - we _want_ them to default to sparsemem because that is what the platform requires.

The ARCH_SPARSEMEM_DEFAULT knob has no effect unless manual selection of the memory model is enabled, i.e. arch Kconfig sets ARCH_SELECT_MEMORY_MODEL to 'y'.

Otherwise, ARCH_SPARSEMEM_ENABLE is sufficient to select SPARSEMEM over FLATMEM:

config SPARSEMEM

	def_bool y
	depends on (!SELECT_MEMORY_MODEL && ARCH_SPARSEMEM_ENABLE) || SPARSEMEM_MANUAL

config FLATMEM

	def_bool y
	depends on (!DISCONTIGMEM && !SPARSEMEM) || FLATMEM_MANUAL
Quoted 11 lines

For example, with RiscPC, which selects ARCH_SPARSEMEM_ENABLE, we have four banks of memory at 0x10000000, 0x14000000, 0x18000000 and 0x1c000000. These correspond with the two memory slots - the first two for the first slot, and the second two for the second slot. Each slot has two banks. The size of each memory bank depends on the size of the module.

Flatmem is completely unable to work with this setup if all banks are populated, and the first bank does not contain enough memory to allocate the struct page array. So, sparsemem is the only option there.

Quoted 5 lines

Hence, for these platforms, we want sparsemem and only sparsemem, not flatmem.

So, this patch which makes it possible to select flatmem is completely out of the question for these platforms.

This patch alone won't make it possible to select flatmem for these platforms, actually, as of now it changes nothing.

The removal of ARCH_SPARSEMEM_DEFAULT will have an effect only with addtion of ARCH_SELECT_MEMORY_MODEL.

If I understood Florian's intention correctly, the goal was to allow manual selection of the memory model for multiplatform builds that today implicitly use flatmem.

I think that the patch below would achieve that without changing the current defaults and without forcing flatmem on the platforms that already explicitly select sparsemem.

arch/arm/Kconfig +8 -2
index 66a04f6f4775..b6eb1a28ca27 100644
@@ -312,6 +312,9 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE
+	select ARCH_SELECT_MEMORY_MODEL
 	select ARM_HAS_SG_CHAIN
 	select ARM_PATCH_PHYS_VIRT
 	select AUTO_ZRELADDR
@@ -1515,11 +1518,14 @@ config OABI_COMPAT
 config ARCH_HAS_HOLES_MEMORYMODEL
 	bool
 
+config ARCH_FLATMEM_ENABLE
+	bool
+
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
+config ARCH_SELECT_MEMORY_MODEL
+	bool
 
 config HAVE_ARCH_PFN_VALID
 	def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
Quoted 3 lines
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author Tested-by
#10 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

Quoted 58 lines · Mike Rapoport
Quoted 13 lines · Russell King - ARM Linux admin
Quoted 9 lines · Florian Fainelli

From: Kevin Cernekee <[email protected]>

If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only choice. This is true for all of the existing ARM users of ARCH_SPARSEMEM_ENABLE.

Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents us from ever defaulting to FLATMEM, so we should remove this setting.

No explanation why that is desirable.

Quoted 8 lines

arch/arm/Kconfig config OABI_COMPAT

Quoted 3 lines
arch/arm/Kconfig +0 -3
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
-

What this basically says is ARCH_SPARSEMEM_ENABLE=ARCH_SPARSEMEM_DEFAULT, which is exactly what we want for the non-multiplatform boards that select ARCH_SPARSEMEM_ENABLE - we _want_ them to default to sparsemem because that is what the platform requires.

The ARCH_SPARSEMEM_DEFAULT knob has no effect unless manual selection of the memory model is enabled, i.e. arch Kconfig sets ARCH_SELECT_MEMORY_MODEL to 'y'.

Otherwise, ARCH_SPARSEMEM_ENABLE is sufficient to select SPARSEMEM over FLATMEM:

config SPARSEMEM

	def_bool y
	depends on (!SELECT_MEMORY_MODEL && ARCH_SPARSEMEM_ENABLE) || SPARSEMEM_MANUAL

config FLATMEM

	def_bool y
	depends on (!DISCONTIGMEM && !SPARSEMEM) || FLATMEM_MANUAL
Quoted 11 lines

For example, with RiscPC, which selects ARCH_SPARSEMEM_ENABLE, we have four banks of memory at 0x10000000, 0x14000000, 0x18000000 and 0x1c000000. These correspond with the two memory slots - the first two for the first slot, and the second two for the second slot. Each slot has two banks. The size of each memory bank depends on the size of the module.

Flatmem is completely unable to work with this setup if all banks are populated, and the first bank does not contain enough memory to allocate the struct page array. So, sparsemem is the only option there.

Quoted 5 lines

Hence, for these platforms, we want sparsemem and only sparsemem, not flatmem.

So, this patch which makes it possible to select flatmem is completely out of the question for these platforms.

This patch alone won't make it possible to select flatmem for these platforms, actually, as of now it changes nothing.

Quoted 6 lines

The removal of ARCH_SPARSEMEM_DEFAULT will have an effect only with addtion of ARCH_SELECT_MEMORY_MODEL.

If I understood Florian's intention correctly, the goal was to allow manual selection of the memory model for multiplatform builds that today implicitly use flatmem.

That is correct.

Quoted 4 lines

I think that the patch below would achieve that without changing the current defaults and without forcing flatmem on the platforms that already explicitly select sparsemem.

Agree, with your patch, we have the following:

mutli_v7_defonfig -> FLATMEM
ep93xx_defconfig -> SPARSEMEM
rpc_defconfig -> SPARSEMEM
assabet_defconfig -> SPARSEMEM

with the bonus that when you run menuconfig you can now select sparsemem for a multi-platform build, which was the intention.

Quoted 37 lines
arch/arm/Kconfig +8 -2
index 66a04f6f4775..b6eb1a28ca27 100644
@@ -312,6 +312,9 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE
+	select ARCH_SELECT_MEMORY_MODEL
 	select ARM_HAS_SG_CHAIN
 	select ARM_PATCH_PHYS_VIRT
 	select AUTO_ZRELADDR
@@ -1515,11 +1518,14 @@ config OABI_COMPAT
 config ARCH_HAS_HOLES_MEMORYMODEL
 	bool
 
+config ARCH_FLATMEM_ENABLE
+	bool
+
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
+config ARCH_SELECT_MEMORY_MODEL
+	bool
 
 config HAVE_ARCH_PFN_VALID
 	def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
Quoted 4 lines
Signature · 3 lines
-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#11 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

Quoted 2 lines · Florian Fainelli

On 5/7/2020 1:29 PM, Mike Rapoport wrote:

...

Quoted 13 lines
Quoted 3 lines

If I understood Florian's intention correctly, the goal was to allow manual selection of the memory model for multiplatform builds that today implicitly use flatmem.

That is correct.

Quoted 4 lines

I think that the patch below would achieve that without changing the current defaults and without forcing flatmem on the platforms that already explicitly select sparsemem.

Agree, with your patch, we have the following:

Quoted 7 lines

mutli_v7_defonfig -> FLATMEM
ep93xx_defconfig -> SPARSEMEM
rpc_defconfig -> SPARSEMEM
assabet_defconfig -> SPARSEMEM

with the bonus that when you run menuconfig you can now select sparsemem for a multi-platform build, which was the intention.

If there is a need to use sparsemem for the multiplatform build, then maybe we should consider moving to sparsemem?

The increase in size for the defconfig build is about 7k and some of if is accounted for the .init code and data:

text data bss dec hex filename

14539957        7461462  413288 22414707        1560573 vmlinux-flatmem
14545233        7461762  415400 22422395        156237b vmlinux-sparse-static

I don't have ARM hardware, so I cannot measure the run-time effect though.

Quoted 1 line

Thanks!

Quoted 40 lines
Quoted 37 lines
arch/arm/Kconfig +8 -2
index 66a04f6f4775..b6eb1a28ca27 100644
@@ -312,6 +312,9 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE
+	select ARCH_SELECT_MEMORY_MODEL
 	select ARM_HAS_SG_CHAIN
 	select ARM_PATCH_PHYS_VIRT
 	select AUTO_ZRELADDR
@@ -1515,11 +1518,14 @@ config OABI_COMPAT
 config ARCH_HAS_HOLES_MEMORYMODEL
 	bool
 
+config ARCH_FLATMEM_ENABLE
+	bool
+
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
+config ARCH_SELECT_MEMORY_MODEL
+	bool
 
 config HAVE_ARCH_PFN_VALID
 	def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
Quoted 4 lines
Signature · 3 lines
-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Signature · 1 line
Florian
Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#12 lore raw

Re: [PATCH 1/2] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting

Quoted 24 lines · Mike Rapoport
Quoted 2 lines · Florian Fainelli

On 5/7/2020 1:29 PM, Mike Rapoport wrote:

...

Quoted 18 lines
Quoted 3 lines

If I understood Florian's intention correctly, the goal was to allow manual selection of the memory model for multiplatform builds that today implicitly use flatmem.

That is correct.

Quoted 4 lines

I think that the patch below would achieve that without changing the current defaults and without forcing flatmem on the platforms that already explicitly select sparsemem.

Agree, with your patch, we have the following:

mutli_v7_defonfig -> FLATMEM
ep93xx_defconfig -> SPARSEMEM
rpc_defconfig -> SPARSEMEM
assabet_defconfig -> SPARSEMEM

Quoted 5 lines
Quoted 2 lines

with the bonus that when you run menuconfig you can now select sparsemem for a multi-platform build, which was the intention.

If there is a need to use sparsemem for the multiplatform build, then maybe we should consider moving to sparsemem?

For ARCH_BRCMSTB we definitively want sparsemem (hence these patches) because of the memory map for those chips, but not having access to all ARM platforms that are supported by the multi-platform kernel, I would rather we stay conservative and allow platforms to select the memory model they want. If it turns out that sparsemem is the default, I suppose we could always change it later on. Arnd, Russell, what do you think?

Quoted 55 lines
Quoted 1 line

The increase in size for the defconfig build is about 7k and some of if

is accounted for the .init code and data:

text data bss dec hex filename

14539957        7461462  413288 22414707        1560573 vmlinux-flatmem
14545233        7461762  415400 22422395        156237b vmlinux-sparse-static

I don't have ARM hardware, so I cannot measure the run-time effect though.

Quoted 1 line

Thanks!

Quoted 40 lines
Quoted 37 lines
arch/arm/Kconfig +8 -2
index 66a04f6f4775..b6eb1a28ca27 100644
@@ -312,6 +312,9 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE
+	select ARCH_SELECT_MEMORY_MODEL
 	select ARM_HAS_SG_CHAIN
 	select ARM_PATCH_PHYS_VIRT
 	select AUTO_ZRELADDR
@@ -1515,11 +1518,14 @@ config OABI_COMPAT
 config ARCH_HAS_HOLES_MEMORYMODEL
 	bool
 
+config ARCH_FLATMEM_ENABLE
+	bool
+
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
-config ARCH_SPARSEMEM_DEFAULT
-	def_bool ARCH_SPARSEMEM_ENABLE
+config ARCH_SELECT_MEMORY_MODEL
+	bool
 
 config HAVE_ARCH_PFN_VALID
 	def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
Quoted 4 lines
Signature · 3 lines
-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Signature · 1 line
Florian
Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#13 lore raw

PATCH 2/2 ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

In reply to Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +5 -0
index 5986277296c3..7bb5264a9c3a 100644
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE
 	select ARM_HAS_SG_CHAIN
 	select ARM_PATCH_PHYS_VIRT
 	select AUTO_ZRELADDR
@@ -1515,6 +1517,9 @@ config OABI_COMPAT
 config ARCH_HAS_HOLES_MEMORYMODEL
 	bool
 
+config ARCH_FLATMEM_ENABLE
+	bool
+
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#14 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 30 lines · Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +0 -0
index 5986277296c3..7bb5264a9c3a 100644

arch/arm/Kconfig choice · line 316

Quoted 5 lines
arch/arm/Kconfig +2 -0
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE

The logic in mm/Kconfig is quite convoluted, so selecting ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.

On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g. something like:

arch/arm/Kconfig +4 -0
index 7bb5264a9c3a..b6eb1a28ca27 100644
@@ -314,6 +314,7 @@ config ARCH_MULTIPLATFORM
 	depends on MMU
 	select ARCH_FLATMEM_ENABLE
 	select ARCH_SPARSEMEM_ENABLE
+	select ARCH_SELECT_MEMORY_MODEL
 	select ARM_HAS_SG_CHAIN
 	select ARM_PATCH_PHYS_VIRT
 	select AUTO_ZRELADDR
@@ -1523,6 +1524,9 @@ config ARCH_FLATMEM_ENABLE
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
+config ARCH_SELECT_MEMORY_MODEL
+	bool
+
 config HAVE_ARCH_PFN_VALID
 	def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
 
Quoted 16 lines
arch/arm/Kconfig +3 -0
 	select ARM_HAS_SG_CHAIN
 	select ARM_PATCH_PHYS_VIRT
 	select AUTO_ZRELADDR
@@ -1515,6 +1517,9 @@ config OABI_COMPAT
 config ARCH_HAS_HOLES_MEMORYMODEL
 	bool
 
+config ARCH_FLATMEM_ENABLE
+	bool
+
 config ARCH_SPARSEMEM_ENABLE
 	bool
 
Signature · 1 line
2.17.1
Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#15 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 40 lines · Mike Rapoport
Quoted 30 lines · Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +0 -0
index 5986277296c3..7bb5264a9c3a 100644

arch/arm/Kconfig choice · line 316

Quoted 5 lines
arch/arm/Kconfig +2 -0
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE

The logic in mm/Kconfig is quite convoluted, so selecting ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.

Quoted 2 lines

On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g. something like:

Yes indeed, thanks that does allow me to select between flatmem and sparsemem from menuconfig correctly now.

Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author Tested-by
#16 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 43 lines · Florian Fainelli
Quoted 40 lines · Mike Rapoport
Quoted 30 lines · Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +0 -0
index 5986277296c3..7bb5264a9c3a 100644

arch/arm/Kconfig choice · line 316

Quoted 5 lines
arch/arm/Kconfig +2 -0
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE

The logic in mm/Kconfig is quite convoluted, so selecting ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.

Quoted 5 lines
Quoted 2 lines

On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g. something like:

Yes indeed, thanks that does allow me to select between flatmem and sparsemem from menuconfig correctly now.

Mike, do you want to make a formal submission to Russell's patch tracker? If so, feel free to add:

Thanks!
--
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#17 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 46 lines · Florian Fainelli
Quoted 43 lines · Florian Fainelli
Quoted 40 lines · Mike Rapoport
Quoted 30 lines · Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +0 -0
index 5986277296c3..7bb5264a9c3a 100644

arch/arm/Kconfig choice · line 316

Quoted 5 lines
arch/arm/Kconfig +2 -0
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
 	bool "Allow multiple platforms to be selected"
 	depends on MMU
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_SPARSEMEM_ENABLE

The logic in mm/Kconfig is quite convoluted, so selecting ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g. something like:

Yes indeed, thanks that does allow me to select between flatmem and sparsemem from menuconfig correctly now.

Mike, do you want to make a formal submission to Russell's patch tracker? If so, feel free to add:

I actually hoped to hear from people what do they think about switching over to SPARSEMEM for the multiplatform builds. I think at least v7 CPUs it would make sense.

Russel, Arnd, can you comment please?

Quoted 5 lines

Thanks!
--
Florian

Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#18 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 49 lines · Mike Rapoport
Quoted 48 lines · Florian Fainelli
Quoted 46 lines · Florian Fainelli
Quoted 40 lines · Mike Rapoport
Quoted 30 lines · Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +0 -0
index 5986277296c3..7bb5264a9c3a 100644

arch/arm/Kconfig choice · line 316

Quoted 5 lines
arch/arm/Kconfig +2 -0
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
  bool "Allow multiple platforms to be selected"
  depends on MMU
+ select ARCH_FLATMEM_ENABLE
+ select ARCH_SPARSEMEM_ENABLE

The logic in mm/Kconfig is quite convoluted, so selecting ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.

Quoted 2 lines

On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g. something like:

Yes indeed, thanks that does allow me to select between flatmem and sparsemem from menuconfig correctly now.

Quoted 6 lines
Quoted 2 lines

Mike, do you want to make a formal submission to Russell's patch tracker? If so, feel free to add:

I actually hoped to hear from people what do they think about switching over to SPARSEMEM for the multiplatform builds. I think at least v7 CPUs it would make sense.

It seems that at least s5p/exynos and clps711x (armv4) used to default to sparsemem, and that got lost in the multiplatform conversion.

I also see discontiguous memory ranges in multiple broadcom chips, on TI dm8168, ecx-2000 and imx.

Quoted 1 line

Russel, Arnd, can you comment please?

I see no problem with giving users the choice for all multiplatform builds. No idea on what the default should be really, i.e. whether only v7 configurations should make it the default, or rather none of them or all of them.

Maybe lets leave the default unchanged with flatmem but enable it in multi_v7_defconfig and the configurations for chips that are known to have discontiguous memory (clps, bcm, imx, exynos, ...).

Arnd

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#19 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 63 lines · Arnd Bergmann
Quoted 49 lines · Mike Rapoport
Quoted 48 lines · Florian Fainelli
Quoted 46 lines · Florian Fainelli
Quoted 40 lines · Mike Rapoport
Quoted 30 lines · Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +0 -0
index 5986277296c3..7bb5264a9c3a 100644

arch/arm/Kconfig choice · line 316

Quoted 5 lines
arch/arm/Kconfig +2 -0
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
  bool "Allow multiple platforms to be selected"
  depends on MMU
+ select ARCH_FLATMEM_ENABLE
+ select ARCH_SPARSEMEM_ENABLE

The logic in mm/Kconfig is quite convoluted, so selecting ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.

Quoted 2 lines

On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g. something like:

Yes indeed, thanks that does allow me to select between flatmem and sparsemem from menuconfig correctly now.

Quoted 6 lines
Quoted 2 lines

Mike, do you want to make a formal submission to Russell's patch tracker? If so, feel free to add:

I actually hoped to hear from people what do they think about switching over to SPARSEMEM for the multiplatform builds. I think at least v7 CPUs it would make sense.

It seems that at least s5p/exynos and clps711x (armv4) used to default to sparsemem, and that got lost in the multiplatform conversion.

I also see discontiguous memory ranges in multiple broadcom chips, on TI dm8168, ecx-2000 and imx.

Quoted 6 lines
Quoted 1 line

Russel, Arnd, can you comment please?

I see no problem with giving users the choice for all multiplatform builds. No idea on what the default should be really, i.e. whether only v7 configurations should make it the default, or rather none of them or all of them.

Me neither :)

I'd say let's move forward with letting user select the memory model for all multiplaform builds and keep flatmem the default.

Enabling sparsemem (with SPARSEMEM_STATIC) for defconfig build increases the kernel nearly by 8k and most probably will make things slower.

Quoted 5 lines

Maybe lets leave the default unchanged with flatmem but enable it in multi_v7_defconfig and the configurations for chips that are known to have discontiguous memory (clps, bcm, imx, exynos, ...).

Arnd

Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#20 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 71 lines · Mike Rapoport
Quoted 63 lines · Arnd Bergmann
Quoted 49 lines · Mike Rapoport
Quoted 48 lines · Florian Fainelli
Quoted 46 lines · Florian Fainelli
Quoted 40 lines · Mike Rapoport
Quoted 30 lines · Florian Fainelli

From: Gregory Fong <[email protected]>

ARMv7 chips with LPAE can often benefit from SPARSEMEM, as portions of system memory can be located deep in the 36-bit address space. Allow FLATMEM or SPARSEMEM to be selectable at compile time; FLATMEM remains the default.

This is based on Kevin's "[PATCH 3/3] ARM: Allow either FLATMEM or SPARSEMEM on the multi-v7 build" from [1] and shamelessly rips off his commit message text above. As Arnd pointed out at [2] there doesn't seem to be any reason to tie this specifically to ARMv7, so this has been changed to apply to all multiplatform kernels.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/286837.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/298950.html

---
 arch/arm/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Kconfig +0 -0
index 5986277296c3..7bb5264a9c3a 100644

arch/arm/Kconfig choice · line 316

Quoted 5 lines
arch/arm/Kconfig +2 -0
@@ -312,6 +312,8 @@ choice
 config ARCH_MULTIPLATFORM
  bool "Allow multiple platforms to be selected"
  depends on MMU
+ select ARCH_FLATMEM_ENABLE
+ select ARCH_SPARSEMEM_ENABLE

The logic in mm/Kconfig is quite convoluted, so selecting ARCH_SPARSEMEM_ENABLE will automatically make SPARSEMEM the only option.

Quoted 2 lines

On top of this you would need to enable ARCH_SELECT_MEMORY_MODEL, e.g. something like:

Yes indeed, thanks that does allow me to select between flatmem and sparsemem from menuconfig correctly now.

Quoted 6 lines
Quoted 2 lines

Mike, do you want to make a formal submission to Russell's patch tracker? If so, feel free to add:

I actually hoped to hear from people what do they think about switching over to SPARSEMEM for the multiplatform builds. I think at least v7 CPUs it would make sense.

It seems that at least s5p/exynos and clps711x (armv4) used to default to sparsemem, and that got lost in the multiplatform conversion.

I also see discontiguous memory ranges in multiple broadcom chips, on TI dm8168, ecx-2000 and imx.

Quoted 6 lines
Quoted 1 line

Russel, Arnd, can you comment please?

I see no problem with giving users the choice for all multiplatform builds. No idea on what the default should be really, i.e. whether only v7 configurations should make it the default, or rather none of them or all of them.

Quoted 7 lines

Me neither :)

I'd say let's move forward with letting user select the memory model for all multiplaform builds and keep flatmem the default.

Enabling sparsemem (with SPARSEMEM_STATIC) for defconfig build increases the kernel nearly by 8k and most probably will make things slower.

I think when selecting the default, you need to consider whether platforms can boot with that default configuration or not.

There are cases where the reason to use sparsemem is not an optional one but is out of necessity - they require the page array to be split up in order to boot successfully.

With that in mind, flatmem becomes an "optimisation" over sparsemem.

Signature · 7 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#21 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 33 lines · Russell King - ARM Linux admin
Quoted 24 lines · Mike Rapoport
Quoted 16 lines · Arnd Bergmann
Quoted 8 lines · Mike Rapoport
Quoted 3 lines · Florian Fainelli

Mike, do you want to make a formal submission to Russell's patch tracker? If so, feel free to add:

I actually hoped to hear from people what do they think about switching over to SPARSEMEM for the multiplatform builds. I think at least v7 CPUs it would make sense.

It seems that at least s5p/exynos and clps711x (armv4) used to default to sparsemem, and that got lost in the multiplatform conversion.

I also see discontiguous memory ranges in multiple broadcom chips, on TI dm8168, ecx-2000 and imx.

Quoted 6 lines
Quoted 1 line

Russel, Arnd, can you comment please?

I see no problem with giving users the choice for all multiplatform builds. No idea on what the default should be really, i.e. whether only v7 configurations should make it the default, or rather none of them or all of them.

Quoted 7 lines

Me neither :)

I'd say let's move forward with letting user select the memory model for all multiplaform builds and keep flatmem the default.

Enabling sparsemem (with SPARSEMEM_STATIC) for defconfig build increases the kernel nearly by 8k and most probably will make things slower.

Quoted 8 lines

I think when selecting the default, you need to consider whether platforms can boot with that default configuration or not.

There are cases where the reason to use sparsemem is not an optional one but is out of necessity - they require the page array to be split up in order to boot successfully.

With that in mind, flatmem becomes an "optimisation" over sparsemem.

At the moment, there are three platforms that enable SPARSEMEM: ARCH_EP93XX, ARCH_RPC and ARCH_SA1100. All the rest have FLATMEM implcitly selected.

I do not intend to change that, I am only going add an ability to select the memory model for ARCH_MULTIPLATFORM.

I'll respin the series on the list before adding the patches to the patch system.

Quoted 3 lines
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up
Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#22 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 7 lines · Mike Rapoport
Quoted 5 lines · Russell King - ARM Linux admin

There are cases where the reason to use sparsemem is not an optional one but is out of necessity - they require the page array to be split up in order to boot successfully.

With that in mind, flatmem becomes an "optimisation" over sparsemem.

Quoted 8 lines

At the moment, there are three platforms that enable SPARSEMEM: ARCH_EP93XX, ARCH_RPC and ARCH_SA1100. All the rest have FLATMEM implcitly selected.

I do not intend to change that, I am only going add an ability to select the memory model for ARCH_MULTIPLATFORM.

I'll respin the series on the list before adding the patches to the patch system.

I think we'll make EP93xx part of multiplatform at some point, IIRC only the missing clock driver is stopping us at the moment, and I already discussed with Linus Walleij how that can be done.

My guess is that ep93xx is one platform on which sparsemem is just an optimization to reduce the initial memory consumption, but we should verify that when we get there.

Arnd

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#23 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 17 lines · Arnd Bergmann
Quoted 7 lines · Mike Rapoport
Quoted 5 lines · Russell King - ARM Linux admin

There are cases where the reason to use sparsemem is not an optional one but is out of necessity - they require the page array to be split up in order to boot successfully.

With that in mind, flatmem becomes an "optimisation" over sparsemem.

Quoted 8 lines

At the moment, there are three platforms that enable SPARSEMEM: ARCH_EP93XX, ARCH_RPC and ARCH_SA1100. All the rest have FLATMEM implcitly selected.

I do not intend to change that, I am only going add an ability to select the memory model for ARCH_MULTIPLATFORM.

I'll respin the series on the list before adding the patches to the patch system.

Quoted 7 lines

I think we'll make EP93xx part of multiplatform at some point, IIRC only the missing clock driver is stopping us at the moment, and I already discussed with Linus Walleij how that can be done.

My guess is that ep93xx is one platform on which sparsemem is just an optimization to reduce the initial memory consumption, but we should verify that when we get there.

When you have a platform where the memory is segmented into separate blocks widely spaced, sparsemem is not an optimisation. For example, If you have four blocks spaced across 1GB, that requires about 256Ki struct page's. Assuming 32 byte struct page, that requires 8MiB of contiguous memory.

If we also consider the other constraint - that the kernel has to fit in the first bank of memory, then, considering the size of the kernel (the first two are non-multiplatform kernels):

text     data   bss      dec      hex      filename
4045505  903700   92984  5042189  4cf00d   n2100/boot/vmlinux-5.6.12+
4045361  957276 1159052  6161689  5e0519   assabet/boot/vmlinux-5.2.0+
6933363 1451420  203984  8588767  830ddf   virt/boot/vmlinux-5.6.0+
9980260 3568070 7403296 20951626 13fb24a   multi/boot/vmlinux-5.3.0+

So, realistically, we're looking at imposing a requirement that the first bank of memory is no smaller than 16MB on these machines if a "default" flatmem multiplatform kernel is going to be able to boot, and if all banks are populated, that there is another bank that has at least 8MB to hold the memmap array.

BTW, the "optimisation" argument for sparsemem doesn't actually hold. For flatmem, we free the unused parts of the memmap array, freeing those pages for other uses. Sparsemem on ARM is about allowing these platforms to boot with their memory spread across the physical address space savannah.

Signature · 7 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#24 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Hi Russell,

Quoted 48 lines · Russell King - ARM Linux admin
Quoted 17 lines · Arnd Bergmann
Quoted 7 lines · Mike Rapoport
Quoted 5 lines · Russell King - ARM Linux admin

There are cases where the reason to use sparsemem is not an optional one but is out of necessity - they require the page array to be split up in order to boot successfully.

With that in mind, flatmem becomes an "optimisation" over sparsemem.

Quoted 8 lines

At the moment, there are three platforms that enable SPARSEMEM: ARCH_EP93XX, ARCH_RPC and ARCH_SA1100. All the rest have FLATMEM implcitly selected.

I do not intend to change that, I am only going add an ability to select the memory model for ARCH_MULTIPLATFORM.

I'll respin the series on the list before adding the patches to the patch system.

Quoted 7 lines

I think we'll make EP93xx part of multiplatform at some point, IIRC only the missing clock driver is stopping us at the moment, and I already discussed with Linus Walleij how that can be done.

My guess is that ep93xx is one platform on which sparsemem is just an optimization to reduce the initial memory consumption, but we should verify that when we get there.

When you have a platform where the memory is segmented into separate blocks widely spaced, sparsemem is not an optimisation. For example, If you have four blocks spaced across 1GB, that requires about 256Ki struct page's. Assuming 32 byte struct page, that requires 8MiB of contiguous memory.

If we also consider the other constraint - that the kernel has to fit in the first bank of memory, then, considering the size of the kernel (the first two are non-multiplatform kernels):

text     data   bss      dec      hex      filename
4045505  903700   92984  5042189  4cf00d   n2100/boot/vmlinux-5.6.12+
4045361  957276 1159052  6161689  5e0519   assabet/boot/vmlinux-5.2.0+
6933363 1451420  203984  8588767  830ddf   virt/boot/vmlinux-5.6.0+
9980260 3568070 7403296 20951626 13fb24a   multi/boot/vmlinux-5.3.0+

So, realistically, we're looking at imposing a requirement that the first bank of memory is no smaller than 16MB on these machines if a "default" flatmem multiplatform kernel is going to be able to boot, and if all banks are populated, that there is another bank that has at least 8MB to hold the memmap array.

Quoted 5 lines

BTW, the "optimisation" argument for sparsemem doesn't actually hold. For flatmem, we free the unused parts of the memmap array, freeing those pages for other uses. Sparsemem on ARM is about allowing these platforms to boot with their memory spread across the physical address space savannah.

There is no argument that sparsemem is more robust and flexible in its ability to hande separated memory banks. And, AFAIU, nobody suggests to start using flatmem instead of sparsemem on any machine.

Currently, when you build the kernel with "make defconfig && make" or "make multi_X_defconfig && make" kconfig implicitly selects flatmem and there is no possiblity to enable sparsemem in the menuconfig.

Florian sent the pathces with the purpose to allow overriding the explict choise of flatmem with sparsemem in menuconfig.

At some point I've asked whether we would like to use sparsemem instead of flatmem as the default for the multiplafrom build. The upside of such change is the robustness you described above. The downside is a bit larger kernel image and slight slow down in page_to_pfn and pfn_to_page.

That said we have two options:
* Massage the patches Florian sent and add ability to select memory model in menuconfig for the multiplatform builds without changing anything in configurations that were not manually atered.
* Simply add 'select ARCH_SPAPSEMEM_ENABLE' under 'ARCH_MULTIPLAFROM' and force all multiplatform builds to use sparsemem.

So the question is what is the preferred way to move forward.

Quoted 3 lines
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up
Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#25 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

In reply to Russell King - ARM Linux admin
Quoted 26 lines · Russell King - ARM Linux admin
Quoted 17 lines · Arnd Bergmann
Quoted 7 lines · Mike Rapoport
Quoted 5 lines · Russell King - ARM Linux admin

There are cases where the reason to use sparsemem is not an optional one but is out of necessity - they require the page array to be split up in order to boot successfully.

With that in mind, flatmem becomes an "optimisation" over sparsemem.

Quoted 8 lines

At the moment, there are three platforms that enable SPARSEMEM: ARCH_EP93XX, ARCH_RPC and ARCH_SA1100. All the rest have FLATMEM implcitly selected.

I do not intend to change that, I am only going add an ability to select the memory model for ARCH_MULTIPLATFORM.

I'll respin the series on the list before adding the patches to the patch system.

Quoted 7 lines

I think we'll make EP93xx part of multiplatform at some point, IIRC only the missing clock driver is stopping us at the moment, and I already discussed with Linus Walleij how that can be done.

My guess is that ep93xx is one platform on which sparsemem is just an optimization to reduce the initial memory consumption, but we should verify that when we get there.

Quoted 5 lines

When you have a platform where the memory is segmented into separate blocks widely spaced, sparsemem is not an optimisation. For example, If you have four blocks spaced across 1GB, that requires about 256Ki struct page's. Assuming 32 byte struct page, that requires 8MiB of contiguous memory.

I checked the datasheet: ep93xx has four chip-selects, each of them with their own 256MB memory area. Most boards we support use only the last chipselect, but those that have more than one would waste up to 2MB per additional memory chip, which is not nice but doesn't make it a hard requirement as long as the kernel can fit into the first one.

However, the chips has a second problem: depending on the specific memory configuration, only every other 2/4/8MB within that range may actually be used, so the mem_map[] array would double its size in practice and (worse) the kernel would likely not fit into the first section without sparsemem.

This means we should indeed treat it as a requirement for ep93xx.

Arnd

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#26 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 40 lines · Arnd Bergmann
Quoted 26 lines · Russell King - ARM Linux admin
Quoted 17 lines · Arnd Bergmann
Quoted 7 lines · Mike Rapoport
Quoted 5 lines · Russell King - ARM Linux admin

There are cases where the reason to use sparsemem is not an optional one but is out of necessity - they require the page array to be split up in order to boot successfully.

With that in mind, flatmem becomes an "optimisation" over sparsemem.

Quoted 8 lines

At the moment, there are three platforms that enable SPARSEMEM: ARCH_EP93XX, ARCH_RPC and ARCH_SA1100. All the rest have FLATMEM implcitly selected.

I do not intend to change that, I am only going add an ability to select the memory model for ARCH_MULTIPLATFORM.

I'll respin the series on the list before adding the patches to the patch system.

Quoted 7 lines

I think we'll make EP93xx part of multiplatform at some point, IIRC only the missing clock driver is stopping us at the moment, and I already discussed with Linus Walleij how that can be done.

My guess is that ep93xx is one platform on which sparsemem is just an optimization to reduce the initial memory consumption, but we should verify that when we get there.

Quoted 5 lines

When you have a platform where the memory is segmented into separate blocks widely spaced, sparsemem is not an optimisation. For example, If you have four blocks spaced across 1GB, that requires about 256Ki struct page's. Assuming 32 byte struct page, that requires 8MiB of contiguous memory.

I checked the datasheet: ep93xx has four chip-selects, each of them with their own 256MB memory area. Most boards we support use only the last chipselect, but those that have more than one would waste up to 2MB per additional memory chip, which is not nice but doesn't make it a hard requirement as long as the kernel can fit into the first one.

Quoted 7 lines

However, the chips has a second problem: depending on the specific memory configuration, only every other 2/4/8MB within that range may actually be used, so the mem_map[] array would double its size in practice and (worse) the kernel would likely not fit into the first section without sparsemem.

This means we should indeed treat it as a requirement for ep93xx.

That is already captured with the select ARCH_SPARSEMEM_ENABLE or the ARCH_EP93XX entry.

Should we just make it possible for multi platform users to override the memory model in their configuration file and later we just default ARCH_MULTI_V7 to sparsemem?

Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#27 lore raw

Re: [PATCH 2/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build

Quoted 15 lines · Florian Fainelli
Quoted 14 lines · Arnd Bergmann

On Tue, May 19, 2020 at 6:54 PM Russell King - ARM Linux admin <[email protected]> wrote:

I checked the datasheet: ep93xx has four chip-selects, each of them with their own 256MB memory area. Most boards we support use only the last chipselect, but those that have more than one would waste up to 2MB per additional memory chip, which is not nice but doesn't make it a hard requirement as long as the kernel can fit into the first one.

However, the chips has a second problem: depending on the specific memory configuration, only every other 2/4/8MB within that range may actually be used, so the mem_map[] array would double its size in practice and (worse) the kernel would likely not fit into the first section without sparsemem.

Quoted 4 lines
Quoted 1 line

This means we should indeed treat it as a requirement for ep93xx.

That is already captured with the select ARCH_SPARSEMEM_ENABLE or the ARCH_EP93XX entry.

Yes, we just need to keep it that way when ep93xx eventually becomes part of the ARCH_MULTI_V4T configuration.

Quoted 3 lines

Should we just make it possible for multi platform users to override the memory model in their configuration file and later we just default ARCH_MULTI_V7 to sparsemem?

I think there are three steps:

1. make the memory model user-selectable for all multiplatform kernels to allow sparsemem
2. change the defconfig files for platforms that would likely benefit (multi_v7_defconfig, exynos_defconfig, imx_v6_v7_defconfig, ...)
3. change the default for ARCH_MULTI_V7, or alternatively for configurations that include platforms that usually want it.

My preference would be to have the first two in v5.8, but leave the third one for a later time, depending on who needs it. I notice that the changelog text does not give a particular example of platforms with very sparse memory maps. It might help to have more background there. Among the platforms I see, it seems fairly rare to have any RAM above the 4GB boundary on ARMv7 based chips: keystone2, r-car, and highbank would be the main examples I can think of, but I don't know if they have large holes in the memory map.

Arnd

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#28 lore raw
In reply to Florian Fainelli
Quoted 5 lines · Florian Fainelli

Hi all,

This patch series somehow got lost back in 2015, and while looking at the various patches that we are carrying in our BRCMSTB downstream kernel those two patches should have made it upstream.

I don't believe it's a good idea for multiplatform.

If you have a platform that relies on sparsemem within the multiplatform family, and you select flatmem, how would it boot?

Sparsemem can support flatmem layouts, but flatmem can't support sparsemem layouts.

So, allowing flatmem seems to go against the underlying principle of multiplatform support.

Signature · 7 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#29 lore raw

Hi Russell,

Quoted 9 lines · Russell King - ARM Linux admin
Quoted 5 lines · Florian Fainelli

Hi all,

This patch series somehow got lost back in 2015, and while looking at the various patches that we are carrying in our BRCMSTB downstream kernel those two patches should have made it upstream.

I don't believe it's a good idea for multiplatform.

Quoted 8 lines

If you have a platform that relies on sparsemem within the multiplatform family, and you select flatmem, how would it boot?

Sparsemem can support flatmem layouts, but flatmem can't support sparsemem layouts.

So, allowing flatmem seems to go against the underlying principle of multiplatform support.

Currently neither of multiplafrom builds has SPARSEMEM enabled, so unless I misread theses patches, they actually allow enabling SPARSEMEM in menuconfig for custom builds based on a multiplatform config.

Quoted 3 lines
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Signature · 7 lines
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel