cmd: cache: Fix non-cached memory cachability
PATCH v2 1/1 cmd: cache: Fix non-cached memory cachability
If dcache is switched OFF to ON state and if non-cached memory is used, this non-cached memory must be re-declared as uncached to mmu each time dcache is set ON.
Introduce noncached_set_region() to set this non-cached region's mmu settings. Let architecture override it by defining it as a weak function.
For ARM architecture, noncached_set_region() defines all noncached region as non-cacheable.
Issue found on STM32MP1 platform using dwc_eth_qos ethernet driver, when going from dcache OFF to dcache ON state, ethernet driver issued TX timeout errors when performing dhcp or ping.
It can be reproduced with the following sequence:
dhcp
while true ; do
ping 192.168.1.300 ;
dcache off ;
ping 192.168.1.300 ;
dcache on ;
done
---
Changes in v2:
- make noncached_set_region a weak function
arch/arm/lib/cache.c | 13 ++++++++++--- cmd/cache.c | 5 +++++ 2 files changed, 15 insertions(+), 3 deletions(-)
arch/arm/lib/cache.c +10 -3
@@ -75,6 +75,15 @@ static unsigned long noncached_start;static unsigned long noncached_end;static unsigned long noncached_next; +void noncached_set_region (void ) +{ +#if !CONFIG_IS_ENABLED (SYS_DCACHE_OFF ) +mmu_set_region_dcache_behaviour (noncached_start, + noncached_end - noncached_start, +DCACHE_OFF ); +#endif +} +void noncached_init (void ) {phys_addr_t start, end;
@@ -91,9 +100,7 @@ void noncached_init(void) noncached_end = end; noncached_next = start; -#if !CONFIG_IS_ENABLED (SYS_DCACHE_OFF ) -mmu_set_region_dcache_behaviour (noncached_start, size,DCACHE_OFF ); -#endif +noncached_set_region (); }phys_addr_t noncached_alloc (size_t size,size_t align)
cmd/cache.c +5 -0
@@ -20,6 +20,10 @@ void __weak invalidate_icache_all(void)puts ("No arch specific invalidate_icache_all available!\n" ); } +__weak void noncached_set_region (void ) +{ +} +static int do_icache (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {switch (argc) {
@@ -64,6 +68,7 @@ static int do_dcache(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])break ;case 1 :dcache_enable (); +noncached_set_region ();break ;case 2 :flush_dcache_all ();
Signature · 1 line
2.17.1
PATCH v2 1/1 cmd: cache: Fix non-cached memory cachability
Quoted 31 lines · Patrice Chotard
If dcache is switched OFF to ON state and if non-cached memory is used, this non-cached memory must be re-declared as uncached to mmu each time dcache is set ON.
Introduce
noncached_set_region()to set this non-cached region's mmu settings. Let architecture override it by defining it as a weak function.For ARM architecture,
noncached_set_region()defines all noncached region as non-cacheable.Issue found on STM32MP1 platform using
dwc_eth_qosethernet driver, when going from dcache OFF to dcache ON state, ethernet driver issued TX timeout errors when performing dhcp or ping.It can be reproduced with the following sequence:
dhcp
while true ; do
ping 192.168.1.300 ;
dcache off ;
ping 192.168.1.300 ;
dcache on ;
doneSigned-off-by Patrice Chotard <[email protected]>Cc Marek Vasut <[email protected]>Cc Joe Hershberger <[email protected]>Cc Ramon Fried <[email protected]>Cc Stephen Warren <[email protected]>
Quoted 8 lines
---
Changes in v2:
- makenoncached_set_regiona weak functionarch/arm/lib/cache.c | 13 ++++++++++--- cmd/cache.c | 5 +++++ 2 files changed, 15 insertions(+), 3 deletions
PATCH v2 1/1 cmd: cache: Fix non-cached memory cachability
In reply to Patrice ChotardQuoted 25 lines · Patrice Chotard
If dcache is switched OFF to ON state and if non-cached memory is used, this non-cached memory must be re-declared as uncached to mmu each time dcache is set ON.
Introduce
noncached_set_region()to set this non-cached region's mmu settings. Let architecture override it by defining it as a weak function.For ARM architecture,
noncached_set_region()defines all noncached region as non-cacheable.Issue found on STM32MP1 platform using
dwc_eth_qosethernet driver, when going from dcache OFF to dcache ON state, ethernet driver issued TX timeout errors when performing dhcp or ping.It can be reproduced with the following sequence:
dhcp
while true ; do
ping 192.168.1.300 ;
dcache off ;
ping 192.168.1.300 ;
dcache on ;
done
Quoted 6 lines
Signed-off-by Patrice Chotard <[email protected]>Cc Marek Vasut <[email protected]>Cc Joe Hershberger <[email protected]>Cc Ramon Fried <[email protected]>Cc Stephen Warren <[email protected]>Reviewed-by Marek Vasut <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200507/3cb3219c/attachment.sig>