drm/amdgpu: Don't report unique_id for Arcturus
Subsystems (2)
PATCH 1/1 drm/amdgpu: Don't report unique_id for Arcturus
This isn't supported in the SMU yet, so just break early. This can be reverted once the SMU supports the feature
--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +5 -0
@@ -317,6 +317,11 @@ static int arcturus_tables_init(struct smu_context *smu, struct smu_table *table smu_table->metrics_time =0 ;if (smu->adev->asic_type ==CHIP_ARCTURUS ) { +/* TODO: SMU doesn't currently support this. Return +* early and remove this once SMU supports it +*/ +return 0 ; +/* Get the SN to turn into a Unique ID */ smu_send_smc_msg (smu, SMU_MSG_ReadSerialNumTop32, &top32);
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
maintainer[AMD Public Use]
Shouldn't all of this code be moved later anyway to make sure the SMU is up and running already?
Alex
________________________________
From: amd-gfx <[email protected]> on behalf of Kent Russell <[email protected]>
Sent: Thursday, May 7, 2020 9:53 AM
To: [email protected] <[email protected]>
Cc: Russell, Kent <[email protected]>
Subject: [PATCH] drm/amdgpu: Don't report unique_id for Arcturus
This isn't supported in the SMU yet, so just break early. This can be reverted once the SMU supports the feature
--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +5 -0
@@ -317,6 +317,11 @@ static int arcturus_tables_init(struct smu_context *smu, struct smu_table *table smu_table->metrics_time =0 ;if (smu->adev->asic_type ==CHIP_ARCTURUS ) { +/* TODO: SMU doesn't currently support this. Return +* early and remove this once SMU supports it +*/ +return 0 ; +/* Get the SN to turn into a Unique ID */ smu_send_smc_msg (smu, SMU_MSG_ReadSerialNumTop32, &top32);
--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C2081bb617dd14d81e7a108d7f28e1f8f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637244564588764106&sdata=GevSmW%2Fgzq862kdiJwcbGbCMHfboIGx77zfA%2FOuwhW8%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
[AMD Public Use]
Indeed. I was trying to keep it all in there anyways to make less churn, but I can remove it altogether, including the definitions that aren't supported. I was informed that it wasn't supported nor working correctly, so I'll revert both patches (definitions and adding support) for clarity. Thanks!
Kent
From: Deucher, Alexander <[email protected]>
Sent: Thursday, May 7, 2020 11:10 AM
To: Russell, Kent <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/amdgpu: Don't report unique_id for Arcturus
[AMD Public Use]
Shouldn't all of this code be moved later anyway to make sure the SMU is up and running already?
Alex
________________________________
From: amd-gfx <[email protected]<mailto:[email protected]>> on behalf of Kent Russell <[email protected]<mailto:[email protected]>>
Sent: Thursday, May 7, 2020 9:53 AM
To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>
Cc: Russell, Kent <[email protected]<mailto:[email protected]>>
Subject: [PATCH] drm/amdgpu: Don't report unique_id for Arcturus
This isn't supported in the SMU yet, so just break early. This can be reverted once the SMU supports the feature
--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +5 -0
@@ -317,6 +317,11 @@ static int arcturus_tables_init(struct smu_context *smu, struct smu_table *table smu_table->metrics_time =0 ;if (smu->adev->asic_type ==CHIP_ARCTURUS ) { +/* TODO: SMU doesn't currently support this. Return +* early and remove this once SMU supports it +*/ +return 0 ; +/* Get the SN to turn into a Unique ID */ smu_send_smc_msg (smu, SMU_MSG_ReadSerialNumTop32, &top32);
--
2.17.1
_______________________________________________
amd-gfx mailing list [email protected]<mailto:[email protected]>
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C2081bb617dd14d81e7a108d7f28e1f8f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637244564588764106&sdata=GevSmW%2Fgzq862kdiJwcbGbCMHfboIGx77zfA%2FOuwhW8%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx