Skip to contentSkip to conversation

Input: wm831x-ts - add missed input_unregister_device

PATCH In review Chuhong Yuan 3 participants 3 messages May 7, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: wm831x-ts - add missed input_unregister_device

This driver calls input_register_device() in probe, but misses input_unregister_device() in remove.
Add the missed function call to fix it.

---
 drivers/input/touchscreen/wm831x-ts.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/wm831x-ts.c +1 -0
index 607d1aeb595d..db09dd473ada 100644
@@ -379,6 +379,7 @@ static int wm831x_ts_remove(struct platform_device *pdev)
 {
 	struct wm831x_ts *wm831x_ts = platform_get_drvdata(pdev);
 
+	input_unregister_device(wm831x_ts->input_dev);
 	free_irq(wm831x_ts->pd_irq, wm831x_ts);
 	free_irq(wm831x_ts->data_irq, wm831x_ts);
 
Signature · 1 line
2.26.2
#1 lore raw
Quoted 14 lines · Chuhong Yuan

This driver calls input_register_device() in probe, but misses input_unregister_device() in remove.
Add the missed function call to fix it.

---
 drivers/input/touchscreen/wm831x-ts.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/wm831x-ts.c +0 -0
index 607d1aeb595d..db09dd473ada 100644

drivers/input/touchscreen/wm831x-ts.c static int wm831x_ts_remove(struct platform_device *pdev) · line 382

Quoted 4 lines
drivers/input/touchscreen/wm831x-ts.c +1 -0
@@ -379,6 +379,7 @@ static int wm831x_ts_remove(struct platform_device *pdev)
 {
 	struct wm831x_ts *wm831x_ts = platform_get_drvdata(pdev);
 
+	input_unregister_device(wm831x_ts->input_dev);

Are you seeing specific issues caused by this being missing, if so it would be good if you could elaborate on them? My understanding is that since this driver uses devm_input_allocate_device input_unregister_device will be handled automatically, see the comments on input_register_device/devm_input_allocate_device.

Thanks,
Charles

Quoted 6 lines
drivers/input/touchscreen/wm831x-ts.c +0 -0
 	free_irq(wm831x_ts->pd_irq, wm831x_ts);
 	free_irq(wm831x_ts->data_irq, wm831x_ts);
 
Signature · 1 line
2.26.2
maintainer
#2 lore raw
In reply to Chuhong Yuan
Quoted 3 lines · Chuhong Yuan

This driver calls input_register_device() in probe, but misses input_unregister_device() in remove.
Add the missed function call to fix it.

The input device in question is devm-managed and therefore does not need explicit unregistering.

Thanks.

Signature · 1 line
Dmitry