Skip to contentSkip to conversation

Input: stmpe-ts - add missed input_unregister_device

PATCH In review Chuhong Yuan 2 participants 2 messages May 7, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: stmpe-ts - add missed input_unregister_device

This driver calls input_register_device() in probe, but misses input_unregister_device() in remove.
Add the missed function call to fix it.

---
 drivers/input/touchscreen/stmpe-ts.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/stmpe-ts.c +1 -0
index 7e16fcfe3b95..5e62b466629b 100644
@@ -350,6 +350,7 @@ static int stmpe_ts_remove(struct platform_device *pdev)
 {
 	struct stmpe_touch *ts = platform_get_drvdata(pdev);
 
+	input_unregister_device(ts->idev);
 	stmpe_disable(ts->stmpe, STMPE_BLOCK_TOUCHSCREEN);
 
 	return 0;
Signature · 1 line
2.26.2
maintainer
#1 lore raw
Quoted 3 lines · Chuhong Yuan

This driver calls input_register_device() in probe, but misses input_unregister_device() in remove.
Add the missed function call to fix it.

The input device in question is devm-managed and therefore does not need explicit unregistering.

Thanks.

Signature · 1 line
Dmitry