firewire: ohci: Replace zero-length array with flexible-array
PATCH 1/1 firewire: ohci: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- drivers/firewire/core-cdev.c | 2 +- drivers/firewire/core-transaction.c | 2 +- drivers/firewire/core.h | 2 +- drivers/firewire/nosy.c | 2 +- drivers/firewire/ohci.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
drivers/firewire/core-cdev.c +1 -1
@@ -117,7 +117,7 @@ struct inbound_transaction_resource {struct descriptor_resource {struct client_resource resource;struct fw_descriptor descriptor; -u32 data[0 ]; +u32 data[]; };struct iso_resource {
drivers/firewire/core-transaction.c +1 -1
@@ -620,7 +620,7 @@ struct fw_request {u32 request_header[4 ];int ack;u32 length; -u32 data[0 ]; +u32 data[]; }; static void free_response_callback(struct fw_packet *packet,
drivers/firewire/core.h +1 -1
@@ -191,7 +191,7 @@ struct fw_node {/* Upper layer specific data. */ void *data; -struct fw_node *ports[0 ]; +struct fw_node *ports[]; };static inline struct fw_node *fw_node_get (struct fw_node *node)
drivers/firewire/nosy.c +1 -1
@@ -52,7 +52,7 @@ struct pcl {struct packet {unsigned int length; -char data[0 ]; +char data[]; };struct packet_buffer {
drivers/firewire/ohci.c +1 -1
@@ -111,7 +111,7 @@ struct descriptor_buffer {dma_addr_t buffer_bus;size_t buffer_size;size_t used; -struct descriptor buffer[0 ]; +struct descriptor buffer[]; };struct context {