sched/fair: Replace zero-length array with flexible-array
PATCH 1/1 sched/fair: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- kernel/sched/fair.c | 2 +- kernel/sched/sched.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +1 -1
@@ -1094,7 +1094,7 @@ struct numa_group {* more by CPU use than by memory faults. */ unsigned long *faults_cpu; -unsigned long faults[0 ]; +unsigned long faults[]; };/*
kernel/sched/sched.h +1 -1
@@ -1461,7 +1461,7 @@ struct sched_group {* by attaching extra space to the end of the structure, * depending on how many CPUs the kernel has booted up with) */ -unsigned long cpumask[0 ]; +unsigned long cpumask[]; };static inline struct cpumask *sched_group_span (struct sched_group *sg)
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 04f5c362ec6d3ff0e14f1c05230b550da7f528a4 Gitweb: https://git.kernel.org/tip/04f5c362ec6d3ff0e14f1c05230b550da7f528a4 Author: Gustavo A. R. Silva <[email protected]> AuthorDate: Thu, 07 May 2020 14:21:41 -05:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Tue, 19 May 2020 20:34:14 +02:00
sched/fair: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- kernel/sched/fair.c | 2 +- kernel/sched/sched.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +1 -1
@@ -1094,7 +1094,7 @@ struct numa_group {* more by CPU use than by memory faults. */ unsigned long *faults_cpu; -unsigned long faults[0 ]; +unsigned long faults[]; };/*
kernel/sched/sched.h +1 -1
@@ -1462,7 +1462,7 @@ struct sched_group {* by attaching extra space to the end of the structure, * depending on how many CPUs the kernel has booted up with) */ -unsigned long cpumask[0 ]; +unsigned long cpumask[]; };static inline struct cpumask *sched_group_span (struct sched_group *sg)