scsi: ufs: Replace zero-length array with flexible-array
PATCH 1/1 scsi: ufs: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/ufs/ufshcd.c +1 -1
@@ -3223,7 +3223,7 @@ static inline int ufshcd_read_desc(struct ufs_hba *hba,struct uc_string_id {u8 len;u8 type; -wchar_t uc[0 ]; +wchar_t uc[]; } __packed;/* replace non-printable or non-ASCII characters with spaces */
Martin K. Petersen
AppliedQuoted 11 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };[...]
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ufs: Replace zero-length array with flexible-array
https://git.kernel.org/mkp/scsi/c/ec38c0adc0a1
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Quoted 7 lines · Martin K. Petersen
On Thu, 7 May 2020 14:25:50 -0500, Gustavo A. R. Silva wrote:
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ufs: Replace zero-length array with flexible-array
https://git.kernel.org/mkp/scsi/c/ec38c0adc0a1
Thanks, Martin.
--
Gustavo