Skip to contentSkip to conversation

Add support for ASUS Z00T TM5P5 NT35596 panel

PATCH In review Konrad Dybcio 2 participants 4 messages May 6, 2020 – May 7, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v4 cover Add support for ASUS Z00T TM5P5 NT35596 panel

changes since v3:
- fix dt-bindings issue

changes since v2:
- fix Kconfig indentation

changes since v1:
- make backlight_properties props constant
- a couple of line breaks
- change name and compatible to reflect ASUS being the vendor
- remove a redundant TODO

Konrad Dybcio (2):
drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver
dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel
compatible

 .../panel/asus,z00t-tm5p5-nt35596.yaml        |  56 +++
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../drm/panel/panel-asus-z00t-tm5p5-n35596.c  | 367 ++++++++++++++++++
 4 files changed, 434 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c
Signature · 1 line
2.26.2
#1 lore raw

PATCH v4 1/2 drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver

This adds support for TMP5P5 NT35596 1080x1920 video mode panel that can be found on some Asus Zenfone 2 Laser (Z00T) devices.

This panel seems to only be found in this device and we have no straightforward way of actually getting the correct model number, as no schematics are released publicly.

---
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../drm/panel/panel-asus-z00t-tm5p5-n35596.c  | 367 ++++++++++++++++++
 3 files changed, 378 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c
drivers/gpu/drm/panel/Kconfig +10 -0
index a1723c1b5fbf8..ad896a877d49f 100644
@@ -18,6 +18,16 @@ config DRM_PANEL_ARM_VERSATILE
 	  reference designs. The panel is detected using special registers
 	  in the Versatile family syscon registers.
 
+config DRM_PANEL_ASUS_Z00T_TM5P5_NT35596
+	tristate "ASUS Z00T TM5P5 NT35596 panel"
+	depends on GPIOLIB && OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y here if you want to enable support for the ASUS TMP5P5
+	  NT35596 1080x1920 video mode panel as found in some Asus
+	  Zenfone 2 Laser Z00T devices.
+
 config DRM_PANEL_BOE_HIMAX8279D
 	tristate "Boe Himax8279d panel"
 	depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
index 96a883cd66305..3efc1de93aeeb 100644
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o
+obj-$(CONFIG_DRM_PANEL_ASUS_Z00T_TM5P5_NT35596) += panel-asus-z00t-tm5p5-n35596.o
 obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
 obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_NL6) += panel-boe-tv101wum-nl6.o
 obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c new file +367 -0

367 lines not on this page · raw message

Signature · 1 line
2.26.2
#2 lore raw

PATCH v4 2/2 dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel compatible

In reply to Konrad Dybcio
---
 .../panel/asus,z00t-tm5p5-nt35596.yaml        | 56 +++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml
Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml new file +56 -0
new file mode 100644
index 0000000000000..083d2b9d0c69a
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/asus,z00t-tm5p5-nt35596.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASUS Z00T TM5P5 NT35596 5.5" 1080×1920 LCD Panel
+
+maintainers:
+  - Konrad Dybcio <[email protected]>
+
+description: |+
+  This panel seems to only be found in the Asus Z00T
+  smartphone and we have no straightforward way of
+  actually getting the correct model number,
+  as no schematics are released publicly.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: asus,z00t-tm5p5-n35596
+  reg: true
+  reset-gpios: true
+  vdd-supply:
+     description: core voltage supply
+  vddio-supply:
+     description: vddio supply
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+  - vddio-supply
+  - reset-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+            #address-cells = <1>;
+            #size-cells = <0>;
+            panel@0 {
+                    reg = <0>;
+
+                    compatible = "asus,z00t-tm5p5-n35596";
+
+                    vdd-supply = <&pm8916_l8>;
+                    vddio-supply = <&pm8916_l6>;
+                    reset-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
+            };
+    };
Signature · 1 line
2.26.2
#3 lore raw
In reply to Konrad Dybcio

Hi Konrad.

Quoted 12 lines · Konrad Dybcio

changes since v3:
- fix dt-bindings issue

changes since v2:
- fix Kconfig indentation

changes since v1:
- make backlight_properties props constant
- a couple of line breaks
- change name and compatible to reflect ASUS being the vendor
- remove a redundant TODO

Quoted 4 lines

Konrad Dybcio (2):
drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver
dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel
compatible

Thanks, applied in the reverse order to have the binding before the driver.
Fixed a few checkpatch warnings while applying.
We use --strict for code in drivers/gpu/*

Sam

Quoted 11 lines
 .../panel/asus,z00t-tm5p5-nt35596.yaml        |  56 +++
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../drm/panel/panel-asus-z00t-tm5p5-n35596.c  | 367 ++++++++++++++++++
 4 files changed, 434 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c
Signature · 1 line
2.26.2