greybus: audio: remove unused code
Subsystems (3)
PATCH 1/1 greybus: audio: remove unused code
GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as reported in September 2016, it depends on an "out-of-tree qualcomm audio driver". This driver never made it upstream.
https://lore.kernel.org/lkml/[email protected]/
Moreover, there doesn't seem to be any interest in actually fixing the driver as it uses ASoC APIs that have been removed from the kernel in 2018 as shown by its use of snd_soc_register_codec and snd_soc_codec_get_drvdata, removed in commit 999f7f5af8eb ("ASoC: remove Codec related code").
--- drivers/staging/greybus/Makefile | 4 - drivers/staging/greybus/audio_codec.c | 1103 ---------------- drivers/staging/greybus/audio_module.c | 478 ------- drivers/staging/greybus/audio_topology.c | 1448 ---------------------- 4 files changed, 3033 deletions(-) delete mode 100644 drivers/staging/greybus/audio_codec.c delete mode 100644 drivers/staging/greybus/audio_module.c delete mode 100644 drivers/staging/greybus/audio_topology.c
drivers/staging/greybus/Makefile +0 -4
@@ -27,8 +27,6 @@ obj-$(CONFIG_GREYBUS_RAW) += gb-raw.o obj-$(CONFIG_GREYBUS_VIBRATOR) += gb-vibrator.o # Greybus Audio is a bunch of modules -gb-audio-module-y := audio_module.o audio_topology.o -gb-audio-codec-y := audio_codec.o gb-audio-gb-y := audio_gb.o gb-audio-apbridgea-y := audio_apbridgea.o gb-audio-manager-y := audio_manager.o audio_manager_module.o
@@ -40,8 +38,6 @@ gb-audio-manager-y := audio_manager.o audio_manager_module.o #ccflags-y += -DGB_AUDIO_MANAGER_SYSFS #endif -obj-$(CONFIG_GREYBUS_AUDIO_MSM8994) += gb-audio-codec.o -obj-$(CONFIG_GREYBUS_AUDIO_MSM8994) += gb-audio-module.o obj-$(CONFIG_GREYBUS_AUDIO) += gb-audio-gb.o obj-$(CONFIG_GREYBUS_AUDIO) += gb-audio-apbridgea.o obj-$(CONFIG_GREYBUS_AUDIO) += gb-audio-manager.o
drivers/staging/greybus/audio_codec.c deleted +0 -1103
1,103 lines not on this page · raw message
drivers/staging/greybus/audio_module.c deleted +0 -478
478 lines not on this page · raw message
drivers/staging/greybus/audio_topology.c deleted +0 -1448
1,403 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.26.2
Part of the diff is not shown here. View the raw message.
Quoted 6 lines · Alexandre Belloni
GREYBUS_AUDIO_MSM8994is not an existing configuration option and as reported in September 2016, it depends on an "out-of-tree qualcomm audio driver". This driver never made it upstream.
Quoted 8 lines
Moreover, there doesn't seem to be any interest in actually fixing the driver as it uses ASoC APIs that have been removed from the kernel in 2018 as shown by its use of
snd_soc_register_codecandsnd_soc_codec_get_drvdata, removed in commit999f7f5af8eb("ASoC: remove Codec related code").Signed-off-by Alexandre Belloni <[email protected]>---
Everything you say is true but it is still kinda sad to see this go. But that is life... If and when someone has the motivation to get this working again they can take a look at the git history.
Thanks for this, Alexandre.
Vaibhav Agarwal
maintainerQuoted 8 lines · Mark Greer
Quoted 6 lines · Alexandre Belloni
GREYBUS_AUDIO_MSM8994is not an existing configuration option and as reported in September 2016, it depends on an "out-of-tree qualcomm audio driver". This driver never made it upstream.
Quoted 8 lines
Quoted 8 lines
Moreover, there doesn't seem to be any interest in actually fixing the driver as it uses ASoC APIs that have been removed from the kernel in 2018 as shown by its use of
snd_soc_register_codecandsnd_soc_codec_get_drvdata, removed in commit999f7f5af8eb("ASoC: remove Codec related code").Signed-off-by Alexandre Belloni <[email protected]>---
Hi Alexandre,
As mentioned in the mail archive referred, the GB Codec driver that is currently available in kernel tree is dependent on qualcomm audio driver. And some time later I made some minor modifications to remove the unnecessary dependencies. However, I missed to share the same with the community :(
Thanks to you for triggering the thread. Now, I could retrieve my local changes and I have been in the process of updating it again to make it compatible with latest kernel.
I'm planning to share the same here in the next few days. I'll mark you in CC to seek your review comments as well.
In case, I'm unable to make those changes to the staging tree, I would also recommend to drop this code. Kindly let me know your opinion.
--
thanks,
./va
Quoted 8 lines
Everything you say is true but it is still kinda sad to see this go. But that is life... If and when someone has the motivation to get this working again they can take a look at the git history.
Thanks for this, Alexandre.
Acked-by Mark Greer <[email protected]>
Greg Kroah-Hartman
maintainerQuoted 25 lines · Vaibhav Agarwal
Quoted 8 lines · Mark Greer
Quoted 6 lines · Alexandre Belloni
GREYBUS_AUDIO_MSM8994is not an existing configuration option and as reported in September 2016, it depends on an "out-of-tree qualcomm audio driver". This driver never made it upstream.Quoted 8 lines
Quoted 8 lines
Moreover, there doesn't seem to be any interest in actually fixing the driver as it uses ASoC APIs that have been removed from the kernel in 2018 as shown by its use of
snd_soc_register_codecandsnd_soc_codec_get_drvdata, removed in commit999f7f5af8eb("ASoC: remove Codec related code").Signed-off-by Alexandre Belloni <[email protected]>---
Hi Alexandre,
As mentioned in the mail archive referred, the GB Codec driver that is currently available in kernel tree is dependent on qualcomm audio driver. And some time later I made some minor modifications to remove the unnecessary dependencies. However, I missed to share the same with the community :(
Quoted 6 lines
Thanks to you for triggering the thread. Now, I could retrieve my local changes and I have been in the process of updating it again to make it compatible with latest kernel.
I'm planning to share the same here in the next few days. I'll mark you in CC to seek your review comments as well.
I'll give you a few more days for that patch to be sent before I apply this one...
thanks,
greg k-h