Skip to contentSkip to conversation

musb-new: Use predefined configuration data for SUN50I_H6

PATCH New Roman Stratiienko 1 participant 4 messages May 8, 2020 – Sep 21, 2020 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 musb-new: Use predefined configuration data for SUN50I_H6

Same was done in the kernel for all devices compatible with 'allwinner,sun8i-a33-musb' at [1] and [2].

Fixes musb initialization on H6 SOC.

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
[2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440

---
CC: Ondrej Jirman <[email protected]>
CC: Icenowy Zheng <[email protected]>
CC: Marek Vasut <[email protected]>
CC: linux-sunxi at googlegroups.com

Hello community,

'$ fastboot usb 0' command works, but host still doesn't see any USB devices. Does anyone have any suggestions where to look?

---
 drivers/usb/musb-new/musb_regs.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/musb-new/musb_regs.h +3 -1
index c4d7203b85..5f012f3b41 100644
@@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
 static inline u8 musb_read_configdata(void __iomem *mbase)
 {
 #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
-		defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
+	defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
+	defined CONFIG_MACH_SUN50I_H6
+
 	/* <Sigh> allwinner saves a reg, and we need to hardcode this */
 	return 0xde;
 #else
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 musb-new: Use predefined configuration data for SUN50I_H6

CC jagan at amarulasolutions.com

??, 8 ??? 2020 ?. ? 15:29, Roman Stratiienko <[email protected]>:

Quoted 42 lines

Same was done in the kernel for all devices compatible with 'allwinner,sun8i-a33-musb' at [1] and [2].

Fixes musb initialization on H6 SOC.

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
[2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440

---
CC: Ondrej Jirman <[email protected]>
CC: Icenowy Zheng <[email protected]>
CC: Marek Vasut <[email protected]>
CC: linux-sunxi at googlegroups.com

Hello community,

'$ fastboot usb 0' command works, but host still doesn't see any USB devices. Does anyone have any suggestions where to look?

---
 drivers/usb/musb-new/musb_regs.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/musb-new/musb_regs.h +3 -2
index c4d7203b85..5f012f3b41 100644
@@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
 static inline u8 musb_read_configdata(void __iomem *mbase)
 {
 #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
-               defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
+       defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
+       defined CONFIG_MACH_SUN50I_H6
+
        /* <Sigh> allwinner saves a reg, and we need to hardcode this */
        return 0xde;
 #else
--

2.25.1

#2 lore raw

PATCH 1/1 musb-new: Use predefined configuration data for SUN50I_H6

??, 14 ??? 2020 ?. ? 09:44, Roman Stratiienko <[email protected]>:

Quoted 24 lines
CC jagan at amarulasolutions.com

??, 8 ??? 2020 ?. ? 15:29, Roman Stratiienko <[email protected]>:

Quoted 20 lines

Same was done in the kernel for all devices compatible with 'allwinner,sun8i-a33-musb' at [1] and [2].

Fixes musb initialization on H6 SOC.

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
[2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440

---
CC: Ondrej Jirman <[email protected]>
CC: Icenowy Zheng <[email protected]>
CC: Marek Vasut <[email protected]>
CC: linux-sunxi at googlegroups.com

Hello community,

'$ fastboot usb 0' command works, but host still doesn't see any USB devices. Does anyone have any suggestions where to look?

Hello,

Second issue was fixed with commit 462a9c7a9cce ("phy: sun4i-usb:
Align H6 initialization logic with the kernel") <merged> This patch is required to fix download gadget support for H6 SOC. Please review/merge.

Quoted 22 lines
Quoted 22 lines
---
 drivers/usb/musb-new/musb_regs.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/musb-new/musb_regs.h +3 -2
index c4d7203b85..5f012f3b41 100644
@@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
 static inline u8 musb_read_configdata(void __iomem *mbase)
 {
 #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
-               defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
+       defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
+       defined CONFIG_MACH_SUN50I_H6
+
        /* <Sigh> allwinner saves a reg, and we need to hardcode this */
        return 0xde;
 #else
--

2.25.1

#3 lore raw

PATCH 1/1 musb-new: Use predefined configuration data for SUN50I_H6

CC linux-sunxi at googlegroups.com

??, 13 ???. 2020 ?. ? 22:33, Roman Stratiienko <[email protected]>:

Quoted 56 lines

??, 14 ??? 2020 ?. ? 09:44, Roman Stratiienko <[email protected]>:

Quoted 24 lines
CC jagan at amarulasolutions.com

??, 8 ??? 2020 ?. ? 15:29, Roman Stratiienko <[email protected]>:

Quoted 20 lines

Same was done in the kernel for all devices compatible with 'allwinner,sun8i-a33-musb' at [1] and [2].

Fixes musb initialization on H6 SOC.

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
[2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440

---
CC: Ondrej Jirman <[email protected]>
CC: Icenowy Zheng <[email protected]>
CC: Marek Vasut <[email protected]>
CC: linux-sunxi at googlegroups.com

Hello community,

'$ fastboot usb 0' command works, but host still doesn't see any USB devices. Does anyone have any suggestions where to look?

Hello,

Second issue was fixed with commit 462a9c7a9cce ("phy: sun4i-usb:
Align H6 initialization logic with the kernel") <merged> This patch is required to fix download gadget support for H6 SOC. Please review/merge.

Quoted 22 lines
Quoted 22 lines
---
 drivers/usb/musb-new/musb_regs.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/musb-new/musb_regs.h +3 -2
index c4d7203b85..5f012f3b41 100644
@@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
 static inline u8 musb_read_configdata(void __iomem *mbase)
 {
 #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
-               defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
+       defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
+       defined CONFIG_MACH_SUN50I_H6
+
        /* <Sigh> allwinner saves a reg, and we need to hardcode this */
        return 0xde;
 #else
--

2.25.1