Skip to contentSkip to conversation

package/rustc: RUSTC_TARGET_NAME is needed to build host-rust

PATCH New Romain Naour 4 participants 4 messages May 8, 2020 – May 29, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rustc: RUSTC_TARGET_NAME is needed to build host-rust

As reported on bugzilla [1], the host-rust package fail when the target architecture or the target libc is not supported.

The error is the following:
failed to parse TOML configuration 'config.toml': expected a table key, found a right bracket at line 15

In such case BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS is not set thus RUSTC_TARGET_NAME is also not set [2].

But RUSTC_TARGET_NAME is needed to generate the file config.toml [3]

Add BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS in the host-rust dependency.

The commit [4] that allowed to select host-rust when the target architecture or the target libc is not supported, should have allowed to select only host-rustc-bin.

Fixes:
Bug #12691

[1] https://bugs.busybox.net/show_bug.cgi?id=12691
[2] https://git.buildroot.net/buildroot/tree/package/rustc/rustc.mk?h=2020.05-rc1#n10
[3] https://git.buildroot.net/buildroot/tree/package/rust/rust.mk?h=2020.05-rc1#n41
[4] 025b863e6facb7b219b82ee6ee7a7916c2c3c47e

---
 package/rustc/Config.in.host | 3 +++
 1 file changed, 3 insertions(+)
package/rustc/Config.in.host +3 -0
index d595efbc6f..1df25ae326 100644
@@ -49,6 +49,9 @@ choice
 
 config BR2_PACKAGE_HOST_RUST
 	bool "host rust"
+	# RUSTC_TARGET_NAME must be set for building host-rust
+	# otherwise config.toml is broken.
+	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
 	# triggers ICE on trunc_int_for_mode, at explow.c:56
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 || !BR2_aarch64
 	help
Signature · 1 line
2.25.4
#1 lore raw

PATCH 1/1 package/rustc: RUSTC_TARGET_NAME is needed to build host-rust

Romain,

Quoted 10 lines · Romain Naour

As reported on bugzilla [1], the host-rust package fail when the target architecture or the target libc is not supported.

The error is the following:
failed to parse TOML configuration 'config.toml': expected a table key, found a right bracket at line 15

In such case BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS is not set thus RUSTC_TARGET_NAME is also not set [2].

Quoted 8 lines

But RUSTC_TARGET_NAME is needed to generate the file config.toml [3]

Add BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS in the host-rust dependency.

The commit [4] that allowed to select host-rust when the target architecture or the target libc is not supported, should have allowed to select only host-rustc-bin.

Thanks for fixing this, looks good to me.

Quoted 10 lines

Fixes:
Bug #12691

[1] https://bugs.busybox.net/show_bug.cgi?id=12691
[2] https://git.buildroot.net/buildroot/tree/package/rustc/rustc.mk?h=2020.05-rc1#n10
[3] https://git.buildroot.net/buildroot/tree/package/rust/rust.mk?h=2020.05-rc1#n41
[4] 025b863e6facb7b219b82ee6ee7a7916c2c3c47e

#2 lore raw

PATCH 1/1 package/rustc: RUSTC_TARGET_NAME is needed to build host-rust

In reply to Romain Naour

Hello,

Quoted 26 lines · On Fri, 8 May 2020 17:27:39 +0200 Romain Naour <[email protected]> wrote:

As reported on bugzilla [1], the host-rust package fail when the target architecture or the target libc is not supported.

The error is the following:
failed to parse TOML configuration 'config.toml': expected a table key, found a right bracket at line 15

In such case BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS is not set thus RUSTC_TARGET_NAME is also not set [2].

But RUSTC_TARGET_NAME is needed to generate the file config.toml [3]

Add BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS in the host-rust dependency.

The commit [4] that allowed to select host-rust when the target architecture or the target libc is not supported, should have allowed to select only host-rustc-bin.

Fixes:
Bug #12691

[1] https://bugs.busybox.net/show_bug.cgi?id=12691
[2] https://git.buildroot.net/buildroot/tree/package/rustc/rustc.mk?h=2020.05-rc1#n10
[3] https://git.buildroot.net/buildroot/tree/package/rust/rust.mk?h=2020.05-rc1#n41
[4] 025b863e6facb7b219b82ee6ee7a7916c2c3c47e

Quoted 5 lines
---
 package/rustc/Config.in.host | 3 +++
 1 file changed, 3 insertions(+)

I have applied to master, because it's the most obvious workaround, but I'm not sure to be entirely happy about it.

Indeed, the whole point of commit 025b863e6facb7b219b82ee6ee7a7916c2c3c47e was to ensure we could use Rust as a host-only tool, even when the target architecture is not supported by rust. This would allow to support building some host tools that are written in Rust.

This is properly supported by the host-rust-bin package, which does not install the target Rust library when BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS is false.

Shouldn't the host-rust package be changed to also build just a host compiler (without cross-compilation capabilities) ? Or is host-rust anyway using host-rust-bin as the host compiler ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/rustc: RUSTC_TARGET_NAME is needed to build host-rust

In reply to Romain Naour
Quoted 23 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

As reported on bugzilla [1], the host-rust package fail when the target architecture or the target libc is not supported.

The error is the following:
failed to parse TOML configuration 'config.toml': expected a table key, found a right bracket at line 15

In such case BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS is not set thus RUSTC_TARGET_NAME is also not set [2].

But RUSTC_TARGET_NAME is needed to generate the file config.toml [3]

Add BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS in the host-rust dependency.

The commit [4] that allowed to select host-rust when the target architecture or the target libc is not supported, should have allowed to select only host-rustc-bin.

Fixes:
Bug #12691

Quoted 7 lines

[1] https://bugs.busybox.net/show_bug.cgi?id=12691
[2] https://git.buildroot.net/buildroot/tree/package/rustc/rustc.mk?h=2020.05-rc1#n10
[3] https://git.buildroot.net/buildroot/tree/package/rust/rust.mk?h=2020.05-rc1#n41
[4] 025b863e6facb7b219b82ee6ee7a7916c2c3c47e

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard