Skip to contentSkip to conversation

cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

PATCH New Michal Simek 5 participants 8 messages May 4, 2020 – May 22, 2020 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and use it instead of trying to find out space where pattern should be saved.

For example if you want to test the whole DDR memory you can't save patter to DDR and you need to find it out. On Xilinx devices DDR or OCM addresses were chosen but that means that OCM needs to be mapped and U-Boot has access permission there.

It is easier to remove this limitation and simply save it on stack because it is very clear that memory test can't rewrite U-Boot and U-Boot has also full access to memory where runs from.

---

 README                               | 4 ----
 cmd/mem.c                            | 9 ++-------
 include/configs/MigoR.h              | 1 -
 include/configs/advantech_dms-ba16.h | 1 -
 include/configs/apalis_imx6.h        | 1 -
 include/configs/aristainetos2.h      | 1 -
 include/configs/armadillo-800eva.h   | 1 -
 include/configs/blanche.h            | 1 -
 include/configs/cgtqmx6eval.h        | 1 -
 include/configs/colibri_imx6.h       | 1 -
 include/configs/dh_imx6.h            | 1 -
 include/configs/el6x_common.h        | 1 -
 include/configs/embestmx6boards.h    | 1 -
 include/configs/ge_bx50v3.h          | 1 -
 include/configs/gw_ventana.h         | 1 -
 include/configs/imx6_logic.h         | 1 -
 include/configs/kzm9g.h              | 1 -
 include/configs/mx6sabre_common.h    | 1 -
 include/configs/nitrogen6x.h         | 1 -
 include/configs/presidio_asic.h      | 1 -
 include/configs/sh7752evb.h          | 1 -
 include/configs/sh7753evb.h          | 1 -
 include/configs/sh7757lcr.h          | 1 -
 include/configs/stm32mp1.h           | 1 -
 include/configs/tao3530.h            | 1 -
 include/configs/tricorder.h          | 1 -
 include/configs/xilinx_versal.h      | 1 -
 include/configs/xilinx_versal_mini.h | 1 -
 include/configs/xilinx_zynqmp.h      | 4 ----
 include/configs/xilinx_zynqmp_mini.h | 1 -
 include/configs/xilinx_zynqmp_r5.h   | 1 -
 scripts/config_whitelist.txt         | 1 -
 32 files changed, 2 insertions(+), 44 deletions(-)
README +0 -4
index 083485067654..4efacf337b74 100644
@@ -2479,10 +2479,6 @@ Configuration Settings:
 		Begin and End addresses of the area used by the
 		simple memory test.
 
-- CONFIG_SYS_MEMTEST_SCRATCH:
-		Scratch address used by the alternate memory test
-		You only need to set this if address zero isn't writeable
-
 - CONFIG_SYS_MEM_RESERVE_SECURE
 		Only implemented for ARMv8 for now.
 		If defined, the size of CONFIG_SYS_MEM_RESERVE_SECURE memory
cmd/mem.c +2 -7
index 009b7b58f328..18f0510098be 100644
@@ -25,10 +25,6 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#ifndef CONFIG_SYS_MEMTEST_SCRATCH
-#define CONFIG_SYS_MEMTEST_SCRATCH 0
-#endif
-
 static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
 
 /* Display values from last command.
@@ -922,7 +918,8 @@ static int do_mem_mtest(cmd_tbl_t *cmdtp, int flag, int argc,
 			char * const argv[])
 {
 	ulong start, end;
-	vu_long *buf, *dummy;
+	vu_long scratch_space;
+	vu_long *buf, *dummy = &scratch_space;
 	ulong iteration_limit = 0;
 	ulong count = 0;
 	ulong errs = 0;	/* number of errors, or -1 if interrupted */
@@ -958,7 +955,6 @@ static int do_mem_mtest(cmd_tbl_t *cmdtp, int flag, int argc,
 	      start, end);
 
 	buf = map_sysmem(start, end - start);
-	dummy = map_sysmem(CONFIG_SYS_MEMTEST_SCRATCH, sizeof(vu_long));
 	for (iteration = 0;
 			!iteration_limit || iteration < iteration_limit;
 			iteration++) {
@@ -988,7 +984,6 @@ static int do_mem_mtest(cmd_tbl_t *cmdtp, int flag, int argc,
 	}
 
 	unmap_sysmem((void *)buf);
-	unmap_sysmem((void *)dummy);
 
 	if (errs == -1UL) {
 		/* Memory test was aborted - write a newline to finish off */
include/configs/MigoR.h +0 -1
index c58b7814ba94..2421300e1e13 100644
@@ -32,7 +32,6 @@
 
 /* Enable alternate, more extensive, memory test */
 /* Scratch address used by the alternate memory test */
-#undef  CONFIG_SYS_MEMTEST_SCRATCH
 
 /* Enable temporary baudrate change while serial download */
 #undef  CONFIG_SYS_LOADS_BAUD_CHANGE
include/configs/advantech_dms-ba16.h +0 -1
index deb4374d1c4a..b7b1ac2f89b7 100644
@@ -185,7 +185,6 @@
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END         0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 #define CONFIG_SYS_LOAD_ADDR           CONFIG_LOADADDR
 
include/configs/apalis_imx6.h +0 -1
index fb0037444f4b..49a28f5a3f5e 100644
@@ -212,7 +212,6 @@
 
 #define CONFIG_SYS_MEMTEST_START	0x10000000
 #define CONFIG_SYS_MEMTEST_END		0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH	0x10800000
 
 #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
 
include/configs/aristainetos2.h +0 -1
index 5f4a4f854f9c..336cf1746ab0 100644
@@ -409,7 +409,6 @@
 
 #define CONFIG_SYS_MEMTEST_START	PHYS_SDRAM
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + 0x100000)
-#define CONFIG_SYS_MEMTEST_SCRATCH	0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM			MMDC0_ARB_BASE_ADDR
include/configs/armadillo-800eva.h +0 -1
index e56929628bc7..c089b9c27c64 100644
@@ -43,7 +43,6 @@
 #define CONFIG_SYS_MEMTEST_START	(ARMADILLO_800EVA_SDRAM_BASE)
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + \
 					 504 * 1024 * 1024)
-#undef	CONFIG_SYS_MEMTEST_SCRATCH
 #undef	CONFIG_SYS_LOADS_BAUD_CHANGE
 
 #define CONFIG_SYS_SDRAM_BASE		(ARMADILLO_800EVA_SDRAM_BASE)
include/configs/blanche.h +0 -1
index 7ee38a7ef9bc..fd29c5d0f1ed 100644
@@ -22,7 +22,6 @@
 #define RCAR_GEN2_SDRAM_SIZE		(1024u * 1024 * 1024)
 #define RCAR_GEN2_UBOOT_SDRAM_SIZE	(512 * 1024 * 1024)
 
-#undef	CONFIG_SYS_MEMTEST_SCRATCH
 #undef	CONFIG_SYS_LOADS_BAUD_CHANGE
 
 /* FLASH */
include/configs/cgtqmx6eval.h +0 -1
index 797fcb14590a..b6dfcdd08b95 100644
@@ -189,7 +189,6 @@
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END	       0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM		       MMDC0_ARB_BASE_ADDR
include/configs/colibri_imx6.h +0 -1
index 4cdd3c53afbb..706665e37fc5 100644
@@ -191,7 +191,6 @@
 
 #define CONFIG_SYS_MEMTEST_START	0x10000000
 #define CONFIG_SYS_MEMTEST_END		0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH	0x10800000
 
 #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
 
include/configs/dh_imx6.h +0 -1
index 087d020cdd37..e16c9ee01d94 100644
@@ -139,7 +139,6 @@
 
 #define CONFIG_SYS_MEMTEST_START	0x10000000
 #define CONFIG_SYS_MEMTEST_END		0x20000000
-#define CONFIG_SYS_MEMTEST_SCRATCH	0x10800000
 
 /* Environment */
 
include/configs/el6x_common.h +0 -1
index 95c04c379706..bd42ad259d93 100644
@@ -76,7 +76,6 @@
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END         0x10800000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM                     MMDC0_ARB_BASE_ADDR
include/configs/embestmx6boards.h +0 -1
index 62561116bbe3..bf51afbd9cdf 100644
@@ -51,7 +51,6 @@
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END         0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM                     MMDC0_ARB_BASE_ADDR
include/configs/ge_bx50v3.h +0 -1
index 3bf0cd518c1a..2b55f51b8ba0 100644
@@ -146,7 +146,6 @@
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END         0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 #define CONFIG_SYS_LOAD_ADDR           CONFIG_LOADADDR
 
include/configs/gw_ventana.h +0 -1
index d169aa19de49..193c88e3da0a 100644
@@ -133,7 +133,6 @@
 /* Memory configuration */
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END	       0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM                     MMDC0_ARB_BASE_ADDR
include/configs/imx6_logic.h +0 -1
index 2274db0e2295..e77fb4a1b5e4 100644
@@ -118,7 +118,6 @@
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END         0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM                     MMDC0_ARB_BASE_ADDR
include/configs/kzm9g.h +0 -1
index cceabdf66363..9ceb12f7e006 100644
@@ -38,7 +38,6 @@
 #define CONFIG_SYS_MEMTEST_START	(KZM_SDRAM_BASE)
 #define CONFIG_SYS_MEMTEST_END \
 	(CONFIG_SYS_MEMTEST_START + (60 * 1024 * 1024))
-#undef  CONFIG_SYS_MEMTEST_SCRATCH
 #undef  CONFIG_SYS_LOADS_BAUD_CHANGE
 
 #define CONFIG_SYS_INIT_RAM_ADDR	(0xE5600000) /* on MERAM */
include/configs/mx6sabre_common.h +0 -1
index ee3b754910cc..b46367c83145 100644
@@ -156,7 +156,6 @@
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END         0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM                     MMDC0_ARB_BASE_ADDR
include/configs/nitrogen6x.h +0 -1
index 9ef6ea90a3f6..5e09a783df2e 100644
@@ -132,7 +132,6 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_MEMTEST_START       0x10000000
 #define CONFIG_SYS_MEMTEST_END	       0x10010000
-#define CONFIG_SYS_MEMTEST_SCRATCH     0x10800000
 
 /* Physical Memory Map */
 #define PHYS_SDRAM		       MMDC0_ARB_BASE_ADDR
include/configs/presidio_asic.h +0 -1
index 023092e486da..56f009ad4e34 100644
@@ -27,7 +27,6 @@
 #define GICD_BASE			0xf7011000
 #define GICC_BASE			0xf7012000
 
-#define CONFIG_SYS_MEMTEST_SCRATCH	0x00100000
 #define CONFIG_SYS_MEMTEST_START	0x05000000
 #define CONFIG_SYS_MEMTEST_END		0x0D000000
 
include/configs/sh7752evb.h +0 -1
index c45b33a91a97..ff49b9c2171b 100644
@@ -25,7 +25,6 @@
 #define CONFIG_SYS_MEMTEST_START	(SH7752EVB_SDRAM_BASE)
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + \
 					 480 * 1024 * 1024)
-#undef	CONFIG_SYS_MEMTEST_SCRATCH
 #undef	CONFIG_SYS_LOADS_BAUD_CHANGE
 
 #define CONFIG_SYS_SDRAM_BASE		(SH7752EVB_SDRAM_BASE)
include/configs/sh7753evb.h +0 -1
index 70e7fb932484..74fb528d2e97 100644
@@ -25,7 +25,6 @@
 #define CONFIG_SYS_MEMTEST_START	(SH7753EVB_SDRAM_BASE)
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + \
 					 480 * 1024 * 1024)
-#undef	CONFIG_SYS_MEMTEST_SCRATCH
 #undef	CONFIG_SYS_LOADS_BAUD_CHANGE
 
 #define CONFIG_SYS_SDRAM_BASE		(SH7753EVB_SDRAM_BASE)
include/configs/sh7757lcr.h +0 -1
index 6a34dc7954b6..8f5c84207fe8 100644
@@ -28,7 +28,6 @@
 #define CONFIG_SYS_MEMTEST_START	(SH7757LCR_SDRAM_BASE)
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + \
 					 224 * 1024 * 1024)
-#undef	CONFIG_SYS_MEMTEST_SCRATCH
 #undef	CONFIG_SYS_LOADS_BAUD_CHANGE
 
 #define CONFIG_SYS_SDRAM_BASE		(SH7757LCR_SDRAM_BASE)
include/configs/stm32mp1.h +0 -1
index 2ba4fb1305a8..4dc7cf53a1f2 100644
@@ -68,7 +68,6 @@
 
 #define CONFIG_SYS_MEMTEST_START	STM32_DDR_BASE
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + SZ_64M)
-#define CONFIG_SYS_MEMTEST_SCRATCH	(CONFIG_SYS_MEMTEST_END + 4)
 
 /*MMC SD*/
 #define CONFIG_SYS_MMC_MAX_DEVICE	3
include/configs/tao3530.h +0 -1
index e95cd0087d3f..c80776b4da0e 100644
@@ -134,7 +134,6 @@
 #define CONFIG_SYS_MEMTEST_START	(0x82000000)		/* memtest */
 								/* defaults */
 #define CONFIG_SYS_MEMTEST_END		(0x83FFFFFF)		/* 64MB */
-#define CONFIG_SYS_MEMTEST_SCRATCH	(0x81000000)	/* dummy address */
 
 #define CONFIG_SYS_LOAD_ADDR		(OMAP34XX_SDRC_CS0)	/* default */
 							/* load address */
include/configs/tricorder.h +0 -1
index 1e4459747d54..de6abb58377d 100644
@@ -248,5 +248,4 @@
 #define CONFIG_SYS_SPL_MALLOC_START	0x80208000
 #define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
 
-#define CONFIG_SYS_MEMTEST_SCRATCH	0x81000000
 #endif /* __CONFIG_H */
include/configs/xilinx_versal.h +0 -1
index 0c259a181f10..480afd993bcc 100644
@@ -18,7 +18,6 @@
 #define GICD_BASE	0xF9000000
 #define GICR_BASE	0xF9080000
 
-#define CONFIG_SYS_MEMTEST_SCRATCH	0xfffc0000
 
 #define CONFIG_SYS_MEMTEST_START	0
 #define CONFIG_SYS_MEMTEST_END		1000
include/configs/xilinx_versal_mini.h +0 -1
index ee305e0226b3..ae7eca11553f 100644
@@ -10,7 +10,6 @@
 #ifndef __CONFIG_VERSAL_MINI_H
 #define __CONFIG_VERSAL_MINI_H
 
-#define CONFIG_SYS_MEMTEST_SCRATCH     0xfffc0000
 
 #define CONFIG_EXTRA_ENV_SETTINGS
 
include/configs/xilinx_zynqmp.h +0 -4
index eddc2b402006..01e05200dfe0 100644
@@ -19,10 +19,6 @@
 #define GICD_BASE	0xF9010000
 #define GICC_BASE	0xF9020000
 
-#ifndef CONFIG_SYS_MEMTEST_SCRATCH
-# define CONFIG_SYS_MEMTEST_SCRATCH	0x10800000
-#endif
-
 #define CONFIG_SYS_MEMTEST_START	0
 #define CONFIG_SYS_MEMTEST_END		1000
 
include/configs/xilinx_zynqmp_mini.h +0 -1
index a6922896e0e1..3078b9c55b52 100644
@@ -10,7 +10,6 @@
 #ifndef __CONFIG_ZYNQMP_MINI_H
 #define __CONFIG_ZYNQMP_MINI_H
 
-#define CONFIG_SYS_MEMTEST_SCRATCH     0xfffc0000
 
 #define CONFIG_EXTRA_ENV_SETTINGS
 
include/configs/xilinx_zynqmp_r5.h +0 -1
index 155d7fe883f0..327f0af3145c 100644
@@ -40,6 +40,5 @@
 /* 0x0 - 0x40 is used for placing exception vectors */
 #define CONFIG_SYS_MEMTEST_START	0x40
 #define CONFIG_SYS_MEMTEST_END		0x100
-#define CONFIG_SYS_MEMTEST_SCRATCH	0
 
 #endif /* __CONFIG_ZYNQ_ZYNQMP_R5_H */
scripts/config_whitelist.txt +0 -1
index 7a5da9d822a4..753d33333c9d 100644
@@ -3079,7 +3079,6 @@ CONFIG_SYS_MEMAC_LITTLE_ENDIAN
 CONFIG_SYS_MEMORY_BASE
 CONFIG_SYS_MEMORY_SIZE
 CONFIG_SYS_MEMTEST_END
-CONFIG_SYS_MEMTEST_SCRATCH
 CONFIG_SYS_MEMTEST_START
 CONFIG_SYS_MEM_MAP
 CONFIG_SYS_MEM_RESERVE_SECURE
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

Quoted 42 lines · Michal Simek

There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and use it instead of trying to find out space where pattern should be saved.

For example if you want to test the whole DDR memory you can't save patter to DDR and you need to find it out. On Xilinx devices DDR or OCM addresses were chosen but that means that OCM needs to be mapped and U-Boot has access permission there.

It is easier to remove this limitation and simply save it on stack because it is very clear that memory test can't rewrite U-Boot and U-Boot has also full access to memory where runs from.

---

 README                               | 4 ----
 cmd/mem.c                            | 9 ++-------
 include/configs/MigoR.h              | 1 -
 include/configs/advantech_dms-ba16.h | 1 -
 include/configs/apalis_imx6.h        | 1 -
 include/configs/aristainetos2.h      | 1 -
 include/configs/armadillo-800eva.h   | 1 -
 include/configs/blanche.h            | 1 -
 include/configs/cgtqmx6eval.h        | 1 -
 include/configs/colibri_imx6.h       | 1 -
 include/configs/dh_imx6.h            | 1 -
 include/configs/el6x_common.h        | 1 -
 include/configs/embestmx6boards.h    | 1 -
 include/configs/ge_bx50v3.h          | 1 -
 include/configs/gw_ventana.h         | 1 -
 include/configs/imx6_logic.h         | 1 -
 include/configs/kzm9g.h              | 1 -
 include/configs/mx6sabre_common.h    | 1 -
 include/configs/nitrogen6x.h         | 1 -
 include/configs/presidio_asic.h      | 1 -
 include/configs/sh7752evb.h          | 1 -
 include/configs/sh7753evb.h          | 1 -
 include/configs/sh7757lcr.h          | 1 -
 include/configs/stm32mp1.h           | 1 -
 include/configs/tao3530.h            | 1 -
Quoted 8 lines
 include/configs/tricorder.h          | 1 -
 include/configs/xilinx_versal.h      | 1 -
 include/configs/xilinx_versal_mini.h | 1 -
 include/configs/xilinx_zynqmp.h      | 4 ----
 include/configs/xilinx_zynqmp_mini.h | 1 -
 include/configs/xilinx_zynqmp_r5.h   | 1 -
 scripts/config_whitelist.txt         | 1 -
 32 files changed, 2 insertions(+), 44 deletions(-)
#2 lore raw

PATCH 1/1 cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

In reply to Michal Simek
Quoted 41 lines · Michal Simek

There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and use it instead of trying to find out space where pattern should be saved.

For example if you want to test the whole DDR memory you can't save patter to DDR and you need to find it out. On Xilinx devices DDR or OCM addresses were chosen but that means that OCM needs to be mapped and U-Boot has access permission there.

It is easier to remove this limitation and simply save it on stack because it is very clear that memory test can't rewrite U-Boot and U-Boot has also full access to memory where runs from.

---

  README                               | 4 ----
  cmd/mem.c                            | 9 ++-------
  include/configs/MigoR.h              | 1 -
  include/configs/advantech_dms-ba16.h | 1 -
  include/configs/apalis_imx6.h        | 1 -
  include/configs/aristainetos2.h      | 1 -
  include/configs/armadillo-800eva.h   | 1 -
  include/configs/blanche.h            | 1 -
  include/configs/cgtqmx6eval.h        | 1 -
  include/configs/colibri_imx6.h       | 1 -
  include/configs/dh_imx6.h            | 1 -
  include/configs/el6x_common.h        | 1 -
  include/configs/embestmx6boards.h    | 1 -
  include/configs/ge_bx50v3.h          | 1 -
  include/configs/gw_ventana.h         | 1 -
  include/configs/imx6_logic.h         | 1 -
  include/configs/kzm9g.h              | 1 -
  include/configs/mx6sabre_common.h    | 1 -
  include/configs/nitrogen6x.h         | 1 -
  include/configs/presidio_asic.h      | 1 -
  include/configs/sh7752evb.h          | 1 -
  include/configs/sh7753evb.h          | 1 -
  include/configs/sh7757lcr.h          | 1 -
  include/configs/stm32mp1.h           | 1 -
  include/configs/tao3530.h            | 1 -
Quoted 8 lines
  include/configs/tricorder.h          | 1 -
  include/configs/xilinx_versal.h      | 1 -
  include/configs/xilinx_versal_mini.h | 1 -
  include/configs/xilinx_zynqmp.h      | 4 ----
  include/configs/xilinx_zynqmp_mini.h | 1 -
  include/configs/xilinx_zynqmp_r5.h   | 1 -
  scripts/config_whitelist.txt         | 1 -
  32 files changed, 2 insertions(+), 44 deletions(-)

Thanks,
Stefan

#3 lore raw

PATCH 1/1 cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

In reply to Michal Simek

Hello Michal,

Am 04.05.2020 um 13:54 schrieb Michal Simek:

Quoted 41 lines

There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and use it instead of trying to find out space where pattern should be saved.

For example if you want to test the whole DDR memory you can't save patter to DDR and you need to find it out. On Xilinx devices DDR or OCM addresses were chosen but that means that OCM needs to be mapped and U-Boot has access permission there.

It is easier to remove this limitation and simply save it on stack because it is very clear that memory test can't rewrite U-Boot and U-Boot has also full access to memory where runs from.

---

  README                               | 4 ----
  cmd/mem.c                            | 9 ++-------
  include/configs/MigoR.h              | 1 -
  include/configs/advantech_dms-ba16.h | 1 -
  include/configs/apalis_imx6.h        | 1 -
  include/configs/aristainetos2.h      | 1 -
  include/configs/armadillo-800eva.h   | 1 -
  include/configs/blanche.h            | 1 -
  include/configs/cgtqmx6eval.h        | 1 -
  include/configs/colibri_imx6.h       | 1 -
  include/configs/dh_imx6.h            | 1 -
  include/configs/el6x_common.h        | 1 -
  include/configs/embestmx6boards.h    | 1 -
  include/configs/ge_bx50v3.h          | 1 -
  include/configs/gw_ventana.h         | 1 -
  include/configs/imx6_logic.h         | 1 -
  include/configs/kzm9g.h              | 1 -
  include/configs/mx6sabre_common.h    | 1 -
  include/configs/nitrogen6x.h         | 1 -
  include/configs/presidio_asic.h      | 1 -
  include/configs/sh7752evb.h          | 1 -
  include/configs/sh7753evb.h          | 1 -
  include/configs/sh7757lcr.h          | 1 -
  include/configs/stm32mp1.h           | 1 -
  include/configs/tao3530.h            | 1 -
Quoted 8 lines
  include/configs/tricorder.h          | 1 -
  include/configs/xilinx_versal.h      | 1 -
  include/configs/xilinx_versal_mini.h | 1 -
  include/configs/xilinx_zynqmp.h      | 4 ----
  include/configs/xilinx_zynqmp_mini.h | 1 -
  include/configs/xilinx_zynqmp_r5.h   | 1 -
  scripts/config_whitelist.txt         | 1 -
  32 files changed, 2 insertions(+), 44 deletions(-)

Hmm.. I think this is from old powerpc times, but I do not see a powerpc board in the list, so this makes sense.

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#4 lore raw

PATCH 1/1 cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

Quoted 58 lines · Heiko Schocher

Hello Michal,

Am 04.05.2020 um 13:54 schrieb Michal Simek:

Quoted 53 lines

There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and
use it instead of trying to find out space where pattern should be saved.

For example if you want to test the whole DDR memory you can't save patter
to DDR and you need to find it out. On Xilinx devices DDR or OCM addresses
were chosen but that means that OCM needs to be mapped and U-Boot has access permission there.

It is easier to remove this limitation and simply save it on stack because
it is very clear that memory test can't rewrite U-Boot and U-Boot has also
full access to memory where runs from.

---

? README?????????????????????????????? | 4 ----
? cmd/mem.c??????????????????????????? | 9 ++-------
? include/configs/MigoR.h????????????? | 1 -
? include/configs/advantech_dms-ba16.h | 1 -
? include/configs/apalis_imx6.h??????? | 1 -
? include/configs/aristainetos2.h????? | 1 -
? include/configs/armadillo-800eva.h?? | 1 -
? include/configs/blanche.h??????????? | 1 -
? include/configs/cgtqmx6eval.h??????? | 1 -
? include/configs/colibri_imx6.h?????? | 1 -
? include/configs/dh_imx6.h??????????? | 1 -
? include/configs/el6x_common.h??????? | 1 -
? include/configs/embestmx6boards.h??? | 1 -
? include/configs/ge_bx50v3.h????????? | 1 -
? include/configs/gw_ventana.h???????? | 1 -
? include/configs/imx6_logic.h???????? | 1 -
? include/configs/kzm9g.h????????????? | 1 -
? include/configs/mx6sabre_common.h??? | 1 -
? include/configs/nitrogen6x.h???????? | 1 -
? include/configs/presidio_asic.h????? | 1 -
? include/configs/sh7752evb.h????????? | 1 -
? include/configs/sh7753evb.h????????? | 1 -
? include/configs/sh7757lcr.h????????? | 1 -
? include/configs/stm32mp1.h?????????? | 1 -
? include/configs/tao3530.h??????????? | 1 -
? include/configs/tricorder.h????????? | 1 -
? include/configs/xilinx_versal.h????? | 1 -
? include/configs/xilinx_versal_mini.h | 1 -
? include/configs/xilinx_zynqmp.h????? | 4 ----
? include/configs/xilinx_zynqmp_mini.h | 1 -
? include/configs/xilinx_zynqmp_r5.h?? | 1 -
? scripts/config_whitelist.txt???????? | 1 -
Quoted 1 line

? 32 files changed, 2 insertions(+), 44 deletions(-)

Quoted 2 lines

Hmm.. I think this is from old powerpc times, but I do not see a powerpc board in the list, so this makes sense.

And was there any reason to setup specific address on PPC for saving test pattern?

Thanks,
Michal

#5 lore raw

PATCH 1/1 cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

Hello Michal,

Am 07.05.2020 um 08:39 schrieb Michal Simek:

Quoted 59 lines · Heiko Schocher
Quoted 58 lines

Hello Michal,

Am 04.05.2020 um 13:54 schrieb Michal Simek:

Quoted 54 lines

There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and
use it instead of trying to find out space where pattern should be saved.

For example if you want to test the whole DDR memory you can't save patter
to DDR and you need to find it out. On Xilinx devices DDR or OCM addresses
were chosen but that means that OCM needs to be mapped and U-Boot has access permission there.

It is easier to remove this limitation and simply save it on stack because
it is very clear that memory test can't rewrite U-Boot and U-Boot has also
full access to memory where runs from.

---

 ? README?????????????????????????????? | 4 ----
 ? cmd/mem.c??????????????????????????? | 9 ++-------
 ? include/configs/MigoR.h????????????? | 1 -
 ? include/configs/advantech_dms-ba16.h | 1 -
 ? include/configs/apalis_imx6.h??????? | 1 -
 ? include/configs/aristainetos2.h????? | 1 -
 ? include/configs/armadillo-800eva.h?? | 1 -
 ? include/configs/blanche.h??????????? | 1 -
 ? include/configs/cgtqmx6eval.h??????? | 1 -
 ? include/configs/colibri_imx6.h?????? | 1 -
 ? include/configs/dh_imx6.h??????????? | 1 -
 ? include/configs/el6x_common.h??????? | 1 -
 ? include/configs/embestmx6boards.h??? | 1 -
 ? include/configs/ge_bx50v3.h????????? | 1 -
 ? include/configs/gw_ventana.h???????? | 1 -
 ? include/configs/imx6_logic.h???????? | 1 -
 ? include/configs/kzm9g.h????????????? | 1 -
 ? include/configs/mx6sabre_common.h??? | 1 -
 ? include/configs/nitrogen6x.h???????? | 1 -
 ? include/configs/presidio_asic.h????? | 1 -
 ? include/configs/sh7752evb.h????????? | 1 -
 ? include/configs/sh7753evb.h????????? | 1 -
 ? include/configs/sh7757lcr.h????????? | 1 -
 ? include/configs/stm32mp1.h?????????? | 1 -
 ? include/configs/tao3530.h??????????? | 1 -
 ? include/configs/tricorder.h????????? | 1 -
 ? include/configs/xilinx_versal.h????? | 1 -
 ? include/configs/xilinx_versal_mini.h | 1 -
 ? include/configs/xilinx_zynqmp.h????? | 4 ----
 ? include/configs/xilinx_zynqmp_mini.h | 1 -
 ? include/configs/xilinx_zynqmp_r5.h?? | 1 -
 ? scripts/config_whitelist.txt???????? | 1 -

? 32 files changed, 2 insertions(+), 44 deletions(-)

Quoted 5 lines
Quoted 2 lines

Hmm.. I think this is from old powerpc times, but I do not see a powerpc board in the list, so this makes sense.

And was there any reason to setup specific address on PPC for saving test pattern?

Not that I am aware of anymore...

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#6 lore raw

PATCH 1/1 cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

In reply to Michal Simek
Quoted 9 lines · Michal Simek

There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and use it instead of trying to find out space where pattern should be saved.

For example if you want to test the whole DDR memory you can't save patter to DDR and you need to find it out. On Xilinx devices DDR or OCM addresses were chosen but that means that OCM needs to be mapped and U-Boot has access permission there.

Quoted 8 lines

It is easier to remove this limitation and simply save it on stack because it is very clear that memory test can't rewrite U-Boot and U-Boot has also full access to memory where runs from.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200508/c8444103/attachment.sig>

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

Cortina Package 2 driver split up

+U-Boot Mailing List

Quoted 14 lines · Alex Nemirovsky

Hi All,

Thank you for reviewing various drivers in this package. Many of the drivers have been reviewed and should be ready for incorporation. However, there seems to be some lone holdouts which are preventing the entire series from entering the master code base.

To accelerate the inclusion of the Cortina drivers into the mainline, we are going to split up the drivers
into individual patch series instead of packaging them up in one large series of patches. Hopefully this will help manage
the flow into the code base.

You should see these individual drivers come across shortly over the u-boot mailing list.

Thank you
Alex