igt/gem_shrink: touch each page in pwrite_/pread_
PATCH 1/1 igt/gem_shrink: touch each page in pwrite_/pread_
pwrite_() and pread_() purport to read each page but weren't.
--- tests/i915/gem_shrink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/i915/gem_shrink.c +2 -2
@@ -58,7 +58,7 @@ static void pwrite_(int fd, uint64_t alloc)uint32_t tmp;uint32_t handle =gem_create (fd, alloc);for (int page =0 ; page < alloc>>12 ; page++) -gem_write (fd, handle, (page + page %4095 ) & ~3 , &tmp,4 ); +gem_write (fd, handle, page <<12 , &tmp,4 );gem_madvise (fd, handle,I915_MADV_DONTNEED ); }
@@ -67,7 +67,7 @@ static void pread_(int fd, uint64_t alloc)uint32_t tmp;uint32_t handle =gem_create (fd, alloc);for (int page =0 ; page < alloc>>12 ; page++) -gem_read (fd, handle, (page + page %4095 ) & ~3 , &tmp,4 ); +gem_read (fd, handle, page <<12 , &tmp,4 );gem_madvise (fd, handle,I915_MADV_DONTNEED ); }
Signature · 6 lines
2.26.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Ashutosh Dixit (2020-05-08 22:34:47)
Quoted 5 lines
pwrite_()andpread_()purport to read each page but weren't.Reported-by CQ Tang <[email protected]>Fixes 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress)Signed-off-by Ashutosh Dixit <[email protected]>
Keep the subpage iteration for the variation.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for igt/gem_shrink: touch each page in pwrite_/pread_ (rev2)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: igt/gem_shrink: touch each page in pwrite_/pread_ (rev2)
URL : https://patchwork.freedesktop.org/series/77085/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8455 -> IGTPW_4549
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4549 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_4549, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4549/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4549:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- fi-cml-s: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/fi-cml-s/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4549/fi-cml-s/igt@i915_selftest@[email protected]
Participating hosts (48 -> 42)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5642 -> IGTPW_4549
CI-20190529: 20190529
CI_DRM_8455: 0fa901c0a0e4f6e0ab2821f7b26c417539cecd08 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4549: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4549/index.html
IGT_5642: d1ce4abb01c70f7be6e777b6d45442663c4b830e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4549/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev