igt/gem_shrink: touch each page in pwrite_/pread_

PATCH In review Ashutosh Dixit 3 participants 4 messages May 8, 2020 – May 9, 2020

lore

Share & tools

lore

Ashutosh Dixit

author

2020-05-08 22:05 UTC #0 lore raw

PATCH 1/1 igt/gem_shrink: touch each page in pwrite_/pread_

pwrite_() and pread_() purport to read each page but weren't.

v2: Keep subpage iteration (Chris)

Reported-by CQ Tang <[email protected]>

Fixes 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress)

Signed-off-by Ashutosh Dixit <[email protected]>

---
 tests/i915/gem_shrink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

tests/i915/gem_shrink.c +2 -2

index c9964ccc0..10d639423 100644
@@ -58,7 +58,7 @@ static void pwrite_(int fd, uint64_t alloc)
 	uint32_t tmp;
 	uint32_t handle = gem_create(fd, alloc);
 	for (int page = 0; page < alloc>>12; page++)
-		gem_write(fd, handle, (page + page % 4095) & ~3, &tmp, 4);
+		gem_write(fd, handle, ((page << 12) + page % 4095) & ~3, &tmp, 4);
 	gem_madvise(fd, handle, I915_MADV_DONTNEED);
 }

@@ -67,7 +67,7 @@ static void pread_(int fd, uint64_t alloc)
 	uint32_t tmp;
 	uint32_t handle = gem_create(fd, alloc);
 	for (int page = 0; page < alloc>>12; page++)
-		gem_read(fd, handle, (page + page % 4095) & ~3, &tmp, 4);
+		gem_read(fd, handle, ((page << 12) + page % 4095) & ~3, &tmp, 4);
 	gem_madvise(fd, handle, I915_MADV_DONTNEED);
 }

Signature · 6 lines

2.26.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Chris Wilson

Reviewed-by on v1 1/1

2020-05-08 22:08 UTC #1 lore raw

Quoting Ashutosh Dixit (2020-05-08 23:05:41)

Quoted 7 lines

pwrite_() and pread_() purport to read each page but weren't.
v2: Keep subpage iteration (Chris)
Reported-by CQ Tang <[email protected]>
Fixes 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress)
Signed-off-by Ashutosh Dixit <[email protected]>

Reviewed-by Chris Wilson <[email protected]>

-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-05-08 22:30 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for igt/gem_shrink: touch each page in pwrite_/pread_ (rev3)

In reply to Ashutosh Dixit

== Series Details ==

Series: igt/gem_shrink: touch each page in pwrite_/pread_ (rev3)
URL : https://patchwork.freedesktop.org/series/77085/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8455 -> IGTPW_4550
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html

Known issues
------------

Here are the changes found in IGTPW_4550 that come from known issues:

### IGT changes ###

#### Warnings ####

* igt@amdgpu/amd_basic@query-info:
- fi-bwr-2160: [SKIP][1] ([fdo#109271]) -> [FAIL][2] ([i915#1125] / [i915#489])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/fi-bwr-2160/igt@amdgpu/[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/fi-bwr-2160/igt@amdgpu/[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1125]: https://gitlab.freedesktop.org/drm/intel/issues/1125
[i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489

Participating hosts (48 -> 42)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5642 -> IGTPW_4550

CI-20190529: 20190529
CI_DRM_8455: 0fa901c0a0e4f6e0ab2821f7b26c417539cecd08 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4550: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html
IGT_5642: d1ce4abb01c70f7be6e777b6d45442663c4b830e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-05-09 00:40 UTC #3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for igt/gem_shrink: touch each page in pwrite_/pread_ (rev3)

In reply to Ashutosh Dixit

== Series Details ==

Series: igt/gem_shrink: touch each page in pwrite_/pread_ (rev3)
URL : https://patchwork.freedesktop.org/series/77085/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8455_full -> IGTPW_4550_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html

Known issues
------------

Here are the changes found in IGTPW_4550_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][1] -> [INCOMPLETE][2] ([i915#155])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen:
- shard-kbl: [PASS][3] -> [FAIL][4] ([i915#54] / [i915#93] / [i915#95]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-farfromfence:
- shard-tglb: [PASS][5] -> [SKIP][6] ([i915#668]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-tglb7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-tglb6/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][7] -> [SKIP][8] ([i915#433])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-tglb8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-tglb5/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#1559] / [i915#93] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl2/igt@[email protected]
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#1559] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl4/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-iclb4/igt@kms_psr@psr2_cursor_render.html

#### Possible fixes ####

* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][15] ([i915#180]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen:
- shard-kbl: [FAIL][17] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl1/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge:
- shard-glk: [FAIL][19] ([i915#118] / [i915#70] / [i915#95]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-glk8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-glk9/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled:
- shard-apl: [FAIL][21] ([i915#52] / [i915#54] / [i915#95]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl8/igt@[email protected]
- shard-kbl: [FAIL][23] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl6/igt@[email protected]

* {igt@kms_flip@flip-vs-suspend@a-dp1}:
- shard-kbl: [DMESG-WARN][25] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl4/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl3/igt@kms_flip@[email protected]

* {igt@kms_flip@flip-vs-suspend@b-hdmi-a1}:
- shard-hsw: [INCOMPLETE][27] ([i915#61]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-hsw2/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-hsw4/igt@kms_flip@[email protected]

* igt@kms_plane_cursor@pipe-a-overlay-size-128:
- shard-kbl: [FAIL][29] ([i915#1559] / [i915#93] / [i915#95]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl4/igt@[email protected]
- shard-apl: [FAIL][31] ([i915#1559] / [i915#95]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl7/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][33] ([fdo#109441]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-hsw: [FAIL][35] ([i915#31]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-hsw6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-hsw1/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@uevent:
- shard-kbl: [FAIL][37] ([i915#357]) -> [FAIL][38] ([i915#357] / [i915#93] / [i915#95])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][39] ([i915#357]) -> [FAIL][40] ([i915#357] / [i915#95])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl2/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][41] ([i915#1525]) -> [FAIL][42] ([i915#1121] / [i915#95])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl4/igt@[email protected]
- shard-kbl: [FAIL][43] ([i915#64]) -> [FAIL][44] ([i915#1121] / [i915#93] / [i915#95])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: [FAIL][45] ([fdo#108145] / [i915#265]) -> [FAIL][46] ([fdo#108145] / [i915#265] / [i915#95]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl8/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (11 -> 8)
------------------------------

Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5642 -> IGTPW_4550
* Piglit: piglit_4509 -> None

== Logs ==