Skip to contentSkip to conversation

gcc-plugins: remove always false $(if ...) in Makefile

PATCH In review Masahiro Yamada 2 participants 3 messages May 10, 2020 – May 12, 2020 Gcc plugins

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-plugins: remove always false $(if ...) in Makefile

This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused GCC_PLUGIN_SUBDIR").

$(if $(findstring /,$(p)),...) is always false because none of plugins contains '/' in the file name.

Clean up the code.

---

 scripts/gcc-plugins/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/gcc-plugins/Makefile +1 -1
index 80f354289eeb..4014ba7e2fbd 100644
@@ -14,7 +14,7 @@ $(objtree)/$(obj)/randomize_layout_seed.h: FORCE
 	$(call if_changed,create_randomize_layout_seed)
 targets = randomize_layout_seed.h randomize_layout_hash.h
 
-hostcxxlibs-y := $(foreach p,$(GCC_PLUGIN),$(if $(findstring /,$(p)),,$(p)))
+hostcxxlibs-y := $(GCC_PLUGIN)
 always-y := $(hostcxxlibs-y)
 
 $(foreach p,$(hostcxxlibs-y:%.so=%),$(eval $(p)-objs := $(p).o))
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Masahiro Yamada

This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused GCC_PLUGIN_SUBDIR").

$(if $(findstring /,$(p)),...) is always false because none of plugins contains '/' in the file name.

Clean up the code.

Signature · 1 line
Kees Cook
#2 lore raw
Quoted 5 lines · Kees Cook
Quoted 3 lines · Masahiro Yamada

This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused GCC_PLUGIN_SUBDIR").

Quoted 9 lines
Quoted 6 lines

$(if $(findstring /,$(p)),...) is always false because none of plugins contains '/' in the file name.

Clean up the code.

Applied to linux-kbuild.

Signature · 2 lines
Best Regards
Masahiro Yamada