Skip to contentSkip to conversation

package/brltty: add host-gawk dependency

PATCH New Fabrice Fontaine 2 participants 3 messages May 8, 2020 – May 9, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/brltty: add host-gawk dependency

host-gawk is used by brltty to build brlapi_constants.h, the build will fail if mawk is used instead of gawk

Fixes:
- http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743

---
 package/brltty/brltty.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/brltty/brltty.mk +5 -1
index e34b9b2b76..4f40e65fc6 100644
@@ -12,7 +12,11 @@ BRLTTY_INSTALL_TARGET_OPTS = INSTALL_ROOT=$(TARGET_DIR) install
 BRLTTY_LICENSE = LGPL-2.1+
 BRLTTY_LICENSE_FILES = LICENSE-LGPL README
 
-BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-autoconf host-pkgconf \
+BRLTTY_DEPENDENCIES = \
+	$(TARGET_NLS_DEPENDENCIES) \
+	host-autoconf \
+	host-gawk \
+	host-pkgconf \
 	$(if $(BR2_PACKAGE_AT_SPI2_CORE),at-spi2-core)
 
 BRLTTY_CONF_ENV = \
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/brltty: add host-gawk dependency

Fabrice, All,

On 2020-05-08 18:28 +0200, Fabrice Fontaine spake thusly:

Quoted 7 lines

host-gawk is used by brltty to build brlapi_constants.h, the build will fail if mawk is used instead of gawk

Fixes:
- http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743

It seemed like a simple patch, but I can't reproduce the error with mawk on my machine:

    $ update-alternatives --get-selections |grep awk
    awk                            manual   /usr/bin/mawk
    $ awk --version
    awk: not an option: --version
    $ wget -O .config http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743/config
    $ make olddefconfig
    $ make brltty

Success...

So, there is something else lurking in the darkness... :-/

Regards,
Yann E. MORIN.

Quoted 28 lines
---
 package/brltty/brltty.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/brltty/brltty.mk +5 -1
index e34b9b2b76..4f40e65fc6 100644
@@ -12,7 +12,11 @@ BRLTTY_INSTALL_TARGET_OPTS = INSTALL_ROOT=$(TARGET_DIR) install
 BRLTTY_LICENSE = LGPL-2.1+
 BRLTTY_LICENSE_FILES = LICENSE-LGPL README
 
-BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-autoconf host-pkgconf \
+BRLTTY_DEPENDENCIES = \
+	$(TARGET_NLS_DEPENDENCIES) \
+	host-autoconf \
+	host-gawk \
+	host-pkgconf \
 	$(if $(BR2_PACKAGE_AT_SPI2_CORE),at-spi2-core)
 
 BRLTTY_CONF_ENV = \
Signature · 6 lines
2.26.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 package/brltty: add host-gawk dependency

Mario, Fabrice, All,

On 2020-05-09 21:24 +0200, Mario Lang spake thusly:

Quoted 23 lines
Quoted 22 lines · Yann E. MORIN

On 2020-05-08 18:28 +0200, Fabrice Fontaine spake thusly:

Quoted 8 lines

host-gawk is used by brltty to build brlapi_constants.h, the build will fail if mawk is used instead of gawk

Fixes:
-
http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743

It seemed like a simple patch, but I can't reproduce the error with mawk on my machine:

    $ update-alternatives --get-selections |grep awk
    awk                            manual   /usr/bin/mawk
    $ awk --version
    awk: not an option: --version
    $ wget -O .config
http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743/config
    $ make olddefconfig
    $ make brltty
Quoted 6 lines
Quoted 3 lines

Success...

So, there is something else lurking in the darkness... :-/

Maybe... However, upstream indeed requires gawk (more or less by accident). This came up just recently while debugging a problem a user had.

So I did further research, and indeed it fails if awk is mawk, and gawk is not installed on the system. Indeed, AC_PROG_AWK will actually search for gawk, then mawk, then awk.

So my test above was flawed, as I stil did get gawk installed. I retried on a system without gawk, and I could reproduce the error.

Patch applied to master, thanks.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'