Skip to contentSkip to conversation

luks2 and discard/trim not working

dm-crypt Nikolay Kichukov 3 participants 8 messages May 9, 2020 – May 10, 2020

lore
Share & tools
lore
#0 lore raw

Hello folks,

Recently, I upgraded to LUKS2 on a NVME SSD disk and noticed that fstrim does not work. Surely it was running fine with LUKS1.

Here are some more details:

GNU/Gentoo Linux
kernel: 5.5.13-gentoo-x86_64
sys-fs/cryptsetup-2.2.2

NVME supports discard and fstrim on filesystem on nvme0n1p2(without LUKS2 encyption) works fine:

NAME DISC-ALN DISC-GRAN DISC-MAX DISC-ZERO
nvme0n1 0 512B 2T 0

├─nvme0n1p1         0      512B       2T         0
├─nvme0n1p2         0      512B       2T         0
└─nvme0n1p3         0      512B       2T         0
  └─root_dif        0        0B       0B         0
    └─root          0        0B       0B         0

dmsetup table /dev/mapper/root | grep allow
0 947028136 crypt capi:rfc7539(chacha20,poly1305)-random :32:logon:cryptsetup:6ae40ec7-1b4c-40ea-871b-d13c9ae66b92-d0 0 254:0 0 2 allow_discards integrity:28:aead

cryptsetup status root
/dev/mapper/root is active and is in use.
type: LUKS2
cipher: chacha20-random
keysize: 256 bits
key location: keyring
integrity: poly1305
device: /dev/nvme0n1p3
sector size: 512

  offset:  0 sectors
  size:    947028136 sectors
  mode:    read/write
  flags:   discards 

However:
fstrim -v /
fstrim: /: the discard operation is not supported

Any ideas?

Thanks,
-Nikolay

#1 lore raw
Quoted 5 lines · Nikolay Kichukov

Hello folks,

Recently, I upgraded to LUKS2 on a NVME SSD disk and noticed that fstrim does not work. Surely it was running fine with LUKS1.

...

Quoted 4 lines

dmsetup table /dev/mapper/root | grep allow
0 947028136 crypt capi:rfc7539(chacha20,poly1305)-random :32:logon:cryptsetup:6ae40ec7-1b4c-40ea-871b-d13c9ae66b92-d0 0 254:0 0 2 allow_discards integrity:28:aead

Was the original luksFormat command combined with --integrity option?

From man cryptsetup: Since dm-integrity doesn't support discards (TRIM), dm-crypt device on top of it inherits this, so integrity protection mode doesn't support discards either.

Signature · 1 line
Chris Murphy
#2 lore raw

Hello Chris,

Quoted 8 lines · On Sat, 9 May 2020 09:45:13 -0600 Chris Murphy <[email protected]> wrote:
Quoted 5 lines · Nikolay Kichukov

Hello folks,

Recently, I upgraded to LUKS2 on a NVME SSD disk and noticed that fstrim does not work. Surely it was running fine with LUKS1.

Quoted 8 lines

...

Quoted 4 lines

dmsetup table /dev/mapper/root | grep allow
0 947028136 crypt capi:rfc7539(chacha20,poly1305)-random :32:logon:cryptsetup:6ae40ec7-1b4c-40ea-871b-d13c9ae66b92-d0 0 254:0 0 2 allow_discards integrity:28:aead

Was the original luksFormat command combined with --integrity option?

yes

Quoted 3 lines

From man cryptsetup: Since dm-integrity doesn't support discards (TRIM), dm-crypt device on top of it inherits this, so integrity protection mode doesn't support discards either.

Thanks for the direction! It seems like, this is in the pipeline for dm-integrity, which is to arrive in version 1.6.0 in kernel 5.7:

"allow_discards
Allow block discard requests (a.k.a. TRIM) for the integrity device. Discards are only allowed to devices using internal hash. The default is to ignore discard requests.
Available since: 1.6.0 (kernel 5.7)"

source: https://gitlab.com/cryptsetup/cryptsetup/-/wikis/DMIntegrity

Does mine use an internal hash?

Thanks,
-Nik

#3 lore raw
Quoted 2 lines · Nikolay Kichukov

Does mine use an internal hash?

No, internal hash is used for non-cryptographic integrity protection (IOW when you use only integritysetup).

LUKS2 can used with authenticated encryption and here discard will be never supported. New cryptsetup should print better error message here though ("TRIM/discard is not supported.")

(Discarded areas means that data area is undefined and reading must return "integrity failure". Many programs do not expect this and will misbehave.
And introducing new state "discarded" would basically define a new state in authenticated encryption - we will not do this in dm-crypt.)

Authenticated encryption for LUKS2 is an experimental feature, I hope one day we will have something better on filesystem layer.

If you use just the same encryption as in LUKS1 (length preserving encryption without any data integrity protection), then it behaves exactly the same - discards can be enabled.

Milan

#4 lore raw
Quoted 7 lines · Milan Broz
Quoted 2 lines · Nikolay Kichukov

Does mine use an internal hash?

No, internal hash is used for non-cryptographic integrity protection (IOW when you use only integritysetup).

Ahh OK, nice, I had it exactly 180 degrees wrong.

Quoted 2 lines

Authenticated encryption for LUKS2 is an experimental feature, I hope one day we will have something better on filesystem layer.

Authenticated Btrfs using hmac:sha256 checksumming is expected to be merged pending review (in-progress). And keyed blake2 also looks possible. No native encryption yet though, but it works fine on top of dm-crypt.
https://lwn.net/Articles/818842/

One of many technical explanations of what is covered.
https://lore.kernel.org/linux-btrfs/SN4PR0401MB3598198E5FB728B68B39A1589BA60@SN4PR0401MB3598.namprd04.prod.outlook.com/

Signature · 1 line
Chris Murphy
#5 lore raw
In reply to Nikolay Kichukov
Quoted 38 lines · Nikolay Kichukov

Hello Chris,

Quoted 8 lines · On Sat, 9 May 2020 09:45:13 -0600 Chris Murphy <[email protected]> wrote:
Quoted 5 lines · Nikolay Kichukov

Hello folks,

Recently, I upgraded to LUKS2 on a NVME SSD disk and noticed that fstrim does not work. Surely it was running fine with LUKS1.

Quoted 8 lines

...

Quoted 4 lines

dmsetup table /dev/mapper/root | grep allow
0 947028136 crypt capi:rfc7539(chacha20,poly1305)-random :32:logon:cryptsetup:6ae40ec7-1b4c-40ea-871b-d13c9ae66b92-d0 0 254:0 0 2 allow_discards integrity:28:aead

Was the original luksFormat command combined with --integrity option?

yes

Quoted 3 lines

From man cryptsetup: Since dm-integrity doesn't support discards (TRIM), dm-crypt device on top of it inherits this, so integrity protection mode doesn't support discards either.

Thanks for the direction! It seems like, this is in the pipeline for dm-integrity, which is to arrive in version 1.6.0 in kernel 5.7:

"allow_discards
Allow block discard requests (a.k.a. TRIM) for the integrity device. Discards are only allowed to devices using internal hash. The default is to ignore discard requests.
Available since: 1.6.0 (kernel 5.7)"

Quoted 3 lines

source: https://gitlab.com/cryptsetup/cryptsetup/-/wikis/DMIntegrity

Does mine use an internal hash?

I'm not certain, but I suspect yes. Offhand I don't see a way to have a separate/external hash device via cryptsetup. If you setup the integrity device separately, before using cryptsetup, it looks like '--data-device' provides a way to have data and hashes separate.

Signature · 1 line
Chris Murphy
#6 lore raw

Thanks Milan and Chris for your responses.

I do need to make use of discards, so my next questions is, can I remove the integrity on the existing luks2 device or does it need to be recreated without --integrity?

Thanks,
-Nikolay

#7 lore raw
Quoted 3 lines · Nikolay Kichukov

I do need to make use of discards, so my next questions is, can I remove the integrity on the existing luks2 device or does it need to be recreated without --integrity?

You have to recreate it.

(Without integrity you can use reencryption to change almost any parameter, but this is an exception. There is a reason integrity extension is experimental. Read cryptsetup man page.)

Milan